From nobody Mon Feb 9 15:50:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679320461; cv=none; d=zohomail.com; s=zohoarc; b=FVdZnYpECTCUXBKQ2ZSwLy9EtTDFzE7+HgGSkxf0FgBRIzfJKSeUu+k9LPtd00r2Ymo4YEKKAOLR97mlf3ZVXxxd1uuub+23+EgV9C/lEl2vgU1jltuftwFIm+Lbso7ulTWnhe37zxL11RVPj8VMermH2Oy/W9VE4G+dkmZXG1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679320461; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/oHo9BVNHotHrIV5jY0Zf+NHiH/4OyaQj0YEM47iTOQ=; b=n5NTblN/pmIeEp7iKdfJPGxDTdarOtBGzMqWEggX+ZJVSRWXMea00Y+lkDRvmalQ3/X7lKo2R4jV5XRZ9ZWeVEjaAxoM/vyILTIUv82AbqCFP62ZiysMkNH9rwBGWyzRHVckBd/b6VuWALcSsLIO5UnQfOc20ujTQlt98visZuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679320461105171.26230556841153; Mon, 20 Mar 2023 06:54:21 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-w1f5Ow1DOvibZ5JQ4rtlWQ-1; Mon, 20 Mar 2023 09:54:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D36901C05EC1; Mon, 20 Mar 2023 13:54:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 275F340C20FA; Mon, 20 Mar 2023 13:54:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 08CCA19465A2; Mon, 20 Mar 2023 13:54:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DD1DE1946594 for ; Mon, 20 Mar 2023 13:54:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CC14D492C14; Mon, 20 Mar 2023 13:54:12 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72F95492C13 for ; Mon, 20 Mar 2023 13:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679320460; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/oHo9BVNHotHrIV5jY0Zf+NHiH/4OyaQj0YEM47iTOQ=; b=gLSpZI0jldqjLkA5JYpzC9M0McYl1VmDXrZTH9ZegTn0ipqDEuMtOhxNkQbOUlQqvyA/oH T48bPGRMC5GUN6FaqO/Y5h5+buwZGj2gyvDobtXSUdp+/P9EpuyT4nbbbnKN1ZtRvn86Pi 0Pgb0I+E5mbEQybczanOS2Ph091j/bQ= X-MC-Unique: w1f5Ow1DOvibZ5JQ4rtlWQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] meson: Work around too strict lld Date: Mon, 20 Mar 2023 14:54:11 +0100 Message-Id: <02045cb3a67b7ab49dc073e8f265d12bf3892c76.1679320214.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679320463414100001 Content-Type: text/plain; charset="utf-8"; x-default="true" With its version 16.0, the LLVM's linker turned on --no-undefined-version by default [1]. This breaks how we detect --version-script=3D detection, because at the compile time there's no library built yet that we can use to make --version-script=3D happy. To cancel their choice of defaults, pass --undefined-version. Unfortunately, this flag is LLVM's invention and is not supported by GNU's ld. This all could be avoided if meson provided proper detection of supported linker arguments, but we are far away from that [2]. 1: https://reviews.llvm.org/D135402 2: https://github.com/mesonbuild/meson/issues/3047 Resolves: https://bugs.gentoo.org/902211 Signed-off-by: Michal Privoznik --- Compile Libvirt? Absolutely Not Gonna. The choice of defaults for LLVM and related subprojects continues to surprise me. meson.build | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c35823a79a..df0d75449a 100644 --- a/meson.build +++ b/meson.build @@ -535,9 +535,13 @@ elif host_machine.system() =3D=3D 'darwin' version_script_flags =3D '' else test_file =3D '@0@/src/libvirt_qemu.syms'.format(meson.project_source_ro= ot()) + version_script_flags =3D '' if cc.has_link_argument('-Wl,--version-script=3D@0@'.format(test_file)) version_script_flags =3D '-Wl,--version-script=3D' - else + elif cc.has_multi_link_arguments('-Wl,--undefined-version', '-Wl,--versi= on-script=3D@0@'.format(test_file)) + version_script_flags =3D '-Wl,--version-script=3D' + endif + if version_script_flags =3D=3D '' error('No supported version script link argument found.') endif endif --=20 2.39.2