From nobody Wed Apr 15 07:04:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1776169132; cv=none; d=zohomail.com; s=zohoarc; b=li/eqTZsX7U2I+/6CYca5FSuhhmqb5s/0VBEWiFoeWmC4UMYwQMTi5W1rLo0Eh4lGXq11VCbUYeC93HRKluFuExZv/vciC3mK5eUDDz/Iri1kGNFscyLWHdOROM5vMRWw0GhnPuW3xlQmYorBSNPKHx9DlobRawsEP9l1dbLgZs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776169132; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=Oyu9D9uxkvycDnFIpzrlSU3Ia/dHeB66OpVXuXM+HdM=; b=D4aMl2hd5ib8BMwQQfZT5CmBq1CLssi6mTaEsiPotCbIdB1QkYQc9WYqCvJiXsNzCcXhSO1H6sD5Yrx5/7l00GjXx5dUp466WaqENnltYGouWTN1AEg5EKmnb9okXkfEd90LK3EPU4fJ1pbNccj193OBRvYCzgUR2V1am9PEUrQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1776169132844895.8410748569394; Tue, 14 Apr 2026 05:18:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8E91D41809; Tue, 14 Apr 2026 08:18:51 -0400 (EDT) Received: from [172.19.199.3] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 886D0418CD; Tue, 14 Apr 2026 08:17:53 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA44C3F2FB; Tue, 14 Apr 2026 08:17:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AF8473F2F5 for ; Tue, 14 Apr 2026 08:17:44 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-9uMReLYUMD-N6mfLrfmhCg-1; Tue, 14 Apr 2026 08:17:42 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1FA418002F5 for ; Tue, 14 Apr 2026 12:17:41 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.20]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1E5AD1800B7F for ; Tue, 14 Apr 2026 12:17:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776169064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oyu9D9uxkvycDnFIpzrlSU3Ia/dHeB66OpVXuXM+HdM=; b=N3YPuROgvH1tmI1XqOslptb5U3S5x1gNXd+7cASZlB2p5zvWhDZdVBH5G3+YJyuwXQXS58 sfE7Ghb0/H3Mwxv/AzPwJqSAEg0ocKHScutGwVdyvumcjQ9kSk49fgrPtVr3PpAmK5+eNn 3RLuCaZHlS63b1UJ9krlb8dPx/4wBeo= X-MC-Unique: 9uMReLYUMD-N6mfLrfmhCg-1 X-Mimecast-MFC-AGG-ID: 9uMReLYUMD-N6mfLrfmhCg_1776169062 To: devel@lists.libvirt.org Subject: [PATCH] conf: Reject blockio settings for "" Date: Tue, 14 Apr 2026 14:17:39 +0200 Message-ID: <01a84495659b0604610ff4b7c1ff9aed97513a4c.1776169059.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1FECzgbbTVnErHgjCCGh82EJsdikygL-H9uQt0QmodQ_1776169062 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: P5LXLEWG55PMVTTJ2KSLRGYRQ6MMLFSA X-Message-ID-Hash: P5LXLEWG55PMVTTJ2KSLRGYRQ6MMLFSA X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1776169135000158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Overriding the blockio settings for disk passthrough via "" doesn't make sense and in fact the 'scsi-block' device in qemu doesn't even expose the appropriate properties: qemu-system-x86_64: -device {"driver":"scsi-block","bus":"scsi0.0","chann= el":0,"scsi-id":0,"lun":0,"drive":"libvirt-1-format","id":"scsi0-0-0-0","lo= gical_block_size":512,"physical_block_size":512}: Property 'scsi-block.phys= ical_block_size' not found Reject those at validation. Resolves: https://redhat.atlassian.net/browse/RHEL-145937 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_validate.c | 8 ++++++ .../disk-blockio-device-lun.x86_64-latest.err | 1 + .../disk-blockio-device-lun.xml | 26 +++++++++++++++++++ tests/qemuxmlconftest.c | 1 + 4 files changed, 36 insertions(+) create mode 100644 tests/qemuxmlconfdata/disk-blockio-device-lun.x86_64-la= test.err create mode 100644 tests/qemuxmlconfdata/disk-blockio-device-lun.xml diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index a49156061f..3946f92182 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -786,6 +786,14 @@ virDomainDiskDefValidate(const virDomainDef *def, if (disk->device =3D=3D VIR_DOMAIN_DISK_DEVICE_LUN) { if (virDomainDiskDefSourceLUNValidate(disk->src) < 0) return -1; + + if (disk->blockio.logical_block_size > 0 || + disk->blockio.physical_block_size > 0 || + disk->blockio.discard_granularity_specified) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("blockio is not supported with device=3D'lun'= ")); + return -1; + } } else { if (disk->src->pr) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", diff --git a/tests/qemuxmlconfdata/disk-blockio-device-lun.x86_64-latest.er= r b/tests/qemuxmlconfdata/disk-blockio-device-lun.x86_64-latest.err new file mode 100644 index 0000000000..508abf7a97 --- /dev/null +++ b/tests/qemuxmlconfdata/disk-blockio-device-lun.x86_64-latest.err @@ -0,0 +1 @@ +unsupported configuration: blockio is not supported with device=3D'lun' diff --git a/tests/qemuxmlconfdata/disk-blockio-device-lun.xml b/tests/qemu= xmlconfdata/disk-blockio-device-lun.xml new file mode 100644 index 0000000000..862e064d4f --- /dev/null +++ b/tests/qemuxmlconfdata/disk-blockio-device-lun.xml @@ -0,0 +1,26 @@ + + QEMUGuest1 + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219136 + 219136 + 1 + + hvm + + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + + + + + + + + + diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 14aa723ec5..4c9b55693a 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -1613,6 +1613,7 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-geometry"); DO_TEST_CAPS_LATEST("disk-blockio"); DO_TEST_CAPS_LATEST("disk-blockio-no-discard"); + DO_TEST_CAPS_LATEST_PARSE_ERROR("disk-blockio-device-lun"); driver.config->storageUseNbdkit =3D 1; DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CA= PS_PLUGIN_CURL); --=20 2.53.0