From nobody Thu May 2 06:16:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524742883525632.2233739393906; Thu, 26 Apr 2018 04:41:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8367530BEBDD; Thu, 26 Apr 2018 11:41:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A32AC2015620; Thu, 26 Apr 2018 11:41:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 68B9918033EB; Thu, 26 Apr 2018 11:41:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3QBfDWL007645 for ; Thu, 26 Apr 2018 07:41:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 278012166BC6; Thu, 26 Apr 2018 11:41:13 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C015D2166BAD for ; Thu, 26 Apr 2018 11:41:12 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Thu, 26 Apr 2018 13:41:08 +0200 Message-Id: <00b50292fd1e32b83307b98be37a9bcc6d96e501.1524742843.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] syntax-check: pass srcdir to group-qemu-caps.pl X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 26 Apr 2018 11:41:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The script assumed to be run in the source directory. Pass top_srcdir as the argument to fix VPATH builds. My commit 81a7571 broke this. Signed-off-by: J=C3=A1n Tomko --- Pushed as a build-breaker fix. cfg.mk | 2 +- tests/group-qemu-caps.pl | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 158d4cbd73..c3d18279ce 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1120,7 +1120,7 @@ test-wrap-argv: $(PERL) $(top_srcdir)/tests/test-wrap-argv.pl --check $$files =20 group-qemu-caps: - $(PERL) $(top_srcdir)/tests/group-qemu-caps.pl --check + $(PERL) $(top_srcdir)/tests/group-qemu-caps.pl --check $(top_srcdir)/ =20 # sc_po_check can fail if generated files are not built first sc_po_check: \ diff --git a/tests/group-qemu-caps.pl b/tests/group-qemu-caps.pl index 847e360254..514764f47f 100755 --- a/tests/group-qemu-caps.pl +++ b/tests/group-qemu-caps.pl @@ -31,15 +31,21 @@ if (defined $ARGV[0] && $ARGV[0] eq "--check") { shift @ARGV; } =20 +my $prefix =3D ''; +if (defined $ARGV[0]) { + $prefix =3D $ARGV[0]; + shift @ARGV; +} + my $ret =3D 0; -if (®roup_caps('src/qemu/qemu_capabilities.c', +if (®roup_caps($prefix . 'src/qemu/qemu_capabilities.c', '^VIR_ENUM_IMPL\(virQEMUCaps,', '\);', 0, " ") < 0) { $ret =3D 1; } -if (®roup_caps('src/qemu/qemu_capabilities.h', +if (®roup_caps($prefix . 'src/qemu/qemu_capabilities.h', 'virQEMUCapsFlags grouping marker', 'QEMU_CAPS_LAST \/\* this must', 1, --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list