From nobody Mon Feb 9 08:31:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614591419; cv=none; d=zohomail.com; s=zohoarc; b=YukHASej8OV3Cej9kOSB2pjK5SEeVjiUJr8IdlXY3NYZDtKctLD/ZO/NSjCL6F1TeZcu6zez/6N8oSFIgnokaqhGDv8fBkR6+CEQiQEX10jsP1dD2XfeeYd7XBuWnhGYGQWpwgsjQkoo33WCiODodFgrgxbdpOVtkECnKuL1dO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614591419; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6L1FaHEm8lPSHIzgNA2CAW0hI2BqN8skEKMUz4hn5Kk=; b=Wn6wBTAtMZHHjTATCnNR+yyO5mE0bwSdTQD3nXcdqyFYzz8UkW9dDtoyq8yVYxz0zL2dOimjLhLlk29KSLEQqZRiJWwzDilMOnqLRccur+c3tDe3kLJ4XZ6QHlF4F7GclT7W2Wl9Cf7ptdBwXUJXQJU4dfggzGrMhY8FynesI6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614591419807715.6869173894189; Mon, 1 Mar 2021 01:36:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-a8h-aADkMNm34wlTUrwkKg-1; Mon, 01 Mar 2021 04:36:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE2B28710EB; Mon, 1 Mar 2021 09:36:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B03660CCE; Mon, 1 Mar 2021 09:36:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6237857DFC; Mon, 1 Mar 2021 09:36:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1219aPfi013753 for ; Mon, 1 Mar 2021 04:36:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0B13A60C04; Mon, 1 Mar 2021 09:36:25 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 805BB60BFA for ; Mon, 1 Mar 2021 09:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614591418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6L1FaHEm8lPSHIzgNA2CAW0hI2BqN8skEKMUz4hn5Kk=; b=M/TR4ScgB8yZbC80j+F8Icj9l0IIJ/7q6WTJhQ0wKYbgOkBKMXZdcyq9DA7UtS5dc2LjDs KF9bvJd4RM9dL8LQoTTMUXMKZdgdhw5Y0TncZp27sfyWZsByZXI/b7c2l4+Yf24Rs0S4kp pj0MVV+6L/fmJ3Ycj8qtl1iWz/90924= X-MC-Unique: a8h-aADkMNm34wlTUrwkKg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/4] util: Drop virFileMakePath() and virFileMakePathWithMode() Date: Mon, 1 Mar 2021 10:36:16 +0100 Message-Id: <00b238e25bc4ba20acfda41aa9c38644369c33ba.1614589944.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" These functions are now unused. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 2 -- src/util/virfile.c | 20 -------------------- src/util/virfile.h | 3 --- 3 files changed, 25 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6b7261b987..8c0a68d1bf 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2202,8 +2202,6 @@ virFileLinkPointsTo; virFileLock; virFileLoopDeviceAssociate; virFileMakeParentPath; -virFileMakePath; -virFileMakePathWithMode; virFileMoveMount; virFileNBDDeviceAssociate; virFileOpenAs; diff --git a/src/util/virfile.c b/src/util/virfile.c index 23e334872f..ee434058c2 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3037,26 +3037,6 @@ int virFileChownFiles(const char *name, } #endif /* WIN32 */ =20 -/** - * Creates the given directory with mode 0777 if it's not already existing. - * - * Returns 0 on success, or -1 if an error occurred (in which case, errno - * is set appropriately). - */ -int -virFileMakePath(const char *path) -{ - return g_mkdir_with_parents(path, 0777); -} - -int -virFileMakePathWithMode(const char *path, - mode_t mode) -{ - return g_mkdir_with_parents(path, mode); -} - - int virFileMakeParentPath(const char *path) { diff --git a/src/util/virfile.h b/src/util/virfile.h index 733d652ac9..bca0c32a04 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -277,9 +277,6 @@ int virDirRead(DIR *dirp, struct dirent **ent, const ch= ar *dirname) void virDirClose(DIR *dirp); G_DEFINE_AUTOPTR_CLEANUP_FUNC(DIR, virDirClose); =20 -int virFileMakePath(const char *path) G_GNUC_WARN_UNUSED_RESULT; -int virFileMakePathWithMode(const char *path, - mode_t mode) G_GNUC_WARN_UNUSED_RESULT; int virFileMakeParentPath(const char *path) G_GNUC_WARN_UNUSED_RESULT; =20 char *virFileBuildPath(const char *dir, --=20 2.26.2