From nobody Sun Feb 8 17:22:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638977458; cv=none; d=zohomail.com; s=zohoarc; b=bi/lR2mgd3hfL8mtAXIxsNT6YdHIVQaryL3y2K3lWCsPZCcybUaVqzmkF013r9633Qo5xTqsssJJV5qB/7r3Hxnc45iO6Euv0BEOmcmYpsJW5Wnjh0/NRA+0qTArhPtcgb7UrVQGncvitiDaKfVNAtwVY4JBcodO6J8u+0oNhUQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638977458; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mVnJEpI7+ofgj5ynVdAU0cmzD2uJMM/bh2rMImFaovU=; b=liyV4N4ksOya6fVUxNsy8bd4cjOufAmE49AgLl0x2OZ9e6PeVtI+3sYE1QegwM7bhwSKNyHu3aEzeqNuyT5PvqWdEQJLGw+lZPgDKtlevg4WR4ukufsoHAhFigD//KTa/KFAvRuundczpvWOcg3H+2hGAfrzL/I9V2IoTMyfShc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638977458348178.64339356805453; Wed, 8 Dec 2021 07:30:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-kkfxBXfkOHuhgyjnXHu9VA-1; Wed, 08 Dec 2021 10:30:55 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BB0E801B0F; Wed, 8 Dec 2021 15:30:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4013145D71; Wed, 8 Dec 2021 15:30:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CC5374BB7C; Wed, 8 Dec 2021 15:30:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B8FTiqT032115 for ; Wed, 8 Dec 2021 10:29:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id E1174794D7; Wed, 8 Dec 2021 15:29:44 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6915E794DD for ; Wed, 8 Dec 2021 15:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638977457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mVnJEpI7+ofgj5ynVdAU0cmzD2uJMM/bh2rMImFaovU=; b=YTlUPfc/HDXRTgbh2s/WqflX1QQsUDCz2z2D9bzAwSZazpygcIlZ8ohqTPbl8bx9gzXRXW v4mucMbRXzUpKp3MvYtar/88I6V/GkebuXugwaDXDB7NWDQuEuHqOtr1pCoUWFlUOJdZsz 2NLaZbpEGJwdF8ou1VdFm2fa1cKJAcQ= X-MC-Unique: kkfxBXfkOHuhgyjnXHu9VA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v1 4/7] logging: Build log manager only when RPC is available Date: Wed, 8 Dec 2021 16:29:06 +0100 Message-Id: <00ae0f9b0e47e32a11da4e6eda698a29d6d0a847.1638977134.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638977459957100001 Content-Type: text/plain; charset="utf-8" The logging manager is very closely tied to RPC. If we are building without RPC support there's not much use for the manager, in fact it fails to build. Signed-off-by: Michal Privoznik --- src/libvirt_logging.syms | 18 ++++++++++++++++++ src/libvirt_private.syms | 9 --------- src/logging/meson.build | 31 ++++++++++++++++++------------- 3 files changed, 36 insertions(+), 22 deletions(-) create mode 100644 src/libvirt_logging.syms diff --git a/src/libvirt_logging.syms b/src/libvirt_logging.syms new file mode 100644 index 0000000000..e2a1a7109f --- /dev/null +++ b/src/libvirt_logging.syms @@ -0,0 +1,18 @@ +# +# Domain logging specific symbols +# + + +# logging/log_manager.h +virLogManagerDomainAppendMessage; +virLogManagerDomainGetLogFilePosition; +virLogManagerDomainOpenLogFile; +virLogManagerDomainReadLogFile; +virLogManagerFree; +virLogManagerNew; + + +# Let emacs know we want case-insensitive sorting +# Local Variables: +# sort-fold-case: t +# End: diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7be5b51100..9900bfbe27 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1666,15 +1666,6 @@ virLockManagerPluginUsesState; virLockManagerRelease; =20 =20 -# logging/log_manager.h -virLogManagerDomainAppendMessage; -virLogManagerDomainGetLogFilePosition; -virLogManagerDomainOpenLogFile; -virLogManagerDomainReadLogFile; -virLogManagerFree; -virLogManagerNew; - - # security/security_driver.h virSecurityDriverLookup; =20 diff --git a/src/logging/meson.build b/src/logging/meson.build index 996d4265fc..89e06a0d5a 100644 --- a/src/logging/meson.build +++ b/src/logging/meson.build @@ -32,20 +32,25 @@ log_daemon_sources =3D files( 'log_handler.c', ) =20 -log_driver_lib =3D static_library( - 'virt_log_driver', - [ - log_driver_sources, - log_protocol_generated, - ], - dependencies: [ - rpc_dep, - src_dep, - xdr_dep, - ], -) +if conf.has('WITH_REMOTE') + log_driver_lib =3D static_library( + 'virt_log_driver', + [ + log_driver_sources, + log_protocol_generated, + ], + dependencies: [ + rpc_dep, + src_dep, + xdr_dep, + ], + ) =20 -libvirt_libs +=3D log_driver_lib + libvirt_libs +=3D log_driver_lib + used_sym_files +=3D 'libvirt_logging.syms' +else + sym_files +=3D 'libvirt_logging.syms' +endif =20 if conf.has('WITH_LIBVIRTD') log_daemon_generated =3D custom_target( --=20 2.32.0