From nobody Fri Apr 26 02:46:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of ovirt.org designates 66.187.230.42 as permitted sender) client-ip=66.187.230.42; envelope-from=kimchi-devel-bounces@ovirt.org; helo=lists.ovirt.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of ovirt.org designates 66.187.230.42 as permitted sender) smtp.mailfrom=kimchi-devel-bounces@ovirt.org; Return-Path: Received: from lists.ovirt.org (lists.phx.ovirt.org [66.187.230.42]) by mx.zohomail.com with SMTPS id 1490272518268864.572091623267; Thu, 23 Mar 2017 05:35:18 -0700 (PDT) Received: from lists.phx.ovirt.org (localhost [127.0.0.1]) by lists.ovirt.org (Postfix) with ESMTP id D98B3820744; Thu, 23 Mar 2017 12:35:16 +0000 (UTC) Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by lists.ovirt.org (Postfix) with ESMTPS id 5BDAD820728 for ; Thu, 23 Mar 2017 12:35:00 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id r45so29122255qte.0 for ; Thu, 23 Mar 2017 05:35:00 -0700 (PDT) Received: from localhost.localdomain ([177.41.195.134]) by smtp.gmail.com with ESMTPSA id q31sm3137928qta.22.2017.03.23.05.34.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Mar 2017 05:34:58 -0700 (PDT) X-Original-To: kimchi-devel@ovirt.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hW/12jtt1aUvBt6Cm7G7+qUyv9qUOB94KjH9GN9bgFA=; b=XEoC4WUoT5JldDMuzuDFKZs5FlaQzJ2UZcGvz5Nlm8iqdVOqR4oF/5t1Syr4rGkfYl afYkmtlCF8TZnSV9aB7yoAU8aPEe2EihfDy0hRU4tQmzh8AoQF6pY0xKYagaeZekQ17L ZAWyJWpQrhx6Mf7CoEJlBvkE6XijtClhPlDDCeJEPUvSQY4BL4ZgGhNNsPwKUrt4DRoX wsP2hgbEFVpvxVYFq77ttPaJWxtfKJmka6SXyuh8ubL/E1IzuTCx3V10VxDGGAAhugB8 0eZ1robPqzkCvmXRM19srmqFHHBDoH41NIOD5+o8PIJ2l9VFXsISaCod2S94VsmMkYF5 99bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hW/12jtt1aUvBt6Cm7G7+qUyv9qUOB94KjH9GN9bgFA=; b=dPkVP4mq7Oud5r3mly5jet6LT/KmY+vFDRUbSFit9DoNyBffykU7NduQLY4og7Hmu0 piCxglQil6eA+f6CRAT+SaMVIddZcRhVB5fBJpIwQ5r0iHe4E03SQuo0nWs+MtWytKFb kkY6TkZMxw/eLl3OoKgfhPIIkewwtXyV2GUwAE5VQU6cUPgnbHjIIX+w5SDe8dJsK/ts MaUBKZ/V1Yzj9ZqAZ4/qztA+9uMGwWBs96PgrbZyrE63tjua4rTpL4fbV+UGIF99rYof wjYD3UUl/rlvMXFSo/1M2EYWB864RQKdJXVNavVxcEplwdyvCvYZ6mS3KkXcLGYTo9pu RCJA== X-Gm-Message-State: AFeK/H2+1jkk7MZp7An3j5AqTdtJSmBJkKBqprN/4B8oHcvp4UI+0BQEYbj9SqTHTjvE4g== X-Received: by 10.237.54.162 with SMTP id f31mr1939508qtb.2.1490272499288; Thu, 23 Mar 2017 05:34:59 -0700 (PDT) From: To: Kimchi Devel Date: Thu, 23 Mar 2017 09:34:51 -0300 Message-Id: <20170323123451.28127-1-dhbarboza82@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [Kimchi-devel] [PATCH] [WoK] Removing sessionStorage call in wok.main.js X-BeenThere: kimchi-devel@ovirt.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: kimchi-devel-bounces@ovirt.org Errors-To: kimchi-devel-bounces@ovirt.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Daniel Henrique Barboza sessionStorage was being used in early versions of the websocket notifications implementation to avoid opening multiple connections, before the current single permanent connection approach was implemented. If the 'wokNotificationWebSocket' key existed in the sessionStorage, we skipped the opening of a new websocket. This patch removes the sessionStorage usage because it accomplishes nothing in current code. No verification is made using the created 'wokNotificationWebSocket' session key in the code. Signed-off-by: Daniel Henrique Barboza --- ui/js/src/wok.main.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/js/src/wok.main.js b/ui/js/src/wok.main.js index 26dc723..411b05e 100644 --- a/ui/js/src/wok.main.js +++ b/ui/js/src/wok.main.js @@ -69,7 +69,6 @@ wok.startNotificationWebSocket =3D function () { } }; =20 - sessionStorage.setItem('wokNotificationWebSocket', 'true'); var heartbeat =3D setInterval(function() { wok.notificationsWebSocket.send(window.btoa('heartbeat')); }, 30000); --=20 2.9.3 _______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel