From nobody Sun Feb 8 19:25:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78946+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78946+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.de ARC-Seal: i=1; a=rsa-sha256; t=1628502729; cv=none; d=zohomail.com; s=zohoarc; b=jenpou8aowOSDKdWfusOqPGYY2uMYmX+z4bFF/HpPcs1R0PM1qQhw1vr1V0WpCklZi1kmCMVGspXnplo8lJoGVFhZZJ9Fq/pCaRh0JZuBEqV6iY1I9RNcFPFU9SjzUSk2EKl+beakqYwaTp6is7huPBawf3nIXurXt1vU4Vob18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628502729; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=JO9V7UMAUFIgH7X3bQW0Afb0QPGcAoZTu0M5sBD1H3g=; b=fgQAeey0v4KnOOoN2fZJCUr9QXbe8aihotfR+StNEprswj9V9JchA9AzsCFhmZlxL1tPGfNfwRrxUqDnmIBAEnXMzFO7sSlI+jtNjrGV56iK23Y4D06cM6uOLFrAVXEA3yxRKHeLx02kd5Ba6tWstjlLDg9B7YSwHjesPnJ4IYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78946+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628502729124432.248521069645; Mon, 9 Aug 2021 02:52:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Eed3YY1788612xNBR9GHNTTR; Mon, 09 Aug 2021 02:52:01 -0700 X-Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web09.20692.1628502716021365054 for ; Mon, 09 Aug 2021 02:51:56 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 3EEF4240106 for ; Mon, 9 Aug 2021 11:51:54 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Gjrvs5g44z6tmG; Mon, 9 Aug 2021 11:51:53 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Vitaly Cheptsov Subject: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg/GdbStub: Mandatory LoadedImage for DebugImageInfoTable Date: Mon, 9 Aug 2021 09:51:31 +0000 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mhaeuser@posteo.de X-Gm-Message-State: 1s66D5eIK8ugJDjOR6ClJe30x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628502721; bh=/tfKmijbHzzzRosvE5stEe9YHmOtejGzzyXfcbxMWno=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=YLBYLFx4FLmfD2dBp6m1uz2MP55cD/Ah61hBcvZoTMUQ0uXOfaaA+YrY+kgvMhjtKLX r/abm7wACF4VxQLT7nyDB90uv+RFzeWbEiEzXYHdTdatLeCXisv71w7Ezg704XW5c8iuy bqCr/8v80NdgGxO3nkcTRaSwx/yKqSyaXss= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628502731218100003 Content-Type: text/plain; charset="utf-8" To make parsing DebugImageInfoTable easier and safer, require the LoadedImage protocol instance to be valid for every NormalImage entry. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Vitaly Cheptsov Signed-off-by: Marvin H=C3=A4user --- EmbeddedPkg/GdbStub/GdbStub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/GdbStub/GdbStub.c b/EmbeddedPkg/GdbStub/GdbStub.c index 09167fdafb4d..29aa63237304 100644 --- a/EmbeddedPkg/GdbStub/GdbStub.c +++ b/EmbeddedPkg/GdbStub/GdbStub.c @@ -1044,8 +1044,9 @@ QxferLibrary ( if (gDebugTable !=3D NULL) { for (; gEfiDebugImageTableEntry < gDebugImageTableHeader->TableSize; g= EfiDebugImageTableEntry++, gDebugTable++) { if (gDebugTable->ImageInfoType !=3D NULL) { - if ((*gDebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_= NORMAL) && - (gDebugTable->NormalImage->LoadedImageProtocolInstance !=3D NU= LL)) { + if (*gDebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_N= ORMAL) { + ASSERT (gDebugTable->NormalImage->LoadedImageProtocolInstance != =3D NULL); + Pdb =3D PeCoffLoaderGetDebuggerInfo ( gDebugTable->NormalImage->LoadedImageProtocolInstance->Im= ageBase, &LoadAddress --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78946): https://edk2.groups.io/g/devel/message/78946 Mute This Topic: https://groups.io/mt/84764909/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-