From nobody Thu May 2 13:46:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78904+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78904+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.de ARC-Seal: i=1; a=rsa-sha256; t=1628451646; cv=none; d=zohomail.com; s=zohoarc; b=i7RV0+As2v+iMtmuUOLKNPXwrmDxoQMsE/MImDYgzkkMVlNHZ+OneDzGWJL2lt1YgHsl8wxBzarBnQCvdFYZPaxc3u85QBSByeNwflypxOAnzPodwC8GbsfIkZp3zo7pyAB3uKWS35L8fAn1V2FT172YGsW3a+MtSx4vj/GgLpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628451646; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3aXn7+iMbgTVNUJQM/osr0UMrEc/9tr/DDcB6Fwq/oU=; b=kDWGXmHGNKnn2ocr6L0s5vlNW9gY5rggIMxTkqXLYSuipiBa/NgcqOdURUYcgLhAWUEq/cnV9weIU7M46HoK7+0pmc4rJ2rHuzSNe1H8H9ag1tpuojJaFSTd8UYq6GYyzkIouwaMzBA2z078+WVnzo/jHE4lAKmnwPW6E66vZ4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78904+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628451646933135.46801110123943; Sun, 8 Aug 2021 12:40:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id meeuYY1788612xORFbs0rXgg; Sun, 08 Aug 2021 12:40:46 -0700 X-Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.13770.1628451645328411879 for ; Sun, 08 Aug 2021 12:40:45 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 93E92240104 for ; Sun, 8 Aug 2021 21:40:43 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GjV1k6Fsjz6tmD; Sun, 8 Aug 2021 21:40:42 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Vitaly Cheptsov Subject: [edk2-devel] [PATCH] EmbeddedPkg/GdbStub: Mandatory LoadedImage for DebugImageInfoTable Date: Sun, 8 Aug 2021 19:40:01 +0000 Message-Id: In-Reply-To: <88816e99692b15cf61f3057ffab4d54455159c7c.1628443860.git.mhaeuser@posteo.de> References: <88816e99692b15cf61f3057ffab4d54455159c7c.1628443860.git.mhaeuser@posteo.de> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mhaeuser@posteo.de X-Gm-Message-State: M7C6SPNN7UTeCbz0g7l2Aeixx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628451646; bh=8K4pvtIR6ansPAcigUxjFMGHeEoKmh855zzUNWb5mTE=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=qeR1LBBMlfmedRgIuNbx+sWtLJPq7QfLNPkcCwrvrSO7ougWBCV8JMR+Yv6ruTACHx3 Jkf3l3ylCUuJljAvHC3m98+i60BcSSvifipNwNLluv3R27yIhDswoo0GH1URvbFfIRDCd nM+Zk8qhxzHnA/sI+BW+n0x5XLFYpOoEXqA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628451648072100108 Content-Type: text/plain; charset="utf-8" To make parsing DebugImageInfoTable easier and safer, require the LoadedImage protocol instance to be valid for every NormalImage entry. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Vitaly Cheptsov Signed-off-by: Marvin H=C3=A4user --- EmbeddedPkg/GdbStub/GdbStub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/GdbStub/GdbStub.c b/EmbeddedPkg/GdbStub/GdbStub.c index 09167fdafb4d..29aa63237304 100644 --- a/EmbeddedPkg/GdbStub/GdbStub.c +++ b/EmbeddedPkg/GdbStub/GdbStub.c @@ -1044,8 +1044,9 @@ QxferLibrary ( if (gDebugTable !=3D NULL) { for (; gEfiDebugImageTableEntry < gDebugImageTableHeader->TableSize; g= EfiDebugImageTableEntry++, gDebugTable++) { if (gDebugTable->ImageInfoType !=3D NULL) { - if ((*gDebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_= NORMAL) && - (gDebugTable->NormalImage->LoadedImageProtocolInstance !=3D NU= LL)) { + if (*gDebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_N= ORMAL) { + ASSERT (gDebugTable->NormalImage->LoadedImageProtocolInstance != =3D NULL); + Pdb =3D PeCoffLoaderGetDebuggerInfo ( gDebugTable->NormalImage->LoadedImageProtocolInstance->Im= ageBase, &LoadAddress --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78904): https://edk2.groups.io/g/devel/message/78904 Mute This Topic: https://groups.io/mt/84754079/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-