From nobody Mon Feb 9 06:27:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47057+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47057+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1568070914; cv=none; d=zoho.com; s=zohoarc; b=cCXP2Sj4l2xg/xm5D2l4HKcYEyrKPJcDD3i+Kn28RxKkq/g+bv7mFpBFA+kTyOWJwNgMCmLBIgGktx8GWdWJjKBqVJmE/pvOZz35YSc4GMDXeXhobBchUtATG/JiTIDVdL2aVC4BpjY/NCg801XkM23nQeZ3MVxsfni10aIroqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568070914; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=PqXRl6uJcq9SP8j3QPlHC4k4i9EY4HXX2CcFkWg4XNs=; b=IoQFQjFctmgEb/2YJf8OusgKrQxFosYSd0ySjsMa48r6ETJsRClu+bT+J051bgMnKTVasm+XBjInH2ljOZZpfP8bXgpAUAwkEElhuaXt6C/1bje7J0JiKeelH5F3tGZbDoFHg54akQ5mFn86w+utx/Un2kVvz3MdL1wcLW8tP9M= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47057+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568070914746177.99889689956353; Mon, 9 Sep 2019 16:15:14 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com []) by groups.io with SMTP; Mon, 09 Sep 2019 16:15:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="268226388" X-Received: from paagyema-desk2.amr.corp.intel.com ([10.7.159.148]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2019 16:15:10 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: David Wei , Liming Gao , Ankit Sinha , Agyeman Prince , Kubacki Michael A , Nate DeSimone Subject: [edk2-devel] [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues Date: Mon, 9 Sep 2019 16:15:08 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prince.agyeman@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568070913; bh=56+XxDxHX/2tWqyQMc62bf9BwujobuBSzchq+WsFmo0=; h=Cc:Date:From:Reply-To:Subject:To; b=q7cL6opF67VfSmB4/cmzBf+ngn+CjG0EVQmjTZutdtTbzbdzGz7bV3O2n+nG6FzdQHK nWfoptLPdZyOHOeD04QxeVmW4Ckj6QtBZ3/77Jz9u4HPk/lIIjdL+NIblziFqA1cPs7lf 8H5CaskxLzHOaoVPcBMWPHxQE9CSyyYHWHo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman Reviewed-by: Nate DeSimone --- .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- 2 files changed, 61 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerL= ib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootMa= nagerLib/BdsPlatform.c index 117c72b35f..953a4a6c15 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c @@ -316,12 +316,6 @@ ConnectRootBridge ( IN VOID *Context ); =20 -STATIC -VOID -SaveS3BootScript ( - VOID - ); - // // BDS Platform Functions // @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( PciAcpiInitialization (); } =20 -/** - Save the S3 boot script. - - Note that DxeSmmReadyToLock must be signaled after this function returns; - otherwise the script wouldn't be saved actually. -**/ -STATIC -VOID -SaveS3BootScript ( - VOID - ) -{ - EFI_STATUS Status; - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; - STATIC CONST UINT8 Info[] =3D { 0xDE, 0xAD, 0xBE, 0xEF }; - - Status =3D gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, - (VOID **) &BootScript); - ASSERT_EFI_ERROR (Status); - - // - // Despite the opcode documentation in the PI spec, the protocol - // implementation embeds a deep copy of the info in the boot script, rat= her - // than storing just a pointer to runtime or NVS storage. - // - Status =3D BootScript->Write(BootScript, EFI_BOOT_SCRIPT_INFORMATION_OPC= ODE, - (UINT32) sizeof Info, - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); - ASSERT_EFI_ERROR (Status); -} - - /** Do the platform specific action after the console is ready =20 diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform= /Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 5cbb47687b..4514641b46 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( return EFI_SUCCESS; } =20 - -/** - Reads 8-bits of CMOS data. - - Reads the 8-bits of CMOS data at the location specified by Index. - The 8-bit read value is returned. - - @param Index The CMOS location to read. - - @return The value read. - -**/ -STATIC -UINT8 -CmosRead8 ( - IN UINTN Index - ) -{ - IoWrite8 (0x70, (UINT8) Index); - return IoRead8 (0x71); -} - - STATIC BOOLEAN IsS3Resume ( --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47057): https://edk2.groups.io/g/devel/message/47057 Mute This Topic: https://groups.io/mt/34086418/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-