From nobody Sun Feb 8 22:17:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106542+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1688079739400693.0284373624452; Thu, 29 Jun 2023 16:02:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pIMIYY1788612xEWEFJsaoyw; Thu, 29 Jun 2023 16:02:19 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.60]) by mx.groups.io with SMTP id smtpd.web11.95.1688079737536921387 for ; Thu, 29 Jun 2023 16:02:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdRaw19fqdjsSHWSwDASLuwFZgrcBhMIEVMJyeYi16K49pnCSKhf5s8LI6aCOhMaxcNPSMQAnD96knapAAvqJtRDu5FX+z6lzP9J4AfLDoq+G+OSk+QpTCtwt4O0WZ4IpRPtUr7vwq9Be4WBzk/9M2wHpko2meUoQbSGMmlOUOrfHE9eH4pxUgAIHd9uihr3PfiWOEzHPh3QpAXZ7YVEh/drWAoyzN2uwpKht13WSuSipQ/enUpTtOIxVb2uishp1/XxMzcH/DeLpKhwVBtNTcjqZ5NmqP4PEb2v7bHFiPz3WrtkhVJ/a3xLrS2XgVvIo4wwgvTPm2oH1xLQJ2P64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7i0UmX102mye8GCQ2D//8YI9YIejJl7scmfvyNzuGM=; b=K038u/sB7vrfHNH1ZY57/87BMs/Qh57lTVUS4Axvlm/dXGpzs7jYn3HgeSMavRvVbNQ2oS6B94XC9RQOnyj+gxOOH01YYRhn6zOSUMdAfHjPUgXGO6LOYOoEOeK91HnzlR9svxVU/Yf23UAkOsmZBNDBMtnUMKCs/E5fhvd6wVHE4IdYepWsOf8AmLKG/7m9H6Hl6Z8rR0MompDwD/lSK0+dR7eUdOIN4lNwj30vFts9snl3Weysar6i17/Ae6upqmi9S1w1xIOLalyfErvTk9t5sMzLL9nZeWBZXmGGJsk10ku5F/n6NWNNVp3nfgWn8HCH17o8M9Pe/Nr0Wxir9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN8PR15CA0010.namprd15.prod.outlook.com (2603:10b6:408:c0::23) by MN0PR12MB6197.namprd12.prod.outlook.com (2603:10b6:208:3c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Thu, 29 Jun 2023 23:02:15 +0000 X-Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:408:c0:cafe::88) by BN8PR15CA0010.outlook.office365.com (2603:10b6:408:c0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 23:02:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106542+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Thu, 29 Jun 2023 23:02:14 +0000 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 16:02:00 -0700 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 16:02:00 -0700 X-Received: from 6cd8174ac25c.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 29 Jun 2023 16:01:59 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , Jeff Brasen , "Swatisri Kantamsetti" , Ashish Singhal Subject: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API Date: Thu, 29 Jun 2023 23:01:49 +0000 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT065:EE_|MN0PR12MB6197:EE_ X-MS-Office365-Filtering-Correlation-Id: 9332b2df-2a24-461d-41ce-08db78f4e15e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: /+4JcPVH9jBVugCywi38UjxQBcadFsMyOwWaQdtMHV3yP8rvPNRvMj71wsbMokX5BqlwcrZEGiKKc/RB2QQnS7GoG41ECW/9IjqInkOQxq3M1sKHhRBJDpoSarQTr69LaIeYr5/Yu4gIf3WXx7YqY9etIsXRBsLOLES6N18XpELiu87GmokhwEqSTJ1Ht1l6D3WEnYk/UT1RDUAJ+muo6Ha2M6zeDXrlOhWf2MQovA7zSrjLMc8/LEoRxix9pUKMsBjrz/Xr8i7sIRZGwrrsJE50GMfwryuQz5aCmaeEigt42GriBrJVX5n3Ug2JA/vz5rKdic4j36cll7Ysakpi4gyf2rvukcWD3CoT0yODuF5vvoheL8mV8wJtSysTgL0y3cUdloOEOU0eT8GyIjaswJQOwPFTqC0kw15P/Cks6MSD1bZC3JW5bWwCWadRbw9PXMmxHdP9XpEvpt+FtMEXXaVZxOf9ENviUxRt1CzEeag6cqp0OZ2DT9ZOdBMxPMf1pMX6R5dvGUSsyRaz6Ow0SHaimlOT7nQful5wa7dP2263VmOMg8ZeWF70p3yQL9Pb6OuDQWyj+WrEydvgxwWjf/7KfOyGVgcS7byAGlKX2UZwzrpzE1iaY6gvnq9/VnCGnXu5UtqMWRbHc9Y5z4WtGJ1+1qEDpFTuqG5ufptx5bifKKFo+UEdAUPp4WZ+f/TIkrzyqjboqw08bijSCCZBkK41J8NDEGKWksV50XZTnaY82fXrEI7eNF9e151vuv8z X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 23:02:14.9430 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9332b2df-2a24-461d-41ce-08db78f4e15e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6197 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: lzj4q4kuh22ksE9ZlGGVoWOpx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1688079739; bh=KSxDo1OSmFZwFwf7BITXj47+dwS9CR3Eu0XbBmsChWQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=k4hpTzz5Ms1vFR0spdrz3uBqdRlCOXIwfvRGAvjI/brDJWGDIMAGc+iI1KkaOeV8TTA +gu8tCdzPAh/sTIu3CoVK/K/LsmVQTq6G1J27j2q40DYEjShh4t7UmbWgsM7b8HkjBugU OCL/zLMPH4jz9moRWRwi/9ealgx6E5OnLG8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1688079740207100004 Content-Type: text/plain; charset="utf-8" Add API to generate a Name that contains a Unicode string buffer. Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534 Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal Reviewed-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 31 +++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 86 +++++++++++++++++++ 2 files changed, 117 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 043e7ee901..5150aa4870 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -958,6 +958,37 @@ AmlCodeGenNameResourceTemplate ( OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL ); =20 +/** AML code generation for a Name object node, containing a String. + + AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNod= e) is + equivalent of the following ASL code: + Name(_STR, Unicode ("String")) + + @ingroup CodeGenApis + + @param [in] NameString The new variable name. + Must be a NULL-terminated ASL NameString + e.g.: "DEV0", "DV15.DEV0", etc. + The input string is copied. + @param [in] String NULL terminated Unicode String to associate = to the + NameString. + @param [in] ParentNode If provided, set ParentNode as the parent + of the node created. + @param [out] NewObjectNode If success, contains the created node. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenNameUnicodeString ( + IN CONST CHAR8 *NameString, + IN CHAR16 *String, + IN AML_NODE_HANDLE ParentNode OPTIONAL, + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL + ); + /** Add a _PRT entry. =20 AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a0d01032d5..20ddad031d 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -869,6 +869,92 @@ AmlCodeGenNameResourceTemplate ( return Status; } =20 +/** AML code generation for a Name object node, containing a String. + + AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNode= ) is + equivalent of the following ASL code: + Name(_STR, Unicode ("String")) + + @ingroup CodeGenApis + + @param [in] NameString The new variable name. + Must be a NULL-terminated ASL NameString + e.g.: "DEV0", "DV15.DEV0", etc. + The input string is copied. + @param [in] String NULL terminated Unicode String to associate t= o the + NameString. + @param [in] ParentNode If provided, set ParentNode as the parent + of the node created. + @param [out] NewObjectNode If success, contains the created node. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenNameUnicodeString ( + IN CONST CHAR8 *NameString, + IN CHAR16 *String, + IN AML_NODE_HANDLE ParentNode OPTIONAL, + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL + ) +{ + EFI_STATUS Status; + AML_OBJECT_NODE *ObjectNode; + AML_DATA_NODE *DataNode; + + if ((NameString =3D=3D NULL) || + (String =3D=3D NULL) || + ((ParentNode =3D=3D NULL) && (NewObjectNode =3D=3D NULL))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + Status =3D AmlCodeGenBuffer (NULL, 0, &ObjectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return Status; + } + + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeRaw, + (CONST UINT8 *)String, + StrSize (String), + &DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode); + return Status; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HEADER *)ObjectNode, + (AML_NODE_HEADER *)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode); + AmlDeleteTree ((AML_NODE_HANDLE)DataNode); + return Status; + } + + Status =3D AmlCodeGenName ( + NameString, + ObjectNode, + ParentNode, + NewObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode); + } + + return Status; +} + /** Add a _PRT entry. =20 AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106542): https://edk2.groups.io/g/devel/message/106542 Mute This Topic: https://groups.io/mt/99861339/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-