From nobody Sun Feb 8 17:47:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+58485+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58485+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1588287206; cv=none; d=zohomail.com; s=zohoarc; b=dQ5D/9quXAXLsxdsmpPWhrmwYdZIqgetbk6nP3N0mMRexQY9jiQCc3VA0NfBtLIk+52EFtIkpzDZtzabIKMCG3lh2/uzRxgnap3XNp8JbSzQQfeoXSw9ZTpkIkNYmsTfAPY9pRpltmjRcdUiqrDm/Qc7IhpT9k575KzXqGTczCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588287206; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0gsfpN9AIue9A3e3FtclNriFIjTn+WvMTu1WxGU0RpQ=; b=TuVMkHrfnn+aF8pzbmM+FsmYEPX3shjHJ4TpSH2SVChZFq97X806lBe9GKx1jHJ9rCri2Kb7DFKxrmnabEQXgYQuMKRnRCNowL6YAi+Ip9lwCqspImq+YE3OBDiLHkiyZ+69F0lZiBAm9HhTTKQBQrXrpgCN4pVasgJzo9IY/RU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58485+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1588287206246600.9492327032874; Thu, 30 Apr 2020 15:53:26 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DwQ2YY1788612xlJdvWouqn3; Thu, 30 Apr 2020 15:53:25 -0700 X-Received: from mga09.intel.com (mga09.intel.com []) by mx.groups.io with SMTP id smtpd.web10.61.1588287204056787193 for ; Thu, 30 Apr 2020 15:53:25 -0700 IronPort-SDR: nJz6nfDA9yp/6CPEJ3uKC477UQEh0a2Eg70BmTFFGzoHCJMc7qmunqcCniTqDlqur7MVkXt0da VRlSZS2qp2sQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 15:53:25 -0700 IronPort-SDR: vCL+yeMo6jRrjqTsLIx2jLqSxR8ubxqO9fyK1b6g9xS8ud3bpnb+H47FbnRYiqTlZE+1FqAQwo +7Vs8jcD0k0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,337,1583222400"; d="scan'208";a="368300818" X-Received: from ecbjorge-mobl1.amr.corp.intel.com ([10.212.184.120]) by fmsmga001.fm.intel.com with ESMTP; 30 Apr 2020 15:53:24 -0700 From: "Bjorge, Erik C" To: devel@edk2.groups.io Cc: Ashley E Desimone , Nate DeSimone , Puja Pandya , Bret Barkelew , Prince Agyeman Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/3] EdkRepo: Improve error message with invalid XML Date: Thu, 30 Apr 2020 15:52:53 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,erik.c.bjorge@intel.com X-Gm-Message-State: QSyVk7TMASDIrV3L47E3wDAsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1588287205; bh=8lkESySD4zlc2AUe0q468MFMS3KEAxq6JCn1jMRS7x8=; h=Cc:Date:From:Reply-To:Subject:To; b=im2HC0JYJVx4VMKQE96V26rFORJSlSOuusl5Ays+X3lNqlyTXxa5C8NfFpvouRY7Omw ZZUPcwynhQgnqezxq0ldGf9hc+CcEleZrC4ANLKb77m89k0znWYo+dJ+eZigvWAEBt599 KKsW0Grddm/jwR9QA4BlwFG/0BCwr7SHAs4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The ETree exception contains additional information about the location of XML tag errors. Adding this information to the error message for better debugging support. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo_manifest_parser/edk_manifest.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/edkrepo_manifest_parser/edk_manifest.py b/edkrepo_manifest_par= ser/edk_manifest.py index 7e5f0fb..2ec6cd1 100644 --- a/edkrepo_manifest_parser/edk_manifest.py +++ b/edkrepo_manifest_parser/edk_manifest.py @@ -51,7 +51,7 @@ GENERAL_CONFIG_MISSING_ERROR =3D "Unable to locate " SOURCELIST_EMPTY_ERROR =3D "Invalid input: empty values in source list" INVALID_PROJECTNAME_ERROR =3D "Invalid input: {} not found in CiIndexXml" UNSUPPORTED_TYPE_ERROR =3D "{} is not a supported xml type: {}" -INVALID_XML_ERROR =3D "{} is not a valid xml file" +INVALID_XML_ERROR =3D "{} is not a valid xml file ({})" =20 =20 class BaseXmlHelper(): @@ -59,8 +59,8 @@ class BaseXmlHelper(): self._fileref =3D fileref try: self._tree =3D ET.ElementTree(file=3Dfileref) # fileref can b= e a filename or filestream - except Exception: - raise TypeError(INVALID_XML_ERROR.format(fileref)) + except Exception as et_error: + raise TypeError(INVALID_XML_ERROR.format(fileref, et_error)) =20 self._xml_type =3D self._tree.getroot().tag if self._xml_type not in xml_types: --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58485): https://edk2.groups.io/g/devel/message/58485 Mute This Topic: https://groups.io/mt/73386942/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-