From nobody Sat Apr 27 15:14:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84845+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84845+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1639533452; cv=none; d=zohomail.com; s=zohoarc; b=gjGFxne1MT4B/yJntI9aiJzga0+pvr1DW14WdN/vKhKlmg6Yp8y0XYyjB05fpMWJLvE/7WwwKMexjHhiXIPtOHAuXQlsEDM6KcoohdJ6AiGlFeVEki94kZVYRSvMIilAMebt/HsH4XjzmSX03bUhPoCe9dqkMdR4R6NBQLDdGa0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639533452; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=+I+Ha/lOJZmEgb86SG/EjpS1YOAvDdLUi2dKO13QDW0=; b=LoStPlXlxoI9z4QwkWcNrJ09B1x4OdcQPMXQCXQprPHTbUvyBRsPbB734MubwQTwTRYWGK4/jMkqpHalanQ76L3Sn/UT/rMA8L3Mr18phPUMKXx/fnKgT/rTLX2swXseGFBa2qBYA0PPNDRJEj+umAm7o9iwxD+QTjFJgCO89u0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84845+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639533452743416.470367160456; Tue, 14 Dec 2021 17:57:32 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id dNAOYY1788612xh33Es0dAaI; Tue, 14 Dec 2021 17:57:32 -0800 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.35088.1639533451291821560 for ; Tue, 14 Dec 2021 17:57:31 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="263272731" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="263272731" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 17:57:26 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="604700733" X-Received: from kxinfux-win10.gar.corp.intel.com ([10.227.107.41]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 17:57:24 -0800 From: "VincentX Ke" To: devel@edk2.groups.io Cc: VincentX Ke , Hao A Wu , Ray Ni , Ian Chiu , Maggie Chu Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Replace with UFS_UNIT_DESC to fix response timeout problem. Date: Wed, 15 Dec 2021 09:57:00 +0800 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,vincentx.ke@intel.com X-Gm-Message-State: Y0VKBhlmhuI81UlY5uwK9Wm9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639533452; bh=IQ9I8buyYazavp1JY5DIgt6Exof0qB+Qw7rM3Az/iXo=; h=Cc:Date:From:Reply-To:Subject:To; b=Pz5kRzUikzV+rtyBjW8iQQwSfhl4RiaLYNoNYH8H9k/yjDI2NaXpwKurGW/zpqzGKib rIPAFVetaXZf4ApafX51TqksZXZ1DArrqD2+QetjkoT9ZVRzAOU02bVFYvyTp6ybpd0XR X/flVgfbMB6f/CZvzB/3t6lBoE0Z5NeqQGM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639533453551100001 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3714 Replace with UFS_UNIT_DESC to fix response timeout problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c b/MdeModule= Pkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c index b331c0f3e3..96a1f38727 100644 --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c @@ -1037,9 +1037,9 @@ InitializeUfsBlockIoPeim ( UFS_PEIM_HC_PRIVATE_DATA *Private; EDKII_UFS_HOST_CONTROLLER_PPI *UfsHcPpi; UINT32 Index; - UFS_CONFIG_DESC Config; UINTN MmioBase; UINT8 Controller; + UFS_UNIT_DESC UnitDescriptor; =20 // // Shadow this PEIM to run from memory @@ -1126,19 +1126,17 @@ InitializeUfsBlockIoPeim ( } =20 // - // Get Ufs Device's Lun Info by reading Configuration Descriptor. + // Check if 8 common luns are active and set corresponding bit mask. // - Status =3D UfsRwDeviceDesc (Private, TRUE, UfsConfigDesc, 0, 0, &Confi= g, sizeof (UFS_CONFIG_DESC)); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Ufs Get Configuration Descriptor Error, Status= =3D %r\n", Status)); - Controller++; - continue; - } - for (Index =3D 0; Index < UFS_PEIM_MAX_LUNS; Index++) { - if (Config.UnitDescConfParams[Index].LunEn !=3D 0) { + Status =3D UfsRwDeviceDesc (Private, TRUE, UfsUnitDesc, (UINT8) Inde= x, 0, &UnitDescriptor, sizeof (UFS_UNIT_DESC)); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Fail to read UFS Unit Descriptor, Index =3D = %X, Status =3D %r\n", Index, Status)); + continue; + } + if (UnitDescriptor.LunEn =3D=3D 0x1) { + DEBUG ((DEBUG_INFO, "UFS LUN %X is enabled\n", Index)); Private->Luns.BitMask |=3D (BIT0 << Index); - DEBUG ((DEBUG_INFO, "Ufs %d Lun %d is enabled\n", Controller, Inde= x)); } } =20 --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84845): https://edk2.groups.io/g/devel/message/84845 Mute This Topic: https://groups.io/mt/87736351/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-