From nobody Fri May 17 06:07:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113063+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704275573337250.9671377186944; Wed, 3 Jan 2024 01:52:53 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=/5pdqF6lBhCu3kx9lUTVQ17RU9nn2I6jDv/IZjuVVyg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704275572; v=1; b=Jx+YmtBYR2FsN7VF/DibO7sl1rmft1sPEh0UXogIk84WUUvtdTmyH7eB87AQXpUHjxenaObA eSov/G1qyzYFs/sNXdjh/o8P20rirxygFzmeKfxweoNO6OeHKtGlKPc/9u6PuqLPZNYnbElunOe YFiYJOvNnby0oYbAY2L4OqYg= X-Received: by 127.0.0.2 with SMTP id CI54YY1788612xpVbmKLY07a; Wed, 03 Jan 2024 01:52:52 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.58]) by mx.groups.io with SMTP id smtpd.web10.14449.1704275571476268639 for ; Wed, 03 Jan 2024 01:52:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zs+hsvKr86AXeQDethxsNtLlN0htzOrxpEKEqN3nUqpr6295d3riP5oKHIOnyTsDiEw7PHBPBNcYoPUCQwp/z2kAfT33u4vstj4aragA/r+8o23x0Rmq36TWSzIYM0/VF5PvevvaRAAdfREseYGw08jmjxAJ80HO+ibzR8Ww3mxS3kF41ErZNL3So79F6CTjqqMvLHG68iWLM48Z+ndm9I9QqquaXq8HWbkx9591nY8/AoM1iEsaKdkRh9k8y3CQ+L+sp2Fo36xshS24sdxTmElbQ5qxw2u0rjT2vRsVgrb8g72DpKMc/hBpvssIerEsCUGNQrn0dBfzh88pYFPjPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hH5edFCuCrbHDxuPWIoVJ1dtEP4KqFH2dMni2hxyz7g=; b=NEk2tzuqQ/bWVZiWlF2tfzXIqslX3vpEI0j6r9emBr8YIRhoxqKDOxoeaQkWYRGpMvFYAuN7gbJUEre++4NSgMsmfOilfVS2TTXxf0JczsZy3ZM0+DRrFh5FLAxuMWJYJzhspS8gIgk8vsQs0wUvPmEEgSe4f5xT39AplJjeCq5dXZ7lmTvbrzbZdILYU5ze+Zp3tfAsrltC1JVh8QcTssCcPt8PYwD4NdYcL6VU4kpy47MqknUUjrDc+z4hecPiTbLM6JLZsvXszN3xUqD3Vgh9TbNNgGZ+4Yb9SYoJS88GKOPvoFwqZJVgSvba1ignytR21KlvEDn5uYll0z6qhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA9PR13CA0085.namprd13.prod.outlook.com (2603:10b6:806:23::30) by MW3PR12MB4427.namprd12.prod.outlook.com (2603:10b6:303:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13; Wed, 3 Jan 2024 09:52:49 +0000 X-Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:23:cafe::4c) by SA9PR13CA0085.outlook.office365.com (2603:10b6:806:23::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13 via Frontend Transport; Wed, 3 Jan 2024 09:52:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113063+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 09:52:48 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:47 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:45 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 3 Jan 2024 03:52:43 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors Date: Wed, 3 Jan 2024 15:22:38 +0530 Message-ID: <90b7c3f026208ea2055293fb34a829d60ba5e1a8.1704265673.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|MW3PR12MB4427:EE_ X-MS-Office365-Filtering-Correlation-Id: 1241aa5c-dc04-4d0d-fbdc-08dc0c41be58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: JqVCsHzliWvZZ8TXcOXOX3nNZxJKBJnrdagBD+uMMBMjQJZfM8SO0Ei8cH2Ofjofp+ySzaM0J46P75gMFcBbBRru0TjN1kizTrS8I+LGUtC+xoQLF/FZKE9WoKZhavzYw9SKvXlJfCB9gr6jODrnYneE/rcBtkq8afYJHVCM9b7+oBDddF9EtjQxl9XsRbPvsSZ/BJittJs2UXpcNgbNipdDuJ4k//nLdU7IC3R/aoU2LC7ZXWH5G67wgcQVoL+zGbpLtoJeBI69GUwJPApSJWApxawVOvvAyC7foB+v8U6xYx54RA5wvMx7FHqcYauiSBBOy6eo7yCZmwSMcs05Yb60+hrpDOmmP8eVkCcRjCT3rH2Rg3HKK5Xx3nd5tmkddwoqdDdq6Bi7dz9phMFaV0XzimEzUVUh6poGhXuVa63ZufLI2J/2hdY4rYUZCNJR40nXl6ITRqqedFyVMLrW/HJOlxEhT7ETNZAojKQ6espJf8RS87tVfaDsHx+crLHJb4dJ3LjYAz+UwS43GtYVF435xtDtyIIMsYvf+rStmvZWoufT3I59r2wZfuAVE/WguPBx8YGJIfcFP5k+4llBUC9wP+WW0ph8YhBTYKJAoh4xAWRTsOx39D4KPlQTaD7goLTPInot1O3qS5iXtcqOCZ+5RxbC1MlJcto00pdB8MgYB+nE9zA0WgHwzhCUDZyjBxjGAYKpDNtU7v/Z8IeT7G0DTExDNbbVouQ/J28iRvdR5VCNaL60/wZbHiMQjsf7ofDAwksWXapx0rKaQ0QheyhduzKUEHQAKnSmgtS8QaGGekEJN9MHQM9VMCbPPVM+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 09:52:48.4740 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1241aa5c-dc04-4d0d-fbdc-08dc0c41be58 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4427 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d8jDHhzpzLl9nFMOYbZPOLEsx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704275573803100003 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add the support for X64 compilation to the CI. Fix the compilation errors. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Sami Mujawar --- DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- .../Library/Common/AmlLib/AmlLib.inf | 2 ++ .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- .../Library/Common/TableHelperLib/TableHelper.c | 2 ++ .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ 7 files changed, 29 insertions(+), 12 deletions(-) diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dyna= micTables.dsc.inc index 9d4312c4e8..804fb00a85 100644 --- a/DynamicTablesPkg/DynamicTables.dsc.inc +++ b/DynamicTablesPkg/DynamicTables.dsc.inc @@ -2,6 +2,7 @@ # Dsc include file for Dynamic Tables Framework. # # Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -21,6 +22,17 @@ SmbiosStringTableLib|DynamicTablesPkg/Library/Common/SmbiosStringTableLi= b/SmbiosStringTableLib.inf =20 [Components.common] + # + # Dynamic Table Factory Dxe + # + DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.i= nf + + # + # Dynamic Tables Manager Dxe + # + DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.i= nf + +[Components.ARM, Components.AARCH64] # # Generators # @@ -70,8 +82,3 @@ NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLi= bArm.inf } =20 - # - # Dynamic Tables Manager Dxe - # - DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.i= nf - diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index bd5084a900..a2db14efaf 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -3,6 +3,7 @@ # # Copyright (c) 2019, Linaro Limited. All rights reserved.
# Copyright (c) 2019 - 2022, Arm Limited. All rights reserved.
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -14,7 +15,7 @@ PLATFORM_VERSION =3D 0.1 DSC_SPECIFICATION =3D 0x0001001a OUTPUT_DIRECTORY =3D Build/DynamicTables - SUPPORTED_ARCHITECTURES =3D ARM|AARCH64 + SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|X64 BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT =20 @@ -44,10 +45,12 @@ DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFix= upLib.inf DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf - DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTableLi= b.inf =20 +[Components.ARM, Components.AARCH64] + DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf + [BuildOptions] *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf b/DynamicTab= lesPkg/Library/Common/AmlLib/AmlLib.inf index 723de3ad44..6d0aa6ff93 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf @@ -2,6 +2,7 @@ # AML Generation Library # # Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -68,6 +69,7 @@ [LibraryClasses] AcpiHelperLib BaseLib + MemoryAllocationLib =20 [BuildOptions] *_*_*_CC_FLAGS =3D -DAML_HANDLE diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index 893ace20ae..d4e3e252cb 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,7 +2,7 @@ AML Code Generation. =20 Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
- Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+ Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reser= ved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -922,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status =3D AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlat= Repo.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo= .c index bc713f30b2..bdeb5c78ae 100644 --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c @@ -2,6 +2,7 @@ Dynamic Platform Info Repository =20 Copyright (c) 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -287,8 +288,8 @@ GroupCmObjNodes ( =20 CmObjDesc =3D &This->ArmCmObjArray[ArmObjIndex]; CmObjDesc->ObjectId =3D CmObjId; - CmObjDesc->Size =3D Size; - CmObjDesc->Count =3D Count; + CmObjDesc->Size =3D (UINT32)Size; + CmObjDesc->Count =3D (UINT32)Count; CmObjDesc->Data =3D GroupedData; =20 return Status; @@ -340,7 +341,7 @@ DynamicPlatRepoFinalise ( // (the array is wrapped in a CmObjDesc). // - Add the Token/CmObj binding to the token mapper. for (ArmObjIndex =3D 0; ArmObjIndex < EArmObjMax; ArmObjIndex++) { - Status =3D GroupCmObjNodes (This, ArmObjIndex); + Status =3D GroupCmObjNodes (This, (UINT32)ArmObjIndex); if (EFI_ERROR (Status)) { ASSERT (0); // Free the TokenMapper. diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b= /DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index 0decd3dc0e..e33d6e656b 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -2,6 +2,7 @@ Table Helper =20 Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -16,6 +17,7 @@ #include #include #include +#include =20 /** The GetCgfMgrInfo function gets the CM_STD_OBJ_CONFIGURATION_MANAGER_I= NFO object from the Configuration Manager. diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.= inf b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf index abbf4bc38c..8df5ab848e 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf @@ -2,6 +2,7 @@ # Table Helper # # Copyright (c) 2017 - 2021, ARM Limited. All rights reserved. +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -25,3 +26,4 @@ =20 [LibraryClasses] BaseLib + AmlLib --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113063): https://edk2.groups.io/g/devel/message/113063 Mute This Topic: https://groups.io/mt/103499169/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 06:07:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113064+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704275572771627.5648145700382; Wed, 3 Jan 2024 01:52:52 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=852o/yc3sqXo8jzuF72PNWIsLDJJ1vpk5UajEMPT7C0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704275572; v=1; b=B4CDSxSRqxCqJ/Vy5jxfsIKzLn5JlaG3O83A2lKYclMIgXdiYZU49NyiHfVBu4zhE5KN70ig kmtJrneBCYn0KtjEtcG/oCczLpuZmcxMA1D2giYMp+Fa/gy9K9xxGaAWogWwbRw+ynv9DpMLq3e cekbJtfLJ27NYUHgZmZo8aiI= X-Received: by 127.0.0.2 with SMTP id 3BEYYY1788612x20nokoDhvL; Wed, 03 Jan 2024 01:52:52 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.81]) by mx.groups.io with SMTP id smtpd.web10.14450.1704275571563757137 for ; Wed, 03 Jan 2024 01:52:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxLlriZzOt5OjhwZZ3xHMqEMo3Y/ZLqCUzdbnTfE+68KoZMev05Fv6GRtPLLLD8VVnv3EFnm8peBg9MU5+UBPbf5GnlcUXamLJHbQq4aJIX+2RnTfaQr6KSs6sn1wRvCpgkzh8DqsI1NXh99V2aNuvDwOH4MZX3Fg8lPJb1rfINgkkov07a4nVfFYSEriNb9cHKyvt4RSz77PpwP974i5Qbyqdk4YuYmdgxP+hr+ldQTWYto476eGP2aLOy4+XN8GjSKZmnCx7x92Q8Red2lXji0v5JQ7ugyW7aidA2TpWYToBwnCZNv8rsVMCnY9maeeJpxoRFanjvk9evm/ufRhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRZQSGGEpyzaH6iSWrihT511XtmJgYtwzYPYTYpdVY8=; b=PFqyzs5GbOUsCcO+FeoFCH7ImcweAufsk0dHo+z03FPyyshk5N0DtEyCm0XxyYqOjgPs4GWZDrTWKK7Dey/spjHRZ1+HIvdo0MF2HJT5gteNjDoO0P27EGOgAhfZLyHd8trjub7H7F1XvFYbRtkjEWbKHaAb80n9VceaBPa0W+BTQ2PyCbA9kgi0UpodQHJCPVl9Ck4OvpURewIqDWdCvloQWlotg0LdwxPmrhGe5Qo2natOsQGM9OXJFzS2o/F/1GIUfqECuHZ2bIgx2oj6yfkMZNT9GxIU6CEI+kWI0tKga777YjtiIE7yV0dlq6r2SbNEwcNGka8YCMtdgPL9qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA9PR13CA0081.namprd13.prod.outlook.com (2603:10b6:806:23::26) by SA3PR12MB7921.namprd12.prod.outlook.com (2603:10b6:806:320::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 09:52:49 +0000 X-Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:23:cafe::2f) by SA9PR13CA0081.outlook.office365.com (2603:10b6:806:23::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13 via Frontend Transport; Wed, 3 Jan 2024 09:52:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113064+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 09:52:49 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:47 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 3 Jan 2024 03:52:46 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 3 Jan 2024 03:52:45 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors Date: Wed, 3 Jan 2024 15:22:39 +0530 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|SA3PR12MB7921:EE_ X-MS-Office365-Filtering-Correlation-Id: baef91c9-c151-4089-43a8-08dc0c41bf02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 7kW7DGdtHUHtIu0jmpQafaZLv1muCAtoe0HBMrcM+iCBJlXIzHleJGAmVvhv6LCqKJ2i35yRQDyUJwYQ+y4pvdJFhWCezNizJOQnLLF92ZonVbgYqiedTZ64NsOSlq2rYynwEtxNB8ZyplnOtiRZjOSD/hm68us8lZ6IyO0lhBTQrJFtbZVw99jWxe86EhMvIgZ94N5g4NucWWUI1L0C9n4IVEOwUmg+IAsonVZ546bjqFv4ZdfQjsx1dCd0IGPNbcZkj3Mrv+dDCw7epGZnBFNHkTYLyxw01JQNsZ9CcRKkjclsjG87WAiEyFOMMvyaiMb2+A1GJm8HlK8fapdiIhwovIvraqy5656GROO6+DMEWSHcS6m7CHcbS6N4zsmi2oqD8xlCogTmXASEqMstnIPpofiGbKm615gFUgTbcmm5GDBZCfpyPDX7OoUNCilx2K8B/9bPBk05Xl/SRomG0dPADCdxZZgxf7NoyycL5khM/3vjJ/21R4oP9W/0i3VYpa6p3qZ0Cm9lTt2nK79Mxcl5wC1bwFgFbkwwGrUzfSeDCFaDUkewLIsvRCBSYm+B4DjKkEZqqFMUW7ACqC75sygI7LMF53BGaTldYqTzen3n34rS9M4YipSBcBPUCH4DN1KFKNkcX8/slAQ5Z45tEtOk0pkY58fKJMatbjBd+yQFV/vW6kyyXS1Dk6DASXxeNHih5b4tc9df1hFfJb0Vre9mqNqDE1JQW7xFiK1WU96s6QwjGwAn6AE+oaX8kpe+DQYoKhvO8kB7JGFjINqfc5bmFTkuzWVNjeoneIIhQLJXiUSzYcbZqMU2oI9Wom2x X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 09:52:49.5990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baef91c9-c151-4089-43a8-08dc0c41bf02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7921 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MNbzpGwBFbxjGYMqM4kG78nOx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704275573773100001 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add the support for X64 compilation to the CI. - Fix the signed and unsigned variable comparision. warning C4018: '>': signed/unsigned mismatch - Fix the NOOPT build error for IA32 by replacing 64bit shift operator with LShiftU64. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Sami Mujawar --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 2 +- DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index a2db14efaf..2f35ac82f2 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -15,7 +15,7 @@ PLATFORM_VERSION =3D 0.1 DSC_SPECIFICATION =3D 0x0001001a OUTPUT_DIRECTORY =3D Build/DynamicTables - SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|X64 + SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|IA32|X64 BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT =20 diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationMa= nagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Config= urationManagerObjectParser.c index ce494816ed..c1a7528419 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c @@ -1130,7 +1130,7 @@ ParseCmObjDesc ( &RemainingSize, 1 ); - if ((RemainingSize > CmObjDesc->Size) || + if ((RemainingSize > (INTN)CmObjDesc->Size) || (RemainingSize < 0)) { ASSERT (0); diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b= /DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index e33d6e656b..12c67b9811 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -170,7 +170,7 @@ AddAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32); + LShiftU64 ((UINT64)Generator->AcpiTableSignat= ure, 32); } =20 // UINT32 OemRevision @@ -257,7 +257,7 @@ AddSsdtAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32); + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); } =20 if (AcpiTableInfo->OemRevision !=3D 0) { --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113064): https://edk2.groups.io/g/devel/message/113064 Mute This Topic: https://groups.io/mt/103499170/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-