From nobody Wed May 15 17:51:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112754+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170306514385715.943383466426212; Wed, 20 Dec 2023 01:39:03 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=IXPH7HpRCHDeXZQ9ESe2DMgBdWeqAqIZTr4PS6gjJsU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703065143; v=1; b=ehaXZOkVzNzGc6q+2pNMtAOIJicnGSqGVYrwGn8c2IJYSPX1GoQ/iJa/KOTzTo7XYXYVU/VI Qlg/jmxko30YqRZT4sxVfn7EOYuA4umBQADCHn2MbDK4rIDWs1rnAaUyHwhWby9cVoCRb3kE69v hV/Tz9gkgWljsZER9mF0OASE= X-Received: by 127.0.0.2 with SMTP id RTxjYY1788612x2OKqazwWgX; Wed, 20 Dec 2023 01:39:03 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.82]) by mx.groups.io with SMTP id smtpd.web10.18450.1703065142853712657 for ; Wed, 20 Dec 2023 01:39:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lnKyy6S+tfBJfOSVr0R9sUDNftD0LaIjISR8OsSAfUoTzZMDK99Xnv/AOPv8apPZB+uoyK56lx3BQqtFlb/EV9QAWTW1mun9jvBv34EGmlI+UKRJ1c8cX0Zsw69ZWY8gQdN/6fW2oBoW8ucV1617o6FwIg+2iiKe6z88rKu35dRTfEVMsP2OMYg1hx5ju8jNRr2FBOlRvQ0to0/rs/txoTO7nOgWX7kn1Jsgvyg9SmpvRccBRC3GGcb8LGQ6kvVeYxzj17ayIKwa6wBx6Iw3ChPTbPP8qs87JChTRKmjX6sxtC5aNjO4F05wI1hKh/qX3F1hhZzUPo8nwfx7aexyWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS9MMwBZ4cFDzPwKn5dgKFC3GuyMq1ZN7j9sRnTgvz8=; b=Lp6XyIjbF/g9H7z+JzfE7usrcId5PlS6BO23InPCXeVkJ9+k2vT4Op1Nk1QWGomycFTZnRpt22m0E5R0FzGqluzUh+f1lhvF6U88Z+oBraY488uKqQ0wYWZfn49nr81sqh0XN2cN4wPzX++v87LZLIb6a4Tayi+pSAL8TqP+CqTWoxu3Pz64qh65P1RsoEnHOf1b3d2cwMqBfzV0dNppMaE7qo2VesaYegD+57vN1u/CL7zWSZY+TpCDtcpbR266rQl29MyCHzjBVoJyZnlFkwfoldSO3Pw2UQ/HPZpX3MNAwEkA9ZDx/Y1JNlYKuE570Mx39bylRth53zznHJj8vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA9P223CA0028.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::33) by CH3PR12MB8933.namprd12.prod.outlook.com (2603:10b6:610:17a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Wed, 20 Dec 2023 09:38:59 +0000 X-Received: from SA2PEPF000015CA.namprd03.prod.outlook.com (2603:10b6:806:26:cafe::f2) by SA9P223CA0028.outlook.office365.com (2603:10b6:806:26::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.39 via Frontend Transport; Wed, 20 Dec 2023 09:38:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112754+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF000015CA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 09:38:58 +0000 X-Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:38:58 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:38:57 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 20 Dec 2023 03:38:56 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v5 1/4] DynamicTablesPkg: AML Code generation for word I/O ranges Date: Wed, 20 Dec 2023 15:08:48 +0530 Message-ID: <5b55e437561bb634f848050fb170b804c519c7ec.1703064925.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CA:EE_|CH3PR12MB8933:EE_ X-MS-Office365-Filtering-Correlation-Id: 65f492ab-811f-4f44-892e-08dc013f7df7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: AnTNaPAdeLB4EQT8nA18BQqe7n6UYrKq3alvnN0dNxoFMcYYbZHsl1dft5iy1t9CEAdBrYtXhcQFjYWd9KLCou4wdemUNT42HTrrSaaIUz2BNY2R73rXXHrw99o+QgOyGt0tlqY+c95O5JSxEw/00VyQFVonhLv9OtpOwV3CnJwWOb0DGK+x9O8TdirxBD620wAd40dTkkc/dcaSm67FmZlZbEEXo/7CbBcTTiIiVG4F+GzEdRdBi2tD/Clq2nxXWZ38otzLF+gt2p0PVSwGB/SpPoQkkx1ZyRnEhELl+OTX1jiyjMWrhTmvHCLI+n9e+ik+YIutrIvgTaePI2jntgyg34dWW+Izmn+OyyzJnIHwPPKcvu6Xun7qGPZcyRw1ZL0bcKegPQCrj+b3OjJL7Xcr6gMe+R3RmKY24XNg5xgKa38PLHtN7I+z85GOUgVoYFqJK1+VmM0NHedgtrqFR2OgIsSoWB2CyKv4avaGy7n908vFSIy3WUhmnK3ex262upzRWRSqz8mcac5HQPT3B15ZNReZRuDb1KDamV4abBx4QV36d/x6BjoGx3oIHwF99b62gpn1r1Xf/2tRLBmokMhIbrk+9OhjSq6fwp2s//vjU92M3cR1ODiRLzPG2RZvfahOxioUYlHO+iYIEveDeam6nE2WO2WtEO+Q3fDlkI4C3oEqjtCF2nqLps/b27MUOSvBoggn+X7KAZPT8ZFsPXTpQAqbwcys4/E+vQ/Rnbbr+aFfFfMz74DjymAVvOx/Yu8Ip0d802tMApjbUEQOIA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 09:38:58.6928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65f492ab-811f-4f44-892e-08dc013f7df7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8933 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xjTnmrE1eYWMOsXO8OBKfZzDx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703065145321100005 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add helper functions to generate AML resource data for word I/O. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Include/Library/AmlLib/AmlLib.h | 65 ++++++++++++++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 88 +++++++++++++++++++ 2 files changed, 153 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 71e8539b30..5e340b94ce 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -2,6 +2,7 @@ AML Lib. =20 Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -724,6 +725,70 @@ AmlCodeGenRdWordBusNumber ( OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL ); =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ); + /** Code generation for the "QWordIO ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 0bc1c1d119..60fe69ba6d 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -2,6 +2,7 @@ AML Resource Data Code Generation. =20 Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -878,6 +879,93 @@ AmlCodeGenRdWordBusNumber ( ); } =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ) +{ + return AmlCodeGenRdWordSpace ( + ACPI_ADDRESS_SPACE_TYPE_IO, + IsResourceConsumer, + IsPosDecode, + IsMinFixed, + IsMaxFixed, + RdIoRangeSpecificFlags ( + IsaRanges, + IsDenseTranslation, + IsTypeStatic + ), + AddressGranularity, + AddressMinimum, + AddressMaximum, + AddressTranslation, + RangeLength, + ResourceSourceIndex, + ResourceSource, + NameOpNode, + NewRdNode + ); +} + /** Code generation for the "QWordSpace ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112754): https://edk2.groups.io/g/devel/message/112754 Mute This Topic: https://groups.io/mt/103278518/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 17:51:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112755+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703065145794884.8955827715305; Wed, 20 Dec 2023 01:39:05 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=SCHrX2kEFte1Q8+D8w7AeR5AYccKH6z8nN9ofU1s8rU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703065145; v=1; b=rUKSLCQB25AiTzKnCQEwd3pX9wm4GYHtG/L0gdkbJ0TYIkJt4cAvsdst2mZCW86rtpwSFUQj df7iPyIi0980rBa9/SPqC31SSNEDAludS86BaTUM4NGUkDf7ZHf8WpD8XFZ2uKiJEW+HZPAkd8G lJE0V8eXpacX7/XhHGixdDGU= X-Received: by 127.0.0.2 with SMTP id XQYpYY1788612xYiZfoZJFHi; Wed, 20 Dec 2023 01:39:05 -0800 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.89]) by mx.groups.io with SMTP id smtpd.web10.18451.1703065144683764056 for ; Wed, 20 Dec 2023 01:39:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPujPoiSG7Iwi47sp5hGmpmiZGzP1+WHvgOfMrHo5hPmT/a+t+rDuhgdbY61BqCwGwrhEkUomEBTl7Uj8pqY7892h9aQEnQee/Oc+5cWlrwaHsdbC5C7uwy+6bK4A98Ey8D+5Fu/iOeHwRUBjozrzcONeWVDa82K+gOi8m/p4KdSsZ3l9XPE5zySHQmWDUdbJsiSXpBbC5dPu/iqVOSM0Auuiipv8LaMLSLBS5suRp9kuxgiSPN6A8EZi6kjpWZHyq4hX3zIlHLUyFiy+rDglF3qeDxuEU6+ZUGq/1JzEXr5xdY9zasWQrn3plflsMNMiYcFSWsmchSyZqPfbNSFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7rLn+dce5q8QqQVI4aPAz3UY21Ary1U67HW/Sc4uu8=; b=dxwByxAXWEaChQgU3tJGCUL9nw0TPN4a305Qd7Kc63dW/E4mCQQU/WQhL0VRkiw21javvXx53giSJwzt28yQ6hwhlGgMXvUn0h3p5UZ0NN8aYDBc9LQ7U11qGvg24VYi8h9z6IZN+TdaZvHhg1i7cwQqbmGofPGY9QDjSElHCDVgRfCIJMkYpXvWndIMxT8p4GVZ4m8MNubem2GlALhEPDXLKNcsJGXXB8UbGWJZcjYhV0R7MhWWyDspE2sq/CiUEGVGz+gcV1IvPo/7J4+okQDPmuIXuvVORWJgnKKdji2G7UxXIbtIacDtYoHv32vR4KzMlyjlqouSjkyahaxJOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CH5P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::20) by IA1PR12MB7758.namprd12.prod.outlook.com (2603:10b6:208:421::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Wed, 20 Dec 2023 09:39:00 +0000 X-Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:610:1f2:cafe::64) by CH5P221CA0004.outlook.office365.com (2603:10b6:610:1f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18 via Frontend Transport; Wed, 20 Dec 2023 09:39:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112755+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 09:39:00 +0000 X-Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:39:00 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:38:59 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 20 Dec 2023 03:38:58 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v5 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters Date: Wed, 20 Dec 2023 15:08:49 +0530 Message-ID: <2054729cf9d6245646f846b4f19ba6c3e9b80ae6.1703064925.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|IA1PR12MB7758:EE_ X-MS-Office365-Filtering-Correlation-Id: f4be8f00-8861-4ceb-be7b-08dc013f7f0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pRPOlb8zt2rUbtwcLBxMKtgITDfoShJhSvU/p+uJfbigk8kPd4PUiRSG7NKFAfr6ztnkktZAM1lbf7NyNv5enyu2QH4Rq+gA7a0gz45GyREqUYjwTaGEuTmWRHvZ+Mu+2V5eU8zUlDxvvrO3qAAS9qA5pQFtG5RLBM8wIY/WuqmbF0G/NiSldRggs3OnLxbFzIROaspYSedV4CcuNBlg9hNlX1d8h8P2D2fkS7/a+Ep+6tiWNl53syg+sTLqk+eqOBXXTFiIdo337DnquUJ7RI6zFRWjVDhWTQent35yfaaIzldOWDNtpbTZ4VYuWF0AaKeN89qjCpLlcVrLUwXa/j3mmF1ZFPw5RSlwCnpMRpV8TUv79ZWs0+ZiJl/9SU7VXCqlg041BmCTCZ8LPvP+qur1lLqBJ2mxRcX+8Y2Ha6FfQtDeIKCdVg96xCOyco8Obkyh5mvywAYmpJfBhYj9Cs4e6drYctRDlE6LuDfxPiPH7OLjtD6lgUEI1B/7/GP0a/mciSUy9gO1Jd/t2poYasAmt2BCcG9CJqxuXQiAp3G1WybwNr8ojiYltOCw2+dE4dKya2gZC1KR4rvFIYUpWmHgoRRjkSHNl042WLcG0KLn3EPB8KU/hmxFvz3QCzawKqiIjwA4GBUz9tOLs15BeIctQKUMc+zGA189B8R9IsPpQVHoBfA0FlkVus6J46bYpq+Tx7gYbBZreAEnvYwAIy+uSv4K3V+Pb0N2UBg9BMN17/K1bxrUe0Ddedi0D8fk7rpQKLnAFCOUB8jnYCSNYA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 09:39:00.5095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4be8f00-8861-4ceb-be7b-08dc013f7f0c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7758 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Cvcl6Ns2lYJj05xnfaBYMxTLx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703065147303100010 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the parameters of AmlCodeGenRdWordBusNumber() to UINT16 to generate word bus number. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +++++----- .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 5e340b94ce..eb8740692f 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 60fe69ba6d..46243f981c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112755): https://edk2.groups.io/g/devel/message/112755 Mute This Topic: https://groups.io/mt/103278519/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 17:51:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112756+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703065146926606.3290076870902; Wed, 20 Dec 2023 01:39:06 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=gRrmY/RuJ3jnMlLUv8qyg8j7w/Pp+P7cLMgH0FQS/kg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703065146; v=1; b=WiCADUyZjGvWACjSfbyaiKwJQlZI0B0L4nugSzO7PfOlJ8gicyqHYhZrhl43Okqg186Gsfc1 9lHnJ+7le3qXuJKXfWuwyFEk6DXm8xQ4NRwaq7aaUYDDPkDEJilfL3luzV4YeoWPn2K20E4Axeb b5b2L9lP7ur8BWWhV+uJaFmk= X-Received: by 127.0.0.2 with SMTP id e3wwYY1788612x7hq5pkLgYi; Wed, 20 Dec 2023 01:39:06 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.66]) by mx.groups.io with SMTP id smtpd.web10.18452.1703065146005620029 for ; Wed, 20 Dec 2023 01:39:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W42f39fkOd8eYQLavyZzkVnArQPuq4/CvxpNELd+tmysQIx6SyRZoJPOZF9ZRj5fYVGVbTl6EBcg7CZqOciY/ysOHXCXplQeDHl5JtIRFl3MDT3fa0qmHimCp96XUe0dDOUOIYa33G9a0orD/xl99VDhmNW+AmOSXTaLhn0TihIDSk7tTcEELg2HZ70DYlPSaExlWiWomcyw4Ax4AkRmOdxxhKNRhhEax5rIAFVAflVprvgyFFiThVqaA5ZNy6EoA9qqPkrevC1Q6q5jbynf4+BS0JKR9t5qiff2StRrMld49HDjdgsMhq13hzEjx4W2EcpxWzDvWOPRf6w0J+kduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Kb5JpOj9coXlncB+5Iq6ppdMQxvnqBqbcCRPEJWFD4=; b=jKKOGeDWv+JnvznEHdH3P6mUZn9ZquhHifz8Yco9zV+B/+bFNuJrDRjl1SkFVb+yjHwmw+Kf1PBgvD0i3EOZGbvrSxbprLvKg7sVyDoZiTjHhDFNNxarED2VxsK21nHJQpWNMyd74ax8TiKOHPQ98iF8pLzqc3+Mfm4yCUsAtRhx/eCyFsZqQKynmH7SQXDlDApRMRKYMWluL3OE0w4/BDGFZK7dI70zeGEpeyJf5xkEoS5PE2a2PkoHwfqQxquMSO/WJkJBlCbE52ErlOTY+zekReCmUammw5ja4PcMIKPgdubF4TiAvFKbf5n5VEf7EEnHNfPowcl2q03saATN1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR11CA0056.namprd11.prod.outlook.com (2603:10b6:5:14c::33) by IA1PR12MB8238.namprd12.prod.outlook.com (2603:10b6:208:3f9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Wed, 20 Dec 2023 09:39:02 +0000 X-Received: from DS1PEPF00017096.namprd05.prod.outlook.com (2603:10b6:5:14c:cafe::2a) by DM6PR11CA0056.outlook.office365.com (2603:10b6:5:14c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18 via Frontend Transport; Wed, 20 Dec 2023 09:39:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112756+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF00017096.mail.protection.outlook.com (10.167.18.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 09:39:02 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:39:01 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:39:01 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 20 Dec 2023 03:39:00 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v5 3/4] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION Date: Wed, 20 Dec 2023 15:08:50 +0530 Message-ID: <7e4002c31255264cbd2daeaf854e4a1e6737c558.1703064925.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017096:EE_|IA1PR12MB8238:EE_ X-MS-Office365-Filtering-Correlation-Id: 10757ac2-3b77-4f5c-021a-08dc013f7ff9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: h9y3fpXva4WXeonebm0yadrrbpSQFb0C8B0+OnLWcHtwnpc0bNjndeRZ8p98q+mAsdSwCDlf9z8lqdxWG/8BXfHQpMCzupTiReQ6An6q6ijDdShn+nO2k57foW/KpjIcK5ZZccPHIi0sfnC0L4jKMVl9UU4gR4jjKBpWfEvg7MytR7777am/+/37t3cHup57NmD5eH9Krd4vXCvTHBnf8ZSPcsCgmA96Jnwy4YXIWb13u2H4964r+M3jOden9bGvqgScySZBD7Imf8bKbdXLtn4uu8eGWDDGZXmPZJynBAJXhW1iSzevX9/S0xbMKja6xAWMQu5yHaX+NCRwPcsEYiFeWllavPITZaMgZJGBD5rWiWe2KmXC6C13nTaMn9zu2A5HD4maf8Z+K+7XpJ1zgiiGQi01aG5eW2vj9vyMS4PDBLOaLo1zh/rLzmbylTqAz3xv0m4zT/7VyIIPatMMI3Gd6aAE0pjPlYn7vPBWwteScpTdJNTeK2w78gUAsPkc+kv/ZN1g84SSCp8hWMywCR5u3Sb1k0UO7G6xp7mGye48/tuqfMSjXNkt8A1hcYVvNZWCOns3yXE8k7RrRq7U8JWsL6ySVkeB8MCMco1XJJqIdFSunGXWYiGa3XiebEYsWD0S+7GcWeYHizEgLcaD79qVFeTM6JKwaI0g4QEDgZ+rUOEVEWqA2gwVxvZnwVS/maEQ9+jRnpLI7rKCKjooO2EoJhgUbCizsV/9tHDqXa0VhvCuk1X/Yur+AwsN99YUM7n9WZu2DJINgSVpuFIKxg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 09:39:02.0579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10757ac2-3b77-4f5c-021a-08dc013f7ff9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017096.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8238 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B4nuXPAaJgyeaPy6molnIPBWx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703065147283100009 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the function pointer typedef AML_PARSE_FUNCTION, otherwise some compiler like VS2019 gives error. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 8e584d4930..d3a51a94c7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -100,8 +100,7 @@ AmlParseStream ( **/ typedef EFI_STATUS -EFIAPI -(*AML_PARSE_FUNCTION) ( +(EFIAPI *AML_PARSE_FUNCTION)( IN CONST AML_NODE_HEADER *Node, IN AML_PARSE_FORMAT ExpectedFormat, IN OUT AML_STREAM *FStream, --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112756): https://edk2.groups.io/g/devel/message/112756 Mute This Topic: https://groups.io/mt/103278520/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 17:51:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112757+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170306514766591.2479047025704; Wed, 20 Dec 2023 01:39:07 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=kbAYxM+vPj0tmUYSdzSVsvjFyKQAP8e/z2/hp4/Hh8g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703065147; v=1; b=L/TIKDx64W0eqsmbTdiDlXz2lf3yxKNxrhZ/hwilzHZwwDknjoyofg52loyf5o9tuQYJrpWI +gdqiFq8PSHQK3cqlbNYx1w7H8/NNz5DR6qWPOQzGHrZNJQSZjznjgMpZMwkBinKONeIC1HJwyO HroeTem3n6KovYazrWUyDPww= X-Received: by 127.0.0.2 with SMTP id kVj9YY1788612xT3iJ4uCzJa; Wed, 20 Dec 2023 01:39:07 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.43]) by mx.groups.io with SMTP id smtpd.web11.18250.1703065146586709817 for ; Wed, 20 Dec 2023 01:39:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlYzW3swDPRYbQw73vVoDfqzIyUFsw1xvcEEbTOgmBjxV68zlXIy+qc/dBhzbU4dMCQhfyYTxRef7FcPr6OYqMLnXbOyxou8CC1JRHCxPko0Pm8eCwcnUt47jiUIbvB7IiOshAY7Wpxs3CKeUsssoUpFt/ifiYnHp83Wv2uIUWBzZtsMz6wyTK7D6eu0ojBHmEX5M66OBhz9/AK0i1M7w6NU4JGAp0CaetNw3GDoLlyPKxyyqZVqRSwRxe4MlOQNfyhPPlRESLO7DbFmzvJo0w26TuhM2a5lJ9qXnyfQh6uLNz2AsUDufSWq4QFCvoxhzNRLbYTvunMtlVG4lKZYeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeouz/5So9nz9p2rARz3MGX245BRuAQFliJwTfrAf8I=; b=khmyBdRdehwDhHwywV0XcgNNThdw5E9zj/f2mNE1VtkYrjSqfANvrGjGyCbL200H+cqKwOJQFvHaLIBzWKyQETY9DIZAkKvPQ1x1yI6GyJHRlH3i6UixI1V2JY95uA8JkUq9Z1EtgYYzHkVF7+q+XVyyb+eAYG7t7p4hT/vubposYXiAZQzzWV7S7uus7lAevuUlzG2N6ERmcWqpCn3Fp6C3CPO9KnZhF4uT2JfbagXcSUq/hem69B5uBmJMxDlNmv8e+yxsO8bwYToJdLFC+6WXT5yhqPzAkREjwz9InpAwj91mg41sxTeBGGKf8zLAWdjC/QKMB883IGDI9gB9mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR05CA0060.namprd05.prod.outlook.com (2603:10b6:5:335::29) by SA1PR12MB7174.namprd12.prod.outlook.com (2603:10b6:806:2b1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Wed, 20 Dec 2023 09:39:03 +0000 X-Received: from DS1PEPF0001709A.namprd05.prod.outlook.com (2603:10b6:5:335:cafe::a3) by DM6PR05CA0060.outlook.office365.com (2603:10b6:5:335::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.16 via Frontend Transport; Wed, 20 Dec 2023 09:39:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112757+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0001709A.mail.protection.outlook.com (10.167.18.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 09:39:03 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 03:39:03 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Wed, 20 Dec 2023 03:39:01 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v5 4/4] DynamicTablesPkg: AML Code generation to invoke a method Date: Wed, 20 Dec 2023 15:08:51 +0530 Message-ID: <0304349ab5b384980681427b98dc3313faf279eb.1703064925.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709A:EE_|SA1PR12MB7174:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b8b0fac-d354-4ce0-6b3c-08dc013f80f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: fVY6I1y6KCbxNTiFF8tMK1XfEfer/5qpVJyN32LriC4s0vHLm84QHtyTmKrnMpB91HOZt6/qfASeKhFyIPIiGOlqQSUcwdSJY6XuMkr1ZluOVuIQLnqjBVkTkjCLMQ+ga5rsICbYuTU19lpyMikVBwEeMsd+1c2/xpK78z3T92An7JW3FyFlH25ZpTt1Go2y7OHOcDPL9x5y+Lmz6Zlerw11nvXDeNH4xUaPzFljc1153CrlAe4XtnEDgVbetV94ZuC/temOfyr5lqAsjKv6EyiBS0uNSGBm40YKvM0kab9E9SGa9gerB8K/aeQ07IwANjWDMQ6FAbCgszs3aDN6r1bLgOw8atGX904PjzWf2z9xWzlOXUGJ+0eJ9dbnCVaoPffo+h3KoBKhvUrn90g/LQg8ZWb48JDGRf+7UoveO7St0YfvANXq6Cp8QvRfiP2ly31DP0YRy3HD6h8q87wl3LHYTQsgH0L96rDilsIiuj3amufeYLfXtPKy0rCbtAnAKDXRewQR6FVT4P6F9No//l5YHZXeFqeNh1LELZLOVTJaIOR0l04U/cvSo7YEJA2XuVeaQgTMUj8DBHacF7eznpJoIcONFiNQ4r+x3XQ18syoM7HtgCOJuDRl++JysdJ3hkshuvyJL8zqgG5jiLcucaDD4+1RayBmmWXcnQZvbC6HROiukvQP47WlP9/Z6HVcMmpSBWNM4uefoHrM3JebHd+6BgorOTce0Kry/iQQnU30nBf2D/a4kV5hOEG0ClpQaJEWaoPo06CgnVILi/VgUw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 09:39:03.7121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b8b0fac-d354-4ce0-6b3c-08dc013f80f5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7174 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9nk766CwJE0uZuGcLx66n9KBx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703065149321100017 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type integer, string, ArgObj or LocalObj. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 112 +++++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 235 +++++++++++++++++- 2 files changed, 346 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index eb8740692f..043ec3d842 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -101,6 +101,56 @@ typedef enum { AmlAddressRangeMax =3D 4 } AML_MEMORY_ATTRIBUTES_MTP; =20 +/** Method parameter types + + Possible values are: + 0 - AmlMethodParamTypeInteger + 1 - AmlMethodParamTypeString + 2 - AmlMethodParamTypeArg + 3 - AmlMethodParamTypeLocal + + @par Reference(s) + - ACPI 6.5, s20.2.5 "Term Objects Encoding" + +**/ +typedef enum { + AmlMethodParamTypeInteger =3D 0, + AmlMethodParamTypeString =3D 1, + AmlMethodParamTypeArg =3D 2, + AmlMethodParamTypeLocal =3D 3 +} AML_METHOD_PARAM_TYPE; + +/** AML Method parameter data + holds the AML method parameter data. +**/ +typedef union { + UINT8 Arg; + UINT8 Local; + UINT64 Integer; + VOID *Buffer; +} AML_METHOD_PARAM_DATA; + +/** structure to hold AML method parameter types + Type - Type of parameter + Data - holds data of parameter + if Type is AmlMethodParamTypeInteger + then Data is of type Integer to hold integer value. + if Type is AmlMethodParamTypeString + then Data contains null terminated string. + If Type is AmlMethodParamTypeArg + then Data contains the Argument number, + 0 to 6 are supported value. + If Type is AmlMethodParamTypeLocal + then Data contains the Local variable number, + 0 to 7 are supported value. + DataSize - for future use +**/ +typedef struct { + AML_METHOD_PARAM_TYPE Type; + AML_METHOD_PARAM_DATA Data; + UINTN DataSize; +} AML_METHOD_PARAM; + /** Parse the definition block. =20 The function parses the whole AML blob. It starts with the ACPI DSDT/SSDT @@ -1693,4 +1743,66 @@ AmlAddNameStringToNamedPackage ( IN AML_OBJECT_NODE_HANDLE NamedNode ); =20 +/** AML code generation to invoke/call another method. + + This method is a subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent to the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent to the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent to the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString The method name to be called or invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters Contains the parameter data. + @param [in] ParentNode The parent node to which the method invoca= tion + nodes are attached. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a6db34fb97..ddec9b67ed 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,6 +2,7 @@ AML Code Generation. =20 Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -921,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status =3D AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { @@ -3849,3 +3850,235 @@ exit_handler: =20 return Status; } + +/** AML code generation to invoke/call another method. + + This method is a subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent to the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent to the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent to the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString The method name to be called or invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters Contains the parameter data. + @param [in] ParentNode The parent node to which the method invoca= tion + nodes are attached. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ) +{ + EFI_STATUS Status; + UINT8 Index; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + AML_DATA_NODE *DataNode; + AML_OBJECT_NODE *ObjectNode; + AML_NODE_HANDLE *NodeStream; + + if ((MethodNameString =3D=3D NULL) || (ParentNode =3D=3D NULL)) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if ((NumArgs > 7) || + ((Parameters =3D=3D NULL) && (NumArgs > 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + /// Allocate space to store methodname, object, data node pointers + NodeStream =3D AllocateZeroPool (sizeof (AML_NODE_HANDLE) * (NumArgs + 1= )); + if (NodeStream =3D=3D NULL) { + ASSERT (0); + return EFI_OUT_OF_RESOURCES; + } + + /// Create a called or invoked method name string. + Status =3D ConvertAslNameToAmlName (MethodNameString, &AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + FreePool (AmlNameString); + goto exit_handler; + } + + DataNode =3D NULL; + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + FreePool (AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[0] =3D (AML_NODE_HANDLE)DataNode; + + if (Parameters !=3D NULL) { + /// Validate and convert the Parameters to the stream of nodes. + for (Index =3D 0; Index < NumArgs; Index++) { + switch (Parameters[Index].Type) { + case AmlMethodParamTypeInteger: + ObjectNode =3D NULL; + Status =3D AmlCodeGenInteger (Parameters[Index].Data.Integer= , &ObjectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeString: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Buffer =3D=3D NULL) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCodeGenString (Parameters[Index].Data.Buffer, &Obj= ectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeArg: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Arg > (UINT8)(AML_ARG6 - AML_ARG0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_ARG0 + Parameters[Ind= ex].Data.Arg, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeLocal: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Local > (UINT8)(AML_LOCAL7 - AML_LOCA= L0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_LOCAL0 + Parameters[I= ndex].Data.Local, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + NodeStream[Index+1] =3D (AML_NODE_HANDLE)ObjectNode; + break; + default: + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + break; + } + } + } + + /// Index <=3D NumArgs, because an additional method name was added. + for (Index =3D 0; Index <=3D NumArgs; Index++) { + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + (AML_NODE_HANDLE)NodeStream[Index] + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler_detach; + } + } + + FreePool (NodeStream); + return Status; + +exit_handler_detach: + /// The index contains the last successful node attached. + for ( ; Index > 0; Index--) { + /// Index contains the node number that is failed for AmlVarListAddTai= l(). + /// Hence, start detaching from the last successful + AmlDetachNode (NodeStream[Index-1]); + } + +exit_handler: + /// Index <=3D NumArgs, because an additional method name was added. + for (Index =3D 0; Index <=3D NumArgs; Index++) { + if (NodeStream[Index] !=3D 0) { + AmlDeleteTree (NodeStream[Index]); + } + } + + FreePool (NodeStream); + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112757): https://edk2.groups.io/g/devel/message/112757 Mute This Topic: https://groups.io/mt/103278521/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-