From nobody Sat Feb 7 03:43:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112198+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170196439767624.364470368700267; Thu, 7 Dec 2023 07:53:17 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=5WI3gCFAATvh/PdUTtj5y0WYLn61oJ+HAR0oK/amcBA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701964397; v=1; b=oUF18ixmzLJe1Qu15v5j1UDUNgSJH8xhtIH0+00slTEOUzY5OpCzKfsmeiUBSeHGwFkqG11i PG8Vrd+LO/qDALD4FwjW2R3S92G504TW/9Yp1Ji1NMClpsFeDnGDTbfC54lLN2Djk1CdZoknByc VwpfsnhrkFCa9pK7bf4Bc0KQ= X-Received: by 127.0.0.2 with SMTP id Se3ZYY1788612xsC0jMrgk69; Thu, 07 Dec 2023 07:53:17 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.48]) by mx.groups.io with SMTP id smtpd.web10.87823.1701964396548997819 for ; Thu, 07 Dec 2023 07:53:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnRtfRJU/P9sBUNpAsAVWnYn53adkItRZivwBqdG3AqxMG18Qf+MzbXAFM3m/+YcWoXdUGn9+3na7OwBk/3FAP2ggUgK8d3qIj8ZHtxMrb0S/cqXVBq93fIb/uvCV35Udn7Y2b1jr+0Bp6KDSyQZqLT7qz3T+BCogNp/0pu0mBRd9xKJf1YO4SCNDKWXqJYxsyCANs6T90RZZ+gT02Q+3x5lCMaQe4fkDlufrZEvO4pX3jywtz3OZRUWJN6dQovr09LvfkLReOctlLhr/HIvUCRnei/2SAQPnSIBP3UOS0Z6xWmA5GYZOCP+WgSKm7i1/zzAq43HHdF+nt+iR1KS3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS9MMwBZ4cFDzPwKn5dgKFC3GuyMq1ZN7j9sRnTgvz8=; b=icSM6UaWUJfzT+jlRBtsrOK5y4ckLbrvkBtpD0VnCoYR0M6XUORMi7aJ5r5jFHnr4bwUEWYIgefyGs2ACn91D3sB/dG/YmhB2e51U+lB3qJTfp0lp57ELv/roInD1b2fImbxqpoFc0yBcEI5Diy2fqKNO/Onf8Qe6gSbwDvW/RV4mL5X7ZhE9w9sAu0jfiGvam+Daf3H9AaHmhXWJd5zr4miAAZvFjGDw4GLXwYDYDG9Pjd56Ix2878DVSRw2FEbX+usMeu5/CaKMvCIqgn/8R9dCs8k5ImUTr9ImQEKo4/z+rsrCFh45XAK3Q5yMI65JV1oCdVtdNZ0wwlwGrMmrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR08CA0039.namprd08.prod.outlook.com (2603:10b6:5:1e0::13) by IA0PR12MB8351.namprd12.prod.outlook.com (2603:10b6:208:40e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 15:53:14 +0000 X-Received: from DS1PEPF0001708F.namprd03.prod.outlook.com (2603:10b6:5:1e0:cafe::dc) by DM6PR08CA0039.outlook.office365.com (2603:10b6:5:1e0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34 via Frontend Transport; Thu, 7 Dec 2023 15:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112198+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0001708F.mail.protection.outlook.com (10.167.17.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Thu, 7 Dec 2023 15:53:14 +0000 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:13 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Thu, 7 Dec 2023 09:53:12 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: AML Code generation for word I/O ranges Date: Thu, 7 Dec 2023 21:23:03 +0530 Message-ID: <4b1502882a7836d29122f0eeb22f59a24b1ebf85.1701963835.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708F:EE_|IA0PR12MB8351:EE_ X-MS-Office365-Filtering-Correlation-Id: ca03fa59-d9d8-4011-8dfd-08dbf73c9f12 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: VSw6dVYn/MrFl9w8RsMdDthI7UQNHiW6skM2/YJx7Oo847y+EFqVf616Ma77LbrVfw+mhjrtpFX83r8p6g4/bXUxz/Fck0ykrmmlf9pWPaBIFACXUj3veWjhQ37Jmddbo1qVbl7ugJ5/uILYyH1sN0U7078XsVM8/JzvWS/dD07z/BAXR0HnvYCAw2uPqTCPL0IKBU5xVS3ty0+vOlM674ULOxhD4rT6FymPYb4t1apkLA1fSIEq/Ry638d/jR+7U7TDjQS9e8AgrfRGOsud/QfZVnh9FuzA1s8Bp8699X4QLijl/zaNk8lbyAfVXjN/39S8/JC37kILIrXLvL+6cYd3pVjzxZUNTjaRb4SEFGBHb9eYAdENEL7SWk905Zpk+bKcR3zUhYkc74eqcZ5Ts7ehblVrRL7p06WrQ1BMt+B+IizMnG94aOBORGkqHuzt30OPUnH52cn9O6hswPl3UngS1smWhoGAVQOgy9GalIa+kUOlkvEMIGJ6e3f28lRtRndwp9bgxDLT/EgNI+XdkxgAv6jC5l8PzgJwLE/ejuLeLQUJyy4IYnXPpQ0qDF8oV40IaRBxaon4q3LVo+/8KbKQw3QghWclhYIbeDnOD3Dbvuxru/Gdw54+7XdKUMP1Qmw6zXxQCKzfu3EjqEKTj5b+iEvvdkPjXRJyZnANwpVEUn2//7RWYEbgTzfTpjBGuiUjYekymSCHB0BF6jMqEw2wgNACul0RKNjb54ffLVKnoxm+8NDa+i5HS0oX0pGyPB+eM96Fvy0b6wbsymF6aQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 15:53:14.1167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca03fa59-d9d8-4011-8dfd-08dbf73c9f12 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8351 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rwSlz8LoCOAEDxdTlYAgK9yxx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701964398567100003 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add helper functions to generate AML resource data for word I/O. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 65 ++++++++++++++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 88 +++++++++++++++++++ 2 files changed, 153 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 71e8539b30..5e340b94ce 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -2,6 +2,7 @@ AML Lib. =20 Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -724,6 +725,70 @@ AmlCodeGenRdWordBusNumber ( OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL ); =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ); + /** Code generation for the "QWordIO ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 0bc1c1d119..60fe69ba6d 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -2,6 +2,7 @@ AML Resource Data Code Generation. =20 Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -878,6 +879,93 @@ AmlCodeGenRdWordBusNumber ( ); } =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ) +{ + return AmlCodeGenRdWordSpace ( + ACPI_ADDRESS_SPACE_TYPE_IO, + IsResourceConsumer, + IsPosDecode, + IsMinFixed, + IsMaxFixed, + RdIoRangeSpecificFlags ( + IsaRanges, + IsDenseTranslation, + IsTypeStatic + ), + AddressGranularity, + AddressMinimum, + AddressMaximum, + AddressTranslation, + RangeLength, + ResourceSourceIndex, + ResourceSource, + NameOpNode, + NewRdNode + ); +} + /** Code generation for the "QWordSpace ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112198): https://edk2.groups.io/g/devel/message/112198 Mute This Topic: https://groups.io/mt/103036575/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:43:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112201+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701964403091999.1221611913201; Thu, 7 Dec 2023 07:53:23 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Sr6pDrT8ZtQm8wv+Qo8JEeNDp6X7zfLEZit0rCFPgNY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701964402; v=1; b=HqfacPAXUor1hwEAptwQ9Cc83Pr0hsSTQDg4dn4tPpfKH0S3y9frD6n77p5xvWZVmmEXijZv yMKL+Ovvp/b5v7S07aR0WX31jqcAdWlB/cH62ZaukBVH3O7Pj9pILFYAO6thJ8vr2kKWcXELP5c 33wVUg4MuZQf2+RP1nf2Q4MQ= X-Received: by 127.0.0.2 with SMTP id hCufYY1788612xYu4OFgi21f; Thu, 07 Dec 2023 07:53:22 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.84]) by mx.groups.io with SMTP id smtpd.web11.87527.1701964401781836613 for ; Thu, 07 Dec 2023 07:53:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4EyznHQ7e86vOHwyF9ndQ1AY9Ihi3cEAXsRiSyRgkk9NEWyKq02bzW8qeOaawk3d7aB6KFFv9tr19hp/Ejn1g0FrSpUspWpx5RoMCH7KOmb3n7XJ0/11KA3SVVhff8y0A7NK8xF2sPFtfDd9/1YCD/FwF8932moQIdsjL/m+I1p++Exmav5T86U6jfxFTvOTIrV+zeUswsQINll6HCRwMVgpvImWQ69UWMMib8vGxmQd/x5Vv2fcpNE+CtWY9awfZE5ZjJHacroC7V9D9JZ0/K0PsY6x3sZMF7ugbQJssmBwy/Uskmg/d3NLa90rBLUzhAOpVkEyHHYkfmCPZstFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7rLn+dce5q8QqQVI4aPAz3UY21Ary1U67HW/Sc4uu8=; b=dekvhLNRjUEXs38YerXsGKDdtPh1noda0zD801uN7q6Nu9aAZdT3bSNORwBIB6vf+Osxxk0zSUZ6qqKGZs8tEz3FIrv6qAqn3MOqsYrbZtsyEipA4uPSQdqCIqGLgxU6fqQurwsrjC50O7CIUVHc58k0VzazPOHyCtQ9kMSm74IN1fVlx0auturTUdFmLa43YkW5afmt9c14II420gmGkzcs8G1hBDIh4A8dvtbJ0EgCJKv0PRae78aLMvPdCoiFp0tZrp2TF9QXiRLXaC3k35GPQyutfd3Gl1otMbDsQOoG77ZbmxvFiAoLM84JHDBQmBitpK6hwCIvDnf4aJOv7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DS7PR03CA0360.namprd03.prod.outlook.com (2603:10b6:8:55::33) by BL1PR12MB5032.namprd12.prod.outlook.com (2603:10b6:208:30a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 15:53:16 +0000 X-Received: from DS1PEPF0001708F.namprd03.prod.outlook.com (2603:10b6:8:55:cafe::cb) by DS7PR03CA0360.outlook.office365.com (2603:10b6:8:55::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27 via Frontend Transport; Thu, 7 Dec 2023 15:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112201+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0001708F.mail.protection.outlook.com (10.167.17.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Thu, 7 Dec 2023 15:53:16 +0000 X-Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:15 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:15 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Thu, 7 Dec 2023 09:53:14 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters Date: Thu, 7 Dec 2023 21:23:04 +0530 Message-ID: <79b9b6fd6a7a832e92c9e5f52aa865bcd911d9f6.1701963835.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708F:EE_|BL1PR12MB5032:EE_ X-MS-Office365-Filtering-Correlation-Id: baa1b5be-44e4-4507-3194-08dbf73ca03a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: E7VGnrz0M98Rz4xfxvxzYZu1zxzMU2+f2bkdOy1hYwWZ1r+mN484/JB5jP2JVPOpjn3RYJmLburmkbXE31QMLo/CJNqTomoXhUA8xCaq86UC8DQs4uRHpaPwzML+xf9yguDmOwFBRQ4DX4mGvysA35K3q+xZV11FvnUIjtxjOlyZCsPe/k5CW1NwPphQVXvYp02LKgupW/Mg7llWpLZcuHnFqn1Ub+B3YO0ahI7pBZxXx0C+NatU5kVPMahKPlhbfG9X0P4guhjvVne8khDfPrh0HLQb36F2u+M/gLv4okvzCzEEnNEIJVqZo9dLpZR2pEvXXGGP9b5h6B97nze9bsUjpTxitVCudSPiflpqw0lBcGvc1UiDRTozcEE58digdUIgMXOXt85sUEySNY/wnnGhy1Hqq+YEkaXlmXGCo0QRaOMW9Xap12WtgtfrD4/FKDY6sK99ZJfS+QrmdPTPSyTQ0hmvFjGGm736Cjrixj1AJWsVHkZ6gYBwXDEV8T5X9bwyewtF4CNx1zb6h/C8MJBkWejpAz9sSbUokAcpkIYm0iA9FvIxgZ10zU18ept9l+3nuW6lMWLq9k4J7VOTDZX7ctucKFgrWm9DZex9jy21htbYEMdPvpJOAhjSA76syEX7pluaHVsVofNRPjB6NGRb/6LbcPlzsZLDN32FNZHjpldh2Y4CqfqP0r/rAd+wstc+q/RE9kjcW3RQgp485ygtAVZAk2+YB+3SGdQQcGrSc4AXH0xcEsUfRqQAv4dmg+e7gvUpkvHEAtw3RDsbDA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 15:53:16.0542 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baa1b5be-44e4-4507-3194-08dbf73ca03a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5032 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Fd8AKQ7Bklz3MlJNNtotu6hxx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701964404612100009 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the parameters of AmlCodeGenRdWordBusNumber() to UINT16 to generate word bus number. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +++++----- .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 5e340b94ce..eb8740692f 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 60fe69ba6d..46243f981c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112201): https://edk2.groups.io/g/devel/message/112201 Mute This Topic: https://groups.io/mt/103036578/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:43:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112199+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701964401295683.07184183584; Thu, 7 Dec 2023 07:53:21 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=/aQVDDyQVADsxDW1Zp5tkTjH1pkQBseTl2WOP7Jx9I8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701964401; v=1; b=Wz7obCK3FrZLiq2dHWmpM03PmpIWRjCKxGmD0KSf39Bp8nY2OOM9n4RPRZleuvtIdMtnA5DA 5I5/scidbHwYS9UsN29Ly/CvHM/CG77GkrWjj7f9G8UPv3UUXZNXY0unKVCd5EtsxmNC9KeyV7G MG0i0ncl9ihfRYdh/IyXRMfQ= X-Received: by 127.0.0.2 with SMTP id UfoVYY1788612xDAwdwW1aUc; Thu, 07 Dec 2023 07:53:21 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.56]) by mx.groups.io with SMTP id smtpd.web10.87825.1701964400337856589 for ; Thu, 07 Dec 2023 07:53:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzAwfO5fYDGqpvVVvIjE0oMhEubLp7wgXqMqYhV5YVsfCx5joqI/YeIebsdEpV8VoMcjpHlC41pb8xwdUJuVLMMXTKtzykI7hN8XGRGq/XLQOwwpEke5UbRJ4vTpO8MblPbw/QjNcO9oubq/J4AtEQK+1nNCc8YQ3eFQ2heIuB0F8VouI5xBjxnjXcR1TKcNW48xDlJC5p6UPcHpYClcXkeXkfJSZa7vZfTReL6cfAPOlhyhyRYLeTGM0M+JqV1xKhVDqR9BJygsuEhOG2FXfe8RMRampmQ50iNQKt2POeMql1vcNtAsesvMELFxfO1zni+8By9ecqLj0TsA+DRCeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Kb5JpOj9coXlncB+5Iq6ppdMQxvnqBqbcCRPEJWFD4=; b=avsuJT0IGbsMPzDlvwAOwk6r2hvJMLRWEVsU+D5Mgst8WVlfnbzpLDgBJHJlbCwJQPhZHqhZOcKouE4rnB/Cyjv6lTF6bn+QDjKHbcGVanabgQ/LFo5lcwaO73pGZdLOVx7eWx+f+ohh26VV460+PHbZrwODFs5mvsCJuAJUA99BhOh9Lz/Ig/fZaCHpiDP9flh3os33FGS9z19r9/NIp+WF7IBMiKbEv5i8wRCA16gLhOvinHu69J7E/xnF6BgeW+BfvAiyceaXGHbTw08DG2s0/HTYN9ebeT5EDJCR3og2mKMKGyLQGe4cgEnXu0hYnsELRC2QIvHjeoAaXRixtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR21CA0013.namprd21.prod.outlook.com (2603:10b6:5:174::23) by BN9PR12MB5211.namprd12.prod.outlook.com (2603:10b6:408:11c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 15:53:17 +0000 X-Received: from DS1PEPF00017093.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::51) by DM6PR21CA0013.outlook.office365.com (2603:10b6:5:174::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.24 via Frontend Transport; Thu, 7 Dec 2023 15:53:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112199+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF00017093.mail.protection.outlook.com (10.167.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Thu, 7 Dec 2023 15:53:17 +0000 X-Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:17 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:16 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Thu, 7 Dec 2023 09:53:15 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION Date: Thu, 7 Dec 2023 21:23:05 +0530 Message-ID: <98894ad42c078089069624162ee0f058037cba63.1701963835.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017093:EE_|BN9PR12MB5211:EE_ X-MS-Office365-Filtering-Correlation-Id: f7d5a194-d170-4d7d-a8e7-08dbf73ca123 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: D+eAK15Nqng1TqcS9U8ESvpa1kkhFj5/k+3B58+pRTIpFRJ6duDr6A/Ow4XoS+ILM3lrzKHTd2fOsRjUixJP9dZ4/m3BilTjy3sZwaLtvfz7htk0f7W+xGu0YsJxhT9lFpzlTxyCZLq+JPQ3fgz1pa3T0lToeh1FIzNl14OELcvCNyH7Ooz7k50tP6j6O76cnb/k361WsMWRQiKo11WI78z/q1vESyImn7LQTByELUSHK4BS/uL3ThAencYmM6gX1eNICmhvCDikqC1oWpBdcYub6v6aGlSGZpTxi/swTq+FbrfSoLAYLW01tpMKK4GYkIDnbeDgtzEvI+IzhSkV4IKt+Ksar1vXcWJ7v56akMApwkCInvPIERnu5xu9jrr9QXjP3t8TJ+1Zj8jdAINxibq8Z3T+zIZ3PzQGrwSfET3zgnb/rgUq4UHXrtjgs+Zwzlb9Zwciihj5iqeHo1ijSBJjXtZK8knVC+MrvlnpKzwaanlq5/dGeb3CSRebb/EDKfCLe5LbjRe/wc6atVbKBzthbGOny9uOPfFkdRB9mfKwVkarHO1ZN8topGlHlAUv10SQpWuqHOHcflEzm9EBjahSAYE5BUsJD04PQbjfxdDufA9xNPb19ER2SHmJtbQu866Kvmc+Opjh1aKrykErSCBtA7w+dlelrGlfmG11KkmQ3iLq8+g72bQJrVgXzOie2eonwmMiWK5FlS7ky/Pttwah+c2v+rm3m0XawbvpfD5C+rRV+C/dIT6xwhU4KmrI5tZ0420Ufljf7/WemzKO/A== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 15:53:17.5999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7d5a194-d170-4d7d-a8e7-08dbf73ca123 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017093.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5211 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HPUSWDoQLTYr2AQB0XH5UZMIx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701964402555100003 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the function pointer typedef AML_PARSE_FUNCTION, otherwise some compiler like VS2019 gives error. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 8e584d4930..d3a51a94c7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -100,8 +100,7 @@ AmlParseStream ( **/ typedef EFI_STATUS -EFIAPI -(*AML_PARSE_FUNCTION) ( +(EFIAPI *AML_PARSE_FUNCTION)( IN CONST AML_NODE_HEADER *Node, IN AML_PARSE_FORMAT ExpectedFormat, IN OUT AML_STREAM *FStream, --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112199): https://edk2.groups.io/g/devel/message/112199 Mute This Topic: https://groups.io/mt/103036576/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat Feb 7 03:43:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112200+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701964402678916.7235963698878; Thu, 7 Dec 2023 07:53:22 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=ThxiwyndbzRxQcvqwf28sHtK18X6Wd1wFGDZcfAR2Js=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701964402; v=1; b=POoyU6KZGD9F6JplYw/dgTJH8k3IeDVkZam6arDbVwr101xNZBUum7TFHjBIc/Ewu0LSi35D 9MiKMVW9NxOWIL3BLEgleZSPqgWZABmMIwWhsOfb8cqL+F+MXu0YcqBQd0V3ej4cXaXltueBh0/ wzgV5ZipWiYR2rgXj5/z2nos= X-Received: by 127.0.0.2 with SMTP id gsBAYY1788612xPpBwAQAqrj; Thu, 07 Dec 2023 07:53:22 -0800 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.72]) by mx.groups.io with SMTP id smtpd.web11.87526.1701964401473968704 for ; Thu, 07 Dec 2023 07:53:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpqtqBOMu2lxhf1JnJq2TrKzJ4elMwYG9Ywgz4xdPJbMuMfPffQqzgj/y/WX/XAQEDigckWowZmFhqfdGTwvPk8bdLQlrpZbYSblNboxkz4LZvhvk5CybOy2wijziNyounE3RQz+em1VinLN9DTexxQqxvfnSAF6WTs1XfJXo6DRM7OlaY3Z0mjMO7Lqo5839kUcX9RBqNzi/16oYIS9nK0XB/VwPHjRNylUuynfrkxsyAQEBgLJgarlel2zAhwRDtRzAz9yMmO6HFqu2rivBJEMyLDpa7CmsWrir0NJrUJtBqHJndJNIXiNTo3oTJqyc2/c/HdZXEFsxkbUxhOxlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERiGNBAyR6VYO5w0hs9/2zCqCk9XhFXhDbRFxlQLTk0=; b=j18DFIL0ctPQj72HBu4KD2WyJD2/NFQgVgLY2fjivu2duG4LJ21hte4Yt0MtX9n7irfDZhwV6qae77l/iaNUpGRHDzdw0rsn9NMMjXyqkmruT7AzfdM5Le67gdzEdjZfiDB1SflXAUCEbweD4Hl7HYPg16cIDIxW6A/JZvh7KMHvFBPlQ5G6uXOT8K6d1RsxAgSuaHLp1jaB+CLjWtPvI75O2UBtzShh1I6MBoFzbkM1gpIeu7Ulr9X8HlfMFQha1baRDt/qnF9q/DtOOX5eGPIfHHAEtLo8Qo9w9cVzDbRiBmoadPRHgCWjox/JlT0MvYEWSW7MWzXrf9jS6DtWtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DS7PR05CA0095.namprd05.prod.outlook.com (2603:10b6:8:56::29) by SN7PR12MB6959.namprd12.prod.outlook.com (2603:10b6:806:261::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.38; Thu, 7 Dec 2023 15:53:19 +0000 X-Received: from DS2PEPF0000343A.namprd02.prod.outlook.com (2603:10b6:8:56:cafe::90) by DS7PR05CA0095.outlook.office365.com (2603:10b6:8:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25 via Frontend Transport; Thu, 7 Dec 2023 15:53:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112200+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF0000343A.mail.protection.outlook.com (10.167.18.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Thu, 7 Dec 2023 15:53:19 +0000 X-Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:18 -0600 X-Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 7 Dec 2023 09:53:18 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Thu, 7 Dec 2023 09:53:17 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Adds API to generate a method with ArgN Date: Thu, 7 Dec 2023 21:23:06 +0530 Message-ID: <39aaff100f2f86f2c5585989c0746fe0c0beba03.1701963835.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343A:EE_|SN7PR12MB6959:EE_ X-MS-Office365-Filtering-Correlation-Id: fdff07ac-8d24-481b-8e6d-08dbf73ca22f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: vNWssW9FoX9gOp6Zx1aXHadBID9SxtOBVnQGIbAztEfq7U4Mh4IkkXBMelW6c9US/hGqi5S7+sPGG/7XpN9xbBOaCLkIVrb8WhbRCDFrRK2eFJMA+dYlpUTK8hFhyRb4xZOJcwcMdVibufeoENlmmREjY525HZ1H33U/6JtjlKfVWkCywXCwOcqY55V13bUpflOxSMdLPLeBHr0NNqobHbYbUmgIK+RY8Mk6MdSFqyY+6jUgwBvMcRQqzQ0DHZob8zS7bSge/07z3YF2ehtK7MIpEY/deatVT88M4NNqR66yN/v01TxnxqXud1BfCJp1Io11V9CNKL9DnHWNxIMHv4WnWf3va7xNsxgahQuA0dscKMRt9FURWFGEPsE2zU/RT/KKr2uwijiR85BY71KWp/FAev2bWiLFuY4L5LLfHIqW1Q/YYJeTp1qa4qYRJ0pFXV3pA9tS58mz+tpsa1hBcCRsA1T88yzkmgDqjkV6nP3Rb+wwoeYFs2Pr3otl0kRx0pRNaxDYB563GpErGZZMOkPHBTSBigDW3now1VI9Re3Mu6adxeiIEu0RCPyS9SjlZNZYbtsX8fv7yAoVyAwYzHrHOWmSkdsQ+hoU8pSy5NmNse+RMoY7CoSlCiU3NcWrKarSqn12geXYl/GqI9XaVaMhLBp811Wi5GiGJ9J04PzAizeZ6ZYLC884ayaxr6n28piExalORhr1cGkBl1DMkyM98/3M7tOyZIvR6WL/OuT5MB3iBHfFEoONSn3xqDgd6JvZGsIVxIfS8li1OEqk6g== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 15:53:19.3399 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdff07ac-8d24-481b-8e6d-08dbf73ca22f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6959 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aI4TarQlnltVj0SUnlYQNfiax1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701964404643100010 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Adds an API to generate a method which invokes another method with arguments. This help to generate dynamic code to invoke another method(might be in static ASL file) with build-in argument parameters. e.g: Method (MET0, 6, Serialized) { \_SB.MET1 (Arg0, Arg1, Arg2, Arg3, Arg4, Arg5) } Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 46 ++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 142 ++++++++++++++++++ 2 files changed, 188 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index eb8740692f..991a33fcf6 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -1693,4 +1693,50 @@ AmlAddNameStringToNamedPackage ( IN AML_OBJECT_NODE_HANDLE NamedNode ); =20 +/** AML code generation for a method invoking another method + with grguments. + + AmlCodeGenMethodInvokeMethodArgN ( + "MET0", "MET1", 4, TRUE, 3, ParentNode, NewObjectNode + ); + is equivalent of the following ASL code: + Method(MET0, 4, Serialized, 3) { + MET1 (Arg0, Arg1, Arg2, Arg3) + } + + @param [in] MethodNameString The new Method's name. + Must be a NULL-terminated ASL NameSt= ring + e.g.: "MET0", "_SB.MET0", etc. + The input string is copied. + @param [in] InvokeMethodNameString The called/invoked method's name. + Must be a NULL-terminated ASL NameSt= ring + e.g.: "MET1", "_SB.MET1", etc. + The input string is copied. + @param [in] NumArgs Number of arguments. + Must be 0 <=3D NumArgs <=3D 6. + @param [in] IsSerialized TRUE is equivalent to Serialized. + FALSE is equivalent to NotSerialized. + Default is NotSerialized in ASL spec. + @param [in] SyncLevel Synchronization level for the method. + Must be 0 <=3D SyncLevel <=3D 15. + Default is 0 in ASL. + @param [in] ParentNode If provided, set ParentNode as the p= arent + of the node created. + @param [out] NewObjectNode If success, contains the created nod= e. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenMethodInvokeMethodArgN ( + IN CONST CHAR8 *MethodNameString, + IN CONST CHAR8 *InvokeMethodNameString, + IN UINT8 NumArgs, + IN BOOLEAN IsSerialized, + IN UINT8 SyncLevel, + IN AML_NODE_HANDLE ParentNode OPTIONAL, + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a6db34fb97..89a4b48ec0 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -3849,3 +3849,145 @@ exit_handler: =20 return Status; } + +/** AML code generation for a method invoking another method + with grguments. + + AmlCodeGenMethodInvokeMethodArgN ( + "MET0", "MET1", 4, TRUE, 3, ParentNode, NewObjectNode + ); + is equivalent of the following ASL code: + Method(MET0, 4, Serialized, 3) { + MET1 (Arg0, Arg1, Arg2, Arg3) + } + + @param [in] MethodNameString The new Method's name. + Must be a NULL-terminated ASL NameSt= ring + e.g.: "MET0", "_SB.MET0", etc. + The input string is copied. + @param [in] InvokeMethodNameString The called/invoked method's name. + Must be a NULL-terminated ASL NameSt= ring + e.g.: "MET1", "_SB.MET1", etc. + The input string is copied. + @param [in] NumArgs Number of arguments. + Must be 0 <=3D NumArgs <=3D 6. + @param [in] IsSerialized TRUE is equivalent to Serialized. + FALSE is equivalent to NotSerialized. + Default is NotSerialized in ASL spec. + @param [in] SyncLevel Synchronization level for the method. + Must be 0 <=3D SyncLevel <=3D 15. + Default is 0 in ASL. + @param [in] ParentNode If provided, set ParentNode as the p= arent + of the node created. + @param [out] NewObjectNode If success, contains the created nod= e. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenMethodInvokeMethodArgN ( + IN CONST CHAR8 *MethodNameString, + IN CONST CHAR8 *InvokeMethodNameString, + IN UINT8 NumArgs, + IN BOOLEAN IsSerialized, + IN UINT8 SyncLevel, + IN AML_NODE_HANDLE ParentNode OPTIONAL, + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL + ) +{ + EFI_STATUS Status; + AML_OBJECT_NODE_HANDLE MethodNode; + AML_DATA_NODE *DataNode; + AML_OBJECT_NODE *ObjectNode; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + UINT8 ArgnCount; + + if ((MethodNameString =3D=3D NULL) || (InvokeMethodNameString =3D=3D NUL= L)) { + return EFI_INVALID_PARAMETER; + } + + // Create a Method named MethodNameString + Status =3D AmlCodeGenMethod ( + MethodNameString, + NumArgs, + IsSerialized, + SyncLevel, + ParentNode, + &MethodNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return Status; + } + + DataNode =3D NULL; + Status =3D ConvertAslNameToAmlName (InvokeMethodNameString, &AmlNameSt= ring); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return Status; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + FreePool (AmlNameString); + return Status; + } + + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + FreePool (AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return Status; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HEADER *)MethodNode, + (AML_NODE_HEADER *)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + DataNode =3D NULL; + + for (ArgnCount =3D 0; ArgnCount < NumArgs; ArgnCount++) { + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_ARG0 + ArgnCount, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HEADER *)MethodNode, + (AML_NODE_HEADER *)ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + ObjectNode =3D NULL; + } + + return Status; + +exit_handler: + if (MethodNode !=3D NULL) { + AmlDeleteTree ((AML_NODE_HANDLE)MethodNode); + } + + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112200): https://edk2.groups.io/g/devel/message/112200 Mute This Topic: https://groups.io/mt/103036577/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-