From nobody Sat May 4 05:44:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92322+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92322+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1660171624; cv=none; d=zohomail.com; s=zohoarc; b=ec6Cq8DcE4hz9l7ie/PMTSdMBb781lLDxvKVianSgd1A7VKqimSYf9a/K9A3e7q+OuIce0NW1R79G1jW2GPW7aa+55QIhAoSbfHmm3XoSIXKsQ6bEqPHH5l71fUERr8JwdO/kUTCb2lFs3LNXNw1fh/Bz0iI9Xm7DJeRijDaqSQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660171624; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=o1YEzI67UQ8cr7ZPEjDqswuAJNLe/tzzEfXmoTF3lpE=; b=YFkrUGfj33Dfve3+S+R1773/ryjRLUCxdT2Ej+3XoBtFohg1Zv4l2N5WZDGT7/AwpMGw5p3kMUipiBvKI7vh7zYw50pmuXY/GbkICcJjGpD5d/9MfiAWTILHubSGGvhVAHb7EdBFeyQTr2b8TuCx+667iFUxNR3nJQC2GndaniQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92322+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660171624243992.5805336701009; Wed, 10 Aug 2022 15:47:04 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dpdUYY1788612xJ7lx023R76; Wed, 10 Aug 2022 15:47:03 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.104.1660171621665418620 for ; Wed, 10 Aug 2022 15:47:02 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="291211813" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="291211813" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:47:00 -0700 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="694690093" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:46:59 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Sai Chaganty , Nate DeSimone , Liming Gao , Ray Ni , Guo Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue Date: Wed, 10 Aug 2022 15:46:47 -0700 Message-Id: <2c8041f852ea4462daabe8bb323f201caa9b501f.1660171324.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: VsOVPUVHmt4rJEVHqNW9KSXIx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660171623; bh=ApxSx2M7FGSlbm0hZBh7D6PNEQHfLvav/dNT1CBAHMM=; h=Cc:Date:From:Reply-To:Subject:To; b=MdWocDxoUXFIyXHp0z3Xcra2477y725jotFRgUyV1ZCZ9/71zSZLl7kPJ45l8+R3ZvA CIdjEHl5cmLmy5MqFiDyTbxXyqR5FZXH+Jwbrn5nDpVJ3yvFoTzi0ur3RhUTLxqIABf3z tb4yFg9h6voUrgfV8ajv3JzijJCOpZKjesU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660171626050100011 Content-Type: text/plain; charset="utf-8" Feature packages should build with -a IA32 -a X64. The commonly board selected libraries were moved to the PlatformPayloadPkg build so as not to conflict with other advanced features. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by: Isaac Oram Reviewed-by: Guo Dong Reviewed-by: Sai Chaganty --- .../Include/PlatformPayloadFeature.dsc | 42 +++++++++---------- .../PlatformPayloadPkg/PlatformPayloadPkg.dsc | 26 +++++++++++- 2 files changed, 46 insertions(+), 22 deletions(-) diff --git a/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeatu= re.dsc b/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeature.d= sc index 3003c563c9..bc776659b6 100644 --- a/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeature.dsc +++ b/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeature.dsc @@ -19,7 +19,9 @@ !error "DXE_ARCH must be specified to build this feature!" !endif =20 - DEFINE SMM_VARIABLE =3D TRUE + !ifndef SMM_VARIABLE + DEFINE SMM_VARIABLE =3D TRUE + !endif =20 =20 ##########################################################################= ###### @@ -28,7 +30,7 @@ # ##########################################################################= ###### =20 -[PcdsPatchableInModule.X64] +[PcdsPatchableInModule] !if $(SMM_VARIABLE) =3D=3D TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0 @@ -45,24 +47,11 @@ # ##########################################################################= ###### =20 -[LibraryClasses] - !if $(SMM_VARIABLE) =3D=3D TRUE - PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf - PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf - # (Optional for variable modules debug output - PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib= .inf - DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Bas= eDebugPrintErrorLevelLib.inf - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.= inf - !endif - [LibraryClasses.common.DXE_SMM_DRIVER,LibraryClasses.common.DXE_RUNTIME_DR= IVER] !if $(SMM_VARIABLE) =3D=3D TRUE SpiFlashLib|PlatformPayloadPkg/Library/SpiFlashLib/SpiFlashLib.inf FlashDeviceLib|PlatformPayloadPkg/Library/FlashDeviceLib/FlashDeviceLi= b.inf DxeHobListLib|UefiPayloadPkg/Library/DxeHobListLib/DxeHobListLib.inf - HobLib|UefiPayloadPkg/Library/DxeHobLib/DxeHobLib.inf - TimerLib|UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf !endif =20 ##########################################################################= ###### @@ -90,13 +79,20 @@ # SMM Variable Support # !if $(SMM_VARIABLE) =3D=3D TRUE - PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf - PlatformPayloadPkg/Fvb/FvbSmm.inf { - - NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf - } + PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf { + + PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf + } + + PlatformPayloadPkg/Fvb/FvbSmm.inf { + + PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf + NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf + } + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { + PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf NULL|MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf NULL|MdeModulePkg/Library/VarCheckPcdLib/VarCheckPcdLib.inf @@ -106,7 +102,11 @@ =20 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf= { + PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf } - MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf { + + PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf + } !endif diff --git a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc b/Fea= tures/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc index adf028c511..702523a73f 100644 --- a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc +++ b/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc @@ -27,6 +27,10 @@ PCD_DYNAMIC_AS_DYNAMICEX =3D TRUE DXE_ARCH =3D X64 =20 + !ifndef SMM_VARIABLE + DEFINE SMM_VARIABLE =3D TRUE + !endif + [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 @@ -55,7 +59,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE =20 -[PcdsPatchableInModule.X64] +[PcdsPatchableInModule] gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F !if $(SOURCE_DEBUG_ENABLE) @@ -90,6 +94,26 @@ !include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc !include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc =20 +# +# For standalone platform payload package build there are specific library= requirements +# + +[LibraryClasses] + !if $(SMM_VARIABLE) =3D=3D TRUE + PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf + PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf + # (Optional for variable modules debug output + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Bas= eDebugPrintErrorLevelLib.inf + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf + DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.= inf + !endif + +[LibraryClasses.common.DXE_SMM_DRIVER,LibraryClasses.common.DXE_RUNTIME_DR= IVER] + !if $(SMM_VARIABLE) =3D=3D TRUE + HobLib|UefiPayloadPkg/Library/DxeHobLib/DxeHobLib.inf + TimerLib|UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf + !endif + # # This package always builds the feature. # --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92322): https://edk2.groups.io/g/devel/message/92322 Mute This Topic: https://groups.io/mt/92947540/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 05:44:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92323+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92323+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1660171623; cv=none; d=zohomail.com; s=zohoarc; b=WR8kXTt9siMFdOaa0DfLnfqHT04AfRQPlDmqS51bURkmVKdeZ7t8sOI5IKFO9udYAMb38aEIk0ftgAHTxt/7fE8MTi1gCrQzO+UVY3iJKE21PtuOpCJdCduSqRcKloBQCvti7h4wjY3c+Ib/GuFx6l+rP2IXTZ93PRVTrLc9Ucg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660171623; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=XzP7/kgDSGkHqAD6WEJ6wYrLlEqESzDu1ryZ+j8ATqs=; b=R+hX7biLLXtn4BnyDZzuuGkZqVL/LXxuj+pzHlZZEV6rKjK+wgY5jFSeDPKJw9S0lkIr7M9cWDShg7tIu1Vbo3yILotcKsu2nAqTc0tBwKo3CZtm+xa73h386ZOINEpyDnr3t9aGrz/4is38l0ZonVdXA1oQfCMMQmvXOWSOvP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92323+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660171623305102.18344425280031; Wed, 10 Aug 2022 15:47:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id omtDYY1788612x4uaNECcVYA; Wed, 10 Aug 2022 15:47:03 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.104.1660171621665418620 for ; Wed, 10 Aug 2022 15:47:02 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="291211816" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="291211816" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:47:00 -0700 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="694690097" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:47:00 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Sai Chaganty , Nate DeSimone , Liming Gao , Ray Ni , Guo Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions Date: Wed, 10 Aug 2022 15:46:48 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: U0KUyEdsw63jGnoShRiwgd0Ex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660171623; bh=JBblqFyQ8cHZt/jQclwxyjK5ZfVNhs/YY+aTwkE74Lw=; h=Cc:Date:From:Reply-To:Subject:To; b=waZJ7ab0PP9SJGex7qryRgddvacztCMi4FfCofFTg47GE63J83C6nulI6B+kAxSZqZ/ KRlUNTNQW9k47hO+B+zmrKFmcRRnlr/EnNDC6QdQV0OOQ8o4xD4d/s8YuuIfZ9egQOs/n M+pTLMR6Leux07AjJMaeefpQ97bJ8QxaOCo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660171624133100004 Content-Type: text/plain; charset="utf-8" Rename PlatformPayloadPkg to PlatformPayloadFeaturePkg. Rename Package DEC, DSC, FDF and py scripts to match. Search and replace PlatformPayloadPkg with PlatformPayloadFeaturePkg. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by: Isaac Oram Reviewed-by: Guo Dong Reviewed-by: Sai Chaganty --- .../Include/AdvancedFeatures.dsc | 2 +- .../Include/AdvancedFeaturesPcd.dsc | 2 +- .../AdvancedFeaturePkg/Include/PostMemory.fdf | 2 +- .../Intel/AdvancedFeaturePkg/Include/PreMemory.fdf | 2 +- .../Fvb/FvbInfo.c | 0 .../Fvb/FvbService.c | 0 .../Fvb/FvbService.h | 0 .../Fvb/FvbServiceSmm.c | 0 .../Fvb/FvbSmm.inf | 2 +- .../Fvb/FvbSmmCommon.h | 0 .../Include/Guid/NvVariableInfoGuid.h | 0 .../Include/Guid/SpiFlashInfoGuid.h | 0 .../Include/Library/FlashDeviceLib.h | 0 .../Include/Library/SpiFlashLib.h | 0 .../Include/PlatformPayloadFeature.dsc | 14 +++++++------- .../Include/PostMemory.fdf | 4 ++-- .../Include/PreMemory.fdf | 0 .../Library/FlashDeviceLib/FlashDeviceLib.c | 0 .../Library/FlashDeviceLib/FlashDeviceLib.inf | 3 +-- .../Library/PcdInitLib/PcdInitLib.c | 0 .../Library/PcdInitLib/PcdInitLib.inf | 3 +-- .../Library/SpiFlashLib/PchSpi.c | 0 .../Library/SpiFlashLib/RegsSpi.h | 0 .../Library/SpiFlashLib/SpiCommon.h | 0 .../Library/SpiFlashLib/SpiFlashLib.c | 0 .../Library/SpiFlashLib/SpiFlashLib.inf | 2 +- .../PchSmiDispatchSmm/PchSmiDispatchSmm.c | 0 .../PchSmiDispatchSmm/PchSmiDispatchSmm.h | 0 .../PchSmiDispatchSmm/PchSmiDispatchSmm.inf | 0 .../PlatformPayloadFeaturePkg.dec} | 2 +- .../PlatformPayloadFeaturePkg.dsc} | 4 ++-- .../PlatformPayloadFeaturePkg.fdf} | 0 .../PlatformPayloadFeaturePkg.py} | 4 ++-- .../Readme.md | 9 ++++----- 34 files changed, 26 insertions(+), 29 deletions(-) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbInfo.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbService.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbService.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbServiceSmm.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbSmm.inf (92%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Fvb/FvbSmmCommon.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/Guid/NvVariableInfoGuid.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/Guid/SpiFlashInfoGuid.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/Library/FlashDeviceLib.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/Library/SpiFlashLib.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/PlatformPayloadFeature.dsc (87%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/PostMemory.fdf (77%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Include/PreMemory.fdf (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/FlashDeviceLib/FlashDeviceLib.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/FlashDeviceLib/FlashDeviceLib.inf (90%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/PcdInitLib/PcdInitLib.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/PcdInitLib/PcdInitLib.inf (92%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/SpiFlashLib/PchSpi.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/SpiFlashLib/RegsSpi.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/SpiFlashLib/SpiCommon.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/SpiFlashLib/SpiFlashLib.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Library/SpiFlashLib/SpiFlashLib.inf (90%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= PchSmiDispatchSmm/PchSmiDispatchSmm.c (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= PchSmiDispatchSmm/PchSmiDispatchSmm.h (100%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= PchSmiDispatchSmm/PchSmiDispatchSmm.inf (100%) rename Features/Intel/{PlatformPayloadPkg/PlatformPayloadPkg.dec =3D> Plat= formPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec} (94%) rename Features/Intel/{PlatformPayloadPkg/PlatformPayloadPkg.dsc =3D> Plat= formPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc} (95%) rename Features/Intel/{PlatformPayloadPkg/PlatformPayloadPkg.fdf =3D> Plat= formPayloadFeaturePkg/PlatformPayloadFeaturePkg.fdf} (100%) rename Features/Intel/{PlatformPayloadPkg/PlatformPayloadPkg.py =3D> Platf= ormPayloadFeaturePkg/PlatformPayloadFeaturePkg.py} (93%) rename Features/Intel/{PlatformPayloadPkg =3D> PlatformPayloadFeaturePkg}/= Readme.md (86%) diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc= b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc index 2a93ca1ec7..6a80546592 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc @@ -80,5 +80,5 @@ # Individual features # !if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE - !include PlatformPayloadPkg/Include/PlatformPayloadFeature.dsc + !include PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc !endif diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.= dsc b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc index 4e0054c226..08f258a48c 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc @@ -56,7 +56,7 @@ # # Individual features # - PlatformPayloadPkg/PlatformPayloadPkg.dec + PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec =20 # # The section below sets all PCDs to FALSE in this DSC file so the feature= is not enabled by default. diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf b/Fea= tures/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf index a0975d4d43..66032ba117 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf @@ -81,5 +81,5 @@ # Individual features # !if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE - !include PlatformPayloadPkg/Include/PostMemory.fdf + !include PlatformPayloadFeaturePkg/Include/PostMemory.fdf !endif diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf b/Feat= ures/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf index b2b821c9c4..9cd6de833b 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf +++ b/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf @@ -81,5 +81,5 @@ # Individual features # !if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE - !include PlatformPayloadPkg/Include/PreMemory.fdf + !include PlatformPayloadFeaturePkg/Include/PreMemory.fdf !endif diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbInfo.c b/Features/Int= el/PlatformPayloadFeaturePkg/Fvb/FvbInfo.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbInfo.c rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbInfo.c diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbService.c b/Features/= Intel/PlatformPayloadFeaturePkg/Fvb/FvbService.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbService.c rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbService.c diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbService.h b/Features/= Intel/PlatformPayloadFeaturePkg/Fvb/FvbService.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbService.h rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbService.h diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbServiceSmm.c b/Featur= es/Intel/PlatformPayloadFeaturePkg/Fvb/FvbServiceSmm.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbServiceSmm.c rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbServiceSmm.c diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbSmm.inf b/Features/In= tel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf similarity index 92% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbSmm.inf rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf index a56654ba09..f973465cba 100644 --- a/Features/Intel/PlatformPayloadPkg/Fvb/FvbSmm.inf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf @@ -28,7 +28,7 @@ MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec UefiCpuPkg/UefiCpuPkg.dec - PlatformPayloadPkg/PlatformPayloadPkg.dec + PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec =20 [LibraryClasses] FlashDeviceLib diff --git a/Features/Intel/PlatformPayloadPkg/Fvb/FvbSmmCommon.h b/Feature= s/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmmCommon.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Fvb/FvbSmmCommon.h rename to Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmmCommon.h diff --git a/Features/Intel/PlatformPayloadPkg/Include/Guid/NvVariableInfoG= uid.h b/Features/Intel/PlatformPayloadFeaturePkg/Include/Guid/NvVariableInf= oGuid.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Include/Guid/NvVariableInfoGu= id.h rename to Features/Intel/PlatformPayloadFeaturePkg/Include/Guid/NvVariableI= nfoGuid.h diff --git a/Features/Intel/PlatformPayloadPkg/Include/Guid/SpiFlashInfoGui= d.h b/Features/Intel/PlatformPayloadFeaturePkg/Include/Guid/SpiFlashInfoGui= d.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Include/Guid/SpiFlashInfoGuid= .h rename to Features/Intel/PlatformPayloadFeaturePkg/Include/Guid/SpiFlashInf= oGuid.h diff --git a/Features/Intel/PlatformPayloadPkg/Include/Library/FlashDeviceL= ib.h b/Features/Intel/PlatformPayloadFeaturePkg/Include/Library/FlashDevice= Lib.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Include/Library/FlashDeviceLi= b.h rename to Features/Intel/PlatformPayloadFeaturePkg/Include/Library/FlashDev= iceLib.h diff --git a/Features/Intel/PlatformPayloadPkg/Include/Library/SpiFlashLib.= h b/Features/Intel/PlatformPayloadFeaturePkg/Include/Library/SpiFlashLib.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Include/Library/SpiFlashLib.h rename to Features/Intel/PlatformPayloadFeaturePkg/Include/Library/SpiFlash= Lib.h diff --git a/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeatu= re.dsc b/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFe= ature.dsc similarity index 87% rename from Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeatur= e.dsc rename to Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadF= eature.dsc index bc776659b6..8056b06548 100644 --- a/Features/Intel/PlatformPayloadPkg/Include/PlatformPayloadFeature.dsc +++ b/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeatu= re.dsc @@ -49,8 +49,8 @@ =20 [LibraryClasses.common.DXE_SMM_DRIVER,LibraryClasses.common.DXE_RUNTIME_DR= IVER] !if $(SMM_VARIABLE) =3D=3D TRUE - SpiFlashLib|PlatformPayloadPkg/Library/SpiFlashLib/SpiFlashLib.inf - FlashDeviceLib|PlatformPayloadPkg/Library/FlashDeviceLib/FlashDeviceLi= b.inf + SpiFlashLib|PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiFlashLib.= inf + FlashDeviceLib|PlatformPayloadFeaturePkg/Library/FlashDeviceLib/FlashD= eviceLib.inf DxeHobListLib|UefiPayloadPkg/Library/DxeHobListLib/DxeHobListLib.inf !endif =20 @@ -79,15 +79,15 @@ # SMM Variable Support # !if $(SMM_VARIABLE) =3D=3D TRUE - PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf { + PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf { PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf } =20 - PlatformPayloadPkg/Fvb/FvbSmm.inf { + PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf { PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf - NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf + NULL|PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLib.inf } =20 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { @@ -97,13 +97,13 @@ NULL|MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf NULL|MdeModulePkg/Library/VarCheckPcdLib/VarCheckPcdLib.inf NULL|MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.inf - NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf + NULL|PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLib.inf } =20 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf= { PlatformHookLib|UefiPayloadPkg/Library/PlatformHookLib/PlatformHoo= kLib.inf - NULL|PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf + NULL|PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLib.inf } MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf { diff --git a/Features/Intel/PlatformPayloadPkg/Include/PostMemory.fdf b/Fea= tures/Intel/PlatformPayloadFeaturePkg/Include/PostMemory.fdf similarity index 77% rename from Features/Intel/PlatformPayloadPkg/Include/PostMemory.fdf rename to Features/Intel/PlatformPayloadFeaturePkg/Include/PostMemory.fdf index 54800b972c..33a0a4c6b2 100644 --- a/Features/Intel/PlatformPayloadPkg/Include/PostMemory.fdf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Include/PostMemory.fdf @@ -11,8 +11,8 @@ # SMM Support # !if $(SMM_VARIABLE) =3D=3D TRUE - INF PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf - INF PlatformPayloadPkg/Fvb/FvbSmm.inf + INF PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchSmiDispatchSmm.inf + INF PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.i= nf INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf diff --git a/Features/Intel/PlatformPayloadPkg/Include/PreMemory.fdf b/Feat= ures/Intel/PlatformPayloadFeaturePkg/Include/PreMemory.fdf similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Include/PreMemory.fdf rename to Features/Intel/PlatformPayloadFeaturePkg/Include/PreMemory.fdf diff --git a/Features/Intel/PlatformPayloadPkg/Library/FlashDeviceLib/Flash= DeviceLib.c b/Features/Intel/PlatformPayloadFeaturePkg/Library/FlashDeviceL= ib/FlashDeviceLib.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/FlashDeviceLib/FlashD= eviceLib.c rename to Features/Intel/PlatformPayloadFeaturePkg/Library/FlashDeviceLib/F= lashDeviceLib.c diff --git a/Features/Intel/PlatformPayloadPkg/Library/FlashDeviceLib/Flash= DeviceLib.inf b/Features/Intel/PlatformPayloadFeaturePkg/Library/FlashDevic= eLib/FlashDeviceLib.inf similarity index 90% rename from Features/Intel/PlatformPayloadPkg/Library/FlashDeviceLib/FlashD= eviceLib.inf rename to Features/Intel/PlatformPayloadFeaturePkg/Library/FlashDeviceLib/F= lashDeviceLib.inf index 7285a37944..bddce099b3 100644 --- a/Features/Intel/PlatformPayloadPkg/Library/FlashDeviceLib/FlashDeviceL= ib.inf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Library/FlashDeviceLib/Flash= DeviceLib.inf @@ -29,10 +29,9 @@ [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec - PlatformPayloadPkg/PlatformPayloadPkg.dec + PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec =20 [LibraryClasses] DebugLib BaseMemoryLib SpiFlashLib - diff --git a/Features/Intel/PlatformPayloadPkg/Library/PcdInitLib/PcdInitLi= b.c b/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLi= b.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib= .c rename to Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdIn= itLib.c diff --git a/Features/Intel/PlatformPayloadPkg/Library/PcdInitLib/PcdInitLi= b.inf b/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInit= Lib.inf similarity index 92% rename from Features/Intel/PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib= .inf rename to Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdIn= itLib.inf index 05411b00d8..02c98d9c4d 100644 --- a/Features/Intel/PlatformPayloadPkg/Library/PcdInitLib/PcdInitLib.inf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLi= b.inf @@ -27,7 +27,7 @@ [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec - PlatformPayloadPkg/PlatformPayloadPkg.dec + PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec =20 [LibraryClasses] BaseLib @@ -47,4 +47,3 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase - diff --git a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/PchSpi.c= b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/PchSpi.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/PchSpi.c rename to Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/PchS= pi.c diff --git a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/RegsSpi.= h b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/RegsSpi.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/RegsSpi.h rename to Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/Regs= Spi.h diff --git a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiCommo= n.h b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiCommo= n.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiCommon= .h rename to Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiC= ommon.h diff --git a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiFlash= Lib.c b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiFla= shLib.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiFlashL= ib.c rename to Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiF= lashLib.c diff --git a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiFlash= Lib.inf b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiF= lashLib.inf similarity index 90% rename from Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiFlashL= ib.inf rename to Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiF= lashLib.inf index fae851c12f..f09714f3f2 100644 --- a/Features/Intel/PlatformPayloadPkg/Library/SpiFlashLib/SpiFlashLib.inf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Library/SpiFlashLib/SpiFlash= Lib.inf @@ -30,7 +30,7 @@ [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec - PlatformPayloadPkg/PlatformPayloadPkg.dec + PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec =20 [LibraryClasses] BaseLib diff --git a/Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDisp= atchSmm.c b/Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchS= miDispatchSmm.c similarity index 100% rename from Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispa= tchSmm.c rename to Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchSmi= DispatchSmm.c diff --git a/Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDisp= atchSmm.h b/Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchS= miDispatchSmm.h similarity index 100% rename from Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispa= tchSmm.h rename to Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchSmi= DispatchSmm.h diff --git a/Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDisp= atchSmm.inf b/Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/Pc= hSmiDispatchSmm.inf similarity index 100% rename from Features/Intel/PlatformPayloadPkg/PchSmiDispatchSmm/PchSmiDispa= tchSmm.inf rename to Features/Intel/PlatformPayloadFeaturePkg/PchSmiDispatchSmm/PchSmi= DispatchSmm.inf diff --git a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dec b/Fea= tures/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec similarity index 94% rename from Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dec rename to Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePk= g.dec index 549f96d85f..78d36f12eb 100644 --- a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dec +++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec @@ -10,7 +10,7 @@ =20 [Defines] DEC_SPECIFICATION =3D 0x00010005 - PACKAGE_NAME =3D PlatformPayloadPkg + PACKAGE_NAME =3D PlatformPayloadFeaturePkg PACKAGE_GUID =3D 17F3ACAC-079D-4518-9EBF-E33289733E8C PACKAGE_VERSION =3D 0.1 =20 diff --git a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc b/Fea= tures/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc similarity index 95% rename from Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc rename to Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePk= g.dsc index 702523a73f..32e33ac53e 100644 --- a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.dsc +++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc @@ -15,7 +15,7 @@ # ##########################################################################= ###### [Defines] - PLATFORM_NAME =3D PlatformPayloadPkg + PLATFORM_NAME =3D PlatformPayloadFeaturePkg PLATFORM_GUID =3D D3C551BE-9BC6-48F5-AA8A-F49425C2= 8CA9 PLATFORM_VERSION =3D 0.1 DSC_SPECIFICATION =3D 0x00010005 @@ -23,7 +23,7 @@ BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT OUTPUT_DIRECTORY =3D Build/$(PLATFORM_NAME) - FLASH_DEFINITION =3D $(PLATFORM_NAME)/PlatformPayload= Pkg.fdf + FLASH_DEFINITION =3D $(PLATFORM_NAME)/PlatformPayload= FeaturePkg.fdf PCD_DYNAMIC_AS_DYNAMICEX =3D TRUE DXE_ARCH =3D X64 =20 diff --git a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.fdf b/Fea= tures/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.fdf similarity index 100% rename from Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.fdf rename to Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePk= g.fdf diff --git a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.py b/Feat= ures/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py similarity index 93% rename from Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.py rename to Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePk= g.py index 1e3e1cce21..2fbb821563 100644 --- a/Features/Intel/PlatformPayloadPkg/PlatformPayloadPkg.py +++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py @@ -45,11 +45,11 @@ def BuildUniversalPayload(Args, MacroList): if not os.path.exists (Edk2PayloadBuildScript): raise Exception("Could not find universal UEFI payload build scrip= t UniversalPayloadBuild.py") =20 - PlatformFvDscPath =3D os.path.normpath("PlatformPayloadPkg/Platfo= rmPayloadPkg.dsc") + PlatformFvDscPath =3D os.path.normpath("PlatformPayloadFeaturePkg= /PlatformPayloadFeaturePkg.dsc") BuildDir =3D os.path.join(os.environ['WORKSPACE'], os.pa= th.normpath("Build/UefiPayloadPkgX64")) PlatformFvReportPath =3D os.path.join(BuildDir, "PlatformPayloadRepo= rt.txt") UniversalUefiPld =3D os.path.join(BuildDir, 'UniversalPayload.el= f') - PlatformFv =3D os.path.join(os.environ['WORKSPACE'], os.pa= th.normpath("Build/PlatformPayloadPkg"), f"{BuildTarget}_{ToolChain}", os.p= ath.normpath("FV/PlatformPayload.Fv")) + PlatformFv =3D os.path.join(os.environ['WORKSPACE'], os.pa= th.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}= ", os.path.normpath("FV/PlatformPayload.Fv")) =20 if "CLANG_BIN" in os.environ: LlvmObjcopyPath =3D os.path.join(os.environ["CLANG_BIN"], "llvm-ob= jcopy") diff --git a/Features/Intel/PlatformPayloadPkg/Readme.md b/Features/Intel/P= latformPayloadFeaturePkg/Readme.md similarity index 86% rename from Features/Intel/PlatformPayloadPkg/Readme.md rename to Features/Intel/PlatformPayloadFeaturePkg/Readme.md index 938b557f30..1067196388 100644 --- a/Features/Intel/PlatformPayloadPkg/Readme.md +++ b/Features/Intel/PlatformPayloadFeaturePkg/Readme.md @@ -15,7 +15,7 @@ or bootloader dependency (only for coreboot). These modul= es would be located in edk2-platform repo. =20 The generic UEFI payload could be built from EDK2 UefiPayloadPkg in ELF fo= rmat following -universal payload specification. And a Platform Payload could be built fro= m PlatformPayloadPkg +universal payload specification. And a Platform Payload could be built fro= m PlatformPayloadFeaturePkg to provide Intel platform specific features (e.g. SPI module, PCH SMM) in = FV/FD format. This platform payload could be inserted into universal UEFI payload as an = ELF section to generate a full-feature payload. @@ -32,11 +32,10 @@ set PACKAGES_PATH=3D%WORKSPACE%\edk2;%WORKSPACE%\edk2-p= latforms\Features\Intel; edk2\edksetup.bat =20 ** Build universal UEFI payload with platform Payload -python edk2-platforms\Features\Intel\PlatformPayloadPkg\PlatformPayloadPkg= .py -t VS2019 - -D SMM_SUPPORT=3DTRUE -DVARIABLE_SUPPORT=3DNONE -D SMM_VARIABLE=3DTRUE +python edk2-platforms\Features\Intel\PlatformPayloadFeaturePkg\PlatformPay= loadFeaturePkg.py -t VS2019 -D SMM_SUPPORT=3DTRUE -DVARIABLE_SUPPORT=3DNONE= -D SMM_VARIABLE=3DTRUE or python edk2\UefiPayloadPkg\UniversalPayloadBuild.py -t VS2019 -D SMM_SUPPO= RT=3DTRUE -DVARIABLE_SUPPORT=3DNONE -python edk2-platforms\Features\Intel\PlatformPayloadPkg\PlatformPayloadPkg= .py -t VS2019 -D SMM_VARIABLE=3DTRUE -s +python edk2-platforms\Features\Intel\PlatformPayloadFeaturePkg\PlatformPay= loadFeaturePkg.py -t VS2019 -D SMM_VARIABLE=3DTRUE -s =20 If build success, the final UEFI payload is at Build\UefiPayloadPkgX64\U= niversalPayload.elf. =20 @@ -55,7 +54,7 @@ Several build macros are used as below for SMM variable f= eature modules. =20 2. Data Flows SMM variable: -The interface with bootloader are defined in PlatformPayloadPkg\Include\Gu= id +The interface with bootloader are defined in PlatformPayloadFeaturePkg\Inc= lude\Guid SpiFlashInfoGuid.h -- SPI related information for SPI flash operation. NvVariableInfoGuid.h -- Variable related information for SPI NV variables. =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92323): https://edk2.groups.io/g/devel/message/92323 Mute This Topic: https://groups.io/mt/92947541/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 05:44:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92324+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92324+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1660171623; cv=none; d=zohomail.com; s=zohoarc; b=YKdFUTIpxlnPlCxjbyAI3dwdHYLQ0GAIAnQHa1FXdOG3sBZLexDbAiQFv7tY7411Kmg23kCHP8AcVnBWq6xGLzK1y2Lv2zRCPg7gQ0MOy3AfYZ50+SLaloJ8DxtmLqEVRZcid9Gwp1MwZNk9c/87XN/NV/0XCougb+fNVASdt/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660171623; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YSwFgVdwghZ1DHrHZ80iVa8fpduHvCK5f3el2V3dAUE=; b=gM+hgRWuUei90gt0DzEsIKwRWRY2FTKDQQ5urPfAUq1pum7neIIdq65gSZ5OEf+WwXP8fWJSUGKgtOqWRr6P/yvm4bTWO2gogQ4knrGT0g8NoWAenW4LOqO1HLCqTD4AXOiA8oD85Opr83ci4vEOi3I2kXjjv/rShdzaIu8dVGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92324+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660171623887935.5577345006554; Wed, 10 Aug 2022 15:47:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WPT7YY1788612x0bGBjYwvtk; Wed, 10 Aug 2022 15:47:03 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.104.1660171621665418620 for ; Wed, 10 Aug 2022 15:47:02 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="291211823" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="291211823" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:47:01 -0700 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="694690102" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 15:47:00 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Sai Chaganty , Nate DeSimone , Liming Gao , Ray Ni , Guo Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 3/3] PlatformPayloadFeaturePkg: Update contents to match feature conventions Date: Wed, 10 Aug 2022 15:46:49 -0700 Message-Id: <493b7ee0cf43c74837db79e0d660011500c99cff.1660171324.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: 7PeEosl1SCS3drz52OTP2vTPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660171623; bh=gJJ5ocKBlR9iP8lFAKjjeezzU2Lu9rtg6qWi0Jvo+ec=; h=Cc:Date:From:Reply-To:Subject:To; b=c2MUIrnBzIiYC4G36qLfZ7p1pwlYwAUIA4DMJ3eZqalwMJarr+Qj2jVejlaiCvlvK7A jZOZVwMw4rMhZVhb5WVd+2p+Mbu4vG5PZVkpbzTXxjEIi5pZJQGHkB5RHpKnm0/Va7a46 aKgWwQj/3GdTb5u7+lf3HfKNo457xs8gN2g= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660171626069100012 Content-Type: text/plain; charset="utf-8" Rename gPlatformPayloadPkgTokenSpaceGuid to gPlatformPayloadFeaturePkgTokenSpaceGuid Rename PcdPayloadPackageFeatureEnable to PcdPlatformPayloadFeatureEnable Update Readme including format improvements Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by: Isaac Oram Reviewed-by: Guo Dong Reviewed-by: Sai Chaganty --- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 2 +- .../Include/AdvancedFeatures.dsc | 2 +- .../Include/AdvancedFeaturesPcd.dsc | 2 +- .../AdvancedFeaturePkg/Include/PostMemory.fdf | 2 +- .../AdvancedFeaturePkg/Include/PreMemory.fdf | 2 +- .../PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf | 2 +- .../PlatformPayloadFeaturePkg.dec | 6 +- .../Intel/PlatformPayloadFeaturePkg/Readme.md | 73 ++++++++++--------- 8 files changed, 48 insertions(+), 43 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index df8e678ae8..236c5570ca 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -84,7 +84,7 @@ # # Individual features # - gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable = |TRUE + gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnable= |TRUE =20 # # PCD that are required to be set by the build target should be configured= here for test purposes diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc= b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc index 6a80546592..804aab89bc 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc @@ -79,6 +79,6 @@ # # Individual features # -!if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE +!if gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnab= le =3D=3D TRUE !include PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc !endif diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.= dsc b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc index 08f258a48c..0af5a8bfbc 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc @@ -82,7 +82,7 @@ gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEnable= |FALSE =20 - gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable = |FALSE + gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnable= |FALSE =20 # # There seems to be some build parsing odd behavior that requires this PCD= to be specified even though diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf b/Fea= tures/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf index 66032ba117..349bdcc491 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf @@ -80,6 +80,6 @@ # # Individual features # -!if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE +!if gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnab= le =3D=3D TRUE !include PlatformPayloadFeaturePkg/Include/PostMemory.fdf !endif diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf b/Feat= ures/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf index 9cd6de833b..b991a5aabf 100644 --- a/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf +++ b/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf @@ -80,6 +80,6 @@ # # Individual features # -!if gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable =3D= =3D TRUE +!if gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnab= le =3D=3D TRUE !include PlatformPayloadFeaturePkg/Include/PreMemory.fdf !endif diff --git a/Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf b/Feat= ures/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf index f973465cba..a692d9bf41 100644 --- a/Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf +++ b/Features/Intel/PlatformPayloadFeaturePkg/Fvb/FvbSmm.inf @@ -60,7 +60,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize - gPlatformPayloadPkgTokenSpaceGuid.PcdNvsDataFile + gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdNvsDataFile =20 [Depex] TRUE diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeatur= ePkg.dec b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeatureP= kg.dec index 78d36f12eb..f02c5f70ca 100644 --- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec +++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dec @@ -21,7 +21,7 @@ # ## Defines the token space for the Payload platform Package PCDs. # - gPlatformPayloadPkgTokenSpaceGuid =3D {0xa375ddc6, 0x74fb, 0x4de1, {0x8= 2, 0x6d, 0xa3, 0x10, 0xa3, 0x3b, 0x89, 0x77}} + gPlatformPayloadFeaturePkgTokenSpaceGuid =3D {0xa375ddc6, 0x74fb, 0x4de= 1, {0x82, 0x6d, 0xa3, 0x10, 0xa3, 0x3b, 0x89, 0x77}} =20 # # SPI variable support @@ -41,9 +41,9 @@ [PcdsFeatureFlag] ## Feature enabling control # @Prompt Enable payload platform FV common for most Intel platforms - gPlatformPayloadPkgTokenSpaceGuid.PcdPayloadPackageFeatureEnable|FALSE|B= OOLEAN|0x00000001 + gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdPlatformPayloadFeatureEnable= |FALSE|BOOLEAN|0x00000001 =20 [PcdsFixedAtBuild, PcdsPatchableInModule] ## FFS filename to find the default variable initial data file. # @Prompt FFS Name of variable initial data file - gPlatformPayloadPkgTokenSpaceGuid.PcdNvsDataFile |{ 0x1a, 0xf1, 0xb1, 0x= ae, 0x42, 0xcc, 0xcf, 0x4e, 0xac, 0x60, 0xdb, 0xab, 0xf6, 0xca, 0x69, 0xe6 = }|VOID*|0x00000025 + gPlatformPayloadFeaturePkgTokenSpaceGuid.PcdNvsDataFile |{ 0x1a, 0xf1, 0= xb1, 0xae, 0x42, 0xcc, 0xcf, 0x4e, 0xac, 0x60, 0xdb, 0xab, 0xf6, 0xca, 0x69= , 0xe6 }|VOID*|0x00000025 diff --git a/Features/Intel/PlatformPayloadFeaturePkg/Readme.md b/Features/= Intel/PlatformPayloadFeaturePkg/Readme.md index 1067196388..9cdb26285c 100644 --- a/Features/Intel/PlatformPayloadFeaturePkg/Readme.md +++ b/Features/Intel/PlatformPayloadFeaturePkg/Readme.md @@ -19,31 +19,45 @@ universal payload specification. And a Platform Payload= could be built from Plat to provide Intel platform specific features (e.g. SPI module, PCH SMM) in = FV/FD format. This platform payload could be inserted into universal UEFI payload as an = ELF section to generate a full-feature payload. + ## Firmware Volumes -* FvPlatformPayload +* PlatformPayload.fv =20 ## Build Flows -use windows host as example to generate a full-feature payload: +Use Windows host as example to generate a full-feature payload: =20 -** Setup the build env +* Setup the build env +
 set WORKSPACE=3Dc:\payload
-set PACKAGES_PATH=3D%WORKSPACE%\edk2;%WORKSPACE%\edk2-platforms\Features\I=
ntel;
-    %WORKSPACE%\edk2-platforms\Platform\Intel
+set PACKAGES_PATH=3D%WORKSPACE%\edk2;%WORKSPACE%\edk2-platforms\Features\I=
ntel;%WORKSPACE%\edk2-platforms\Platform\Intel
 edk2\edksetup.bat
-
-** Build universal UEFI payload with platform Payload
+
+* Build universal UEFI payload with platform payload +
 python edk2-platforms\Features\Intel\PlatformPayloadFeaturePkg\PlatformPay=
loadFeaturePkg.py -t VS2019 -D SMM_SUPPORT=3DTRUE -DVARIABLE_SUPPORT=3DNONE=
 -D SMM_VARIABLE=3DTRUE
-or
+
+* Build universal UEFI payload then build the platform payload and patch i= t to the universal UEFI payload +
 python edk2\UefiPayloadPkg\UniversalPayloadBuild.py -t VS2019 -D SMM_SUPPO=
RT=3DTRUE -DVARIABLE_SUPPORT=3DNONE
 python edk2-platforms\Features\Intel\PlatformPayloadFeaturePkg\PlatformPay=
loadFeaturePkg.py -t VS2019 -D SMM_VARIABLE=3DTRUE -s
+
=20 - If build success, the final UEFI payload is at Build\UefiPayloadPkgX64\U= niversalPayload.elf. +If build succeeds, the final UEFI payload is at Build\UefiPayloadPkgX64= \UniversalPayload.elf =20 +Note that standalone feature package build works with "-a X64" or "-a IA32= -a X64" but "-a IA32" is not supported. +Note that this does not patch the universal UEFI payload, it only creates = a PlatformPayload.fv. +
+build -p PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc -a X64 -a=
 IA32
+
## Features =20 -1. Modules -Currently only SMM veriable feature is available. +1. SMM variable feature configuration + * PcdPlatformPayloadFeatureEnable - Enables this feature. + * SMM_VARIABLE - TRUE enables the SPI SMM variable feature implementatio= n. + +2. Modules: Currently only SMM variable feature is available. Several build macros are used as below for SMM variable feature modules. +
 !if $(SMM_VARIABLE) =3D=3D TRUE
   ## PchSmiDispatchSmm
   ## FvbSmm
@@ -51,11 +65,16 @@ Several build macros are used as below for SMM variable=
 feature modules.
   ## VariableSmm
   ## VariableSmmRuntimeDxe
 !endif
+
+ +3. Data Flows =20 -2. Data Flows SMM variable: + The interface with bootloader are defined in PlatformPayloadFeaturePkg\Inc= lude\Guid + SpiFlashInfoGuid.h -- SPI related information for SPI flash operation. + NvVariableInfoGuid.h -- Variable related information for SPI NV variables. =20 ## Control Flows @@ -63,33 +82,19 @@ EDK2 DXE/SMM core from universal UEFI payload would dis= patch all the modules from this platform payload. =20 ## Test Point Results -*_TODO_* -The test(s) that can verify porting is complete for the feature. - -Each feature must describe at least one test point to verify the feature i= s successful. If the test point is not -implemented, this should be stated. +None implemented =20 ## Functional Exit Criteria -*_TODO_* -The testable functionality for the feature. - -This section should provide an ordered list of criteria that a board integ= rator can reference to ensure the feature is -functional on their board. +Boot to UEFI shell and verify variable functionality over resets =20 ## Feature Enabling Checklist -*_TODO_* -An ordered list of required activities to achieve desired functionality fo= r the feature. +Verify configuration of PcdPlatformPayloadFeatureEnable and SMM_VARIABLE +Boot to UEFI Shell +Update a variable +Reset the system and verify variable remains updated =20 ## Performance Impact -A general expectation for the impact on overall boot performance due to us= ing this feature. - -This section is expected to provide guidance on: -* How to estimate performance impact due to the feature -* How to measure performance impact of the feature -* How to manage performance impact of the feature +Minimal expected =20 ## Common Optimizations -*_TODO_* -Common size or performance tuning options for this feature. - -This section is recommended but not required. If not used, the contents sh= ould be left empty. +None --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92324): https://edk2.groups.io/g/devel/message/92324 Mute This Topic: https://groups.io/mt/92947542/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-