From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91734+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91734+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515601; cv=none; d=zohomail.com; s=zohoarc; b=VGdwO0DEt3rSanmpWm2sAOBu+VZEO6Zm/EoBVbs+ORa0Ce3QgcYfQRe9TLWvnW5rdpcS1tyS1g5+aBSjTua4qpem4BYII2DHLZTnC9taweXwEO17re9zKo3F4pYg/vz64kAZ3WEN8pBNJEEFqHvN8ITDDJS9HqtskiTqH+T07hM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515601; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=VJh5aoCxR1lbdt63OCPcF4KiKGBzG1pPQXcEAEUGgKg=; b=F/5h6a4PhlC/+chB6bKjeYjtfb1NGcSI9wXnpep9Wgxtd8aWvo62JOkmjl4AVyEhpa89BlA8QXJOIuGI9+8dKf5R69bJ9uY8eQf7o8o1tg4p/koe0n9uKAMHTlhWwm2XpFUo9LI71B2HLBYHyGNQqkrtC2LL9KdnV/k64GGAD7c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91734+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515601842338.02485458799663; Fri, 22 Jul 2022 11:46:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id gnB4YY1788612xKh6ESth2SI; Fri, 22 Jul 2022 11:46:41 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138258" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138258" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767956" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 01/13] MinPlatformPkg/Include: Simplify board creation Date: Fri, 22 Jul 2022 11:46:12 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: bsVO4dLYmQxh8IaGn4fxq7aqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515601; bh=fPUDRCaHAF6zVq0A+znvEILiLuvp3FIiunQXuDBDpIs=; h=Cc:Date:From:Reply-To:Subject:To; b=YRfTm3nDG68EGhgeom/8BdEd/gfVlJyhP1GN0ISNBk0DidoBVPiFNm2CNOHtsXWpjpv z0dULcKfxR7MFn6SUcteULP+BXo3KWfTyIjR0ONPT2LvG1i+ihicFmVxg+4TbDqGoCBqK SB3GXmOSUpSS2+SUWZBUWRPI6pGXcBwQEoA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515603241100007 Content-Type: text/plain; charset="utf-8" Reduce the need for boards to initialize common MinPlatformPkg PCD used in build files. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 26 +++++++++++++++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 +++++----- 2 files changed, 32 insertions(+), 8 deletions(-) create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFe= aturesPcd.dsc.inc diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesP= cd.dsc.inc b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesP= cd.dsc.inc new file mode 100644 index 0000000000..842668a081 --- /dev/null +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.= inc @@ -0,0 +1,26 @@ +## @file +# DSC file for defining default PCD for MinPlatform features. +# +# This makes it easy for boards to initially configure their build. +# +# This initializes features to be disable by default. +# A board can enable a feature by configuring the PCD in the board DSC file +# after this file has been included. +# +# Copyright (C) 2022 Intel Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[PcdsFeatureFlag] + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable |FALSE + + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable |FALSE + + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dsc index 09aa6fe4d5..90127c16b5 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -38,14 +38,12 @@ # ##########################################################################= ###### =20 -[PcdsFeatureFlag] - # configuration - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 ##########################################################################= ###### # --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91734): https://edk2.groups.io/g/devel/message/91734 Mute This Topic: https://groups.io/mt/92554227/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91735+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91735+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515603; cv=none; d=zohomail.com; s=zohoarc; b=cituGqU1t0+vd3iR5hQcc57Qxh51NzWSXKnppD6EdgRc55b21oCzy2NW+nYL9FXAeQXCxZ3dyRphH+7fot1bg5pdStwkf+NKepY3q8QS5WMPuS1Nvd4LViVqFRtZavvoQiJsT6QUW0ly1cOmgak+0SdSgtDgO4BYK7e4kaci3EA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515603; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FosYzKL0KYFvtoaaYfdTUhwDrt2rSM94WeZ0BRkWPAM=; b=D5VF6OsWkEeZO5mgwgkqwi+Wn1JuOipyaH6sv8sx4lCnz5AmYlajyrImpheGvgd20b+20M141/Ode3zS7v3QGwJfC+e5J9DxwwvvFgtFMRSNtvp4gv1OD2cwEHiITd3H3TBsG3obeATUkN1eBmu3NMswhcdz4RcActIE6jMbb0w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91735+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515603815663.1740414818967; Fri, 22 Jul 2022 11:46:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6mqAYY1788612xPo4uKIKe1r; Fri, 22 Jul 2022 11:46:43 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138260" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138260" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767959" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel][edk2-platforms][PATCH V1 02/13] WhitleyOpenBoardPkg/Build: Reduce duplicate code Date: Fri, 22 Jul 2022 11:46:13 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: U7iHIRG8YVBLmil5xYkZ4Ynux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515603; bh=cEavG0+N89b6d0JuhRbZIOnF0PYzFYv6DiCZO3by0r8=; h=Cc:Date:From:Reply-To:Subject:To; b=WttwZB5FJcLBwrYFhB3sKrPx+OtaoY9/J8wNgYAE4biuphZrlHBRrCTmhWxU7sFuBj9 Wk83RwpYlkHuLlH+2cPrD0p+plaE8ImsBauRYEZrJseGuPbFwd1h8iYLuoi+PM6fOPzsH FEicb0GPxaA/RkBk7o2LQ8HbzQiUrbPEH1c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515605157100010 Content-Type: text/plain; charset="utf-8" Leverage common includes for default feature values. Remove PERFORMANCE_ENABLE in favor of PcdPerformanceEnable. Use DpDynamicCommand instead of standalone DpApp. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- ...blePerformanceMonitoringInfrastructure.dsc | 5 +-- ...anceMonitoringInfrastructurePostMemory.fdf | 5 +-- ...manceMonitoringInfrastructurePreMemory.fdf | 2 +- .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 45 ++++++++++++++----- .../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 5 files changed, 39 insertions(+), 20 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/EnablePerforman= ceMonitoringInfrastructure.dsc b/Platform/Intel/WhitleyOpenBoardPkg/Include= /Dsc/EnablePerformanceMonitoringInfrastructure.dsc index c308e0df4f..7439b2fb36 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/EnablePerformanceMonit= oringInfrastructure.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/EnablePerformanceMonit= oringInfrastructure.dsc @@ -6,7 +6,7 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent ## =20 -!if $(PERFORMANCE_ENABLE) =3D=3D TRUE +!if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE =20 [PcdsFixedAtBuild] gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly|TRUE @@ -34,7 +34,6 @@ [Components.X64] MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerf= ormanceSmm.inf - MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf - ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf + ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf =20 !endif diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerforman= ceMonitoringInfrastructurePostMemory.fdf b/Platform/Intel/WhitleyOpenBoardP= kg/Include/Fdf/EnablePerformanceMonitoringInfrastructurePostMemory.fdf index a3576bd7a8..52b79a31d0 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerformanceMonit= oringInfrastructurePostMemory.fdf +++ b/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerformanceMonit= oringInfrastructurePostMemory.fdf @@ -6,9 +6,8 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent ## =20 -!if $(PERFORMANCE_ENABLE) =3D=3D TRUE +!if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwar= ePerformanceDxe.inf INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/Firmwar= ePerformanceSmm.inf - INF MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.= inf - INF ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf + INF ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf !endif diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerforman= ceMonitoringInfrastructurePreMemory.fdf b/Platform/Intel/WhitleyOpenBoardPk= g/Include/Fdf/EnablePerformanceMonitoringInfrastructurePreMemory.fdf index dbc98f6f1f..18574f67ef 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerformanceMonit= oringInfrastructurePreMemory.fdf +++ b/Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/EnablePerformanceMonit= oringInfrastructurePreMemory.fdf @@ -6,6 +6,6 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent ## =20 -!if $(PERFORMANCE_ENABLE) =3D=3D TRUE +!if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmwar= ePerformancePei.inf !endif diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc index cefee8273b..5b5d84779e 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc @@ -39,12 +39,39 @@ DEFINE IIO_INSTANCE =3D UnknownCpu !endif =20 +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# Optional MinPlatformPkg features should be enabled after this +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + +# +# AdvancedFeature common include for feature enable/disable PCD +# +# !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc =20 +# +# PCD required by advanced features +# [PcdsFixedAtBuild] gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 =20 +# +# Feature enable/disable flags +# [PcdsFeatureFlag] + # + # MinPlatform control flags + # + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |TRUE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |TRUE + # # Debugging features # @@ -124,20 +151,16 @@ # Pcd Section - list of all EDK II PCD Entries defined by this Platform # ##########################################################################= ###### -[PcdsFeatureFlag] - # - # MinPlatform control flags - # - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE =20 +[PcdsFeatureFlag] + # # don't degrade 64bit MMIO space to 32-bit + # gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE =20 + # # Server doesn't support capsule update on Reset. + # gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|TRUE gUefiCpuPkgTokenSpaceGuid.PcdCpuHotPlugSupport|FALSE @@ -761,13 +784,13 @@ =20 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf { - !if $(PERFORMANCE_ENABLE) =3D=3D TRUE + !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE TimerLib|UefiCpuPkg/Library/SecPeiDxeTimerLibUefiCpu/SecPeiDxeTimerL= ibUefiCpu.inf !endif } =20 [Components.X64] - !include WhitleyOpenBoardPkg/Include/Dsc/CoreDxeInclude.dsc + !include MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc =20 $(RP_PKG)/Platform/Dxe/PlatformType/PlatformType.inf =20 diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkgConfig.dsc b/Pla= tform/Intel/WhitleyOpenBoardPkg/PlatformPkgConfig.dsc index a4ac8b6935..c9620f11d8 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkgConfig.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkgConfig.dsc @@ -15,8 +15,6 @@ DEFINE CRB_FLAG_ENABLE =3D TRUE DEFINE DEBUG_FLAGS_ENABLE =3D FALSE =20 -DEFINE PERFORMANCE_ENABLE =3D TRUE - DEFINE SERVER_BIOS_ENABLE =3D TRUE DEFINE PCH_SERVER_BIOS_ENABLE =3D TRUE =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91735): https://edk2.groups.io/g/devel/message/91735 Mute This Topic: https://groups.io/mt/92554228/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91736+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91736+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515605; cv=none; d=zohomail.com; s=zohoarc; b=d6my5ffmPAwiWBsfEjhgU0x3Byorc+vlvBKmN/3L7dVbnx8SFZCIkhFBFRLuqzJY5T7QaCRk6BhbzWP28SBrmle8wbgAtrQ53HVa160iAQOmpAXAoIvsm3xDQnEybFelkchurY82oCBBxj5HcfyBK6Tt8occZ0bR3I23F1OebSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515605; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=byVGjjR3qxvXqM6O9+oUDB5hk7HaUOx5TH/eafsybqY=; b=C2wrZWl5XhjMymCDHDMZMjuVgkGpU3m0zQnZi7c7DR4tH0d9Ey0/DMEDU254mBoiDEaeVQXcoUxBy37pRnlBvElyDvU7Y7ZT/Ef2E8jvNtZ3peEq89+eOgks75EHNfDMvEJja7fvm4rMl8nmYy8Ybw7ejjKhqaONSMbJTYy1nPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91736+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515605529197.22134270524077; Fri, 22 Jul 2022 11:46:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id GFdBYY1788612xsTKCQnLonE; Fri, 22 Jul 2022 11:46:45 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.11538.1658515598830308993 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138261" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138261" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767963" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Sai Chaganty , Nate DeSimone , Liming Gao Subject: [edk2-devel][edk2-platforms][PATCH V1 03/13] Features/Intel: Reduce duplicate code Date: Fri, 22 Jul 2022 11:46:14 -0700 Message-Id: <2efb22612de62016524ab4d5321dd495781c90a7.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: eCat1AGT1zwD8NB7Ok0kLw6vx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515605; bh=E/s7HFFkzay8weaOHrjiGYu/3zMDBXn35kdK/puu0Ag=; h=Cc:Date:From:Reply-To:Subject:To; b=exON8aoddUuD1s1zN8XqcbAbwp/cqmOZiKAW4rZ44/4vABHdoFyaaWTk6RK76+3z36E Wrm8KlsuTFffGQny0gwScR5+xWkzWRnakbo7TvyyXwN+eJDLBJTFnDaKBaHv9rr8q3laJ qN2SSNH+8wSqafm3odpYf5H8JSGUDI6QEVA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515607206100021 Content-Type: text/plain; charset="utf-8" Enable simpler initialation of the MinPlatformPkg feature selection PCD. Most features and boards don't benefit from initializing these. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++++++------- .../AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc | 12 ++++-------- .../BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc | 15 +++++++-------- .../PostCodeDebugFeaturePkg.dsc | 15 +++++++-------- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++++++------- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++++++------- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++++++------- .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 13 ++++++------- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++++++------- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++++++------- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++++++------ .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++++++------- .../VirtualKeyboardFeaturePkg.dsc | 13 ++++++------- 13 files changed, 78 insertions(+), 93 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 28530b8c67..b572f2eda8 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -88,13 +88,12 @@ [PcdsFixedAtBuild] gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 =20 -[PcdsFeatureFlag] - # - # MinPlatform common include currently required PCD - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeatureP= kg.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d= sc index 3b76d39ea8..306d8bce16 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc @@ -28,15 +28,11 @@ MinPlatformPkg/MinPlatformPkg.dec =20 # -# Since there are no 32b libraries or components in this package, these PC= D are specified for 64b only +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. # -[PcdsFeatureFlag.X64] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeatureP= kg.dsc b/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.d= sc index 56cad020bf..cad4e30aa3 100644 --- a/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc +++ b/Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc @@ -28,17 +28,16 @@ MinPlatformPkg/MinPlatformPkg.dec BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE - [PcdsDynamicExDefault] gBeepDebugFeaturePkgTokenSpaceGuid.PcdStatusCodeUseBeep|TRUE =20 +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + # # Include common libraries # diff --git a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebug= FeaturePkg.dsc b/Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeD= ebugFeaturePkg.dsc index 349604098f..16642e6c59 100644 --- a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeature= Pkg.dsc +++ b/Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeature= Pkg.dsc @@ -27,20 +27,19 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE - [PcdsDynamicExDefault] # # PCD needed for this feature to build # gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdStatusCodeUsePostCode|TRUE =20 +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + # # Include common libraries # diff --git a/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc= b/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc index cdc5dc851d..87060714e7 100644 --- a/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc +++ b/Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeatureP= kg.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d= sc index c35e1e174e..76d2c45a73 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc @@ -28,13 +28,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= sc index 2ee874a58e..8d71939a16 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc b= /Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc index e16a1f8d00..2d1d197b2a 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeatur= ePkg.dsc b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeatureP= kg.dsc index e72b341154..5a9ff5b1b8 100644 --- a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc +++ b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc b/Fea= tures/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc index 03657047dc..191173051f 100644 --- a/Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc +++ b/Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc= b/Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc index 5a6436178c..ffcd104a3e 100644 --- a/Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc +++ b/Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc @@ -31,12 +31,12 @@ [PcdsFeatureFlag] gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable = |FALSE =20 - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeatur= ePkg.dsc b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeatureP= kg.dsc index 10360c5737..8af4dd4cd9 100644 --- a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc +++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Virtual= KeyboardFeaturePkg.dsc b/Features/Intel/UserInterface/VirtualKeyboardFeatur= ePkg/VirtualKeyboardFeaturePkg.dsc index 6717c892f1..d13bd673d3 100644 --- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar= dFeaturePkg.dsc +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar= dFeaturePkg.dsc @@ -27,13 +27,12 @@ [Packages] MinPlatformPkg/MinPlatformPkg.dec =20 -[PcdsFeatureFlag] - # - # PCD needed for MinPlatform build includes - # - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 # # Include common libraries --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91736): https://edk2.groups.io/g/devel/message/91736 Mute This Topic: https://groups.io/mt/92554229/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91737+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91737+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515604; cv=none; d=zohomail.com; s=zohoarc; b=ErRLTd40AbuEG4VJ96/wu1LOhpa4sZDr2TK5uP4iZuYGB0xFvaRO0N6fH24uN7Bf72D1RM/MdRFnvwyD4DS/aOINSst3DRrxTIxMysOPO/Qs6601XyTrCPZW0wxlA9X8hUvYl/qQEMuL0x4a45BEBRwsxh6zpz+V2PDE3a+S1eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515604; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FR6laVPVKRkHG44FAW2vdVA6PBl0BpliDGICA1jCoxY=; b=MCV/xkIhE3xWplaslrElkhJfXs8B6Oeuqq6pncPdvQp8gnvqBrAGkHfRdXjSSR/cW/FU64/j1BPyi9tYyIIcZRFfFhvpKruuCooGaVeoCRD5B5OOwQhO5/FJgr7Um+TzX6DKcNp9tjE0K3zzXUCnvwXDG95roA+pFKvq8OFR57s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91737+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515604457668.4404774539486; Fri, 22 Jul 2022 11:46:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Vg3jYY1788612xk1qkJGG0Kc; Fri, 22 Jul 2022 11:46:44 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138262" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138262" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767966" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel][edk2-platforms][PATCH V1 04/13] WhitleyOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:15 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: LaKP8HlBY04gbNupIRaTTimfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515604; bh=ljQuOfhIA24728GNKjIFj1IxQn9b0AwKsQmvZmz2b1w=; h=Cc:Date:From:Reply-To:Subject:To; b=WQIcKkqt4xc1WhavInCR/4bBiFxnwlSG/wUdGQ/+ry4HNDt6dPH7WNKIC5eP3pZul5b zdarfaqA8PVkhhnHxhqEhbZygJA6J0ks08naRUV7ddhrcanCluzO8gTCsawK0H7OmHXv3 lJDnCqouB716Uzwk8PBKQNrHDAeN/D2MAww= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515605167100011 Content-Type: text/plain; charset="utf-8" Use MinPlatformFeaturesPcd.dsc.inc to initialize feature PCD Move individual feature enabling examples to BoardPortTemplate Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../Aowanda/PlatformPkg.dsc | 3 -- .../BoardPortTemplate/PlatformPkg.dsc | 50 ++++++++++++++++++ .../JunctionCity/PlatformPkg.dsc | 3 -- .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 51 ------------------- 4 files changed, 50 insertions(+), 57 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc b/P= latform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc index 63648172da..8761f8b56a 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc @@ -26,9 +26,6 @@ !if $(gMinPlatformPkgTokenSpaceGuid.PcdBootStage) >=3D 5 gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |TRUE gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |TRUE -!else - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE !endif =20 !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git a/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformP= kg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.d= sc index e3e8ceb7ce..9bf5d02a3d 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.dsc @@ -15,6 +15,56 @@ =20 !include $(RP_PKG)/PlatformPkg.dsc =20 +# +# Feature enable/disable flags +# +[PcdsFeatureFlag] + # + # MinPlatform control flags + # + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |TRUE + + # + # Debugging features + # + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |FALSE + gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable = |FALSE + gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEnable = |FALSE + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |FALSE + + # + # Network features + # + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |FALSE + + # + # OutOfBandManagement features + # + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |FALSE + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable = |FALSE + + # + # PowerManagement features + # + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE + + # + # SystemInformation features + # + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |FALSE + + # + # UserInterface features + # + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable = |FALSE + gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE + gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEnable= |FALSE + +!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc + [Defines] DEFINE BOARD_NAME =3D BoardPortTemplate PLATFORM_GUID =3D f3518dd4-5dec-4d2c-9ac9-561121e2= 628b diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.ds= c b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc index 8cedbaccee..8e226c1552 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc @@ -26,9 +26,6 @@ !if $(gMinPlatformPkgTokenSpaceGuid.PcdBootStage) >=3D 5 gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |TRUE gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |TRUE -!else - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE !endif =20 !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc index 5b5d84779e..0ff9c00b94 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc @@ -59,57 +59,6 @@ [PcdsFixedAtBuild] gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 =20 -# -# Feature enable/disable flags -# -[PcdsFeatureFlag] - # - # MinPlatform control flags - # - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |TRUE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |TRUE - - # - # Debugging features - # - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |FALSE - gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable = |FALSE - gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEnable = |FALSE - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |FALSE - - # - # Network features - # - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |FALSE - - # - # OutOfBandManagement features - # - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |FALSE - gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable = |FALSE - - # - # PowerManagement features - # - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE - - # - # SystemInformation features - # - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |FALSE - - # - # UserInterface features - # - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable = |FALSE - gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE - gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEnable= |FALSE - -!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc - # # Platform On/Off features are defined here # --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91737): https://edk2.groups.io/g/devel/message/91737 Mute This Topic: https://groups.io/mt/92554230/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91738+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91738+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515606; cv=none; d=zohomail.com; s=zohoarc; b=PRCTdfzGog4rDOKUZLxfZaEpeEP59mbDthVuTFAM3cyXl6ac/6YAvCA/F2h54FwPfsxL+/kcTbrZrim8mUwDBzxwRxv5mCkOjFNTGucK6zPIHmmEbCfSATGaXYaY65uMhqDZlarduUmKnE+Q+Vxi4vE733e5IsdUvBZq917A1NE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515606; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kObiM4TM3gPNGnBV10/1mwt81Ef7qhpIcDyk1JCl37E=; b=kbaywP0bbk2xCQpoYXnmbPiGrtSvpGJZgycxwNQlF35qU+ZqYUAM2j8hRXH5RTwGwusivEUwo/Zowp4a3PH+kGiPti7QHnQTIA53FyXwlvBSJq1ZWUyf52jfaAAZmMVge2PpRoHjYu7YvKM/zatGR7qb1MnFbkA/HrdAFLeErLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91738+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515606951929.1223298661284; Fri, 22 Jul 2022 11:46:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id lMeOYY1788612xIbBeNcjLPD; Fri, 22 Jul 2022 11:46:46 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.11538.1658515598830308993 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138264" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138264" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767970" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 05/13] MinPlatformPkg/Include: Simplify build logic Date: Fri, 22 Jul 2022 11:46:16 -0700 Message-Id: <2082a8bc205a50292e6ac9d23e6c94e2a2b4e0aa.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: 5iozjtNXLBLD5x0D360pxBX7x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515606; bh=HCVvFXy4NTJOvDvtlGC2X+2/OY2u6J26q1nfBKbE6dM=; h=Cc:Date:From:Reply-To:Subject:To; b=FCzRHYUdPI6BX6wEHkmn7KXPVquXniMeQPw6DfX2Tq4zCJqbFRRbDyi3rtR3rqLtGXC yFcWQCdUU/28h49rbbpXEg5HhtaC2cBGVT4ywAbN3gkS65KHap+3qmNtnAxb3sU5uEcNj 8hg3vW5PmkQqDVyVPhW0EaQP7rfF9ayWVgc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515607165100020 Content-Type: text/plain; charset="utf-8" Removed the logic that doesn't build some things only if you are doing a shell boot. Since they are built for stage 1 or 2, there is no porting benefit to this logic. Build simplified to build both sets of drivers. Switched from PcdSmiHandlerProfileEnable to using RELEASE build type to disable SMI profiling. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../Include/Dsc/CoreCommonLib.dsc | 6 ++--- .../Include/Dsc/CoreDxeInclude.dsc | 23 +++++++++---------- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 1 - 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/= Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc index b77d55dfd5..3749199da7 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc @@ -122,10 +122,10 @@ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebug= LibReportStatusCode.inf !endif =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - SmiHandlerProfileLib|MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmi= HandlerProfileLib.inf -!else +!if $(TARGET) =3D=3D RELEASE SmiHandlerProfileLib|MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerP= rofileLibNull.inf +!else + SmiHandlerProfileLib|MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmi= HandlerProfileLib.inf !endif =20 PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibN= ull.inf diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc b= /Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc index c2ade240f3..21570afe3f 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc @@ -29,7 +29,17 @@ PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.i= nf MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE + # + # Emulated variables for stages 1-4 + # + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { + + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE + } + + # + # Real variables for stages 5+ + # MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { @@ -38,12 +48,6 @@ NULL|MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf NULL|MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.inf } -!else - MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { - - gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE - } -!endif =20 MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntim= eDxe.inf =20 @@ -122,7 +126,6 @@ PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf } =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf =20 @@ -133,14 +136,11 @@ =20 UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferD= xe.inf -!endif =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerf= ormanceSmm.inf MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsRes= ourceTableDxe.inf -!endif =20 !if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable =3D=3D TRUE SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDx= e.inf @@ -162,4 +162,3 @@ !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf !endif - diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesP= cd.dsc.inc b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesP= cd.dsc.inc index 842668a081..2d665c25c5 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.= inc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.= inc @@ -22,5 +22,4 @@ gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable |FALSE =20 - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91738): https://edk2.groups.io/g/devel/message/91738 Mute This Topic: https://groups.io/mt/92554232/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91739+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91739+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515604; cv=none; d=zohomail.com; s=zohoarc; b=W4Awx+feNkrfazY2+6PILwmpEhsgUk3tR2l3ic41BXMYDBouJ6SuHMUPBc0F30WGjPQpCkaT2G+l7+R6H+3AW+IePGFQ5va/FCcso9iETkPhLywpDqN/OSfRvYYVdDm+vj11Jf/aTsmDK3BIz/9LuoPA6DBKUovxqHH+cnXiaUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515604; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=pkpKdGNiDMMAtl1Bw7gN9XGMIlRV8AhCAcCuuoU08kE=; b=flJc7GReBMHY/lb7x1YmtutoOYDhJC00n9xHD/4NaFK2wh6D5HQQkGVzBEJAwxOhjS6VknHtaKTqwLbty5cKRyoaC98oTXfDz2/Jg95vivNlreaxpNuUH2J/DRHYiGMLETWL1iTnBPfhDvzASZoZuJnezlqgE+o58VFAHBrveqw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91739+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515604732409.11637377743637; Fri, 22 Jul 2022 11:46:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5Fo6YY1788612xC44QZ4z1Nf; Fri, 22 Jul 2022 11:46:43 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138265" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138265" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767973" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Eric Dong , Liming Gao Subject: [edk2-devel][edk2-platforms][PATCH V1 06/13] BoardModulePkg/Include: Add include for stage behavior logic Date: Fri, 22 Jul 2022 11:46:17 -0700 Message-Id: <4947838e5acd57ebb01bef4807d65e9f589ad99f.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: UGH3wynMFyIG4fdsdMMqmfTdx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515603; bh=3xRW1oMUJ2SKbIM8ZKo2rxZNjhKYOtqyJkOBxKeDFVM=; h=Cc:Date:From:Reply-To:Subject:To; b=JJHS4bVXxBrkG4rpr06hcw5vuj/Vs/kFp+B+JZR87W5f513kcKsUSiUPQwexEVbqAwN o0mk6Wqj7fEwQsQacuN/9MTA7lIu/GeutfS7sV5EJSiojUZRmEUjsj95LhGR5+6epXQ/M s+J9hhoAGdP+oc2m9Hd+DkX9BAYBX6o4Mig= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515605134100009 Content-Type: text/plain; charset="utf-8" This is a commonly used set of settings modifications based on the boot stage targeted. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageCo= nfig.dsc.inc diff --git a/Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.ds= c.inc b/Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc new file mode 100644 index 0000000000..6927b5c9c2 --- /dev/null +++ b/Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc @@ -0,0 +1,37 @@ +## @file +# Commonly used stage configuration logic +# +# Copyright (C) 2022 Intel Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[PcdsFeatureFlag.Common] + !if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE + !endif + + !if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE + !endif + + !if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE + !endif + + !if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE + !endif + + !if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE + gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE + !endif + +[PcdsFixedAtBuild.Common] + !if $(TARGET) !=3D RELEASE + gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 + !endif --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91739): https://edk2.groups.io/g/devel/message/91739 Mute This Topic: https://groups.io/mt/92554233/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91740+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91740+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515606; cv=none; d=zohomail.com; s=zohoarc; b=ZZqx7nXeOaHv3bDi7l6y444bbtUrZawmveC+3tzp2M68/c+Dys8K1lJBHRHar1CfP1SJDvrKp2fdUFX/O+XPBIGSkI0Wo9e0yZY0nhDMQ+pa7lHk2i16VuNFUoHO7jp4e0IipBiqCtIJdb/hgBGmD5w60xgrfo0sKFkIbgeRStE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515606; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=yjbt97DOhsOOzsngTUsCmFiWFMlz5N0CRJSyIfg+Cc4=; b=FTBdBpYmAnOplqJX0TYizaGJstcicOUIb6X3hx7LiBPwAS0znuck1MD12Fg/W7bEQ2iNxY5Xw92Xn0QQHJ+aemk2HgatOVHp2wTq2IfzRVr6KPVVWcEkhBQl3UcLPCkeSbGqxNhrwWC1dTxPqIKN4i2+E7IRb6xHtZWWqs+iqt8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91740+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515606243453.11968985515784; Fri, 22 Jul 2022 11:46:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id C5xgYY1788612xXf9KDjaums; Fri, 22 Jul 2022 11:46:45 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.11538.1658515598830308993 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138269" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138269" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767976" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH V1 07/13] WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:18 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: ECd8v7NiqmgT68mfV2DsrTbGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515605; bh=cl3TDyV0xKkL6RVhXeKe/gGBtcDSVDO6woxn9UA5SXQ=; h=Cc:Date:From:Reply-To:Subject:To; b=m3KZgA1dTVKNQr+Oq1Tq4dF7Tlzb1Os/m8YLbkDolhakDi6Y2EVCVsj7BbNpBmjx9j0 n+yHBl476BrzR/crDjnlpXmY3KjvE+UY+lv+DmVHLDqYgy8GW1i/O+qRMRy5yKtxL0Hod I9cebMTQM0LEGn4/yrPBbKF4viWqKHfROoc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515607132100019 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 +++++-------------- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 +++++-------------- 2 files changed, 24 insertions(+), 78 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPc= d.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc index 8f3cc6ba28..a7e9a41e2c 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc @@ -121,42 +121,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -191,9 +167,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x5000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE =20 # diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoa= rdPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkgPcd.dsc index 4a5d5ef03b..daf5411ac3 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc @@ -121,42 +121,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -191,9 +167,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x5000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91740): https://edk2.groups.io/g/devel/message/91740 Mute This Topic: https://groups.io/mt/92554234/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91741+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91741+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515607; cv=none; d=zohomail.com; s=zohoarc; b=BHpfIt/qzRtbDYH0vfX0gEcFN6E6vIf4Uj/kTNTOKCeOVcxv18DhZFDhYPfX2t79g7bk+mEWSX1wedmK9o/7cYff9dZzqGurmep54P6y5QfRMYZCibEGSQGlNPePjLvyV/06gKRLFTR0ELja/RwYppKGsBl1lxYqe+crTQgiutU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515607; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=VtZrS/xiVcFE5KeEZ4TQ+b30DVUMnnb+tjaQIzyH+pg=; b=C3budJwxc/ltcdd26jfpfPC011kS97E/UALj0j8JOpenUqU0OIcXSdd0QAaxy+PxdeXJyzWA8kCV4f4TJJoc6qPC06LLWgNrJuKiajh7djrK0hIwoWMw75PYfsPmlD+bwBSPX1T2WsdPE1x8zGK1BENL6y1heZuwsVVLaNIwjUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91741+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 165851560701688.31335822196388; Fri, 22 Jul 2022 11:46:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id a1p2YY1788612xzp6PvIEcgN; Fri, 22 Jul 2022 11:46:45 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138270" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138270" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767979" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Heng Luo Subject: [edk2-devel][edk2-platforms][PATCH V1 08/13] TigerLakeOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:19 -0700 Message-Id: <1b1847457fb88a3d8b83acd1ca53898450fbfadd.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: BLw8dZfTYLwGWKxVkqMA8fLVx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515605; bh=SAssi1zQUeM+Pixy+S+TnaszfP1pphRZKTs6cow8UzE=; h=Cc:Date:From:Reply-To:Subject:To; b=Tqm2fSCzpdWfLQQqn1EkqeEO4QpIRMJ6fZFmwe21URok539gSnBdH+7F6h5KzjliD9Q H6KtnYStXxn4HlXlSduKkQtWIq2CHClyAGFUy2s0lB7jStK9C9W4eLBCbpB/Dbyv+TObz FtgsBvSFwrAGM/vixYzdK6eV6I1cMP791yA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609140100041 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 +++++-------------- 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPk= gPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgP= cd.dsc index aba3c8d6d0..2fd6d0c50e 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc @@ -138,42 +138,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -212,9 +188,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x10000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE @@ -396,4 +369,3 @@ # !include $(PLATFORM_FSP_BIN_PACKAGE)/TigerLakeFspPcds.dsc !endif - --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91741): https://edk2.groups.io/g/devel/message/91741 Mute This Topic: https://groups.io/mt/92554235/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91744+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91744+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515608; cv=none; d=zohomail.com; s=zohoarc; b=kzno+mn8PHp94kmqeqItvao0+p8sYVc7hg+qj2dbl9v86W6Lu6lrgXdv7MpOdyd7tDsNRnj/WylR/dvIEEpRfeSrCTMP4iVTfJ0OdTVGBhO9UcMdIKyDuFd52Y53iYTq6YeX8IzYCkXzBPl34JD79lfQUPX4YiNETkV+51sfh0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=11pMF1g+T6QDzCVjD9cLFTWMAdmqHCTLw/VES8vzQS4=; b=AjwLb7DftNH9LmEEj6moej87gLdl244olr2MIKJX7WV4Bi7l6aye2ol6NCt1veSH51CDV6+/YusqO/uropLGIZeQ8SO4Q+8Sif3Fmd2PNbDGaptoA4i+oP2d7esdp3lu2dYTWrPmsttxlOVNVyrBPTlrxja/ySPf5UAj3qOzero= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91744+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515608357223.28545319501904; Fri, 22 Jul 2022 11:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YH08YY1788612xvln5NQzZfa; Fri, 22 Jul 2022 11:46:48 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.11533.1658515599883284865 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138271" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138271" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767982" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH V1 09/13] SimicsOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:20 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: H9oWWSF1kRPBKXIdjkBAHooXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515608; bh=ohuNdoMtZwN2D5ex6R5WJ54GUF673WeEsuhM6FLfS9c=; h=Cc:Date:From:Reply-To:Subject:To; b=OrZRC5VH4VT9mYSHzI1qQHy6qokqAFDNgHtdNQyHqTqnZDdlO/qhV18VhO8Je2mi53c M81WK+XKKVHyA1KpjwY1lRtqteUMIAZD7LHQVXIuFpf6Ff0etCQ9xEzSxwRoQoMfPp5Ew faQ5J4C8IDECQmj/tWzX9m6F6EWWlElPu/I= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609159100043 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Nate DeSimone Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 +++++-------------- 1 file changed, 12 insertions(+), 39 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPc= d.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index 44b6a81277..e2171dd376 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc @@ -42,42 +42,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Silicon Configuration @@ -212,9 +188,6 @@ ###################################### # Edk2 Configuration ###################################### -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91744): https://edk2.groups.io/g/devel/message/91744 Mute This Topic: https://groups.io/mt/92554238/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91742+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91742+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515608; cv=none; d=zohomail.com; s=zohoarc; b=oCdZGgPl54DNvxb/nLpb8DW33epRJlK+cDU+bgCg438knZc7dabex6qSVPswjwWleMB/F2/exT9w6vai+/R7WCVy3F/wKp3mQG1IEUMO8wUDZn8ooNOXuYbHlXsuR/KQxqCYmGv3Q6muFZ/FvYrnnltjsjK4Xd4pdLJoaeZkOBY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Dyrk98m+cGiYRNOgp4y0FVgloYPv3Hfqw6I5ZQrxSq4=; b=h1ReQW+mINSyV5/kxCfUG442s973NdqkmpAHQUyO7s4FRspdC5TFLlPVUQKM10nx21/P79Dop4RCINn40Ex2xaQ+JW+5AKL9ZAmoMCJQdWWjLk9G6tY0X+iO6SCo0e7lTMgilAj2hkH0Rw7qIf44zUNROyS1fB6C3qbSpneorR0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91742+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515608879333.5912325085475; Fri, 22 Jul 2022 11:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kqzmYY1788612xDwQSibVcFU; Fri, 22 Jul 2022 11:46:47 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.11538.1658515598830308993 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138279" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138279" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767985" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH V1 10/13] PurleyOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:21 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: fzP7a86WeRzV346fQuW4IM2Sx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515607; bh=5oDF29q4/HC5i+Xv1Tu7FKXPHZlfw6FMjDPmXUBWaCw=; h=Cc:Date:From:Reply-To:Subject:To; b=SqBNmHgO+EJVS3TJsM/0nv0T9bz0H53+P5A0ToPQxzhwUL7sgRUJyAKcTab/HxaGfYa lSkn2gotkXMvGAhauOTtCkRQ8xTrxVpwsvNeNnPsk0P3I+bQGPli6JztAvoLN+95ypHL9 IxmvbbQaKFrKMf3bP986RNdX6uGyOpttX6M= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609236100046 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 +++++----------- .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 +++++-------------- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 +++++------------ .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 +++++-------------- 4 files changed, 49 insertions(+), 149 deletions(-) diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgCo= nfig.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgConf= ig.dsc index 2bd714c01e..2359243310 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgConfig.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgConfig.dsc @@ -14,40 +14,18 @@ gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4 =20 [PcdsFeatureFlag] - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - - !if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE - !else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE - !endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|TRUE =20 diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPc= d.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc index 050f9b6228..069f463d5e 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgPcd.dsc @@ -61,42 +61,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 [PcdsFeatureFlag.X64] gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackGuard|FALSE @@ -278,10 +254,6 @@ [PcdsPatchableInModule.common] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042 =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x80000000 gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgCo= nfig.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgConf= ig.dsc index cefb81b76e..e393cf3097 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgConfig.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgConfig.dsc @@ -14,40 +14,18 @@ gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4 =20 [PcdsFeatureFlag] - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - - !if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE - !else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE - !endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|TRUE =20 @@ -62,4 +40,4 @@ !if gPlatformTokenSpaceGuid.PcdFastBoot =3D=3D TRUE gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE gPlatformTokenSpaceGuid.PcdUpdateConsoleInBds|FALSE -!endif \ No newline at end of file +!endif diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPc= d.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc index 5940c40dfc..d8cd559490 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/PlatformPkgPcd.dsc @@ -61,42 +61,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 [PcdsFeatureFlag.X64] gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackGuard|FALSE @@ -281,10 +257,6 @@ [PcdsPatchableInModule.common] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042 =20 -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x80000000 gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91742): https://edk2.groups.io/g/devel/message/91742 Mute This Topic: https://groups.io/mt/92554236/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91743+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91743+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515608; cv=none; d=zohomail.com; s=zohoarc; b=F4qfWbROtjU36UYyfulYdcMdCXiOD8NFnuBAX8hDMerv4mI2p9lq5VO1FcbR53DS6Ehw57HOajii4OPJpuWT0qM2EIwbFAtwkthZDBbmMHxanVIwKpjQV0uMRQEaUQoUuj99o8dshX07IMORnuOZP909Snj0mfK9CPbLcILaeO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=H8mhsFUJQjzfcu6wN0E+UtiBbcKHAHEeBN6pk1aOPF4=; b=KtiMRiXfKEst8UdA2bE6CZa83+KaiuUQldu5MwjGzgO3JASOfuJfk5EcpXuqTg8UViX4Uvp2QIAfeJj3Y6XfE9GJ2DNe8+jEruonk/7e0C7U4aYf8pH6Ie0l8K//dbPX/t1LHnwaEheg0uBIcQL0skeahjt24t8+FqpgswCpdXU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91743+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515608004414.79476451501046; Fri, 22 Jul 2022 11:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id LFRAYY1788612xMpYgJZMwz2; Fri, 22 Jul 2022 11:46:47 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138280" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138280" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767989" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH V1 11/13] KabylakeOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:22 -0700 Message-Id: <014f6c3ef5912329bb2d1f1681aeca0c94026a79.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: PUDerNUBllAu2QtV0JjBpNiTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515607; bh=qnsQWKP4n93WijmAQ6EY3l8sFPgI5TBlpaYxZvHOC+4=; h=Cc:Date:From:Reply-To:Subject:To; b=KLEIbEJNAGRoJtCrNe2AqgX4XpDexawX5WxEHlSI8PZ3gGni1kcxZOHH1RL4nP+tKa/ bTqz7IO48t7xvpHBYkEWv0vQ4wKAK8JOwlcsbmqxDs/Fg8P3AnLmF6THGI4BCThDPiPmc huj5C+NuAolhn+S9pAzIT3+C9M87sCBjykA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609194100044 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 +++++-------------- .../GalagoPro3/OpenBoardPkgPcd.dsc | 51 +++++------------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 +++++------------- 3 files changed, 36 insertions(+), 118 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoar= dPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoa= rdPkgPcd.dsc index 02080aa864..da8f9a075c 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd= .dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd= .dsc @@ -195,43 +195,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE # FIXME: Defin= e by PERFORMANCE_BUILD? - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE # FIXME: De= fine in build-system? - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -# TODO: Is TESTING setting, is not test point -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -285,9 +260,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE !if $(TARGET) =3D=3D RELEASE diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd= .dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc index 26e2c16aae..2b9fbe81c0 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc @@ -163,42 +163,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -233,9 +209,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x5000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgP= cd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d= sc index ccf757e202..360b99e0cf 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc @@ -163,42 +163,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -233,9 +209,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x5000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91743): https://edk2.groups.io/g/devel/message/91743 Mute This Topic: https://groups.io/mt/92554237/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91745+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91745+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515608; cv=none; d=zohomail.com; s=zohoarc; b=meYcgV1fbiTcrEP6pnU48nqdrXR0743SVVcuOtyJd4XsfKDGygewL2IkSFSiqaO1JDumOuZ+bJKlqqDpqXyByExjKs3cZnnSaC6WTPu7EmZutnnkwfeDZzd3xBGwBnqHjQBchKYPQG39dF29n6i8nXPfv7tBy8kl62dmnq59FeU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=/R2FS804Is6OOoB12KIaHfStJdgr6ZeUAAY6rrKPNgE=; b=XzLI9L/BTqaSwPcDohLHsvMIgBzDFef/T1w/Sh3aiAhbuhbrVojYJ+Rp4gD18G7x/I9hZg8GgZD1SVO0EeUrHQ7GC56H5rfuIafSecrPdiLcaohUYWkOHtzlSy4LBuiPNxVUYEM7o/7XNnBx6Ow04AHiiQRBdr56fUfsrrOV/jQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91745+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515608722152.42924809193164; Fri, 22 Jul 2022 11:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qY6LYY1788612xTYe8VQKXef; Fri, 22 Jul 2022 11:46:48 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.11533.1658515599883284865 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138282" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138282" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767994" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Rangasai V Chaganty , Deepika Kethi Reddy , Kathappan Esakkithevar Subject: [edk2-devel][edk2-platforms][PATCH V1 12/13] CometlakeOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:23 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: yrVd0Dt5MbRA4E16yXN1I74Zx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515608; bh=1F+vLiQtqn7HoXJNYdRUO6u96jqvad/+eo++hN1nYsU=; h=Cc:Date:From:Reply-To:Subject:To; b=jgk/PHS+L7/yLunimXjDL0uJRmbQZUduXAZkiYrLyrNlfEHY/tNHyqP9axOlCFFND3B MilfARkuGzInfKbHHHfIoIoWbb7cwZRYCaAOlf+ulaZdQ1BlnN/HftNkXgptmjkwO5nN5 mMiEahE4pbJtvxdg2dUp4NUgom9qoX2IR40= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609157100042 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 +++++-------------- 1 file changed, 12 insertions(+), 39 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= gPcd.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP= cd.dsc index 68dd08423b..79924f1fda 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgPcd.dsc @@ -125,42 +125,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Board Configuration @@ -195,9 +171,6 @@ !endif gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x5000 gEfiMdeModulePkgTokenSpaceGuid.PcdReclaimVariableSpaceAtEndOfDxe|TRUE -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91745): https://edk2.groups.io/g/devel/message/91745 Mute This Topic: https://groups.io/mt/92554239/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 09:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91746+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91746+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515609; cv=none; d=zohomail.com; s=zohoarc; b=cXLNnvKTs/AGWpb4N7tZ5m8/vBfE8zvSKJVGrFMT/HHal9DaN3igJNVHM8QmRDJ37pBIYSm6ORGTPCy/gRwkltVwjeKdmtKkDq/PJwfh4AYOI47ecp9wnfPjHChZ+87Haofm6vMsGjDcKfdyd+HXAiL2v//Osr+vyMgkqwyOzG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515609; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=bqyVcebcUIDs16i8ACEQEHjdiekfPsAQVSbprN9iVX0=; b=fdLBvN7YsqB0w6nwVOO38BFVgDCo2plwUE2TrWXbxEa2AvTEk7T1jQeIHMyjfUgUFqZo4SCIKmUChq/i4TwhmiWw/athCfWL8U/Kxk7jSobekoy2GG47gVzLyygRD/1EUUtmL2zlwYEd+25ejAGVMB81fJQ6x2N1yewEnExuYFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91746+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515609085742.6499488874082; Fri, 22 Jul 2022 11:46:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 1Wx4YY1788612xhDd8kOsF8P; Fri, 22 Jul 2022 11:46:48 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.11533.1658515599883284865 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138288" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138288" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666768003" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:40 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 13/13] MinPlatformPkg: Remove unnecessary feature controls Date: Fri, 22 Jul 2022 11:46:24 -0700 Message-Id: <6f789ad9a3134a64b201c28760f4b697dd4c541f.1658513099.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: L0msrAOZhAHJjaCBsCqptotfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515608; bh=0ZuFSklf5TfvNAXS8YbnF9nhxM8DROPSX+azlOtQH3g=; h=Cc:Date:From:Reply-To:Subject:To; b=FoQNn1z88hC0MWQ6X0gjTQh1Xb5TTcoNEC93OwByM3d5bnVeynYU+63Vm3PlrjwFXv6 UvH3GMVac5ShTvVX41yAEu0JHHcApj4i2O2j1oAN3P+soMq1vLMABO0M/mZUo1TWjLL1h 0VvhBH11HwKhShzehv39Ur4a2XYVyArS1es= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515611212100055 Content-Type: text/plain; charset="utf-8" Remove SMI handler profile feature control. Disable handler profiling on RELEASE builds. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dec index 098bb50075..5aaa4a9b92 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -383,6 +383,5 @@ gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly |FALSE|BOOLEAN|0= xF00000A3 gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE|BOOLEAN|0= xF00000A4 gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable |FALSE|BOOLEAN|0= xF00000A5 - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE|BOOLEAN|0= xF00000A6 gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE|BOOLEAN|0= xF00000A7 gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable |FALSE|BOOLEAN|0= xF00000B0 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91746): https://edk2.groups.io/g/devel/message/91746 Mute This Topic: https://groups.io/mt/92554240/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-