From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86378+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86378+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643921882; cv=none; d=zohomail.com; s=zohoarc; b=dfpwfD6hx9/S85duoD61cTZtdltEsMeVRD0Nvl3PUwx5JCe6O5niV6pBGxNW/AndCf2aKmTI9+2c0lH11OfF7WwRB0F62s81XcKviS5CVb1mqnX0DUjEFC9Dk5QIB6BFvFTZy/5yGaywvBUYni/yBIYHaBL1fxB9Drv9Z2ErNy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643921882; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=o/MpiXzWTiEcHgpPvC0hyRbaU+oAyQr2etQMZ/dPIL8=; b=ZxTYeE79rV3q57WoFu4SyQUsqBIyJRFCyEZbKXybVHTbydxCZc170qCbEOAUxGELAkPXJ232Hd65gW28Pig5DA5I3wdRSwH79mRJ2/jvGwnAivxoFKaOM1OIG2IDIC7Qmri4KE9ANJXkwj8HRHw5BnnA87ahRnmNilGEOtg7SI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86378+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643921882380129.73994573730704; Thu, 3 Feb 2022 12:58:02 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id T9LzYY1788612x6mhdLi3u5h; Thu, 03 Feb 2022 12:58:01 -0800 X-Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by mx.groups.io with SMTP id smtpd.web12.124.1643921881171143023 for ; Thu, 03 Feb 2022 12:58:01 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="989484221" X-Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 03 Feb 2022 20:57:45 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com (Postfix) with ESMTPS id C322180C16; Thu, 3 Feb 2022 20:57:44 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 20:57:41 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 1/8] OvmfPkg/Library: Create base HardwareInfoLib for PCI Host Bridges Date: Thu, 3 Feb 2022 21:56:21 +0100 Message-ID: <9a33f78e90fd65e1f718cfc6b42384aadd8f10ac.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: KjHaVE3htMsDg1pirf6zvRzOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643921881; bh=HzmEf9KKvwDJikcjkb8D9xRcbmhUJXHfR1m8JT1iBt0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=bAEfzrFNATEVCPwWGS09aS9XRZzpNQXqlEwblMNfc9ndjBYZJrPqY3kOgb6xRgdPwQ6 CU8C0plZ5SuWNTVIxPavkqFIo/8OKa3qkYn3TThr1bVbqe/gYyXGBYzIIRaVbxGrHqUK5 OUwYnFKPbdSNSZpHIrcxGFCDvrZvnFI8xcY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643921884941100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create the Hardware Info library base together with the specifics to describe PCI Host Bridges. The Hardware Info library is intended to be used for disclosing non-discoverable hardware information from the host to the guest in Ovmf platforms. Core functionality will provide the possibility to parse information from a generic BLOB into runtime structures. The library is conceived in a generic way so that further hardware elements can also be described using it. For such purpose the length of the BLOB is not restricted but instead regarded as a sequence of header-info elements that allow the parsing during runtime. The first type of hardware defined will be PCI host bridges, providing the possibility to define multiple and specify the resources each of them can use. This enables the guest firmware to configure PCI resources properly. Having the size of each individual element favors the reuse of a single interface to convey descriptions of an arbitrary number of heterogenous hardware elements. Furthermore, flexible access mechanisms coupled with the size will grant the possibility of interpreting them in a single run. Define the base types of the generic Hardware Info library to parse heterogeneous data. Also provide the specific changes to support PCI host bridges as the first hardware type supported by the library. Additionally, define the HOST_BRIDGE_INFO structure to describe PCI host bridges along with the functionality to parse such information into proper structures used by the PCI driver in a centralized manner and taking care of versioning. As an example and motivation, the library will be used to define multiple PCI host bridges for complex platforms that require it. The first means of transportation that will be used is going to be fw-cfg, over which a stream of bytes will be transferred and later parsed by the hardware info library. Accordingly, the PCI driver will make use of these host bridges definitions to populate the list of Root Bridges and proceed with the configuration and discovery of underlying hardware components. As mentioned before, the binary data to be parsed by the Hardware Info library should be organized as a sequence of Header-element pairs in which the header describes the type and size of the associated element that comes right after it. As an illustration, to provide inforation of 3 host bridges the data, conceptually, would look like this: Header PCI Host Bridge (type and size) # 1 PCI Host Bridge info # 1 Header PCI Host Bridge (type and size) # 2 PCI Host Bridge info # 2 Header PCI Host Bridge (type and size) # 3 PCI Host Bridge info # 3 Cc: Alexander Graf Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- Notes: v4: - Minor change in InvalidateRootBridgeAperture to always set the invalid base address to MAX_UINT64, thus having a universal invalid value. .../HardwareInfoPciHostBridgeLib.c | 514 ++++++++++++++++++ .../HardwareInfoPciHostBridgeLib.h | 262 +++++++++ .../HardwareInfoLib/HardwareInfoTypesLib.h | 64 +++ 3 files changed, 840 insertions(+) create mode 100644 OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBrid= geLib.c create mode 100644 OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBrid= geLib.h create mode 100644 OvmfPkg/Library/HardwareInfoLib/HardwareInfoTypesLib.h diff --git a/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.c= b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.c new file mode 100644 index 0000000000..43a8d233ab --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.c @@ -0,0 +1,514 @@ +/**@file + Hardware info library with types and accessors to parse information about + PCI host bridges. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. + **/ + +#include + +#include "HardwareInfoPciHostBridgeLib.h" + +#define IS_RANGE_INVALID(Start, Size, MaxValue) (Start >=3D MaxValue || S= ize =3D=3D 0) + +/** + Calculate the last (inclusive) address of a range. + + @param[in] Start First address of the range + @param[in] Size Size of the range + @return Last address of the range +**/ +STATIC +UINT64 +GetRangeEnd ( + IN UINT64 Start, + IN UINT64 Size, + IN UINT64 MaxValue + ) +{ + if (IS_RANGE_INVALID (Start, Size, MaxValue)) { + return 0; + } + + return Start + Size - 1; +} + +/** + Internal helper to update LastAddress if the Limit address + of the Mem aperture is higher than the provided value. + + @param[in] Mem Pointer to aperture whose limit is + to be compared against accumulative + last address. + @param[out] LastAddress Pointer to accumulative last address + to be updated if Limit is higher +**/ +STATIC +VOID +UpdateLastAddressIfHigher ( + IN PCI_ROOT_BRIDGE_APERTURE *Mem, + OUT UINT64 *LastAddress + ) +{ + if (Mem->Limit > *LastAddress) { + *LastAddress =3D Mem->Limit; + } +} + +EFI_STATUS +HardwareInfoPciHostBridgeLastMmioAddress ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + IN BOOLEAN HighMem, + OUT UINT64 *LastMmioAddress + ) +{ + EFI_STATUS Status; + PCI_ROOT_BRIDGE_APERTURE Mem; + PCI_ROOT_BRIDGE_APERTURE MemAbove4G; + PCI_ROOT_BRIDGE_APERTURE PMem; + PCI_ROOT_BRIDGE_APERTURE PMemAbove4G; + + if (LastMmioAddress =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + // + // Set the output to the lowest possible value so that if some step fails + // the overall outcome reflects no information found + // + *LastMmioAddress =3D 0; + + Status =3D HardwareInfoPciHostBridgeGetApertures ( + HostBridge, + DataSize, + NULL, + &Mem, + &MemAbove4G, + &PMem, + &PMemAbove4G, + NULL + ); + + // + // Forward error to caller but ignore warnings given that, very likely, + // the host bridge will have a PIO aperture we are explicitly + // ignoring here since we care only about MMIO resources. + // + if (EFI_ERROR (Status)) { + return Status; + } + + if (HighMem) { + UpdateLastAddressIfHigher (&MemAbove4G, LastMmioAddress); + UpdateLastAddressIfHigher (&PMemAbove4G, LastMmioAddress); + } else { + UpdateLastAddressIfHigher (&Mem, LastMmioAddress); + UpdateLastAddressIfHigher (&PMem, LastMmioAddress); + } + + return EFI_SUCCESS; +} + +/** + Set the boundaries of an aperture to invalid values having + size zero and start MaxValue (yields Start > Limit which + depicts an invalid range) + + @param[in] MaxValue Max value of the aperture's range (depends + on the data type) + @param[out] Aperture Aperture object to invalidate +**/ +STATIC +VOID +InvalidateRootBridgeAperture ( + OUT PCI_ROOT_BRIDGE_APERTURE *Aperture + ) +{ + if (Aperture =3D=3D NULL) { + return; + } + + Aperture->Base =3D MAX_UINT64; + Aperture->Limit =3D 0; +} + +/** + Fill a PCI ROOT BRIDGE APERTURE with the proper values calculated + from the provided start and size. + + @param[in] Start Start address of the aperture + @param[in] Size Size, in bytes, of the aperture + @param[in] MaxValue Max value a valid address could take and which + represents an invalid start address. + @param[out] Aperture Pointer to the aperture to be filled + + @retval EFI_SUCCESS Aperture was filled successfully + @retval EFI_INVALID_PARAMETER Range depicted by Start and Size is + valid but ignored because aperture + pointer is NULL + @retval EFI_WARN_BUFFER_TOO_SMALL Aperture pointer is invalid but the + range also is so no harm. +**/ +STATIC +EFI_STATUS +FillHostBridgeAperture ( + IN UINT64 Start, + IN UINT64 Size, + IN UINT64 MaxValue, + OUT PCI_ROOT_BRIDGE_APERTURE *Aperture + ) +{ + UINT64 End; + + End =3D GetRangeEnd (Start, Size, MaxValue); + + if (Aperture =3D=3D NULL) { + if (!IS_RANGE_INVALID (Start, Size, MaxValue)) { + // + // Report an error to the caller since the range specified in + // the host bridge's resources is non-empty but the provided + // aperture pointer is null, thus the valid range is ignored. + // + return EFI_INVALID_PARAMETER; + } + + return EFI_WARN_BUFFER_TOO_SMALL; + } + + if (IS_RANGE_INVALID (Start, Size, MaxValue)) { + // + // Fill Aperture with invalid range values to signal the + // absence of an address space (empty range) + // + InvalidateRootBridgeAperture (Aperture); + } else { + Aperture->Base =3D Start; + Aperture->Limit =3D End; + } + + return EFI_SUCCESS; +} + +/** + Merge 2 ranges (normal and prefetchable) into a single aperture + comprehending the addresses encompassed by both of them. If both + ranges are not empty they must be contiguous for correctness. + + @param[in] Start Range start address + @param[in] Size Range size in bytes + @param[in] PStart Prefetchable range start address + @param[in] PSize Prefetchable range size in bytes + @param[in] MaxValue Max value a valid address could take and which + represents an invalid start address. + @param[out] Aperture Pointer to the aperture to be filled + + @retval EFI_SUCCESS Aperture was filled successfully + @retval EFI_INVALID_PARAMETER Either range depicted by Start, Size + or PStart, PSize or both are valid + but ignored because aperture pointer + is NULL + @retval EFI_WARN_BUFFER_TOO_SMALL Aperture pointer is invalid but both + ranges are too so no harm. +**/ +STATIC +EFI_STATUS +MergeHostBridgeApertures ( + IN UINT64 Start, + IN UINT64 Size, + IN UINT64 PStart, + IN UINT64 PSize, + IN UINT64 MaxValue, + OUT PCI_ROOT_BRIDGE_APERTURE *Aperture + ) +{ + UINT64 PEnd; + + if (Aperture =3D=3D NULL) { + if (!IS_RANGE_INVALID (Start, Size, MaxValue) || + !IS_RANGE_INVALID (PStart, PSize, MaxValue)) + { + // + // Report an error to the caller since the range specified in + // the host bridge's resources is non-empty but the provided + // aperture pointer is null, thus the valid range is ignored. + // + return EFI_INVALID_PARAMETER; + } + + return EFI_WARN_BUFFER_TOO_SMALL; + } + + // + // Start from an empty range (Limit < Base) + // + InvalidateRootBridgeAperture (Aperture); + + if (!IS_RANGE_INVALID (Start, Size, MaxValue)) { + Aperture->Base =3D Start; + Aperture->Limit =3D Start + Size - 1; + } + + if (!IS_RANGE_INVALID (PStart, PSize, MaxValue)) { + PEnd =3D PStart + PSize - 1; + + if (PStart < Aperture->Base) { + Aperture->Base =3D PStart; + } + + if (PEnd > Aperture->Limit) { + Aperture->Limit =3D PEnd; + } + } + + return EFI_SUCCESS; +} + +EFI_STATUS +HardwareInfoPciHostBridgeGetBusNrRange ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINTN *BusNrStart, + OUT UINTN *BusNrLast + ) +{ + if ((HostBridge =3D=3D NULL) || (DataSize =3D=3D 0) || + (BusNrStart =3D=3D NULL) || (BusNrLast =3D=3D NULL)) + { + return EFI_INVALID_PARAMETER; + } + + // + // For now only version 0 is supported + // + if (HostBridge->Version !=3D 0) { + return EFI_INCOMPATIBLE_VERSION; + } + + *BusNrStart =3D HostBridge->BusNrStart; + *BusNrLast =3D HostBridge->BusNrLast; + + return EFI_SUCCESS; +} + +EFI_STATUS +HardwareInfoPciHostBridgeGetApertures ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT PCI_ROOT_BRIDGE_APERTURE *Io, + OUT PCI_ROOT_BRIDGE_APERTURE *Mem, + OUT PCI_ROOT_BRIDGE_APERTURE *MemAbove4G, + OUT PCI_ROOT_BRIDGE_APERTURE *PMem, + OUT PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G, + OUT PCI_ROOT_BRIDGE_APERTURE *PcieConfig + ) +{ + EFI_STATUS Status; + BOOLEAN StickyError; + + StickyError =3D FALSE; + if ((HostBridge =3D=3D NULL) || (DataSize =3D=3D 0)) { + return EFI_INVALID_PARAMETER; + } + + // + // For now only version 0 is supported + // + if (HostBridge->Version !=3D 0) { + return EFI_INCOMPATIBLE_VERSION; + } + + Status =3D FillHostBridgeAperture ( + HostBridge->IoStart, + HostBridge->IoSize, + MAX_UINT32, + Io + ); + StickyError |=3D EFI_ERROR (Status); + + Status =3D FillHostBridgeAperture ( + HostBridge->PcieConfigStart, + HostBridge->PcieConfigSize, + MAX_UINT64, + PcieConfig + ); + StickyError |=3D EFI_ERROR (Status); + + if (HostBridge->Flags.Bits.CombineMemPMem) { + Status =3D MergeHostBridgeApertures ( + HostBridge->MemStart, + HostBridge->MemSize, + HostBridge->PMemStart, + HostBridge->PMemSize, + MAX_UINT32, + Mem + ); + StickyError |=3D EFI_ERROR (Status); + + Status =3D MergeHostBridgeApertures ( + HostBridge->MemAbove4GStart, + HostBridge->MemAbove4GSize, + HostBridge->PMemAbove4GStart, + HostBridge->PMemAbove4GSize, + MAX_UINT64, + MemAbove4G + ); + StickyError |=3D EFI_ERROR (Status); + + // + // Invalidate unused apertures + // + InvalidateRootBridgeAperture (PMem); + InvalidateRootBridgeAperture (PMemAbove4G); + } else { + Status =3D FillHostBridgeAperture ( + HostBridge->MemStart, + HostBridge->MemSize, + MAX_UINT32, + Mem + ); + StickyError |=3D EFI_ERROR (Status); + + Status =3D FillHostBridgeAperture ( + HostBridge->PMemStart, + HostBridge->PMemSize, + MAX_UINT32, + PMem + ); + StickyError |=3D EFI_ERROR (Status); + + Status =3D FillHostBridgeAperture ( + HostBridge->MemAbove4GStart, + HostBridge->MemAbove4GSize, + MAX_UINT64, + MemAbove4G + ); + StickyError |=3D EFI_ERROR (Status); + + Status =3D FillHostBridgeAperture ( + HostBridge->PMemAbove4GStart, + HostBridge->PMemAbove4GSize, + MAX_UINT64, + PMem + ); + StickyError |=3D EFI_ERROR (Status); + } + + if (StickyError) { + // + // If any function returned an error it is due to a valid range + // specified in the host bridge that was ignored due to a NULL + // pointer. Translate it to a warning to allow for calling with + // only a subset of the apertures. + // + return EFI_WARN_STALE_DATA; + } + + return EFI_SUCCESS; +} + +EFI_STATUS +HardwareInfoPciHostBridgeGetFlags ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINT64 *Attributes OPTIONAL, + OUT BOOLEAN *DmaAbove4G OPTIONAL, + OUT BOOLEAN *NoExtendedConfigSpace OPTIONAL, + OUT BOOLEAN *CombineMemPMem OPTIONAL + ) +{ + if ((HostBridge =3D=3D NULL) || (DataSize =3D=3D 0)) { + return EFI_INVALID_PARAMETER; + } + + // + // For now only version 0 is supported + // + if (HostBridge->Version !=3D 0) { + return EFI_INCOMPATIBLE_VERSION; + } + + if (Attributes) { + *Attributes =3D HostBridge->Attributes; + } + + if (DmaAbove4G) { + *DmaAbove4G =3D !!HostBridge->Flags.Bits.DmaAbove4G; + } + + if (NoExtendedConfigSpace) { + *NoExtendedConfigSpace =3D !!HostBridge->Flags.Bits.NoExtendedConfigSp= ace; + } + + if (CombineMemPMem) { + *CombineMemPMem =3D !!HostBridge->Flags.Bits.CombineMemPMem; + } + + return EFI_SUCCESS; +} + +EFI_STATUS +HardwareInfoPciHostBridgeGet ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINTN *BusNrStart, + OUT UINTN *BusNrLast, + OUT UINT64 *Attributes OPTIONAL, + OUT BOOLEAN *DmaAbove4G OPTIONAL, + OUT BOOLEAN *NoExtendedConfigSpace OPTIONAL, + OUT BOOLEAN *CombineMemPMem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *Io OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *Mem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *MemAbove4G OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PMem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PcieConfig OPTIONAL + ) +{ + EFI_STATUS Status; + + Status =3D HardwareInfoPciHostBridgeGetBusNrRange ( + HostBridge, + DataSize, + BusNrStart, + BusNrLast + ); + + if (EFI_ERROR (Status)) { + return Status; + } + + Status =3D HardwareInfoPciHostBridgeGetFlags ( + HostBridge, + DataSize, + Attributes, + DmaAbove4G, + NoExtendedConfigSpace, + CombineMemPMem + ); + + if (EFI_ERROR (Status)) { + return Status; + } + + Status =3D HardwareInfoPciHostBridgeGetApertures ( + HostBridge, + DataSize, + Io, + Mem, + MemAbove4G, + PMem, + PMemAbove4G, + PcieConfig + ); + + return Status; +} diff --git a/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.h= b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.h new file mode 100644 index 0000000000..397c8f8a5d --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPciHostBridgeLib.h @@ -0,0 +1,262 @@ +/**@file + Hardware info library with types and accessors to parse information about + PCI host bridges. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. + **/ + +#ifndef __HARDWARE_INFO_PCI_HOST_BRIDGE_LIB_H__ +#define __HARDWARE_INFO_PCI_HOST_BRIDGE_LIB_H__ + +#include +#include +#include + +// +// Host Bridge resources information +// +#pragma pack(1) +typedef struct { + // + // Feature tracking, initially 0 + // + UINT64 Version; + + // + // Host bridge enabled attributes (EFI_PCI_ATTRIBUTE_*) + // + UINT64 Attributes; + + union { + UINT64 Uint64; + struct { + UINT64 DmaAbove4G : 1; + UINT64 NoExtendedConfigSpace : 1; + UINT64 CombineMemPMem : 1; + UINT64 Reserved : 61; + } Bits; + } Flags; + + // + // Bus number range + // + UINT8 BusNrStart; + UINT8 BusNrLast; + + UINT8 Padding[6]; + + // + // IO aperture + // + UINT64 IoStart; + UINT64 IoSize; + + // + // 32-bit MMIO aperture + // + UINT64 MemStart; + UINT64 MemSize; + + // + // 32-bit prefetchable MMIO aperture + // + UINT64 PMemStart; + UINT64 PMemSize; + + // + // 64-bit MMIO aperture + // + UINT64 MemAbove4GStart; + UINT64 MemAbove4GSize; + + // + // 64-bit prefetchable MMIO aperture + // + UINT64 PMemAbove4GStart; + UINT64 PMemAbove4GSize; + + // + // MMIO accessible PCIe config space (ECAM) + // + UINT64 PcieConfigStart; + UINT64 PcieConfigSize; +} HOST_BRIDGE_INFO; +#pragma pack() + +/** + Extract the last MMIO address, either from high (64-bit) or low (32-bit) + memory used by the HostBridge's apertures. + + @param[in] HostBridge Root bridge's resources specification + @param[in] DataSize Size in bytes of the actually filled + data available in the HostBridge object + @param[in] HighMem 64-bit (true) or 32-bit (false) MMIO + address + @param[out] LastMmioAddress Pointer to last MMIO address + + @retval EFI_SUCCESS Operation succeeded + @retval EFI_INVALID_PARAMETER One or more pointer parameters are + invalid + @retval EFI_INCOMPATIBLE_VERSION HostBridge information belongs to + an unsupported version +**/ +EFI_STATUS +HardwareInfoPciHostBridgeLastMmioAddress ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + IN BOOLEAN HighMem, + OUT UINT64 *LastMmioAddress + ); + +/** + Interpret the HostBridge resources and extact the bus number + range. + + @param[in] HostBridge Root bridge's resources specification + @param[in] DataSize Size in bytes of the actually filled + data available in the HostBridge object + @param[out] BusNrStart Pointer to the Bus Number range start + @param[out] BusNrLast Pointer to the Bus Number range end + + @retval EFI_SUCCESS Retrieved the bus number range + without any issues. + @retval EFI_INVALID_PARAMETER One of the parameters is invalid, + either NULL pointer or size 0 + @retval EFI_INCOMPATIBLE_VERSION HostBridge data of unsupported + version +**/ +EFI_STATUS +HardwareInfoPciHostBridgeGetBusNrRange ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINTN *BusNrStart, + OUT UINTN *BusNrLast + ); + +/** + Interpret the MMIO resources in HostBridge and set the apertures + in 32-bit space (Mem), 64-bit space (MemAbove4G), PIO (IO) and + ECAM (PcieConfig) accordingly. + + The 2 types of apertures in each MMIO space (prefetchable and + non-prefetchable) may be merged into a single window, hence if both + types of apertures are defined while the CombineMemPMem flag is set, + the ranges must be contiguous. + + @param[in] HostBridge Root bridge's resources specification + @param[in] DataSize Size in bytes of the actually filled + data available in the HostBridge object + @param[out] Mem Pointer to 32-bit MMIO aperture + @param[out] MemAbove4G Pointer to 64-bit MMIO aperture + @param[out] PMem Pointer to the 32-bit prefetchable MMIO aperture + @param[out] PMemAbove4G Pointer to the 64-bit prefetchable MMIO aperture + @param[out] PcieConfig Pointer to MMIO mapped PCIe config aperture (EC= AM) + + @retval EFI_INVALID_PARAMETER HostBridge object is invalid + @retval EFI_INCOMPATIBLE_VERSION HostBridge information belongs to + an unsupported version + @retval EFI_WARN_STALE_DATA One or more valid aperture in the + HostBridge's resources were ignored + because corresponding aperture pointer + is NULL. + @retval EFI_SUCCESS Operation executed cleanly, all valid + ranges were parsed into the correspond= ing + aperture object. +**/ +EFI_STATUS +HardwareInfoPciHostBridgeGetApertures ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT PCI_ROOT_BRIDGE_APERTURE *Io, + OUT PCI_ROOT_BRIDGE_APERTURE *Mem, + OUT PCI_ROOT_BRIDGE_APERTURE *MemAbove4G, + OUT PCI_ROOT_BRIDGE_APERTURE *PMem, + OUT PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G, + OUT PCI_ROOT_BRIDGE_APERTURE *PcieConfig + ); + +/** + Retrieve all flags and attributes of a host bridge describing the + resources and capabilities. + + @param[in] HostBridge Host bridge information object + @param[in] DataSize Size in bytes of the actually filled + data available in the HostBridge object + @param[out] Attributes Pointer to the host bridge's attributes + @param[out] DmaAbove4G Pointer to the DMA Above 4G flag + @param[out] NoExtendedConfigSpace Pointer to the Extended Config Space f= lag + @param[out] CombineMemPMem Pointer to the Combine Mem and PMem fl= ag + + @retval EFI_INVALID_PARAMETER HostBridge object is invalid + @retval EFI_INCOMPATIBLE_VERSION HostBridge information belongs to + an unsupported version + @retval EFI_SUCCESS Operation executed cleanly +**/ +EFI_STATUS +HardwareInfoPciHostBridgeGetFlags ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINT64 *Attributes OPTIONAL, + OUT BOOLEAN *DmaAbove4G OPTIONAL, + OUT BOOLEAN *NoExtendedConfigSpace OPTIONAL, + OUT BOOLEAN *CombineMemPMem OPTIONAL + ); + +/** + Getter that parses information from a HOST_BRIDGE_INFO object + into smaller chunks of types handled by the PciHostBridgeLib. + + @param[in] HostBridge Host bridge information object + @param[in] DataSize Size in bytes of the actually filled + data available in the HostBridge object + @param[out] BusNrStart Pointer to the Bus Number range start + @param[out] BusNrLast Pointer to the Bus Number range end + @param[out] Attributes Pointer to the host bridge's attributes + @param[out] DmaAbove4G Pointer to the DMA Above 4G flag + @param[out] NoExtendedConfigSpace Pointer to the Extended Config Space f= lag + @param[out] CombineMemPMem Pointer to the Combine Mem and PMem fl= ag + @param[out] Io Pointer to the PIO aperture object + @param[out] Mem Pointer to the 32-bit MMIO aperture ob= ject + @param[out] MemAbove4G Pointer to the 64-bit MMIO aperture ob= ject + @param[out] PMem Pointer to the 32-bit prefetchable MMIO + aperture object + @param[out] PMemAbove4G Pointer to the 64-bit prefetchable MMIO + aperture object + @param[out] PcieConfig MMIO mapped PCIe config aperture (ECAM) + + @retval EFI_SUCCESS Whole operation succeeded + @retval EFI_INVALID_PARAMETER HostBridge object and/or non-optional + output parameters are invalid + @retval EFI_INCOMPATIBLE_VERSION HostBridge information provided belong= s to + and unsupported version + @retval EFI_WARN_STALE_DATA One or more apertures having valid ran= ges + in the HostBridge info were ignored be= cause + the correspnding aperture pointer is N= ULL +**/ +EFI_STATUS +HardwareInfoPciHostBridgeGet ( + IN CONST HOST_BRIDGE_INFO *HostBridge, + IN UINTN DataSize, + OUT UINTN *BusNrStart, + OUT UINTN *BusNrLast, + OUT UINT64 *Attributes OPTIONAL, + OUT BOOLEAN *DmaAbove4G OPTIONAL, + OUT BOOLEAN *NoExtendedConfigSpace OPTIONAL, + OUT BOOLEAN *CombineMemPMem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *Io OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *Mem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *MemAbove4G OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PMem OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G OPTIONAL, + OUT PCI_ROOT_BRIDGE_APERTURE *PcieConfig OPTIONAL + ); + +#endif // __HARDWARE_INFO_PCI_HOST_BRIDGE_LIB_H__ diff --git a/OvmfPkg/Library/HardwareInfoLib/HardwareInfoTypesLib.h b/OvmfP= kg/Library/HardwareInfoLib/HardwareInfoTypesLib.h new file mode 100644 index 0000000000..84edd1c6ac --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoTypesLib.h @@ -0,0 +1,64 @@ +/**@file + Hardware info types' definitions. + + General hardware info types to parse the binary data + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. + **/ + +#ifndef __HARDWARE_INFO_TYPES_LIB_H__ +#define __HARDWARE_INFO_TYPES_LIB_H__ + +// Specific hardware types: +#include "HardwareInfoPciHostBridgeLib.h" + +// +// Hardware info types enumeration listing the supported +// types which have an associated type definition +// +typedef enum { + HardwareInfoTypeUndefined =3D 0, + HardwareInfoTypeHostBridge =3D 1, +} HARDWARE_INFO_TYPE; + +// +// Header format preceding and describing an associated hardware +// info element +// +#pragma pack(1) +typedef struct { + union { + UINT64 Uint64; + HARDWARE_INFO_TYPE Value; + } Type; + UINT64 Size; +} HARDWARE_INFO_HEADER; +#pragma pack() + +// +// Generic data structure to access any supported hardware type +// resource definition +// +#pragma pack(1) +typedef struct { + LIST_ENTRY Link; + HARDWARE_INFO_HEADER Header; + union { + UINT8 *Raw; + HOST_BRIDGE_INFO *PciHostBridge; + } Data; +} HARDWARE_INFO; +#pragma pack() + +#define HARDWARE_INFO_FROM_LINK(a) \ + BASE_CR (a, HARDWARE_INFO, Link) + +#endif // __HARDWARE_INFO_TYPES_LIB_H__ --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86378): https://edk2.groups.io/g/devel/message/86378 Mute This Topic: https://groups.io/mt/88892980/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86379+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86379+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643921899; cv=none; d=zohomail.com; s=zohoarc; b=mRRgP5yI7y2NSwLGOpjD9vWl9Lj3ploBSZhniyos+3eplRmfllHRYSh3KqvpZtgW8pQqXQq/NMovvX50EaYLuIiGO0X6MAXbcSwcpcVTyNRC05NQa5ehZ37S1/eCqWKzSyMD/J35NjGE/rpD2ekMzi1BCcJg6rCq09jC0SjGNPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643921899; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=pAmujkg0ACxBLixYiag+ET6K4ryJ2B2FDq4ntBiXAGc=; b=FWPpnWp22IwE4zsUIEmIPPnVngncL+1Vh//wP7+vZQGNe79440Q/Y6vH8w9tZD1un2Yif0MY+Jvmz0e5IX+GH3tZEfaAdOpVun3FzdHMYWd3MsgotURN4SlyOncSJInMbMyTrmXQ2Bhb0dxonhdb15J7lxtMkZ/qGL/S3IbowMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86379+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 164392189945875.11393446850855; Thu, 3 Feb 2022 12:58:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id RFOTYY1788612xmWW36Fg2FI; Thu, 03 Feb 2022 12:58:18 -0800 X-Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by mx.groups.io with SMTP id smtpd.web09.154.1643921897903950492 for ; Thu, 03 Feb 2022 12:58:18 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="170806561" X-Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-0168675e.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 03 Feb 2022 20:58:06 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-0168675e.us-east-1.amazon.com (Postfix) with ESMTPS id 8C165A252D; Thu, 3 Feb 2022 20:58:05 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 20:58:01 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 2/8] Ovmf/HardwareInfoLib: Create Pei lib to parse directly from fw-cfg Date: Thu, 3 Feb 2022 21:56:22 +0100 Message-ID: <854644de1f6ff2e98aea63110c6efb5de7d2e381.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: FaYwGbKmne1ViaSTUm2J5aS3x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643921898; bh=dYzzq5e/DwErwWH/pw+Ic/Q+DcOjKmlp6mA4OWrXo7E=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=JDQ0xAjsLdNLIoHnITxxm4QgWaT9xIH+Ql+o2QUdRXmQX+fm0dnI/1NonSBC116yPvg 0h2u/FfZjTQPWsC/6xXuwDPAD4sn1ZRpIgNdqc+SnlfQPu0C2jcTZNrqMK/Q97knhL418 KNfb8I8LA+vbMsqiVhKHBAYgBeHNNqgSSVg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643921901381100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Define the HardwareInfoLib API and create the PeiHardwareInfoLib which implements it, specifically for Pei usage, supporting only static accesses to parse data directly from a fw-cfg file. All list-like APIs are implemented as unsupported and only a fw-cfg wrapper to read hardware info elements is provided. The Hardware Info library is intended to describe non-discoverable hardware information and share that from the host to the guest in Ovmf platforms. The QEMU fw-cfg extension for this library provides a first variation to parse hardware info by reading it directly from a fw-cfg file. This library offers a wrapper function to the plain QmeuFwCfgReadBytes which, specifically, parses header-data pairs out of the binary values in the file. For this purpose, the approach is incremental, reading the file block by block and outputting the values only for a specific known hardware type (e.g. PCI host bridges). One element is returned in each call until the end of the file is reached. Considering fw-cfg as the first means to transport hardware info from the host to the guest, this wrapping library offers the possibility to statically, and in steps, read a specific type of hardware info elements out of the file. This method reads one hardware element of a specific type at a time, without the need to pre-allocate memory and read the whole file or dynamically allocate memory for each new element found. As a usage example, the static approach followed by this library enables early UEFI stages to use and read hardware information supplied by the host. For instance, in early times of the PEI stage, hardware information can be parsed out from a fw-cfg file prescinding from memory services, that may not yet be available, and avoiding dynamic memory allocations. Cc: Alexander Graf Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- OvmfPkg/Include/Library/HardwareInfoLib.h | 165 ++++++++++++++++++ .../Library/HardwareInfoLib/HardwareInfoPei.c | 85 +++++++++ .../HardwareInfoLib/PeiHardwareInfoLib.inf | 43 +++++ .../QemuFwCfgHardwareInfoLib.c | 89 ++++++++++ OvmfPkg/OvmfPkgX64.dsc | 1 + 5 files changed, 383 insertions(+) create mode 100644 OvmfPkg/Include/Library/HardwareInfoLib.h create mode 100644 OvmfPkg/Library/HardwareInfoLib/HardwareInfoPei.c create mode 100644 OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf create mode 100644 OvmfPkg/Library/HardwareInfoLib/QemuFwCfgHardwareInfoLi= b.c diff --git a/OvmfPkg/Include/Library/HardwareInfoLib.h b/OvmfPkg/Include/Li= brary/HardwareInfoLib.h new file mode 100644 index 0000000000..9a8149bf20 --- /dev/null +++ b/OvmfPkg/Include/Library/HardwareInfoLib.h @@ -0,0 +1,165 @@ +/*/@file + Hardware info parsing functions. + Binary data is expected as a consecutive series of header - object pairs. + Complete library providing static Qemu fw-cfg wrappers as well as list-l= ike + interface to dynamically manipulate hardware info objects and parsing fr= om + a generic blob. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. +**/ + +#ifndef __HARDWARE_INFO_LIB_H__ +#define __HARDWARE_INFO_LIB_H__ + +#include "../Library/HardwareInfoLib/HardwareInfoTypesLib.h" + +/** + Read, if available, the next Type element in the FwCfg file. + The FwCfg item must already be selected, this is a wrapper around + QemuFwCfgReadBytes and the Data pointer should be set to an existent + memory location with TypeSize bytes allocated for the date to be + properly written. If a Type element is found in the file which has a + size (in the header) greater than TypeSize, it is skipped. + + @param[in] Type Hardware Info Type to search for + @param[in] TypeSize Size (in bytes) of the structure intended= to + be used to dereference the data + @param[in] TotalFileSize Total size (in bytes) of the FwCfg file f= rom + which the data is read. + @param[out] Data Pointer to a memory allocated instance in= to + which the data is written to. + @param[out] DataSize Size in bytes of the actually filled + data available in the Data object after a + successful operation + @param[inout] ReadIndex Index of the next byte to be read. Increm= ented + accordingly after a read operation to ref= lect + up to date status + + @retval EFI_SUCCESS Next element found and read into Data + @retval EFI_INVALID_PARAMETER Operation failed + @retval EFI_END_OF_FILE End of the file reached, no more elements + to read. +**/ +EFI_STATUS +QemuFwCfgReadNextHardwareInfoByType ( + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize, + IN UINTN TotalFileSize, + OUT VOID *Data, + OUT UINTN *DataSize OPTIONAL, + IN OUT UINTN *ReadIndex + ); + +/** + Parse binary data containing resource information of multiple hardware + elements into a list of interpreted resources. + The translation is done on a copy-parse base so the blob can be freed + afterwards. + + @param[in] Blob Binary data to be parsed + @param[in] BlobSize Size (in bytes) of the binary data + @param[in] TypeFilter Optional type to filter entries. Set to + undefined to disable filtering and retrieve a= ll + @param[out] ListHead Head of the list to populate hardware informa= tion + + @retval EFI_SUCCESS Succeed. + @retval EFI_INVALID_PARAMETER Provided Blob inforation is invalid + @retval EFI_OUT_OF_RESOURCES Out of memory, list populated as far as + possible +**/ +EFI_STATUS +CreateHardwareInfoList ( + IN UINT8 *Blob, + IN UINTN BlobSize, + IN HARDWARE_INFO_TYPE TypeFilter, + OUT LIST_ENTRY *ListHead + ); + +/** + Free the dynamically allocated list of HADWARE_INFO items populated + during parsing of Blob + + @param ListHead Head of the list to be destroyed +**/ +VOID +FreeHardwareInfoList ( + IN OUT LIST_ENTRY *ListHead + ); + +/** + Retrieve the number of hardware components of a specific type + in the list. + + @param[in] ListHead Head of the hardware info list + @param[in] Type Type of hardware elements to count + @param[in] TypeSize Size (in bytes) of the structure intended to + be used to dereference the data + @return Count of elements of Type found +**/ +UINTN +GetHardwareInfoCountByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ); + +/** + Get the First Hardware Info entry in the list of the specified type + + @param[in] ListHead Head of the hardware info list + @param[in] Type Hardware Info Type to search for + @param[in] TypeSize Size (in bytes) of the structure intended to + be used to dereference the data + @return Link of first entry of specified type or list head if not found +**/ +LIST_ENTRY * +GetFirstHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ); + +/** + Get the Next Hardware Info entry in the list with the specified + type, which follows the provided Node. + + @param[in] ListHead Head of the hardware info list + @param[in] Node Current, already processed, node's link + @param[in] Type Hardware Info Type to search for + @param[in] TypeSize Size (in bytes) of the structure intended to + be used to dereference the data + @return Link of next entry, after Node, of the specified type. + List head otherwise +**/ +LIST_ENTRY * +GetNextHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ); + +/** + Assess if Node stands at the end of the doubly linked list + + @param[in] ListHead Head of the hardware info list + @param[in] Node Current Node link + + @retval TRUE Node is at the end of the list + @retval FALSE Node is not at the end of the list +**/ +BOOLEAN +EndOfHardwareInfoList ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node + ); + +#endif // __HARDWARE_INFO_LIB_H__ diff --git a/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPei.c b/OvmfPkg/Li= brary/HardwareInfoLib/HardwareInfoPei.c new file mode 100644 index 0000000000..40d27f69ad --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoPei.c @@ -0,0 +1,85 @@ +/*/@file + Hardware info parsing functions. + Binary data is expected as a consecutive series of header - object pairs. + Provides static Qemu fw-cfg wrappers as well as list-like interface to + dynamically manipulate hardware info objects and parsing from a generic + blob. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. +**/ + +#include + +#include + +EFI_STATUS +CreateHardwareInfoList ( + IN UINT8 *Blob, + IN UINTN BlobSize, + IN HARDWARE_INFO_TYPE TypeFilter, + OUT LIST_ENTRY *ListHead + ) +{ + ASSERT (FALSE); + return EFI_UNSUPPORTED; +} + +VOID +FreeHardwareInfoList ( + IN OUT LIST_ENTRY *ListHead + ) +{ + ASSERT (FALSE); +} + +UINTN +GetHardwareInfoCountByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + ASSERT (FALSE); + return 0; +} + +LIST_ENTRY * +GetFirstHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + ASSERT (FALSE); + return ListHead; +} + +LIST_ENTRY * +GetNextHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + ASSERT (FALSE); + return ListHead; +} + +BOOLEAN +EndOfHardwareInfoList ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node + ) +{ + ASSERT (FALSE); + return TRUE; +} diff --git a/OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf b/OvmfP= kg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf new file mode 100644 index 0000000000..540c0d0a8d --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf @@ -0,0 +1,43 @@ +## @file +# Hardware information library wrappers over Qemu fw-cfg functionality to= parse, +# in a static manner, non-discoverable hardware information. +# +# Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the B= SD License +# which accompanies this distribution. The full text of the license may = be found at +# http://opensource.org/licenses/bsd-license.php +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IM= PLIED. +# +## + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D PeiHardwareInfoLib + FILE_GUID =3D 3D5011B3-9CBB-4C0B-88E8-1D758283C659 + MODULE_TYPE =3D BASE + VERSION_STRING =3D 1.0 + LIBRARY_CLASS =3D PeiHardwareInfoLib + +# +# The following information is for reference only and not required by the = build +# tools. +# +# VALID_ARCHITECTURES =3D X64 +# + +[Sources] + HardwareInfoPei.c + QemuFwCfgHardwareInfoLib.c + HardwareInfoPciHostBridgeLib.c + +[Packages] + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec + +[LibraryClasses] + DebugLib + QemuFwCfgLib diff --git a/OvmfPkg/Library/HardwareInfoLib/QemuFwCfgHardwareInfoLib.c b/O= vmfPkg/Library/HardwareInfoLib/QemuFwCfgHardwareInfoLib.c new file mode 100644 index 0000000000..31ffff290a --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/QemuFwCfgHardwareInfoLib.c @@ -0,0 +1,89 @@ +/*/@file + Qemu fw-cfg wrappers for hardware info parsing. + Provides an alternative to parse hardware information from a fw-cfg + file without relying on dynamic memory allocations. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. +**/ + +#include +#include + +#include + +/** + Update an optional pointer value if possible + + @param[out] DataSize Pointer to variable to be updated + @param[in] Value Value to set the pointed variable to. +**/ +STATIC +VOID +UpdateDataSize ( + OUT UINTN *DataSize, + IN UINTN Value + ) +{ + if (DataSize =3D=3D NULL) { + return; + } + + *DataSize =3D Value; +} + +EFI_STATUS +QemuFwCfgReadNextHardwareInfoByType ( + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize, + IN UINTN TotalFileSize, + OUT VOID *Data, + OUT UINTN *DataSize OPTIONAL, + IN OUT UINTN *ReadIndex + ) +{ + HARDWARE_INFO_HEADER Header; + + if ((Data =3D=3D NULL) || + (ReadIndex =3D=3D NULL) || + (TypeSize =3D=3D 0) || + (Type =3D=3D HardwareInfoTypeUndefined) || + (TotalFileSize =3D=3D 0)) + { + return EFI_INVALID_PARAMETER; + } + + UpdateDataSize (DataSize, 0); + + while (*ReadIndex < TotalFileSize) { + QemuFwCfgReadBytes (sizeof (Header), &Header); + *ReadIndex +=3D sizeof (Header); + + if ((Header.Type.Value =3D=3D Type) && (Header.Size <=3D TypeSize)) { + QemuFwCfgReadBytes (Header.Size, Data); + + *ReadIndex +=3D Header.Size; + UpdateDataSize (DataSize, Header.Size); + + return EFI_SUCCESS; + } + + // + // Skip the bytes corresponding to the next element as it is + // not of the expected type and/or size. The TotalFileSize + // and individual elements sizes should match so the size + // check is skipped. + // + QemuFwCfgSkipBytes (Header.Size); + *ReadIndex +=3D Header.Size; + } + + return EFI_END_OF_FILE; +} diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 4589adff38..7a36f62e9f 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -180,6 +180,7 @@ VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLi= b.inf + PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf !if $(SMM_REQUIRE) =3D=3D FALSE LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf !endif --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86379): https://edk2.groups.io/g/devel/message/86379 Mute This Topic: https://groups.io/mt/88892990/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86380+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86380+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643921919; cv=none; d=zohomail.com; s=zohoarc; b=JxemN0mOLlZbWyPVBwk2sXlmmqSWNgURpBv6jd9U21+pjpl06soIRIZ+tM83V7sS7jZb0PyZ9eUBjhtQHh35WzCcewAu7X3QfaHyROREnr46kpY2g+tkjtC7OpjcGlyrXb+gIH2G2NK65/wEZ0oKAXJpHzpCvOiLawO3NyXI5p0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643921919; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=HDAJ8Nb+eTtHTFXv7FmHZca/zK1pc/99JfmIBpeHag4=; b=L289k2YtuK1323HbW1nyxNPRNPaScknY8IUxAeS3l6zn7LQK0Kx8dWESNyD8lJpKWthu2DcLGgx7V67fcnmniWi2/5S2gDj6TfxMlZjRYsDu+Wv1y7xBqzua5SfM1QKoKc/17+b9IhAbA350D9N/Tm7MM+pj1hxyN1hVPFrseZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86380+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643921919694589.9133103329756; Thu, 3 Feb 2022 12:58:39 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 59cnYY1788612xMVqTpkuqR7; Thu, 03 Feb 2022 12:58:38 -0800 X-Received: from smtp-fw-80006.amazon.com (smtp-fw-80006.amazon.com [99.78.197.217]) by mx.groups.io with SMTP id smtpd.web10.151.1643921918305161198 for ; Thu, 03 Feb 2022 12:58:38 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="60334896" X-Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP; 03 Feb 2022 20:58:23 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com (Postfix) with ESMTPS id C27FD81206; Thu, 3 Feb 2022 20:58:21 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 20:58:18 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 3/8] Ovmf/HardwareInfoLib: Add Dxe lib to dynamically parse heterogenous data Date: Thu, 3 Feb 2022 21:56:23 +0100 Message-ID: <6c9c4c84eebc0b714e5e6e337bf43549ab03b780.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: jGyHUJmyPbqHjC7QXXK9dmwqx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643921918; bh=R50O2y+VE3gN+xkyPylTDmhRwsXt5HorjhvUt4d/jQE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=nwjPxKPMKwaAXRTP0hmvbFXUpbSGHDJr3GOc3X0gjE64WRFw1ORa/bjXpWMfc0YjhoD AHausgsB0XNIrtQT0ZgA/ZekBkjhpLrS6fyOQFWBc30ilnw2EoV8FhFzek0+NfUyFZRpB Eq2B6TIRe47xzQsd7nXNlTJnHW0EdD8haKw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643921922172100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Following the Hardware Info library, create the DxeHardwareInfoLib which implements the whole API capable of parsing heterogeneous hardware information. The list-like API grants callers a flexible and common pattern to retrieve the data. Moreover, the initial source is a BLOB which generalizes the host-to-guest transmission mechanism. The Hardware Info library main objective is to provide a way to describe non-discoverable hardware so that the host can share the available resources with the guest in Ovmf platforms. This change features and embraces the main idea behind the library by providing an API that parses a BLOB into a linked list to retrieve hardware data from any source. Additionally, list-like APIs are provided so that the hardware info list can be traversed conveniently. Similarly, the capability is provided to filter results by specific hardware types. However, heterogeneous elements can be added to the list, increasing the flexibility. This way, a single source, for example a fw-cfg file, can be used to describe several instances of multiple types of hardware. This part of the Hardware Info library makes use of dynamic memory and is intended for stages in which memory services are available. A motivation example is the PciHostBridgeLib. This library, part of the PCI driver populates the list of PCI root bridges during DXE stage for future steps to discover the resources under them. The hardware info library can be used to obtain the detailed description of available host bridges, for instance in the form of a fw-cfg file, and parse that information into a dynmaic list that allows, first to verify consistency of the data, and second discover the resources availabe for each root bridge. Cc: Alexander Graf Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- .../HardwareInfoLib/DxeHardwareInfoLib.inf | 43 +++ .../Library/HardwareInfoLib/HardwareInfoDxe.c | 255 ++++++++++++++++++ OvmfPkg/OvmfPkgX64.dsc | 1 + 3 files changed, 299 insertions(+) create mode 100644 OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf create mode 100644 OvmfPkg/Library/HardwareInfoLib/HardwareInfoDxe.c diff --git a/OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf b/OvmfP= kg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf new file mode 100644 index 0000000000..0a93d24b8a --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf @@ -0,0 +1,43 @@ +## @file +# Hardware information library to describe non-discoverable hardware reso= urces +# +# Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the B= SD License +# which accompanies this distribution. The full text of the license may = be found at +# http://opensource.org/licenses/bsd-license.php +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IM= PLIED. +# +## + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D DxeHardwareInfoLib + FILE_GUID =3D F60B206A-5C56-11EC-AEAC-67CB080BCFF2 + MODULE_TYPE =3D BASE + VERSION_STRING =3D 1.0 + LIBRARY_CLASS =3D DxeHardwareInfoLib + +# +# The following information is for reference only and not required by the = build +# tools. +# +# VALID_ARCHITECTURES =3D X64 +# + +[Sources] + HardwareInfoDxe.c + HardwareInfoPciHostBridgeLib.c + QemuFwCfgHardwareInfoLib.c + +[Packages] + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec + +[LibraryClasses] + BaseMemoryLib + DebugLib + MemoryAllocationLib diff --git a/OvmfPkg/Library/HardwareInfoLib/HardwareInfoDxe.c b/OvmfPkg/Li= brary/HardwareInfoLib/HardwareInfoDxe.c new file mode 100644 index 0000000000..4f0b51c942 --- /dev/null +++ b/OvmfPkg/Library/HardwareInfoLib/HardwareInfoDxe.c @@ -0,0 +1,255 @@ +/*/@file + Hardware info parsing functions. + Binary data is expected as a consecutive series of header - object pairs. + Complete library providing list-like interface to dynamically manipulate + hardware info objects and parsing from a generic blob. + + Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. +**/ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +EFI_STATUS +CreateHardwareInfoList ( + IN UINT8 *Blob, + IN UINTN BlobSize, + IN HARDWARE_INFO_TYPE TypeFilter, + OUT LIST_ENTRY *ListHead + ) +{ + UINT8 *Index; + HARDWARE_INFO *HwComponent; + + if ((Blob =3D=3D NULL) || (BlobSize <=3D 0) || + (ListHead =3D=3D NULL)) + { + return EFI_INVALID_PARAMETER; + } + + Index =3D Blob; + while (Index < (Blob + BlobSize)) { + HwComponent =3D AllocateZeroPool (sizeof (HARDWARE_INFO)); + + if (HwComponent =3D=3D NULL) { + goto FailedAllocate; + } + + HwComponent->Header.Type.Uint64 =3D *((UINT64 *)Index); + Index +=3D sizeof (HwComponent->Header.Type); + HwComponent->Header.Size =3D *((UINT64 *)(Index)); + Index +=3D sizeof (HwComponent->Header.Size); + + // + // Check if optional TypeFilter is set, skip if the current + // object is of a different type and release the partially + // allocated object + // + if ((TypeFilter !=3D HardwareInfoTypeUndefined) && + (HwComponent->Header.Type.Value !=3D TypeFilter)) + { + FreePool (HwComponent); + Index +=3D HwComponent->Header.Size; + continue; + } + + HwComponent->Data.Raw =3D AllocateZeroPool (HwComponent->Header.Size); + if (HwComponent->Data.Raw =3D=3D NULL) { + goto FreeResources; + } + + CopyMem (HwComponent->Data.Raw, Index, HwComponent->Header.Size); + Index +=3D HwComponent->Header.Size; + + InsertTailList (ListHead, &HwComponent->Link); + } + + return EFI_SUCCESS; + +FreeResources: + // + // Clean the resources allocated in the incomplete cycle + // + FreePool (HwComponent); + +FailedAllocate: + DEBUG (( + EFI_D_ERROR, + "%a: Failed to allocate memory for hardware info\n", + __FUNCTION__ + )); + + return EFI_OUT_OF_RESOURCES; +} + +VOID +FreeHardwareInfoList ( + IN OUT LIST_ENTRY *ListHead + ) +{ + LIST_ENTRY *CurrentLink; + HARDWARE_INFO *HwComponent; + + if (IsListEmpty (ListHead)) { + return; + } + + CurrentLink =3D ListHead->ForwardLink; + while (CurrentLink !=3D NULL && CurrentLink !=3D ListHead) { + HwComponent =3D HARDWARE_INFO_FROM_LINK (CurrentLink); + + // + // Remove item from list before invalidating the pointers + // + CurrentLink =3D RemoveEntryList (CurrentLink); + + FreePool (HwComponent->Data.Raw); + FreePool (HwComponent); + } +} + +/** + Validates if the specified Node has a valid data size and is of + specified type. + The data size can be less or equal to the provided type size to be + regarded as valid and thus accessible with the typed pointer. + + For future compatibility the size is allowed to be smaller so that + different versions interpret fields differently and, particularly, + have smaller data structures. However, it cannot be larger than the + type size to avoid accessing memory out of bounds. + + @param[in] Node Hardware Info node to be validated + @param[in] TypeSize Size (in bytes) of the data type intended to be + used to dereference the data. + @retval TRUE Node is valid and can be accessed + @retval FALSE Node is not valid +/*/ +STATIC +BOOLEAN +IsHardwareInfoNodeValidByType ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Link, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + HARDWARE_INFO *HwComponent; + + if (IsNull (ListHead, Link)) { + return FALSE; + } + + HwComponent =3D HARDWARE_INFO_FROM_LINK (Link); + + // + // Verify if the node type is the specified one and the size of + // the data allocated to the node is greater than the size of + // the type intended to dereference it in order to avoid access + // to memory out of bondaries. + // + if ((HwComponent->Header.Type.Value =3D=3D Type) && + (HwComponent->Header.Size >=3D TypeSize)) + { + return TRUE; + } + + return FALSE; +} + +UINTN +GetHardwareInfoCountByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + UINTN Count; + LIST_ENTRY *Link; + + Count =3D 0; + for (Link =3D GetFirstHardwareInfoByType (ListHead, Type, TypeSize); + !IsNull (ListHead, Link); + Link =3D GetNextHardwareInfoByType (ListHead, Link, Type, TypeSize)) + { + if (IsHardwareInfoNodeValidByType (ListHead, Link, Type, TypeSize)) { + Count++; + } + } + + return Count; +} + +LIST_ENTRY * +GetFirstHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + LIST_ENTRY *Link; + + if (IsListEmpty (ListHead)) { + return ListHead; + } + + Link =3D GetFirstNode (ListHead); + + if (IsHardwareInfoNodeValidByType (ListHead, Link, Type, TypeSize)) { + return Link; + } + + return GetNextHardwareInfoByType (ListHead, Link, Type, TypeSize); +} + +LIST_ENTRY * +GetNextHardwareInfoByType ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node, + IN HARDWARE_INFO_TYPE Type, + IN UINTN TypeSize + ) +{ + LIST_ENTRY *Link; + + Link =3D GetNextNode (ListHead, Node); + + while (!IsNull (ListHead, Link)) { + if (IsHardwareInfoNodeValidByType (ListHead, Link, Type, TypeSize)) { + // + // Found a node of specified type and with valid size. Break and + // return the found node. + // + break; + } + + Link =3D GetNextNode (ListHead, Link); + } + + return Link; +} + +BOOLEAN +EndOfHardwareInfoList ( + IN LIST_ENTRY *ListHead, + IN LIST_ENTRY *Node + ) +{ + return IsNull (ListHead, Node); +} diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 7a36f62e9f..b376387b7c 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -181,6 +181,7 @@ LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLi= b.inf PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf + DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf !if $(SMM_REQUIRE) =3D=3D FALSE LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf !endif --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86380): https://edk2.groups.io/g/devel/message/86380 Mute This Topic: https://groups.io/mt/88892996/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86381+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86381+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643921935; cv=none; d=zohomail.com; s=zohoarc; b=ieXUtQkoLaMT8NQFyXBBwEVj7AAnYMXZOLKtmYiGPVy26100nK/+IeFZu4zaz1JpW2YqnOKeSTSXGT4sbOLqCGiZTyqnjmEgRu9uyJnLQHnV1JK6XfdC/N/GRvSV0nkGC7lpD/U+bntaYqFuasuZQYhOYdyzAW8mV40+eOXLVBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643921935; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=qhwmPSvytv+m6aLzE1F1WMk1ysG3e1Qw5dH5wwLkB8w=; b=SuPY2v9WipDB0Zqx3jWWhxgVokmOncKJZPg6E9fEwacAathFgboG90S2fo/vuTLfPLNbJ7z/PdyDSrMM0aOkVlkRl4SJ7pNWdvFHJHNAlC/yjUK06vFU0QZX18avwtYOAWmgqjKMjJ73XTTZqNupLoEMcnTObQm/smCpcl6Rh0o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86381+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643921935670812.685537396128; Thu, 3 Feb 2022 12:58:55 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qWGXYY1788612xYoMSSkUftk; Thu, 03 Feb 2022 12:58:55 -0800 X-Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by mx.groups.io with SMTP id smtpd.web10.155.1643921934470526523 for ; Thu, 03 Feb 2022 12:58:54 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="173913747" X-Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 03 Feb 2022 20:58:38 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com (Postfix) with ESMTPS id 5A9B5813E5; Thu, 3 Feb 2022 20:58:37 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 20:58:33 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 4/8] Ovmf/PlatformPei: Use host-provided GPA end if available Date: Thu, 3 Feb 2022 21:56:24 +0100 Message-ID: <38869b4f8bb1b500225375f902352c9ecdf4ab8a.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: cwpeWaa17oT5JjtjEEwILIqex1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643921935; bh=Zu/ibfgz5ghuZIUi0fwxhHLTyL/Uat5ZBgYrCRWgmVA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=SQ2Xwi1FpzhBqs6Ly8+erLsIs25MaJMsfKKP/8TdOGBlx0WGr3YBh2titb8JlGvBJkY zBmo+EXmP04CubOFhbW5s71cquEbp0cqw/1M5clh0g6GEWfiD9gaxVZ9+Gra02MT+r0IL pr/JDKzeFBgAXYVqaOahzXwtxvXFlJnagXg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643921938224100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Read the "hardware-info" item from fw-cfg to extract specifications of PCI host bridges and analyze the 64-bit apertures of them to find out the highest 64-bit MMIO address required which determines the address space required by the guest, and, consequently, the FirstNonAddress used to calculate size of physical addresses. Using the static PeiHardwareInfoLib, read the fw-cfg file of hardware information to extract, one by one, all the host bridges. Find the last 64-bit MMIO address of each host bridge, using the HardwareInfoPciHostBridgeLib API, and compare it to an accumulate value to discover the highest address used, which corresponds to the highest value that must be included in the guest's physical address space. Given that platforms with multiple host bridges may provide the PCI apertures' addresses, the memory detection logic must take into account that, if the host provided the MMIO windows that can and must be used, the guest needs to take those values. Therefore, if the MMIO windows are found in the host-provided fw-cfg file, skip all the logic calculating the physical address size and just use the value provided. Since each PCI host bridge corresponds to an element in the information provided by the host, each of these must be analyzed looking for the highest address used. Cc: Alexander Graf Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- OvmfPkg/PlatformPei/MemDetect.c | 146 ++++++++++++++++++++++++++-- OvmfPkg/PlatformPei/PlatformPei.inf | 1 + 2 files changed, 141 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetec= t.c index 1bcb5a08bc..26f6df7e7e 100644 --- a/OvmfPkg/PlatformPei/MemDetect.c +++ b/OvmfPkg/PlatformPei/MemDetect.c @@ -36,6 +36,7 @@ Module Name: #include #include #include +#include =20 #include "Platform.h" #include "Cmos.h" @@ -369,6 +370,126 @@ GetSystemMemorySizeAbove4gb ( return LShiftU64 (Size, 16); } =20 +/** + Iterate over the PCI host bridges resources information optionally provi= ded + in fw-cfg and find the highest address contained in the PCI MMIO windows= . If + the information is found, return the exclusive end; one past the last us= able + address. + + @param[out] PciMmioAddressEnd Pointer to one-after End Address updated w= ith + information extracted from host-provided d= ata + or zero if no information available or an + error happened + + @retval EFI_SUCCESS PCI information was read and the output + parameter updated with the last valid + address in the 64-bit MMIO range. + @retval EFI_INVALID_PARAMETER Pointer parameter is invalid + @retval EFI_INCOMPATIBLE_VERSION Hardware information found in fw-cfg + has an incompatible format + @retval EFI_UNSUPPORTED Fw-cfg is not supported, thus host + provided information, if any, cannot be + read + @retval EFI_NOT_FOUND No PCI host bridge information provided + by the host. +**/ +STATIC +EFI_STATUS +ScanHostProvided64BitPciMmioEnd ( + OUT UINT64 *PciMmioAddressEnd + ) +{ + EFI_STATUS Status; + HOST_BRIDGE_INFO HostBridge; + FIRMWARE_CONFIG_ITEM FwCfgItem; + UINTN FwCfgSize; + UINTN FwCfgReadIndex; + UINTN ReadDataSize; + UINT64 Above4GMmioEnd; + + if (PciMmioAddressEnd =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + *PciMmioAddressEnd =3D 0; + Above4GMmioEnd =3D 0; + + Status =3D QemuFwCfgFindFile ("etc/hardware-info", &FwCfgItem, &FwCfgSiz= e); + if (EFI_ERROR (Status)) { + return Status; + } + + QemuFwCfgSelectItem (FwCfgItem); + + FwCfgReadIndex =3D 0; + while (FwCfgReadIndex < FwCfgSize) { + Status =3D QemuFwCfgReadNextHardwareInfoByType ( + HardwareInfoTypeHostBridge, + sizeof (HostBridge), + FwCfgSize, + &HostBridge, + &ReadDataSize, + &FwCfgReadIndex + ); + + if (Status !=3D EFI_SUCCESS) { + // + // No more data available to read in the file, break + // loop and finish process + // + break; + } + + Status =3D HardwareInfoPciHostBridgeLastMmioAddress ( + &HostBridge, + ReadDataSize, + TRUE, + &Above4GMmioEnd + ); + + if (Status !=3D EFI_SUCCESS) { + // + // Error parsing MMIO apertures and extracting last MMIO + // address, reset PciMmioAddressEnd as if no information was + // found, to avoid moving forward with incomplete data, and + // bail out + // + DEBUG (( + DEBUG_ERROR, + "%a: ignoring malformed hardware information from fw_cfg\n", + __FUNCTION__ + )); + *PciMmioAddressEnd =3D 0; + return Status; + } + + if (Above4GMmioEnd > *PciMmioAddressEnd) { + *PciMmioAddressEnd =3D Above4GMmioEnd; + } + } + + if (*PciMmioAddressEnd > 0) { + // + // Host-provided PCI information was found and a MMIO window end + // derived from it. + // Increase the End address by one to have the output pointing to + // one after the address in use (exclusive end). + // + *PciMmioAddressEnd +=3D 1; + + DEBUG (( + DEBUG_INFO, + "%a: Pci64End=3D0x%Lx\n", + __FUNCTION__, + *PciMmioAddressEnd + )); + + return EFI_SUCCESS; + } + + return EFI_NOT_FOUND; +} + /** Return the highest address that DXE could possibly use, plus one. **/ @@ -550,15 +671,28 @@ AddressWidthInitialization ( VOID ) { - UINT64 FirstNonAddress; + UINT64 FirstNonAddress; + EFI_STATUS Status; =20 // - // As guest-physical memory size grows, the permanent PEI RAM requiremen= ts - // are dominated by the identity-mapping page tables built by the DXE IP= L. - // The DXL IPL keys off of the physical address bits advertized in the C= PU - // HOB. To conserve memory, we calculate the minimum address width here. + // First scan host-provided hardware information to assess if the address + // space is already known. If so, guest must use those values. // - FirstNonAddress =3D GetFirstNonAddress (); + Status =3D ScanHostProvided64BitPciMmioEnd (&FirstNonAddress); + + if (EFI_ERROR (Status)) { + // + // If the host did not provide valid hardware information leading to a + // hard-defined 64-bit MMIO end, fold back to calculating the minimum = range + // needed. + // As guest-physical memory size grows, the permanent PEI RAM requirem= ents + // are dominated by the identity-mapping page tables built by the DXE = IPL. + // The DXL IPL keys off of the physical address bits advertized in the= CPU + // HOB. To conserve memory, we calculate the minimum address width her= e. + // + FirstNonAddress =3D GetFirstNonAddress (); + } + mPhysMemAddressWidth =3D (UINT8)HighBitSet64 (FirstNonAddress); =20 // diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/Plat= formPei.inf index 8ef404168c..e840f960d3 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -64,6 +64,7 @@ MemEncryptSevLib PcdLib VmgExitLib + PeiHardwareInfoLib =20 [Pcd] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86381): https://edk2.groups.io/g/devel/message/86381 Mute This Topic: https://groups.io/mt/88893010/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86382+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86382+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643922027; cv=none; d=zohomail.com; s=zohoarc; b=iqfAbUfTB4bnbskUJ7fle1xpFP2eajEavJul+nXEBEHWuRFG1VmXIfz7gY7bxp/uEzj83Q2FB3VRNtJkc1OjGPO2Lghy+WttCgDQ46WlR+QMgzH270ANQAaPGGkRNGPRogqD6yTevkglCksQjyzm8wgm4YkDRNNos0E0AaAcTg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643922027; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=HRAtBrP+bD6iVRsdJ+f+6enDof4QOaRq796Cj1CAedo=; b=dLi7bGzzd3BLXV1UjjfJbQbPehen3qR48BeFfKVFNv94QuUgTvcbY/RFwi1/sa/+RWetm1GvvtqLpAUU/+wzU47XEm4rDsX7S1w1WX8xff6nf8UBtUp6r2jUU0HSxlcXDxOe0gmO96UP5YeypQ0XUru8LBY4xumZcNpDImKAJaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86382+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643922027569691.4903514016344; Thu, 3 Feb 2022 13:00:27 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id GEtaYY1788612x46WfoSZjhB; Thu, 03 Feb 2022 13:00:27 -0800 X-Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by mx.groups.io with SMTP id smtpd.web12.164.1643922026139950130 for ; Thu, 03 Feb 2022 13:00:26 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="175399855" X-Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-4ba5c7da.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 03 Feb 2022 21:00:13 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-4ba5c7da.us-east-1.amazon.com (Postfix) with ESMTPS id C6E17C3B9B; Thu, 3 Feb 2022 21:00:12 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 21:00:09 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 5/8] OvmfPkg/PciHostBridgeUtilityLib: Initialize RootBridges apertures with spec Date: Thu, 3 Feb 2022 21:56:25 +0100 Message-ID: <048b039ecfad8765487246c4b1c5d928a91c57aa.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: 5aGDxzswF4RHPQcYylIXRScfx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643922027; bh=laA6R+ZxmgRa9aHN5Cau4CUEKxWS1B7tdrUqoIlr1gQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=mz+K0gAG6uDzMtaaKdxSPpMCuqBbN5veRLHRj237x1/927OtJ59oukn7iIT4QAaw9PO LgT83IVKWmB315kP79NdtireBYDfAdredPxgVmysFRqZLNRHkEMidoS1EGjkPqA3N35ms FCzOA/akVlQ1KQW8pPkE1dw/cDsyHJx4SVU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643922030251100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Consume the host-provided specification of PCI host bridges if available. Using the DxeHardwareInfoLib, populate a list of hardware descriptors based on the content of the "hardware-info" fw-cfg file, if provided. In the affirmative case, use the resources and attributes specified by the hypervisor for each Host Bridge to create the RootBridge elements. In Ovmf platforms, the host can provide the specification of non-discoverable hardware resources like PCI host bridges. If the proper fw-cfg file is found, parse the contents provided by the host into a linked list by using the Hardware Info library. Then, using the list of PCI host bridges' descriptions, populate the PCI_ROOT_BRIDGES array with the resources and attributes specified by the host. If the file is not provided or no Host Bridge is found in it, fold back to the legacy method based on pre-defined apertures and rules. In some use cases, the host requires additional control over the hardware resources' configurations in the guest for performance and discoverability reasons. For instance, to disclose information about the PCI hierarchy to the guest so that this can profit from optimized accesses. In this case, the host can decide to describe multiple PCI Host Bridges and provide a specific set of resources (e.g. MMIO apertures) so that the guest uses the values provided. Using the provided values may entitle the guest to added performance, for example by using specific MMIO mappings that can enable peer-to-peer communication across the PCI hierarchy or by allocating memory closer to a device for faster DMA transactions. Cc: Alexander Graf Cc: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon Acked-by: Gerd Hoffmann --- Notes: v4: - Splitted PciHostBridgeUtilityGetRootBridges into 2 smaller functions, one that performs same BusScan population and a new one that uses HostProvided values to populate Root Bridges. - PciHostBridgeUtilityGetRootBridges is left as a thin wrapper that calls the 2 functions depending on availability of host-provided data. .../PciHostBridgeUtilityLib.c | 316 +++++++++++++++++- .../PciHostBridgeUtilityLib.inf | 1 + 2 files changed, 312 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLi= b.c b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c index 92e1ea812f..4bd4671f10 100644 --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c @@ -12,13 +12,16 @@ =20 #include #include +#include #include #include #include +#include #include #include #include #include +#include =20 #pragma pack(1) typedef struct { @@ -189,7 +192,9 @@ PciHostBridgeUtilityUninitRootBridge ( } =20 /** - Utility function to return all the root bridge instances in an array. + Utility function to scan PCI root bridges and create instances for those + that are found not empty. Populate their resources from the default + provided parameters and return all the root bridge instances in an array. =20 @param[out] Count The number of root bridge instances. =20 @@ -217,9 +222,9 @@ PciHostBridgeUtilityUninitRootBridge ( =20 @return All the root bridge instances in an a= rray. **/ +STATIC PCI_ROOT_BRIDGE * -EFIAPI -PciHostBridgeUtilityGetRootBridges ( +PciHostBridgeUtilityGetRootBridgesBusScan ( OUT UINTN *Count, IN UINT64 Attributes, IN UINT64 AllocationAttributes, @@ -243,8 +248,6 @@ PciHostBridgeUtilityGetRootBridges ( UINTN LastRootBridgeNumber; UINTN RootBridgeNumber; =20 - *Count =3D 0; - if ((BusMin > BusMax) || (BusMax > PCI_MAX_BUS)) { DEBUG (( DEBUG_ERROR, @@ -403,6 +406,309 @@ FreeBridges: return NULL; } =20 +/** + Utility function to read root bridges information from host-provided fw-= cfg + file and return them in an array. + + @param[out] Count The number of root bridge instances. + + @return All the root bridge instances in an array parsed from + host-provided fw-cfg file (hardware-info). +**/ +STATIC +PCI_ROOT_BRIDGE * +PciHostBridgeUtilityGetRootBridgesHostProvided ( + OUT UINTN *Count + ) +{ + EFI_STATUS Status; + FIRMWARE_CONFIG_ITEM FwCfgItem; + UINTN FwCfgSize; + PCI_ROOT_BRIDGE *Bridges; + UINTN Initialized; + UINTN LastRootBridgeNumber; + UINTN RootBridgeNumber; + UINTN PciHostBridgeCount; + UINT8 *HardwareInfoBlob; + LIST_ENTRY HwInfoList; + LIST_ENTRY *HwLink; + HARDWARE_INFO *HwInfo; + UINT64 Attributes; + UINT64 AllocationAttributes; + BOOLEAN DmaAbove4G; + BOOLEAN NoExtendedConfigSpace; + BOOLEAN CombineMemPMem; + PCI_ROOT_BRIDGE_APERTURE Io; + PCI_ROOT_BRIDGE_APERTURE Mem; + PCI_ROOT_BRIDGE_APERTURE MemAbove4G; + PCI_ROOT_BRIDGE_APERTURE PMem; + PCI_ROOT_BRIDGE_APERTURE PMemAbove4G; + + // + // Initialize the Hardware Info list head to start with an empty but val= id + // list head. + // + InitializeListHead (&HwInfoList); + HardwareInfoBlob =3D NULL; + Initialized =3D 0; + Bridges =3D NULL; + PciHostBridgeCount =3D 0; + + // + // Hypervisor can provide the specifications (resources) for one or more + // PCI host bridges. Such information comes through fw-cfg as part of + // the hardware-info file. + // + Status =3D QemuFwCfgFindFile ("etc/hardware-info", &FwCfgItem, &FwCfgSiz= e); + + if (EFI_ERROR (Status)) { + return NULL; + } + + HardwareInfoBlob =3D AllocatePool (FwCfgSize); + + if (HardwareInfoBlob =3D=3D NULL) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to allocate memory for hardware resources info\n", + __FUNCTION__ + )); + return NULL; + } + + QemuFwCfgSelectItem (FwCfgItem); + QemuFwCfgReadBytes (FwCfgSize, HardwareInfoBlob); + + // + // Create the list of hardware info devices filtering for PCI host + // bridges + // + Status =3D CreateHardwareInfoList ( + HardwareInfoBlob, + FwCfgSize, + HardwareInfoTypeHostBridge, + &HwInfoList + ); + + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create hardware info list to retrieve host " + "bridges information from fw-cfg\n", + __FUNCTION__ + )); + + goto FreeBridges; + } + + PciHostBridgeCount =3D GetHardwareInfoCountByType ( + &HwInfoList, + HardwareInfoTypeHostBridge, + sizeof (HOST_BRIDGE_INFO) + ); + + if (PciHostBridgeCount =3D=3D 0) { + goto FreeBridges; + } + + DEBUG (( + DEBUG_INFO, + "%a: Host provided description for %Lu root bridges\n", + __FUNCTION__, + PciHostBridgeCount + )); + + // + // Allocate the root bridges + // + Bridges =3D AllocatePool (((UINTN)PciHostBridgeCount) * sizeof *Bridges); + if (Bridges =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: %r\n", __FUNCTION__, EFI_OUT_OF_RESOURCES)); + goto FreeBridges; + } + + // + // If Host Bridges' specification was obtained from fw-cfg, the list + // contains information to populate all root bridges in the system + // including resources and attributes. + // + HwLink =3D GetFirstHardwareInfoByType ( + &HwInfoList, + HardwareInfoTypeHostBridge, + sizeof (HOST_BRIDGE_INFO) + ); + + while (!EndOfHardwareInfoList (&HwInfoList, HwLink)) { + HwInfo =3D HARDWARE_INFO_FROM_LINK (HwLink); + + HardwareInfoPciHostBridgeGet ( + HwInfo->Data.PciHostBridge, + HwInfo->Header.Size, + &RootBridgeNumber, + &LastRootBridgeNumber, + &Attributes, + &DmaAbove4G, + &NoExtendedConfigSpace, + &CombineMemPMem, + &Io, + &Mem, + &MemAbove4G, + &PMem, + &PMemAbove4G, + NULL + ); + + AllocationAttributes =3D 0; + if (CombineMemPMem) { + AllocationAttributes |=3D EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM; + } + + if ((MemAbove4G.Limit > MemAbove4G.Base) || + (PMemAbove4G.Limit > PMemAbove4G.Base)) + { + AllocationAttributes |=3D EFI_PCI_HOST_BRIDGE_MEM64_DECODE; + } + + Status =3D PciHostBridgeUtilityInitRootBridge ( + Attributes, + Attributes, + AllocationAttributes, + DmaAbove4G, + NoExtendedConfigSpace, + RootBridgeNumber, + LastRootBridgeNumber, + &Io, + &Mem, + &MemAbove4G, + &PMem, + &PMemAbove4G, + &Bridges[Initialized] + ); + + if (EFI_ERROR (Status)) { + goto FreeBridges; + } + + ++Initialized; + + HwLink =3D GetNextHardwareInfoByType ( + &HwInfoList, + HwLink, + HardwareInfoTypeHostBridge, + sizeof (HOST_BRIDGE_INFO) + ); + } + + *Count =3D Initialized; + + // + // If resources were allocated for host bridges info, release them + // + if (HardwareInfoBlob) { + FreePool (HardwareInfoBlob); + } + + FreeHardwareInfoList (&HwInfoList); + return Bridges; + +FreeBridges: + while (Initialized > 0) { + --Initialized; + PciHostBridgeUtilityUninitRootBridge (&Bridges[Initialized]); + } + + if (Bridges) { + FreePool (Bridges); + } + + if (HardwareInfoBlob) { + FreePool (HardwareInfoBlob); + } + + FreeHardwareInfoList (&HwInfoList); + return NULL; +} + +/** + Utility function to return all the root bridge instances in an array. + + @param[out] Count The number of root bridge instances. + + @param[in] Attributes Initial attributes. + + @param[in] AllocAttributes Allocation attributes. + + @param[in] DmaAbove4G DMA above 4GB memory. + + @param[in] NoExtendedConfigSpace No Extended Config Space. + + @param[in] BusMin Minimum Bus number, inclusive. + + @param[in] BusMax Maximum Bus number, inclusive. + + @param[in] Io IO aperture. + + @param[in] Mem MMIO aperture. + + @param[in] MemAbove4G MMIO aperture above 4G. + + @param[in] PMem Prefetchable MMIO aperture. + + @param[in] PMemAbove4G Prefetchable MMIO aperture above 4G. + + @return All the root bridge instances in an a= rray. +**/ +PCI_ROOT_BRIDGE * +EFIAPI +PciHostBridgeUtilityGetRootBridges ( + OUT UINTN *Count, + IN UINT64 Attributes, + IN UINT64 AllocationAttributes, + IN BOOLEAN DmaAbove4G, + IN BOOLEAN NoExtendedConfigSpace, + IN UINTN BusMin, + IN UINTN BusMax, + IN PCI_ROOT_BRIDGE_APERTURE *Io, + IN PCI_ROOT_BRIDGE_APERTURE *Mem, + IN PCI_ROOT_BRIDGE_APERTURE *MemAbove4G, + IN PCI_ROOT_BRIDGE_APERTURE *PMem, + IN PCI_ROOT_BRIDGE_APERTURE *PMemAbove4G + ) +{ + PCI_ROOT_BRIDGE *Bridges; + + *Count =3D 0; + + // + // First attempt to get the host provided descriptions of the Root Bridg= es + // if available. + // + Bridges =3D PciHostBridgeUtilityGetRootBridgesHostProvided (Count); + + // + // If host did not provide Root Bridge information, scan the buses and + // auto populate them with default resources. + // + if (Bridges =3D=3D NULL) { + Bridges =3D PciHostBridgeUtilityGetRootBridgesBusScan ( + Count, + Attributes, + AllocationAttributes, + DmaAbove4G, + NoExtendedConfigSpace, + BusMin, + BusMax, + Io, + Mem, + MemAbove4G, + PMem, + PMemAbove4G + ); + } + + return Bridges; +} + /** Utility function to free root bridge instances array from PciHostBridgeUtilityGetRootBridges(). diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLi= b.inf b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf index 83a734c172..e4fc903121 100644 --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf @@ -38,6 +38,7 @@ BaseMemoryLib DebugLib DevicePathLib + DxeHardwareInfoLib MemoryAllocationLib PciLib QemuFwCfgLib --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86382): https://edk2.groups.io/g/devel/message/86382 Mute This Topic: https://groups.io/mt/88893061/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86383+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86383+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643922075; cv=none; d=zohomail.com; s=zohoarc; b=YxMd2eGLbLz1cXBr4CKT0nenR44YFJPdbgvl9aCy6wAtFcqhLUHxSPxXTVN7/sXTI8zoHdwL1dFcjVhu+6ETh29CdZ3H+RCaPTO3tFMptW2UhmlBzQaAywb4KYR9Sk8siN3AfIbE9EkZUYVwlZMAyWYfaMu8PG5/a3zLnJLaBus= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643922075; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=AJEh8p8v9fMOJltrZJjVyIVcFq19O1cnmtP+GPhU2OY=; b=cVpX6e8GOrprToPjYKU1ISC1YX9EnsWCn4HdsjXZ5i8bDJPpRLRhDJRaBOrQ8fvOSPyBhWLMC6Sfe7qxhmblt+qEJWdAAubZi9dsUkhbqPtNhujbCvx1C5DbHDA4AxSp9DjSiZUP9/ySUviT49n4OgAHJZbzfwV24L5xqyeIvyU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86383+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643922075749283.95777242329825; Thu, 3 Feb 2022 13:01:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id eaLCYY1788612xVs2dOYj9mR; Thu, 03 Feb 2022 13:01:15 -0800 X-Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by mx.groups.io with SMTP id smtpd.web09.204.1643922074525184561 for ; Thu, 03 Feb 2022 13:01:14 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="989485279" X-Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1box-d-74e80b3c.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 03 Feb 2022 21:01:13 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1box-d-74e80b3c.us-east-1.amazon.com (Postfix) with ESMTPS id B767D85C59; Thu, 3 Feb 2022 21:01:12 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 21:01:09 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 6/8] MdeModulePkg, OvmfPkg: Add Pcd token for PCI pre-populated BARs Date: Thu, 3 Feb 2022 21:56:26 +0100 Message-ID: <260fc07686b09a0eaa336c966cfe6fca65e41a62.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: ZwqPU50QDZKaa8QwXJKbyhAzx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643922075; bh=Ll4g3uYVDFzuzC5XYa+qkUENQ0DeFmB1jrNFoPY+HsI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=EzLg7RVIIFESYC3wP+M0WFI/3tOrRE6jTVVfTO0mwfBOUHinTR2gmmL09lF7xK6UGSc QmaQ+2ojSEU/lc18A7dHEQBdK1FRoT3CGNfhiTbige9mg1i664RRG/CGqD4IR6Xn/Hx5m Qj+TZQFul9b6CXw1MQScwjEzXFVpN27xNn8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643922077588100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create a new PCD boolean token in MdeModulePkg for global use. We use this token to indicate if the configuration, parsed from fw-cfg, requires pre-populated BARs to be preserved. During creation of root bridges configurations, the flag is set according to the "pre-populated-bars" item in fw-cfg. The Pcd token is created as a dynamic item so it can be modified at runtime and it is consumed in both Pei and Dxe PCI modules. In virtualized environments, the hypervisor provides a layer of isolation between the VMs and the hardware. This isolation may include address translations and shadowing of configurations that prevent guests directly modifying hardware registers. The hypervisor then takes care of emulating the hardware accesses requested by the guest. In some cases, the host may want the guest to use a specific value for some or all PCI BARs so that transactions in GPA level (particularly DMA) can make use of the controlled set of addresses. The host then indicates the guest to preserve those BARs that are pre-populated, that is, BARs that already report a value even before guest's firmware BAR placement. The token provides a globally accessible configuration flag to determine, during PCI BAR allocation, if pre-populated BARs must be respected. The pre-allocated PCI BARs are used in platforms in which MMIO resources are configured with the same host physical addresses in the guest so that DMA transactions can happen between PCI devices without packets going through the IOMMU. Performance is improved due to PCI packets travelling shorter distances and avoiding links reaching the Root Complex, which can get busy during I/O intensive periods. Cc: Alexander Graf Cc: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- Notes: v4: - Move the code reading the pre-populated-bars fw-cfg file and setting the PcdPciPreservePopulatedMappings token to the new function that gets root bridge information from host-provided data. It only makes sense to have fixed BARs if the root bridge resources are also controlled and thus, both things match. MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 1 + MdeModulePkg/MdeModulePkg.dec | 6 ++++++ .../PciHostBridgeUtilityLib.c | 17 +++++++++++++++++ .../PciHostBridgeUtilityLib.inf | 4 ++++ OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/PlatformPei/PlatformPei.inf | 1 + 6 files changed, 30 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf b/MdeModulePkg/Bu= s/Pci/PciBusDxe/PciBusDxe.inf index e317169d9c..046876bb3b 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf @@ -107,6 +107,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport ## CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration ## SOMETIM= ES_CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport ## CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings## CONSUMES =20 [UserExtensions.TianoCore."ExtraFiles"] PciBusDxeExtra.uni diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 463e889e9a..078877ba7f 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1902,6 +1902,12 @@ # @Prompt Disable full PCI enumeration. gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE|BOOLEAN= |0x10000048 =20 + ## The flag to control preservation of pre-populated PCI BARs + # TRUE - Respect pre-populated PCI BARs + # FALSE - No pre-populated BARs, place all BARs + # @Prompt Enable preservsation of pre-populated PCI BARs + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings|FALSE|BOO= LEAN|0x10000050 + ## Disk I/O - Number of Data Buffer block. # Define the size in block of the pre-allocated buffer. It provide better # performance for large Disk I/O requests. diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLi= b.c b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c index 4bd4671f10..bb666aef62 100644 --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -443,6 +444,22 @@ PciHostBridgeUtilityGetRootBridgesHostProvided ( PCI_ROOT_BRIDGE_APERTURE MemAbove4G; PCI_ROOT_BRIDGE_APERTURE PMem; PCI_ROOT_BRIDGE_APERTURE PMemAbove4G; + UINT64 PrePopulatedBars; + + // + // Find file for pre-populated bars and set Pcd token if enabled + // + Status =3D QemuFwCfgFindFile ("etc/pre-populated-bars", &FwCfg= Item, &FwCfgSize); + PrePopulatedBars =3D 0; + if (!EFI_ERROR (Status) && (FwCfgSize =3D=3D sizeof (PrePopulatedBars)))= { + QemuFwCfgSelectItem (FwCfgItem); + QemuFwCfgReadBytes (FwCfgSize, &PrePopulatedBars); + + if (PrePopulatedBars) { + PcdSetBoolS (PcdPciPreservePopulatedMappings, TRUE); + DEBUG ((DEBUG_INFO, "%a: Pre-populated BARs present\n", __FUNCTION__= )); + } + } =20 // // Initialize the Hardware Info list head to start with an empty but val= id diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLi= b.inf b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf index e4fc903121..570bf7e97c 100644 --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf @@ -40,5 +40,9 @@ DevicePathLib DxeHardwareInfoLib MemoryAllocationLib + PcdLib PciLib QemuFwCfgLib + +[Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index b376387b7c..1656509f03 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -594,6 +594,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0 !endif + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800 gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/Plat= formPei.inf index e840f960d3..b58f79c6e3 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -96,6 +96,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86383): https://edk2.groups.io/g/devel/message/86383 Mute This Topic: https://groups.io/mt/88893079/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86384+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86384+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643922100; cv=none; d=zohomail.com; s=zohoarc; b=hJ0DY4pKDH5nCkA8r4Yfp2jabfctBwQMouZnmMPKzkQXJDgzHIzGICM7wy6ZuH/YGNL5hSyA6FZfNc7Y4eIWATJdgv129YwyHbFdnPlFm6E2ytPPZxNtVc0Aw0DOe5MFPLhf0DF9jLMScGoCBpEgPsW7bffDNRprjq0lT2SKqV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643922100; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hLDYpVZX33wgDvttd95hO4x2lu+xIJ5xnsDxiabIecc=; b=NQKX1H2ZqYGUPKcG5O6RL8QCgYJLR/JamgYtr0rbU3dNlrJIOo8Bl4pFFv30TlxbKNwr7ZlE8Yk6TdjmbIcGUOKvvVIrQxrra/MA+INTiFYnEhBkc6QJaEiLQ2DFCfFSpHHbRULxCx88FTngBPBfhimiTm/PoQb71bjJgB0lDLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86384+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 164392210025031.926594967870415; Thu, 3 Feb 2022 13:01:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id to1JYY1788612x5qLHxWpY3Z; Thu, 03 Feb 2022 13:01:39 -0800 X-Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com [99.78.197.218]) by mx.groups.io with SMTP id smtpd.web12.182.1643922099161468561 for ; Thu, 03 Feb 2022 13:01:39 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="60356302" X-Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-c92fe759.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP; 03 Feb 2022 21:01:24 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-c92fe759.us-east-1.amazon.com (Postfix) with ESMTPS id 5F119C096A; Thu, 3 Feb 2022 21:01:23 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 21:01:19 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation Date: Thu, 3 Feb 2022 21:56:27 +0100 Message-ID: <68baf235a1b6fe824424f874c6d6f5a015676717.1643919691.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: ijswcMF6xfzpBn7UHNBGomqAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643922099; bh=iq2HwRMw860eAGypqIO2oA2zRqozu/ZS98tSqjU6fdM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=HuUrNJf8NpWuIBoWyaonW66FoeZcpgHo23KSTrMMrYJKY+1+NTHlclQOf0kL9TzzwFP fqePcOxc1323IEM3kbGpOiH6+mwkmLlsXVuwUJ7WXgL0BCEc6Ggsk+an6J9q4qvO/OrSN qOLdw2RXErpzkqQzU648eijy8XkQFv3/k/U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643922101515100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Enhance the PCI Resource Allocation services to include a new state in which only the base address of each root bridge is set. This new, partial state is used in conjunction with GetProposedResources to retrieve the Base Addresses of the resources before the allocation takes place, and is reached only if pre-populated mappings are enabled. The need for this information before allocation emerges from the handling of pre-populated resources, that is, PCI BARs that have a fixed value and should not be placed at a different address. For such a case, the firmware already receives a fixed resource description of the root bridges that agrees with those pre-populated resources. For example, in Ovmf platform, the host can provide the specific resources to be used for each root bridge in the guest and also indicate that there are pre-populated resources that must be respected. In this case, those resources need to be placed (offset-wise) before the rest of the resources. The placement logic assigns a root bridge relative offset to each BAR, therefore, the offsets of the pre-populated BARs need to be calculated first and, for that, the root bridge' base address must be known beforehand so that absolute addresses read from the devices can be translated into a root bridge relative offset. Cc: Alexander Graf Cc: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- Notes: v4: - Major restructuring of the concept to avoid modifications to the PCI Resource Allocation protocol which comes from UEFI spec. Previous rev3 patch was completely removed. - Extended existing services of the protocol to integrate a new state that allows the traditional GetProposedResources to retrieve, before allocation phase, the base address of root bridges. - Changes are guarded with PcdPciPreservePopulatedMappings token so that existent platforms experience no change at all. MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 1 + .../Bus/Pci/PciBusDxe/PciEnumerator.c | 4 +- .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 93 ++++++++++++++++++- .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 2 + .../Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf | 4 + .../Pci/PciHostBridgeDxe/PciHostResource.h | 1 + MdeModulePkg/Include/Library/PciResourceLib.h | 20 ++++ 7 files changed, 122 insertions(+), 3 deletions(-) create mode 100644 MdeModulePkg/Include/Library/PciResourceLib.h diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h b/MdeModulePkg/Bus/Pci= /PciBusDxe/PciBus.h index 4b58c3ea9b..ecb3d3cb5d 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h @@ -38,6 +38,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include =20 #include #include diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePkg/= Bus/Pci/PciBusDxe/PciEnumerator.c index 3f8c6e6da7..fdf8984661 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c @@ -1307,7 +1307,9 @@ GetResourceBase ( Ptr =3D (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *)Temp; ResStatus =3D Ptr->AddrTranslationOffset; =20 - if (ResStatus =3D=3D EFI_RESOURCE_SATISFIED) { + if ((ResStatus =3D=3D EFI_RESOURCE_SATISFIED) || + (ResStatus =3D=3D PCI_RESOURCE_PARTIAL)) + { switch (Ptr->ResType) { // // Memory type aperture diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeMod= ulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c index b20bcd310a..cfe45a6e3f 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c @@ -884,8 +884,75 @@ NotifyPhase ( =20 case EfiPciHostBridgeBeginResourceAllocation: // - // No specific action is required here, can perform any chipset spec= ific programing + // In general, no specific action is required here, can perform any = chipset specific programing // + if (PcdGetBool (PcdPciPreservePopulatedMappings)) { + // + // If pre populated resources are present, resources are moved into + // ResBaseDiscovered state to enable the retrival of BaseAddresses. + // Set the base address of each resource with value in root bridges + // using same alignments but no allocation. This partial informati= on is + // intended to be used by a preliminary call to GetProposedResoruc= es + // that retrieves only base addressed for resource placement purpo= ses + // + for (Link =3D GetFirstNode (&HostBridge->RootBridges) + ; !IsNull (&HostBridge->RootBridges, Link) + ; Link =3D GetNextNode (&HostBridge->RootBridges, Link) + ) + { + RootBridge =3D ROOT_BRIDGE_FROM_LINK (Link); + + for (Index =3D TypeIo; Index < TypeBus; Index++) { + if (RootBridge->ResAllocNode[Index].Status =3D=3D ResNone) { + Alignment =3D RootBridge->ResAllocNode[Index].Alignmen= t; + BitsOfAlignment =3D LowBitSet64 (Alignment + 1); + BaseAddress =3D MAX_UINT64; + + switch (Index) { + case TypeIo: + BitsOfAlignment =3D MIN (15, BitsOfAlignment); + BaseAddress =3D ALIGN_VALUE (RootBridge->Io.Base, Al= ignment + 1); + BaseAddress =3D ALIGN_VALUE (BaseAddress, LShiftU64 = (1, BitsOfAlignment)); + break; + + case TypeMem32: + BitsOfAlignment =3D MIN (31, BitsOfAlignment); + BaseAddress =3D ALIGN_VALUE (RootBridge->Mem.Base, A= lignment + 1); + BaseAddress =3D ALIGN_VALUE (BaseAddress, LShiftU64 = (1, BitsOfAlignment)); + break; + + case TypePMem32: + BitsOfAlignment =3D MIN (31, BitsOfAlignment); + BaseAddress =3D ALIGN_VALUE (RootBridge->PMem.Base, = Alignment + 1); + BaseAddress =3D ALIGN_VALUE (BaseAddress, LShiftU64 = (1, BitsOfAlignment)); + break; + + case TypeMem64: + BitsOfAlignment =3D MIN (63, LowBitSet64 (Alignment + 1)= ); + BaseAddress =3D ALIGN_VALUE (RootBridge->MemAbove4G.= Base, Alignment + 1); + BaseAddress =3D ALIGN_VALUE (BaseAddress, LShiftU64 = (1, BitsOfAlignment)); + break; + + case TypePMem64: + BitsOfAlignment =3D MIN (63, LowBitSet64 (Alignment + 1)= ); + BaseAddress =3D ALIGN_VALUE (RootBridge->PMemAbove4G= .Base, Alignment + 1); + BaseAddress =3D ALIGN_VALUE (BaseAddress, LShiftU64 = (1, BitsOfAlignment)); + break; + + default: + ASSERT (FALSE); + break; + } + + if (BaseAddress !=3D MAX_UINT64) { + RootBridge->ResAllocNode[Index].Base =3D BaseAddress; + RootBridge->ResAllocNode[Index].Status =3D ResBaseDiscover= ed; + } + } + } + } + } + break; =20 case EfiPciHostBridgeAllocateResources: @@ -919,7 +986,9 @@ NotifyPhase ( DEBUG ((DEBUG_INFO, " RootBridge: %s\n", RootBridge->DevicePathStr= )); =20 for (Index1 =3D TypeIo; Index1 < TypeBus; Index1++) { - if (RootBridge->ResAllocNode[Index1].Status =3D=3D ResNone) { + if ((RootBridge->ResAllocNode[Index1].Status =3D=3D ResNone) || + (RootBridge->ResAllocNode[Index1].Status =3D=3D ResBaseDisco= vered)) + { ResNodeHandled[Index1] =3D TRUE; } else { // @@ -1571,6 +1640,22 @@ SubmitResources ( RootBridge->ResAllocNode[Type].Status =3D ResSubmitted; } =20 + if (PcdGetBool (PcdPciPreservePopulatedMappings)) { + // + // If pre-populated resources are present, causing the resources + // to go into ResBaseDiscovered before EfiPciHostBridgeAllocateRes= ources + // clear nodes that are still in that state, which have a Base Add= ress + // but no resources underneath them. Mark them as empty nodes sinc= e no + // resources were submitted for them, length required is zero. + // + for (Type =3D TypeIo; Type < TypeBus; Type++) { + if (RootBridge->ResAllocNode[Type].Status =3D=3D ResBaseDiscover= ed) { + RootBridge->ResAllocNode[Type].Status =3D ResNone; + RootBridge->ResAllocNode[Type].Base =3D 0; + } + } + } + RootBridge->ResourceSubmitted =3D TRUE; return EFI_SUCCESS; } @@ -1652,6 +1737,10 @@ GetProposedResources ( Descriptor->AddrTranslationOffset =3D (ResStatus =3D=3D ResAlloc= ated) ? EFI_RESOURCE_SATISFIED : PCI_RESOURCE_LESS; Descriptor->AddrLen =3D RootBridge->ResAllocNode[I= ndex].Length; =20 + if (ResStatus =3D=3D ResBaseDiscovered) { + Descriptor->AddrTranslationOffset =3D PCI_RESOURCE_PARTIAL; + } + switch (Index) { case TypeIo: Descriptor->ResType =3D ACPI_ADDRESS_SPACE_TYPE_IO; diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h b/MdeMod= ulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h index e7a30fd909..940adc5965 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h @@ -15,6 +15,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include +#include #include #include =20 diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf b/M= deModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf index 9c24cacc30..42d1cc6289 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf @@ -39,6 +39,7 @@ UefiLib PciHostBridgeLib TimerLib + PcdLib =20 [Protocols] gEfiCpuIo2ProtocolGuid ## CONSUMES @@ -50,3 +51,6 @@ [Depex] gEfiCpuIo2ProtocolGuid AND gEfiCpuArchProtocolGuid + +[Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdPciPreservePopulatedMappings## CONSUMES diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h b/MdeM= odulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h index 772f4b513f..12725d3797 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h @@ -28,6 +28,7 @@ typedef enum { ResNone, ResSubmitted, ResAllocated, + ResBaseDiscovered, ResStatusMax } RES_STATUS; =20 diff --git a/MdeModulePkg/Include/Library/PciResourceLib.h b/MdeModulePkg/I= nclude/Library/PciResourceLib.h new file mode 100644 index 0000000000..e16394c352 --- /dev/null +++ b/MdeModulePkg/Include/Library/PciResourceLib.h @@ -0,0 +1,20 @@ +/** @file + Pci resource library consumed by PciBusDxe and PciHostBridgeDxe drivers = to + share non-UEFI spec artefacts used in both drivers + + Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BS= D License + which accompanies this distribution. The full text of the license may b= e found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMP= LIED. + **/ +#ifndef __PCI_RESOURCE_LIB_H__ +#define __PCI_RESOURCE_LIB_H__ + +#define PCI_RESOURCE_PARTIAL 0xFFFFFFFFFFFFFFFDULL + +#endif --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86384): https://edk2.groups.io/g/devel/message/86384 Mute This Topic: https://groups.io/mt/88893097/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 13 06:44:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86385+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86385+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1643922105; cv=none; d=zohomail.com; s=zohoarc; b=CHC1YL5gCCktg2SUGIHX74D6agrKp/mvbboLc8UtR/kVGu3vJvjXaGOCths6RtlTZRmpGCQ74yBmA4YIIAh5ld97hZE7S3WU+JjwQBSo84xhi1S3dxJRhY0jw/9KYMcSPCJH0z9b3dQtwbEJlXYm5jiSh2qKLUjHjVxQDt/Fiq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643922105; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=gq7XnBzaT5aKTLLQjgibmNOD6jwFMMpr54gm9scbbr4=; b=ZujQK6CrcMla5Z6mDtzVS00D4BwixrYKn+hc6YYKT6+plrPGPwkQE8BrkzNaJ0L6EUj+CaZGWem7mRokEufzceuvM+X1eMrsiiYbWOD3TfBUujAMeuMbmxXSvVOXjmIx4tMNRbNlr4mOKu0A5S2iftNHT4x9DXk7x1rZsDDg5V0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86385+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643922105771295.94719288379065; Thu, 3 Feb 2022 13:01:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zQsbYY1788612xA7l9tUuqIL; Thu, 03 Feb 2022 13:01:45 -0800 X-Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by mx.groups.io with SMTP id smtpd.web11.208.1643922104410309147 for ; Thu, 03 Feb 2022 13:01:44 -0800 X-IronPort-AV: E=Sophos;i="5.88,340,1635206400"; d="scan'208";a="989485476" X-Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 03 Feb 2022 21:01:43 +0000 X-Received: from EX13D49EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com (Postfix) with ESMTPS id F33B381618; Thu, 3 Feb 2022 21:01:42 +0000 (UTC) X-Received: from ub4014a598e6c52.ant.amazon.com (10.43.160.114) by EX13D49EUC003.ant.amazon.com (10.43.164.91) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 3 Feb 2022 21:01:39 +0000 From: "Ojeda Leon, Nicolas via groups.io" To: CC: , Nicolas Ojeda Leon , Alexander Graf , Gerd Hoffmann Subject: [edk2-devel] [PATCH v4 8/8] MdeModulePkg/PciBusDxe: Handling of pre-populated PCI BARs Date: Thu, 3 Feb 2022 21:56:28 +0100 Message-ID: <776ac740fddedd1f58f7ebbad6fba8837ef06600.1643919692.git.ncoleon@amazon.com> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.160.114] X-ClientProxiedBy: EX13D27UWB004.ant.amazon.com (10.43.161.101) To EX13D49EUC003.ant.amazon.com (10.43.164.91) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ncoleon@amazon.com X-Gm-Message-State: YHLDYLxicgaTowG80qbY0t6ex1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643922105; bh=y9on9rvyNA9bUp8aei9l1eZu3Hhy5S7ZgYXBoCaC3UU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=OraNu9ae7Gxhdxn6Be4L/TqxuDewp7eetGzX4JxuXdzl/XbGzOdQH350q4WfIVOXK7B NZutqAxRbYtOLePvNfjVNtAZjFIIzMgFntUyLVlSYEXg9/X31nTzTQPKnUZEcz8YyR9Jm bDLj8ZprQv8QSU0yX4b1hCUU4CYkQABFMqk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643922108885100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the PCI BAR placement logic in order to consider pre-populated resources first, if indicated by the Pcd token for such purpose. The PCI_BAR type is augmented by one field for mapping the absolute address of prepopulated BARs into a root bridge relative offset. As part of the CreateResourceMap stage of the PCI resource allocation process, all the resources belonging to a root bridge are analyzed and if a BaseAddress (absolute address read from the PCI device during enumeration) is present, it is translated into a root-bridge relative offset and the space occupied by it is marked as used in the root bridge's aperture. This process is performed before the regular placement logic is executed. The remaining unassigned BARs are then placed according to default logic starting after the last pre-populated resource. The motivation behind respecting pre-populated BARs is that the hypervisor can decide on placement of some resources and the guest must use the same values to benefit from performance optimizations or specific requirements. Cc: Alexander Graf Cc: Gerd Hoffmann Signed-off-by: Nicolas Ojeda Leon --- Notes: v4: - Guarded the root bridge address retreiving and the handling of pre-populated resources in PciLib with PcdPciPreservePopulatedMappings token - Use the new way to fetch Root Bridge base addresses by calling GetProposedResources before allocation to then populate the resource apertures to take care of pre-populated BARs. MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 1 + .../Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 5 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 49 ++++ .../Bus/Pci/PciBusDxe/PciResourceSupport.c | 277 +++++++++++++++++- .../Bus/Pci/PciBusDxe/PciResourceSupport.h | 20 ++ 5 files changed, 348 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h b/MdeModulePkg/Bus/Pci= /PciBusDxe/PciBus.h index ecb3d3cb5d..1200924e95 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h @@ -95,6 +95,7 @@ typedef enum { // struct _PCI_BAR { UINT64 BaseAddress; + UINT64 BaseAddressOffset; UINT64 Length; UINT64 Alignment; PCI_BAR_TYPE BarType; diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeMod= ulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c index 9251388bc2..91caf162e0 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c @@ -1776,8 +1776,9 @@ PciParseBar ( return Offset + 4; } =20 - PciIoDevice->PciBar[BarIndex].BarTypeFixed =3D FALSE; - PciIoDevice->PciBar[BarIndex].Offset =3D (UINT8)Offset; + PciIoDevice->PciBar[BarIndex].BarTypeFixed =3D FALSE; + PciIoDevice->PciBar[BarIndex].Offset =3D (UINT8)Offset; + PciIoDevice->PciBar[BarIndex].BaseAddressOffset =3D 0; if ((Value & 0x01) !=3D 0) { // // Device I/Os diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci= /PciBusDxe/PciLib.c index 63d149b3b8..be6bbd01c7 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c @@ -595,6 +595,55 @@ PciHostBridgeResourceAllocator ( GetResourceFromDevice (RootBridgeDev, IoBridge, Mem32Bridge, PMem3= 2Bridge, Mem64Bridge, PMem64Bridge); } =20 + if (PcdGetBool (PcdPciPreservePopulatedMappings)) { + // + // If there are pre-populated resources (e.g. in virtualized platf= orms) + // the base addresses need to be retrieved to place them before the + // other resources. This also implies the firmware received the PCI + // apertures fixed and that these are consistent with the pre-popu= lated + // values. At this point, the resources have status ResBaseDiscove= rd and + // have only the Base address set (partially filled and not alloca= ted) + // + AcpiConfig =3D NULL; + Status =3D PciResAlloc->GetProposedResources ( + PciResAlloc, + RootBridgeDev->Handle, + &AcpiConfig + ); + + if (EFI_ERROR (Status)) { + return Status; + } + + // + // Get the resource base by interpreting acpi resource node + // + // + GetResourceBase ( + AcpiConfig, + &IoBase, + &Mem32Base, + &PMem32Base, + &Mem64Base, + &PMem64Base + ); + + if (AcpiConfig !=3D NULL) { + FreePool (AcpiConfig); + } + + // + // Handle pre-populated resources + // + PopulateResourceAperture ( + Mem32Base, + PMem32Base, + Mem64Base, + PMem64Base, + RootBridgeDev + ); + } + // // Create resourcemap by going through all the devices subject to th= is root bridge // diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c index 8ffd05f327..e2a550bf8e 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c @@ -324,6 +324,266 @@ CalculateApertureIo16 ( Bridge->Length =3D MAX (Bridge->Length, PaddingAperture); } =20 +/** + Analyze a single BAR and if it is pre-populated (its baseAddress is alre= ady + set), calculate the offset inside the root bridge. + + @param Bar PCI BAR to be placed if pre-populated + @param Base Base address of the root bridge + +**/ +STATIC +VOID +PrePopulateBAR ( + IN OUT PCI_BAR *Bar, + IN UINT64 Base + ) +{ + if (Base =3D=3D gAllOne) { + return; + } + + // + // Pre-populated IO space BARs are not supported + // + if ((Bar->BarType =3D=3D PciBarTypeIo16) || (Bar->BarType =3D=3D PciBarT= ypeIo32)) { + return; + } + + if (Bar->BaseAddress < Base) { + return; + } + + if (Bar->BaseAddress !=3D 0) { + Bar->BaseAddressOffset =3D Bar->BaseAddress - Base; + } +} + +/** + Calculate and set the address offset inside the root bridge of device + BARs that are pre-populated. + + @param Dev PCI device whose BARs are to be analyzed + @param Base Base address of the root bridge under which the device + is located. + + */ +STATIC +VOID +PopulateDeviceBars ( + IN UINT64 Mem32Base, + IN UINT64 PMem32Base, + IN UINT64 Mem64Base, + IN UINT64 PMem64Base, + IN PCI_IO_DEVICE *Dev + ) +{ + UINTN Index; + + for (Index =3D 0; Index < PCI_MAX_BAR; Index++) { + switch (Dev->PciBar[Index].BarType) { + case PciBarTypeMem32: + PrePopulateBAR (&Dev->PciBar[Index], Mem32Base); + break; + + case PciBarTypePMem32: + PrePopulateBAR (&Dev->PciBar[Index], PMem32Base); + break; + + case PciBarTypeMem64: + PrePopulateBAR (&Dev->PciBar[Index], Mem64Base); + break; + + case PciBarTypePMem64: + PrePopulateBAR (&Dev->PciBar[Index], PMem64Base); + break; + + default: + break; + } + } +} + +/** + Considering the Bridge attributes specifying the supported resources, + merge the base addresses to fake the non-suported types belonging to + the alternative type. + + @param Mem32Base 32-bit base address + @param PMem32Base 32-bit prefetchable base address + @param Mem64Base 64-bit base address + @param PMem64Base 64-bit prefetchable base address + @param Bridge PCI resource node for given bridge device. + + */ +STATIC +VOID +MergeBridgeResourceBases ( + IN OUT UINT64 *Mem32Base, + IN OUT UINT64 *PMem32Base, + IN OUT UINT64 *Mem64Base, + IN OUT UINT64 *PMem64Base, + IN PCI_IO_DEVICE *Bridge + ) +{ + // + // if root bridge supports combined Pmem Mem decoding + // merge these two type of resource + // + if (BridgeSupportResourceDecode (Bridge, EFI_BRIDGE_PMEM_MEM_COMBINE_SUP= PORTED)) { + *PMem32Base =3D *Mem32Base; + *PMem64Base =3D *Mem64Base; + } + + // + // If bridge doesn't support Pmem32 + // degrade it to mem32 + // + if (!BridgeSupportResourceDecode (Bridge, EFI_BRIDGE_PMEM32_DECODE_SUPPO= RTED)) { + *PMem32Base =3D *Mem32Base; + } + + // + // If firmware is in 32-bit mode, + // then degrade PMEM64/MEM64 requests + // + if (sizeof (UINTN) <=3D 4) { + *Mem64Base =3D *Mem32Base; + *PMem64Base =3D *PMem32Base; + } else { + // + // if the bridge does not support MEM64, degrade MEM64 to MEM32 + // + if (!BridgeSupportResourceDecode (Bridge, EFI_BRIDGE_MEM64_DECODE_SUPP= ORTED)) { + *Mem64Base =3D *Mem32Base; + } + + // + // if the bridge does not support PMEM64, degrade PMEM64 to PMEM32 + // + if (!BridgeSupportResourceDecode (Bridge, EFI_BRIDGE_PMEM64_DECODE_SUP= PORTED)) { + *PMem64Base =3D *PMem32Base; + } + } +} + +/** + Populate a root bridge's resource aperture according to + initial conditions ruled by individual pre-populated + resources + + @param Bridge PCI resource node for given bridge device. + @param Base Resource aperture base address + +**/ +VOID +PopulateResourceAperture ( + IN UINT64 Mem32Base, + IN UINT64 PMem32Base, + IN UINT64 Mem64Base, + IN UINT64 PMem64Base, + IN OUT PCI_IO_DEVICE *Bridge + ) +{ + PCI_IO_DEVICE *Temp; + LIST_ENTRY *CurrentLink; + + // + // Verify if pre-populated BARs need to be respected, otherwise + // there is no need to pre-populate any resource + // + if (!PcdGetBool (PcdPciPreservePopulatedMappings)) { + return; + } + + CurrentLink =3D Bridge->ChildList.ForwardLink; + + // + // Merge base addresses of the different types depending on resource + // decoding supported by the bridge + // + MergeBridgeResourceBases ( + &Mem32Base, + &PMem32Base, + &Mem64Base, + &PMem64Base, + Bridge + ); + + while (CurrentLink !=3D NULL && CurrentLink !=3D &Bridge->ChildList) { + Temp =3D PCI_IO_DEVICE_FROM_LINK (CurrentLink); + + PopulateDeviceBars ( + Mem32Base, + PMem32Base, + Mem64Base, + PMem64Base, + Temp + ); + + // + // Recursive call to analyze the hierarchical tree under a bridge + // + if (IS_PCI_BRIDGE (&Temp->Pci)) { + PopulateResourceAperture ( + Mem32Base, + PMem32Base, + Mem64Base, + PMem64Base, + Temp + ); + } + + CurrentLink =3D CurrentLink->ForwardLink; + } +} + +/** + Calculate the current used resource of the bridge provided that some + of the resources under it might been pre-populated. + + @param Bridge PCI resource node for given bridge device. + +**/ +STATIC +UINT64 +GetBridgePopulatedAperture ( + IN PCI_RESOURCE_NODE *Bridge + ) +{ + UINT64 Aperture; + UINT64 EndAddress; + LIST_ENTRY *CurrentLink; + PCI_RESOURCE_NODE *Node; + PCI_BAR *Bar; + + Aperture =3D 0; + + // + // Analyze all resource nodes looking for the prepopulated with the + // highest address used. + // + for ( CurrentLink =3D GetFirstNode (&Bridge->ChildList) + ; !IsNull (&Bridge->ChildList, CurrentLink) + ; CurrentLink =3D GetNextNode (&Bridge->ChildList, CurrentLink) + ) + { + Node =3D RESOURCE_NODE_FROM_LINK (CurrentLink); + + Bar =3D &Node->PciDev->PciBar[Node->Bar]; + + if (Bar->BaseAddress !=3D 0) { + EndAddress =3D Bar->BaseAddressOffset + Bar->Length; + + if (EndAddress > Aperture) { + Aperture =3D EndAddress; + } + } + } + + return Aperture; +} + /** This function is used to calculate the resource aperture for a given bridge device. @@ -337,6 +597,7 @@ CalculateResourceAperture ( ) { UINT64 Aperture[2]; + UINT64 InitialAperture; LIST_ENTRY *CurrentLink; PCI_RESOURCE_NODE *Node; =20 @@ -349,8 +610,14 @@ CalculateResourceAperture ( return; } =20 - Aperture[PciResUsageTypical] =3D 0; - Aperture[PciResUsagePadding] =3D 0; + // + // Initialize apertures at bridge's current resource usage + // which might be occupied by pre-populated resources. + // + InitialAperture =3D GetBridgePopulatedAperture (Bridge); + Aperture[PciResUsageTypical] =3D InitialAperture; + Aperture[PciResUsagePadding] =3D InitialAperture; + // // Assume the bridge is aligned // @@ -361,6 +628,12 @@ CalculateResourceAperture ( { Node =3D RESOURCE_NODE_FROM_LINK (CurrentLink); =20 + PCI_BAR *Bar =3D &Node->PciDev->PciBar[Node->Bar]; + if (PcdGetBool (PcdPciPreservePopulatedMappings) && Bar->BaseAddress) { + Node->Offset =3D Bar->BaseAddressOffset; + continue; + } + // // It's possible for a bridge to contain multiple padding resource // nodes due to DegradeResource(). diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.h b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciResourceSupport.h index 1527d4eafa..c5ab5f3fd9 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.h @@ -111,6 +111,26 @@ CalculateApertureIo16 ( IN PCI_RESOURCE_NODE *Bridge ); =20 +/** + Populate a root bridge's resource aperture according to + initial conditions ruled by individual pre-populated + resources + + @note Pre-populated PIO BARs are not supported. + + @param Bridge PCI resource node for given bridge device. + @param Base Resource aperture base address + +**/ +VOID +PopulateResourceAperture ( + IN UINT64 Mem32Base, + IN UINT64 PMem32Base, + IN UINT64 Mem64Base, + IN UINT64 PMem64Base, + IN OUT PCI_IO_DEVICE *Bridge + ); + /** This function is used to calculate the resource aperture for a given bridge device. --=20 2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86385): https://edk2.groups.io/g/devel/message/86385 Mute This Topic: https://groups.io/mt/88893098/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-