From nobody Wed May 8 11:47:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82402+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82402+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1634698797; cv=none; d=zohomail.com; s=zohoarc; b=IcZWoiPy8dh/Vr+sE2nardr0BK0A1rqbzhviiPQb/xvJLYB/Wm9I7xKhPvopZw7Qlp4lyb1AbWYTk6iP5DwZWkcpfacU8NamFJ398Kz6FcHPIzgg0clXnmg2YgVpWkquXj5Pbkxr2LPVR6Df20raOkceD7BROFWVXShUh2vqdUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634698797; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=l4xJ3UyJ9cTM6fEi05HwabSOGP+BSVUksY2zx9jKOiU=; b=DL33+oy9l2+7wnxKeUFPGOLLRHMp4ixsNG0ONbEJEi2FCcPNlsZIKlRPAkqO+GyHMyDdIGL9uFkBTvoO7Xpb9fI+XXByhxQO34xsvcCAzZTDrXod+PrFW0Wwc0T/DH0K78Xh8Te2tJMswjj9H7ZqLywmnEBJVLsF9Wf8qgr7biY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82402+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1634698797010572.0841249513383; Tue, 19 Oct 2021 19:59:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id HEXhYY1788612xOzFD53Nk8v; Tue, 19 Oct 2021 19:59:56 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.3052.1634698795205002451 for ; Tue, 19 Oct 2021 19:59:56 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="314879208" X-IronPort-AV: E=Sophos;i="5.87,165,1631602800"; d="scan'208";a="314879208" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 19:59:54 -0700 X-IronPort-AV: E=Sophos;i="5.87,165,1631602800"; d="scan'208";a="494410163" X-Received: from iworam-desk.amr.corp.intel.com ([10.7.150.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 19:59:54 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/MultiPchPei: Open Source PEIM Date: Tue, 19 Oct 2021 19:59:50 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: BWr4ryKG7TxKFQJ0AJ4yVNKmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634698796; bh=eJKKI8Kab3L3AWOvW0uw5n74kaSyiNMb35Ihldo9MUQ=; h=Cc:Date:From:Reply-To:Subject:To; b=CXFReIe8IpCzfE9XC+AC45RFcGYvlnmLViVhP48MOFqOGodBou1MQiTfxBpmmtSB8IL xnR7bCZqDV77et5JLdO94js05K1xEPjK8YKbFva2xgPw9MdSeJ6UDoyzvwQrBTyms08OL Oq0i48oz/V9fGPPcK6DW+RZeUmuat+vq9HQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634698799138100003 Content-Type: text/plain; charset="utf-8" Eliminate the need for the binary PEIM currenty in use by Whitley. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/Library/PchMul= tiPch.h | 34 ++++++++ Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/MultiPchP= ei.c | 84 ++++++++++++++++++++ Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/MultiPchP= ei.inf | 40 ++++++++++ 3 files changed, 158 insertions(+) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/Li= brary/PchMultiPch.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/I= nclude/Library/PchMultiPch.h new file mode 100644 index 0000000000..1fe502b7a7 --- /dev/null +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/Library/P= chMultiPch.h @@ -0,0 +1,34 @@ +/** @file + Prototype of the MultiPch library. + + @copyright + Copyright 2019 - 2021 Intel Corporation.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent +**/ + +#ifndef _PCH_MULTI_PCH_LIB_H_ +#define _PCH_MULTI_PCH_LIB_H_ + +#include +#include + +#define PCH_IP_INFO_REVISION 1 + +typedef struct _PCH_IP_INFO { + /** + Revision 1: Original version + **/ + UINT8 Revision; + + BOOLEAN Valid[PCH_MAX]; + UINT8 SocketId[PCH_MAX]; + UINT8 Segment[PCH_MAX]; + UINT8 Bus[PCH_MAX]; + UINT64 P2sbBar[PCH_MAX]; + UINT64 TempBar[PCH_MAX]; + UINT64 PmcBar[PCH_MAX]; + UINT64 SpiBar[PCH_MAX]; +} PCH_IP_INFO; + +#endif // _PCH_MULTI_PCH_LIB_H_ diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/P= ei/MultiPchPei.c b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Mult= iPch/Pei/MultiPchPei.c new file mode 100644 index 0000000000..65cee5d031 --- /dev/null +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/Mult= iPchPei.c @@ -0,0 +1,84 @@ +/** @file + This driver manages the initial phase of Multi PCH + + @copyright + Copyright 2019 - 2021 Intel Corporation.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent +**/ + +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +/// +/// The default PCH PCI segment number +/// +#define DEFAULT_PCI_SEGMENT_NUMBER_PCH 0 + +/** + @brief + Multi PCH entry point. + + @param[in] FileHandle PEIM file handle + @param[in] PeiServices General purpose services available to every PEIM + + @retval EFI_SUCCESS The function completed successfully. +**/ +EFI_STATUS +MultiPchPeiEntryPoint ( + IN EFI_PEI_FILE_HANDLE FileHandle, + IN CONST EFI_PEI_SERVICES **PeiServices + ) +{ + EFI_STATUS Status; + PCH_IP_INFO *PchInfo; + EFI_PEI_PPI_DESCRIPTOR *PchIpInfoPpiDesc; + + DEBUG ((DEBUG_INFO, "[PCH] MultiPchPeiEntryPoint called.\n")); + + // + // Create PchIpInfo + // + PchInfo =3D (PCH_IP_INFO *) AllocateZeroPool (sizeof (PCH_IP_INFO)); + if (PchInfo =3D=3D NULL) { + ASSERT (FALSE); + return EFI_OUT_OF_RESOURCES; + } + PchInfo->Revision =3D PCH_IP_INFO_REVISION; + PchInfo->Valid[PCH_LEGACY_ID] =3D TRUE; + PchInfo->Segment[PCH_LEGACY_ID] =3D DEFAULT_PCI_SEGMENT_NUMBER_PCH; + PchInfo->Bus[PCH_LEGACY_ID] =3D DEFAULT_PCI_BUS_NUMBER_PCH; + PchInfo->P2sbBar[PCH_LEGACY_ID] =3D PCH_PCR_BASE_ADDRESS; + PchInfo->PmcBar[PCH_LEGACY_ID] =3D PCH_PWRM_BASE_ADDRESS; + PchInfo->SpiBar[PCH_LEGACY_ID] =3D PCH_SPI_BASE_ADDRESS; + PchInfo->TempBar[PCH_LEGACY_ID] =3D PCH_TEMP_BASE_ADDRESS; + + // + // Install PchIpInfoPpi + // + PchIpInfoPpiDesc =3D (EFI_PEI_PPI_DESCRIPTOR *) AllocateZeroPool (sizeof= (EFI_PEI_PPI_DESCRIPTOR)); + if (PchIpInfoPpiDesc =3D=3D NULL) { + return EFI_OUT_OF_RESOURCES; + } + + PchIpInfoPpiDesc->Flags =3D EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DES= CRIPTOR_TERMINATE_LIST; + PchIpInfoPpiDesc->Guid =3D &gPchIpInfoPpiGuid; + PchIpInfoPpiDesc->Ppi =3D PchInfo; + + Status =3D PeiServicesInstallPpi (PchIpInfoPpiDesc); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + return EFI_UNSUPPORTED; + } + + return EFI_SUCCESS; +} diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/P= ei/MultiPchPei.inf b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Mu= ltiPch/Pei/MultiPchPei.inf new file mode 100644 index 0000000000..bd15593f2b --- /dev/null +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/Mult= iPchPei.inf @@ -0,0 +1,40 @@ +## @file +# This driver manages the initial phase of Multi PCH +# +# @copyright +# Copyright 2019 - 2021 Intel Corporation.
+# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D MultiPch + FILE_GUID =3D 0043A734-CB11-4274-B363-E165F958CB5F + MODULE_TYPE =3D PEIM + VERSION_STRING =3D 1.0 + ENTRY_POINT =3D MultiPchPeiEntryPoint + +# +# The following information is for reference only and not required by the = build tools. +# +# VALID_ARCHITECTURES =3D IA32 +# + +[Sources] + MultiPchPei.c + +[Packages] + MdePkg/MdePkg.dec + WhitleySiliconPkg/SiliconPkg.dec + +[LibraryClasses] + BaseLib + PeimEntryPoint + DebugLib + +[Ppis] + gPchIpInfoPpiGuid + +[Depex] + TRUE --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82402): https://edk2.groups.io/g/devel/message/82402 Mute This Topic: https://groups.io/mt/86457103/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 8 11:47:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82403+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82403+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1634698797; cv=none; d=zohomail.com; s=zohoarc; b=hBNSwub3aFuQdv9bPlQtpCPkYmWKQcCSnU4tdw/XzNPzdlOYx28K3y5GYFnEkFd2ikwlb9Xw6m7aMwS7qtbYjsMJmIzbJ7vSI/lDxjjF0XjpqVirbf0gUJh7/Ykzg06sZE1AklG7whkYjbwkcBhH08oKGdXb9bbIhozfxrlUZQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634698797; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=NAr9p3ZNmb4al+vbRkYSyPBVirQoWW9kElG2QClXrtU=; b=lTlDTvSdMpoSs84/ixTJZ1j7JErhLjLs+LGM8rYNSsjmz19QHz/MJlsCDqCcXXPYL5mhAPs31xY53H+0vxTc1aNZYM2uzuMhG45ULDWgMwlHm0ZWOrRd4S1DF0VtA7cx3YA9E3em4PjzHSZF7a9Kcn+h4AdSIUUAQlGlCP9d6HE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82403+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1634698797990164.64267014645202; Tue, 19 Oct 2021 19:59:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7NKDYY1788612xVNhj9uG6uy; Tue, 19 Oct 2021 19:59:57 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.3053.1634698796146740003 for ; Tue, 19 Oct 2021 19:59:56 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="314879209" X-IronPort-AV: E=Sophos;i="5.87,165,1631602800"; d="scan'208";a="314879209" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 19:59:55 -0700 X-IronPort-AV: E=Sophos;i="5.87,165,1631602800"; d="scan'208";a="494410166" X-Received: from iworam-desk.amr.corp.intel.com ([10.7.150.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 19:59:54 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/Build: Remove MultiPchPei PEIM binary use Date: Tue, 19 Oct 2021 19:59:51 -0700 Message-Id: <4dcda5e181330cbb427d8853bb54985591ece8aa.1634698531.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: fGVssQnPRJkDckq7c0RBsUlbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634698797; bh=xJsW3mWEvB/tEZTZe+5byvdvCaJAEgVldbzxaQrzxBM=; h=Cc:Date:From:Reply-To:Subject:To; b=hZDFf+x3MbW+VZYRYBnMCKmdBhxE8iELFt/c1ewg+MHq+FwheNM5mvb+L5/q3rnpln6 Qt1MrkPhpb/g9juTLnGcK2KTm3TvGV1/xVfwRXVXEtXt4GPj51pxjeLCel5JCInTeHmYi eX+ZLuLmlRi1PAz/DQd9mdUTUzRv4bh3KGM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634698799201100006 Content-Type: text/plain; charset="utf-8" Use the open source version of MultiPchPei PEIM. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 1 + Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc index b3e96ecf3f..9855e5fefd 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc @@ -687,6 +687,7 @@ =20 $(RP_PKG)/BiosInfo/BiosInfo.inf =20 + WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/MultiPchPei.inf UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf =20 UefiCpuPkg/CpuMpPei/CpuMpPei.inf diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf index 79fcf1e369..41d33f3f18 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf @@ -413,11 +413,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize = =3D 0x01000000 =20 INF WhitleyOpenBoardPkg/BiosInfo/BiosInfo.inf =20 - FILE PEIM =3D 0043A734-CB11-4274-B363-E165F958CB5F { - SECTION PEI_DEPEX =3D $(FSP_BIN_PKG)/UefiDrivers/$(FSP_BIN_DIR)/0043A7= 34-CB11-4274-B363-E165F958CB5FMultiPch.depex - SECTION Align =3D 32 PE32 =3D $(FSP_BIN_PKG)/UefiDrivers/$(FSP_BIN_DIR= )/0043A734-CB11-4274-B363-E165F958CB5FMultiPch.efi - SECTION UI =3D "MultiPch" - } + INF WhitleySiliconPkg/Pch/SouthClusterLbg/MultiPch/Pei/MultiPchPei.inf =20 FILE PEIM =3D ac4b7f1b-e057-47d3-b2b5-1137493c0f38 { SECTION PEI_DEPEX =3D $(FSP_BIN_PKG)/UefiDrivers/$(FSP_BIN_DIR)/ac4b7f= 1b-e057-47d3-b2b5-1137493c0f38DynamicSiLibrary.depex --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82403): https://edk2.groups.io/g/devel/message/82403 Mute This Topic: https://groups.io/mt/86457104/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-