[edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI

Ashish Singhal posted 2 patches 4 years, 5 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c |   2 +-
MdeModulePkg/Bus/Pci/XhciPei/DmaMem.c   | 128 ++++++++++++++++++++++++++++++++
MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c |  25 +------
MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.h  |  28 +++++++
4 files changed, 161 insertions(+), 22 deletions(-)
[edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI
Posted by Ashish Singhal 4 years, 5 months ago
This patch set is an attempt to fix the error where we allocate incorrectly
aligned memory for XHCI PEI and DXE. The change for DXE phase has been verified
already but change for PEI needs to be verified by Hao as I do not have a
setup to be able to verify that.

The change in DXE just updates a parameter passed in to allocate aligned memory.
The change in PEI adds a new function to allocate aligned memory. There was no
need to add separate function to free aligned pages as unaligned pages have been
already freed during allocation function and the aligned one can be freed using
the existing function.

Ashish Singhal (2):
  MdeModulePkg/XhciDxe: Fix Aligned Page Allocation
  MdeModulePkg/XhciPei: Fix Aligned Page Allocation

 MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c |   2 +-
 MdeModulePkg/Bus/Pci/XhciPei/DmaMem.c   | 128 ++++++++++++++++++++++++++++++++
 MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c |  25 +------
 MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.h  |  28 +++++++
 4 files changed, 161 insertions(+), 22 deletions(-)

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49023): https://edk2.groups.io/g/devel/message/49023
Mute This Topic: https://groups.io/mt/34547969/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI
Posted by Wu, Hao A 4 years, 5 months ago
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ashish Singhal
> Sent: Wednesday, October 16, 2019 1:21 AM
> To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; jbrasen@nvidia.com
> Cc: Ashish Singhal
> Subject: [edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI
> 
> This patch set is an attempt to fix the error where we allocate incorrectly
> aligned memory for XHCI PEI and DXE. The change for DXE phase has been
> verified
> already but change for PEI needs to be verified by Hao as I do not have a
> setup to be able to verify that.
> 
> The change in DXE just updates a parameter passed in to allocate aligned
> memory.
> The change in PEI adds a new function to allocate aligned memory. There was
> no
> need to add separate function to free aligned pages as unaligned pages have
> been
> already freed during allocation function and the aligned one can be freed
> using
> the existing function.
> 
> Ashish Singhal (2):
>   MdeModulePkg/XhciDxe: Fix Aligned Page Allocation
>   MdeModulePkg/XhciPei: Fix Aligned Page Allocation
> 
>  MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c |   2 +-
>  MdeModulePkg/Bus/Pci/XhciPei/DmaMem.c   | 128
> ++++++++++++++++++++++++++++++++
>  MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c |  25 +------
>  MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.h  |  28 +++++++
>  4 files changed, 161 insertions(+), 22 deletions(-)


Thanks for resolving the issues.
Series pushed via commits 0f28c513d3..2bbbdeeea2.

Best Regards,
Hao Wu


> 
> --
> 2.7.4
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49262): https://edk2.groups.io/g/devel/message/49262
Mute This Topic: https://groups.io/mt/34547969/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-