From nobody Mon Feb 9 08:50:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91744+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91744+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515608; cv=none; d=zohomail.com; s=zohoarc; b=kzno+mn8PHp94kmqeqItvao0+p8sYVc7hg+qj2dbl9v86W6Lu6lrgXdv7MpOdyd7tDsNRnj/WylR/dvIEEpRfeSrCTMP4iVTfJ0OdTVGBhO9UcMdIKyDuFd52Y53iYTq6YeX8IzYCkXzBPl34JD79lfQUPX4YiNETkV+51sfh0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=11pMF1g+T6QDzCVjD9cLFTWMAdmqHCTLw/VES8vzQS4=; b=AjwLb7DftNH9LmEEj6moej87gLdl244olr2MIKJX7WV4Bi7l6aye2ol6NCt1veSH51CDV6+/YusqO/uropLGIZeQ8SO4Q+8Sif3Fmd2PNbDGaptoA4i+oP2d7esdp3lu2dYTWrPmsttxlOVNVyrBPTlrxja/ySPf5UAj3qOzero= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91744+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515608357223.28545319501904; Fri, 22 Jul 2022 11:46:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YH08YY1788612xvln5NQzZfa; Fri, 22 Jul 2022 11:46:48 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.11533.1658515599883284865 for ; Fri, 22 Jul 2022 11:46:40 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138271" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138271" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767982" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:39 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH V1 09/13] SimicsOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:20 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: H9oWWSF1kRPBKXIdjkBAHooXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515608; bh=ohuNdoMtZwN2D5ex6R5WJ54GUF673WeEsuhM6FLfS9c=; h=Cc:Date:From:Reply-To:Subject:To; b=OrZRC5VH4VT9mYSHzI1qQHy6qokqAFDNgHtdNQyHqTqnZDdlO/qhV18VhO8Je2mi53c M81WK+XKKVHyA1KpjwY1lRtqteUMIAZD7LHQVXIuFpf6Ff0etCQ9xEzSxwRoQoMfPp5Ew faQ5J4C8IDECQmj/tWzX9m6F6EWWlElPu/I= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515609159100043 Content-Type: text/plain; charset="utf-8" Leverage common includes to reduce duplicated or low value code. Cc: Nate DeSimone Signed-off-by: Isaac Oram --- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 +++++-------------- 1 file changed, 12 insertions(+), 39 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPc= d.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index 44b6a81277..e2171dd376 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc @@ -42,42 +42,18 @@ ###################################### # Platform Configuration ###################################### - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 1 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 2 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 3 - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|TRUE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 4 - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE -!endif - -!if gMinPlatformPkgTokenSpaceGuid.PcdBootStage >=3D 5 - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|TRUE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE -!endif - -!if $(TARGET) =3D=3D DEBUG - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|TRUE -!else - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE -!endif + # + # MinPlatform common include for required feature PCD + # These PCD must be set before the core include files, CoreCommonLib, + # CorePeiLib, and CoreDxeLib. + # Optional MinPlatformPkg features should be enabled after this + # + !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc + + # + # Commonly used MinPlatform feature configuration logic that maps functi= onity to stage + # + !include BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc =20 ###################################### # Silicon Configuration @@ -212,9 +188,6 @@ ###################################### # Edk2 Configuration ###################################### -!if gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable =3D=3D TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 -!endif gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91744): https://edk2.groups.io/g/devel/message/91744 Mute This Topic: https://groups.io/mt/92554238/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-