From nobody Fri May 3 10:41:54 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+84826+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639504780147721.8628069266177; Tue, 14 Dec 2021 09:59:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id a0HcYY1788612x4etwDXLO1E; Tue, 14 Dec 2021 09:59:39 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.57]) by mx.groups.io with SMTP id smtpd.web11.29196.1639504778338216688 for ; Tue, 14 Dec 2021 09:59:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIt9TTPDL9NfJH+K6Umuf1cI9BzgXVSEIbnkT4AJpqKx1W5WJseVcZbdTi1sougFNqlM1th35km2qD/ho5X86li4sb2toeckXS95wzJSrfvilZVIgF3+IvA0lRzq6gKsHi+BPJSrxvnt1i2APGvNZruDWiA0paRIp5hgk/Mj5fhmLcv0x2aJt2V4alZbZFf+oHVKsZ0SBWOZvZ+pO55IS9pCyeOsMY1bYmyQ1Dx2eTaXlucxv4h120OnpTz6PNySdGgQLxSAoPTnNV3R9KLGJ2v3C2kXFzLxRNmuiX+jtEC6pB0Di/MNvK/GAhYEJ7eq7VM0zhQ7xaUQcr7iuy/u6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Dj2JDaGgVUEOxsldx/MlG4CJyvgzYLzZs5KXtapGag=; b=Xhy7C61MteG9GHlQkdSwW1E6vj6fkdn+bj68Rayx2HCg5AwdnXIbGfWm9stPBXWTbvv8lhbms4yZoe2H3dOLngwDjgYQC4pLobapbXO8WrfQUUQyM6b6WVBqwK3v8e+pHZuJgYOBI/70msAfVwQX3VpRZRISW+9CLeMfTa2mwI7I1sNSZ4b4VGsfDAJTH1pm09gPnnHqV/ZNvj2OijGxBWzBvhboGqLvbHDrXL3YCCmuJeKDOx4zFfLCkLgY3neSQHOeal54SYjqjP66husodGaVpD7jlhpIvu3Sw+JXT4pT4WU+xjKla77gESLB3AcCNXDuyf+5FE1LS928cahNLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 203.18.50.13) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN0PR04CA0171.namprd04.prod.outlook.com (2603:10b6:408:eb::26) by DM6PR12MB4012.namprd12.prod.outlook.com (2603:10b6:5:1cc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 17:59:32 +0000 X-Received: from BN8NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::8d) by BN0PR04CA0171.outlook.office365.com (2603:10b6:408:eb::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Tue, 14 Dec 2021 17:59:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 203.18.50.13) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+84826+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 203.18.50.13 as permitted sender) receiver=protection.outlook.com; client-ip=203.18.50.13; helo=mail.nvidia.com; X-Received: from mail.nvidia.com (203.18.50.13) by BN8NAM11FT038.mail.protection.outlook.com (10.13.176.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4778.13 via Frontend Transport; Tue, 14 Dec 2021 17:59:31 +0000 X-Received: from HQMAIL111.nvidia.com (172.20.187.18) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 14 Dec 2021 17:59:30 +0000 X-Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 14 Dec 2021 17:59:28 +0000 X-Received: from build-jbrasen-20211102T141553502.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 14 Dec 2021 09:59:28 -0800 From: "Jeff Brasen via groups.io" To: CC: , , Jeff Brasen Subject: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Date: Tue, 14 Dec 2021 17:59:20 +0000 Message-ID: X-NVConfidentiality: public MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2cee290-027e-4208-ac2c-08d9bf2b7b55 X-MS-TrafficTypeDiagnostic: DM6PR12MB4012:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: KTcwcwT5edrWO+5K2W2wXzxRtv7AkqjYh7rL5PpzT0yVJ2biOY9OQ/xR5oLzWdCsvv00fIxhMrIsMklxYeRUHQqvNwopErXgCGELS8IcVCSwPnfWvLnsKolk87ImVffEnbJuaFR8gxDgp1foLp3SH5/pJTiGJaNBsx0DDiT/4LKd/9O+h0aQXzKbZktgUq/TZVtoG0DXTGNJIAZsUMfCW7Ha4KERsAxgCWARceMCxWSqqs5RvaWzHZndsDypRbI3oDF8T3I8INz+AFIClEtMai0ocwsTtDXYeLFwxAlgWNgv1vJ9Hn7P9/wuGsqvTs1iC1c14y/p4cSrC9wNX4NQ8mEIzxE56RVgKeQ/wwBXVFFq5aGY6W7sqSxx9aArG3sbUhkazQ/ayG97c0LzGALP6Lm9OiVDO3UV1JU6VWyg6uIk50uixzHJSse8LesQYYQYYxd5hI1rD3peTgJlHDrD3cTCIJl43eHYd+mAL3CLJPsxnazZcEU59dLTexjq3C8jjGrffnX++OBTKqEJ7kVwHjVvB+9zbbfj+9NbiKNhoiAn8Quhwyak6ZhNPumMGvz3xmJZesNQTvgeuXnjmGaRt4s0HGaYbx3yxiQLRUOG+7an49cebz+mVN63P6a7IWpl2CEEJMM9FekrxajREHRrjsxSZ1ywyP+7RZmbHhSJhmDgGosczMFSSlZhHj9y2+mNs2KDh0PeQx5ZpZ+tNUTuCoGSmAz+rQSF+DhLhCuXo/Uijr2f2eatmH1CWajNJ6g0HgG1pD6UpVs59uVh+Hrx5eAKQwxZTkRohVYnTaxuIls= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 17:59:31.8503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2cee290-027e-4208-ac2c-08d9bf2b7b55 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[203.18.50.13];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4012 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: 82sICOw6rJL4esB756PZANy9x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639504779; bh=91mMm8l7BsrFOpyxu6S8hzQ1Vz1GI323s19eyfNEM4Q=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ryqUrqe+oUiTmc5UjxJ5663hgsPCZuoTsKSYI7IfwlI4GoDdOKlxGsQMeewtxcNeX22 w1PQHA/ocB363mOLgdBXD8+Lu/RtjfR13RpO9gProAd3rexYA5MorCfYipG97GIGuq/0W w8M2PLfjCUgWGrrnexch7BaeSA2O1gAPf90= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639504781367100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBACK. This allows services like variable services that run at TPL_NOTIFY to be hosted on ScsiDisks (i.e. UFS) Aligns with the eMMC driver that also uses a higher TPL. This change was made in 3b1d8241d0dac25c5e678c364fa2754ac1731060 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 22 ++++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bu= s/Scsi/ScsiDiskDxe/ScsiDisk.c index 98e84b4ea8..b6e5848e77 100644 --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c @@ -514,7 +514,7 @@ ScsiDiskReset ( SCSI_DISK_DEV *ScsiDiskDevice; EFI_STATUS Status; =20 - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); =20 ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); =20 @@ -581,7 +581,7 @@ ScsiDiskReadBlocks ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -733,7 +733,7 @@ ScsiDiskWriteBlocks ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -898,7 +898,7 @@ ScsiDiskResetEx ( SCSI_DISK_DEV *ScsiDiskDevice; EFI_STATUS Status; =20 - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); =20 ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); =20 @@ -975,7 +975,7 @@ ScsiDiskReadBlocksEx ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -1154,7 +1154,7 @@ ScsiDiskWriteBlocksEx ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -1323,7 +1323,7 @@ ScsiDiskFlushBlocksEx ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -1717,7 +1717,7 @@ ScsiDiskEraseBlocks ( EFI_TPL OldTpl; =20 MediaChange =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_ERASEBLK (This); =20 if (!IS_DEVICE_FIXED (ScsiDiskDevice)) { @@ -1907,7 +1907,7 @@ ScsiDiskReceiveData ( AlignedBuffer =3D NULL; MediaChange =3D FALSE; AlignedBufferAllocated =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -2122,7 +2122,7 @@ ScsiDiskSendData ( AlignedBuffer =3D NULL; MediaChange =3D FALSE; AlignedBufferAllocated =3D FALSE; - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); Media =3D ScsiDiskDevice->BlkIo.Media; =20 @@ -2294,7 +2294,7 @@ ScsiDiskDetectMedia ( =20 Status =3D gBS->CreateEvent ( EVT_TIMER, - TPL_CALLBACK, + TPL_NOTIFY, NULL, NULL, &TimeoutEvt --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84826): https://edk2.groups.io/g/devel/message/84826 Mute This Topic: https://groups.io/mt/87726872/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-