From nobody Sun Feb 8 06:05:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53757+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1580857334028784.8984963345804; Tue, 4 Feb 2020 15:02:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id II0dYY1788612xu0oEa6ZfHj; Tue, 04 Feb 2020 15:02:13 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.74]) by mx.groups.io with SMTP id smtpd.web12.1639.1580857332959241939 for ; Tue, 04 Feb 2020 15:02:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ua8PxTes1CmlxVLCQRzKG+SBLeaTpX10G0FgiRBTHAgkJTyhp3FgP80l+unRbttxGmFVfF769z59YQA3Gg4lbjwBA7lNa5Q7bnWmT8KdqX7X8Ef73WFn8WHfUOUrMrhvLyOMVkgCBhycvIlXEp2QVAVVEEAzxd+ESX4Nmw4FBePV8/EelgdC/DPifDfOCvBDtaAk6SzNS42fMoPweEegAlGta03vRVPeNNuMi7bg5Rp9oYVBXFGteWMT1OcGmUFuKb616vgW0xgQ5pDpcq4dQML2okdx/BzG0SAKNjOb3wVwYsvKclCziRvP3l2YSdw0PIXSvWRtWy97aTkOdUHGHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzzJ+NhxH1F8dICxlgldhHTtj0jLCpO97baZU/QqGHY=; b=CdM7kOpMW5Qpe3DkIwMEkSqp/SOXDeLMRyD0QhD2a8VK3wvrQyWe/OyCKj5kkXXzqoGoYEq5Hf6/1UprqcxGAUV1c01r1eO0vjuZ4uhT2sJ9qdxlpAFJ5WzyaDMC4NLjGYE0hCa0jSIQijUvDdJd5qXdsI/lIlcxG4Rrq2g6jM1AIn2VA+Pon6EY4ZIsNXwJozhRONoocChAAamQwxygIFsTAUp6h6dl/GOXlc+t1s5T55aRhnW+CulcSY6OxCgsebXCmx/1ZWA08zn5z498Dfh/SRR05tZqM/mRM8v0Hq9HNqLOi1deYXG/51tBJnefoxt3zkD/67eUoBJoDsE3Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com (20.179.71.154) by DM6PR12MB3930.namprd12.prod.outlook.com (10.255.174.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 23:02:11 +0000 X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270%7]) with mapi id 15.20.2707.020; Tue, 4 Feb 2020 23:02:11 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [edk2-devel] [PATCH v4 10/40] UefiCpuPkg/CpuExceptionHandler: Support string IO for IOIO_PROT NAE events Date: Tue, 4 Feb 2020 17:01:14 -0600 Message-Id: In-Reply-To: References: X-ClientProxiedBy: SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) MIME-Version: 1.0 X-Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.32 via Frontend Transport; Tue, 4 Feb 2020 23:02:10 +0000 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: da9f31f2-9f77-4f7d-15dc-08d7a9c64459 X-MS-TrafficTypeDiagnostic: DM6PR12MB3930:|DM6PR12MB3930: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53757+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: ajaPsPiVCOCV0DBwDAmUwDNbe5nEDWtFtah5USLXeVgvwE52AITlfZbZOrfypDYytIQdgXwPhhvPy8/x/3KaD84IoMNCF6hROkev4ZIUbsQjekIgjT5DSMdyXnPlUob9w/HF2gihRvbZ4Ahkq1K4KMUDM4UXsqlEw8xW5i3WC2c5tD73QS+6/93YMGjf7DPlI4keTnqJWwvadFQpLaCr7RvbCVlioC/S8bIk9JFd8IyCtWLoQBKiTjaj1HbjxMVHJbizMMqOukr3u3w6JO/fNVEzKczaaIlLuYVa66JAWNLQgox7qW3FAGwX3QbMokV03hWWzfKzG1KyTRQL3KA5Eg/V2ZxEKxtco+QEXufs69CF1Uhi5j2PDmqdxmp0PC2RqR3BUAJhlb0IPKNTxnPEbbWDCvwRUISOOt2EBqdk78rdeeWmkcp0kQmuvuT4xTaJEFiAD3niHVZmAKoAdphrqoRBKWXl0+mJKQr3Orl33/lHOfTXZzIUSTlhoNraZi8Fpqug2ASyctpMiBhqUfxkkQ== X-MS-Exchange-AntiSpam-MessageData: ISlX2h8OBvcs51FmITEqhSCyRLP9TJ0eyld8VJBbGyfxzN/ky30ZccOEplHka/PeBVdXwN+e0Rgsd0m647UUky9Au756ww7ulzxCe9kubvSHsvXS2RK6hQunfVkZkpY3j4JpxkvT8sJLSWJqbfJSEw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: da9f31f2-9f77-4f7d-15dc-08d7a9c64459 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2020 23:02:11.3820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rp3ElMO1AFBcuf8OZ6Xv6bZ00uiNvgDmSF6INeK6ZdryobXzVXy4U1zMXocuvT13ryiKJr7Uvfl7HuWHyoYgEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3930 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: 8ttg00qZmn9YcjlIJKA1RNzIx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1580857333; bh=9V9F06rDLXNtESZZ7Gxk59olQLVdy1NG1yEWfQsuxBs=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=oT1xr7iU2bQYth5FsNluvez8dvmRecUopkfWza3xDhPLBtq1uuSdK1cfadn/FCCYePk VuabNsul5THcixSRWWfPNREiuGsbutK7a+TXsZ7sXbrrVm4TOWgpDlZ6xrgi4Nqqh+Alz Cf3i7qAKXIuJQ1JB4+2d7ATk8tZxTArSWt4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 Add support to the #VC exception handler to handle string IO. This requires expanding the IO instruction parsing to recognize string based IO instructions as well as preparing an un-encrypted buffer to be used to transfer (either to or from the guest) the string contents for the IO operation. The SW_EXITINFO2 and SW_SCRATCH fields of the GHCB are set appropriately for the operation. Multiple VMGEXIT invocations may be needed to complete the string IO operation. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AMDSevVcCommon.c | 78 ++++++++++++++++--- 1 file changed, 68 insertions(+), 10 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c= b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c index 48eb5c2358ed..49609c5ef22f 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/AMDSevVcCommon.c @@ -321,6 +321,22 @@ IoioExitInfo ( UINT64 ExitInfo =3D 0; =20 switch (*(InstructionData->OpCodes)) { + // INS opcodes + case 0x6C: + case 0x6D: + ExitInfo |=3D IOIO_TYPE_INS; + ExitInfo |=3D IOIO_SEG_ES; + ExitInfo |=3D ((Regs->Rdx & 0xffff) << 16); + break; + + // OUTS opcodes + case 0x6E: + case 0x6F: + ExitInfo |=3D IOIO_TYPE_OUTS; + ExitInfo |=3D IOIO_SEG_DS; + ExitInfo |=3D ((Regs->Rdx & 0xffff) << 16); + break; + // IN immediate opcodes case 0xE4: case 0xE5: @@ -358,6 +374,8 @@ IoioExitInfo ( } =20 switch (*(InstructionData->OpCodes)) { + case 0x6C: + case 0x6E: case 0xE4: case 0xE6: case 0xEC: @@ -404,7 +422,8 @@ IoioExit ( SEV_ES_INSTRUCTION_DATA *InstructionData ) { - UINT64 ExitInfo1, Status; + UINT64 ExitInfo1, ExitInfo2, Status; + BOOLEAN String; =20 ExitInfo1 =3D IoioExitInfo (Regs, InstructionData); if (!ExitInfo1) { @@ -421,16 +440,55 @@ IoioExit ( Ghcb->SaveArea.Rax =3D Regs->Rax; GhcbSetRegValid (Ghcb, GhcbRax); =20 - Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, 0); - if (Status) { - return Status; - } - - if (ExitInfo1 & IOIO_TYPE_IN) { - if (!GhcbIsRegValid (Ghcb, GhcbRax)) { - return UnsupportedExit (Ghcb, Regs, InstructionData); + String =3D (ExitInfo1 & IOIO_TYPE_STR) ? TRUE : FALSE; + if (String) { + UINTN IoBytes, VmgExitBytes; + UINTN GhcbCount, OpCount; + + Status =3D 0; + + IoBytes =3D (ExitInfo1 >> 4) & 0x7; + GhcbCount =3D sizeof (Ghcb->SharedBuffer) / IoBytes; + + OpCount =3D (ExitInfo1 & IOIO_REP) ? Regs->Rcx : 1; + while (OpCount) { + ExitInfo2 =3D MIN (OpCount, GhcbCount); + VmgExitBytes =3D ExitInfo2 * IoBytes; + + if (!(ExitInfo1 & IOIO_TYPE_IN)) { + CopyMem (Ghcb->SharedBuffer, (VOID *) Regs->Rsi, VmgExitBytes); + Regs->Rsi +=3D VmgExitBytes; + } + + Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, ExitInfo2); + if (Status) { + return Status; + } + + if (ExitInfo1 & IOIO_TYPE_IN) { + CopyMem ((VOID *) Regs->Rdi, Ghcb->SharedBuffer, VmgExitBytes); + Regs->Rdi +=3D VmgExitBytes; + } + + if (ExitInfo1 & IOIO_REP) { + Regs->Rcx -=3D ExitInfo2; + } + + OpCount -=3D ExitInfo2; + } + } else { + Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, 0); + if (Status) { + return Status; + } + + if (ExitInfo1 & IOIO_TYPE_IN) { + if (!GhcbIsRegValid (Ghcb, GhcbRax)) { + return UnsupportedExit (Ghcb, Regs, InstructionData); + } + Regs->Rax =3D Ghcb->SaveArea.Rax; } - Regs->Rax =3D Ghcb->SaveArea.Rax; } =20 return 0; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53757): https://edk2.groups.io/g/devel/message/53757 Mute This Topic: https://groups.io/mt/70984931/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-