From nobody Sat May 18 14:10:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+74878+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+74878+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=amd.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1620656718355601.4230173319424; Mon, 10 May 2021 07:25:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JKQtYY1788612xSHoxAT53SF; Mon, 10 May 2021 07:25:16 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.52]) by mx.groups.io with SMTP id smtpd.web11.32321.1620656710806583014 for ; Mon, 10 May 2021 07:25:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mITBCihzCn6Z8Eyw6GJVnDWfUXdW+2h60i9A1fsGrw95n5N/5iq9xKFMclcvtDCXuuEp0N/Klm7goervLUYjfgLK3CE9G/8AFvcDop716nKrPswCV51i0syTA2pqRmUhUnBtCIIDJwYC6WmXfhTMBlfZ06Gkcl3XcfzRZW2feR4eSkAZuhIAKH/iLn2uTtcr13Rj+DYjyeI4eXgMGFjlvYfH0vyw4sWCGx5DpbvQCZlnxTPrK8O7nRG3VD/w0RPDEyB2InqdzonQG4gl8egedoh6rjs+qbdf9FOIbFyL4UQeiXQuphAXIOzugAx591tQ6LY4WbICA9Yb05MRbospsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nwzn+FKc8R1xR24Oto5YxsW8NXVK9DuoQRXJNT7fozI=; b=GgN2xiS80QB66ZDGsuSny7EXdDTulf9yxZ6h8oF4Z7OfJ82UjdAePIlRoW7JP2E8NfMc89Zzk6Ox7rEAtS3IJOewzruA3LbAss/tjcSk6kolqjxDdPAKTQIIKGT5qA8LTbwi8JNAoAaAaSZDMsAlV0ICOCGRGbmn9pgetgOuricRzP23h1E3nNChzIl9XWDoB7MDY/bXEDrciSXS1t0Xnt1rPQenhIGZsfAPwg070tybJH8vdZ3rEOm5+Anc712ARYyLPxmuPey7+4CyYSeuTD4avNMBBIm1MDhoO7rOYED1sX3Xd988SzRRvVIV1M/1NH69zHfccQg/RQU/7lLkyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR1201MB0123.namprd12.prod.outlook.com (2603:10b6:4:50::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 14:25:07 +0000 X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9%12]) with mapi id 15.20.4108.031; Mon, 10 May 2021 14:25:06 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Eric Dong , Ray Ni , Laszlo Ersek , Rahul Kumar Subject: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Properly cast from PCD to SEV-ES jump table pointer Date: Mon, 10 May 2021 09:24:55 -0500 Message-ID: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0601CA0017.namprd06.prod.outlook.com (2603:10b6:803:2f::27) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from tlendack-t1.amd.com (165.204.77.1) by SN4PR0601CA0017.namprd06.prod.outlook.com (2603:10b6:803:2f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 14:25:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d23e2da7-89b8-4864-8aec-08d913bf68b5 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0123: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: qh6uw3x2IIxedyLwtZz2C4jqfNU6EuOQOVBNiIUEHoyYFP1HD/6AIzMpdSm1nkkrQlp52HlBQtdLaoNaGLNEKYLz2uBtIV0j5vJDYWgAFiYkQjLTfWXCgx6JzzzqS7gzz1BOnz7BIfIQmY69T7BEjcJOxX4YDuTl8yPQnBooqZiXwSoJB44ISnDnaKH5GtoD79QCqudYrUBBAuCNREZZCO+GDTYroqfPM8duA85b5pRZmfqxc85IPaAoh2OWadczC94p/chW/OXq8IFqAGuZnWeszoGRudiA5mkSTq9xoqqqgqpFLzozBr4G0lNyDN2UT6Sw4mnCAIh1834hMkWgE0DVOWVJwW3Wz52d2ORGfcQaf2Reiu47PxvqycCbHWXkHr65JyIRV0cQ1JhBL5TvKDB8NOwj1CkjNxk2RQR4hcbSsUb61SOEeAovGNBSdQNIi+7jp/bXYQNS8k8JqGVH/Q1F+kw9J06K0qZnTMxLnUhUj3IoYOzKuB5DXUtWBC/kaFHzzZpB1FlvQpQLeqbjRmu0OPUmByd3YTam5MpUiSG5Y0jbm1X6oI06tvKJCS9zjYazpQwsPl81orzWGMidADJzH1C8YLd4yR5sRGarXvldG1ZbVwYnkxXpHfHrtLobhE/aXzAHAoEPzgxpU62HrR4On5D1YgmLXrb1M/XrKBcaqxZRE2z3Bylvna81DK+dgH2Vp3z3Km6qQ5B1FdmoZG/at45O47Ew7LSuW1LI1+w= X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?AC5lECpsa3qGuRfe6gHurfsfwu1i7nnm++4v5cygrF9uPD74bniHRxzXSXPo?= =?us-ascii?Q?gP2matY8FQSa9yAT3b7DNJKDVogsm3ST63gLlGs2Njt2jPog9F4vjQyBMAA5?= =?us-ascii?Q?q0EPjeQ5QpjFKcB7zI7HD9CSHursiamkLtDrE4cb9Sm6+PkEM5aSw4SxLhNp?= =?us-ascii?Q?KVanUrnsqtBpwl9qpgnxq70XFVdbNrHF7TedfgIS1czDK4oVijzUFMqFWDGK?= =?us-ascii?Q?iLt/H7SI3gAAxWorx3IdsEWJ6WJXT7trRs3JftuU7KN+pIXLihSRYArmR1Gd?= =?us-ascii?Q?T03ic7tbf6GlaQ+bKQMjHFNLkG8H46TX9dbAFRiW/NCE3VsTPJ8Ukk5W1LUM?= =?us-ascii?Q?Qw5E3vx5STO9DHuDPXRTEJ+dlVl3PH7FKuL0JltqHxXbC9B9RV7IhoB7Aouj?= =?us-ascii?Q?3XKFPWrDED61eDVpEP75CXCZI0sjIgJt2Ru9dtgMVO1QsGIA8YfqqKV7arpj?= =?us-ascii?Q?6h8uFPFX9EXjJ5IZvrtkpD6LfMc38rCv5BKobmKtCgon2UYwq7RcYq5W9C0R?= =?us-ascii?Q?mk9XDDhMEeHClZhad3/slftZN4YL7fD2iCB92szaDYAUx7DWnAmy/G6FJjOP?= =?us-ascii?Q?lI8RnPJmofBVoR9LJMqP5DjslzRurQYMDwVu04oAlE00nMYhBJMwBup+q7s9?= =?us-ascii?Q?g7mLyKDHBfgx6+cWI4mcNfTRxHVP1mkzX+krrarJ4BghvZGa7xbslYAh4z/Q?= =?us-ascii?Q?aJ4CGnEkGmedH8L2KD98xPFD3DWroO96j3AxkMAGLj5WAK74mYthLFW7FMx8?= =?us-ascii?Q?Bjww1sIaj9Ms8yZD4HIN2zCxIryeLdKpMtLJQjvz+1X1EeODwbbYsUqmZx5F?= =?us-ascii?Q?1ooHFT8EM4pMrASYr458b2ZPuB0HWvn73I8J6Rj++5z50GbxWQVzew1JONRO?= =?us-ascii?Q?LQVoLoUxEtmJNWnpkxP8wPFV78DSv5Nhapap3RO8NhlEsNT3ARjMo8eJHoLu?= =?us-ascii?Q?rAERKriLq8WZbai+uhC9qlKWJcpL5YPd/WZEVzuWwKe1OZ2NwgkYhvlYKN6S?= =?us-ascii?Q?tySlKt6meJW/G65XShTcqce7TNO1xPTfhXtddlpBzGPJ/+U1iMTRrfEXU1SX?= =?us-ascii?Q?CL64ZoaVnRJijHZCDD4HR/acxb2MgZjn6lOTW2gJFytkppbUrYn9rDnIQYIT?= =?us-ascii?Q?iWxbaXG2uIEQxexD7FwNPpyrqqhPYsGx1YeyQdtS1TY33ukFHXTvjDFTrE7O?= =?us-ascii?Q?Vwjx64dzsOUbRinuAcZ/kszdAM5f++lTihrQ0fSwFUsI+y1hK+c35kSRbBvN?= =?us-ascii?Q?Il21QOjm8dc/VK7ugNKxGMHq8LmYcuKSRcGOaIdZ31kVb1mjehea/7MxAMV7?= =?us-ascii?Q?Hc4VFnUQBGSPPIyMQTZ83eiS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d23e2da7-89b8-4864-8aec-08d913bf68b5 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 14:25:06.8254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GR5P7Uj+YnmEZ2QP5I/YQv1ARMC0wkEaMCDt8FHFOuAQGs/k0Nn+hifiYXIS/0n4xX53mbYUu/aG46WVAzcL0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0123 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: MpcTHW0NbogTHZqAMmgDq0gnx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1620656716; bh=tD9BhbPbc4pp0KHaCK/lOu3Aa55QN2SeZqv9sfYSaH0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=EZRUgjt0U8Me62J7Sv0+dN9+ktC0bj9LRBfuZxzBREDXlwFpr9vCeWzilTi+SYPcTAN CRW8dNqJQX6WdQQCVQMcy0MKt+3KdnYFxzQljpEDgT9uUapS57umw08aKyW2eOiN53EhZ djO5y/0jrzYX5qTabAXPkXz0l3fXRJNjpqM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3385 A VS2012 build fails with a cast conversion warning when the SEV-ES work area PCD is cast as a pointer to the SEV_ES_AP_JMP_FAR type. When casting from a PCD value to a pointer, the cast should first be done to a UINTN and then to the pointer. Update the code to perform a cast to a UINTN before casting to a pointer to the SEV_ES_AP_JMP_FAR type. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Tom Lendacky Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao Reviewed-by: just yet. Look for a new version soon. --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 3d945972a025..dc2a54aa31e8 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1265,7 +1265,7 @@ SetSevEsJumpTable ( UINT32 Offset, InsnByte; UINT8 LoNib, HiNib; =20 - JmpFar =3D (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 (PcdSevEsWorkAreaBase); + JmpFar =3D (SEV_ES_AP_JMP_FAR *) (UINTN) FixedPcdGet32 (PcdSevEsWorkArea= Base); ASSERT (JmpFar !=3D NULL); =20 // --=20 2.31.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74878): https://edk2.groups.io/g/devel/message/74878 Mute This Topic: https://groups.io/mt/82721039/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-