From nobody Mon Feb 9 15:46:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59703+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59703+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1589579038; cv=none; d=zohomail.com; s=zohoarc; b=TWiXFsRQ6bTG2tAjjPBWnREux1HLkX4Gi0wH0q7cU/NAwbUoC/YijbS+LRUGte2aI0xRAhHpViUBWv/QIj5D0NWvl0cIrnMNqSfmQhGEPqai/sikseIOOQ+dlehudHBxTfxP4va2d9GsyMPtdDyo0fa0ya828T2XzqQd7+od9tA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589579038; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=47DJiJpX0PHXsQKcO5skx3I4YiYszEer+Sbz/AiPE/4=; b=nexs9WLKajV3ioF6W5cJw4SYP+XjO4RaDt/s8I+75xSmsERCtMrc6/JGPI2D/D46j7/ZCuhiGWtzh7JShqDgLJU+IwXz8abyg1jrjglwPKou8o7j5J8K1MSOgXfjWI6UnqyeDznjKnpKRfAm7oHghcBC+0T8nqLTN6cd1TDN7jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59703+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1589579038924776.6746055233502; Fri, 15 May 2020 14:43:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id lcI1YY1788612xIstzMfgx3C; Fri, 15 May 2020 14:43:58 -0700 X-Received: from mga09.intel.com (mga09.intel.com []) by mx.groups.io with SMTP id smtpd.web11.1467.1589579035519069832 for ; Fri, 15 May 2020 14:43:58 -0700 IronPort-SDR: nGy2oOvdrz/aHJMvprDPtXVrNFGpmZkQ8W//B40OEotPhMrj8mY+3IcxIRipv+35Y1mDqLTFyP Phm7+tmzGVsQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 14:43:57 -0700 IronPort-SDR: OZdo0pp6/9CngCg+NNcE752n7vf0/SxFwYsLmzcATy3n0xs6e/DIwVqnJl7TAPovhcB5ULhotp vvp7VoI14DUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,396,1583222400"; d="scan'208";a="410599853" X-Received: from ecbjorge-mobl1.amr.corp.intel.com ([10.212.5.228]) by orsmga004.jf.intel.com with ESMTP; 15 May 2020 14:43:57 -0700 From: "Bjorge, Erik C" To: devel@edk2.groups.io Cc: Ashley E Desimone , Nate DeSimone , Puja Pandya , Bret Barkelew , Prince Agyeman Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Fixed use of incorrect variable names Date: Fri, 15 May 2020 14:43:30 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,erik.c.bjorge@intel.com X-Gm-Message-State: QUEW8IlCSnDTChErc8sSoTWTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589579038; bh=GinXGTdHp0GotmzryUx94btd/jJK8ehgNEyAzKFxO6E=; h=Cc:Date:From:Reply-To:Subject:To; b=pPDjyBGtdfeA/1SXIH3HQPijc0zLJSK8nYdV7+vUtz3eVUzcfS+rSwlEWntF+Yh/3pI zqj56rs3rnEeu2PkcZ9A7p8trkh0eNpa5V7Tr5+h/IBYv8K/E7Kzpd7EpcXRzVNh9F4B/ OopnLO8zDtg8P5jPdwH6XSWuM/0vtOuwu0o= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Fixed two small issues. - Fixed current combo not being updated in local data. - Fixed use of name mangled (private) variable. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge --- edkrepo_manifest_parser/edk_manifest.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/edkrepo_manifest_parser/edk_manifest.py b/edkrepo_manifest_par= ser/edk_manifest.py index 480cd3f..02d4620 100644 --- a/edkrepo_manifest_parser/edk_manifest.py +++ b/edkrepo_manifest_parser/edk_manifest.py @@ -434,7 +434,7 @@ class ManifestXml(BaseXmlHelper): =20 element.attrib['combination'] =3D combo_name self._tree.write(filename) - self._general_config.current_combo =3D combo_name + self._general_config.curr_combo =3D combo_name =20 def write_source_manifest_repo(self, manifest_repo, filename=3DNone): ''' @@ -453,7 +453,7 @@ class ManifestXml(BaseXmlHelper): element.tail =3D '\n' element.attrib['manifest_repo'] =3D manifest_repo self._tree.write(filename) - self.__general_config.source_manifest_repo =3D manifest_repo + self._general_config.source_manifest_repo =3D manifest_repo =20 def generate_pin_xml(self, description, combo_name, repo_source_list, = filename=3DNone): =20 @@ -1070,6 +1070,7 @@ def main(): =20 print('\nAttempting to write TESTCOMBO to current combo field = of TestManifest.xml') test_manifest.write_current_combo('TESTCOMBO', 'TestManifest.x= ml') + print('Updated current combo: {}'.format(test_manifest.general= _config.current_combo)) =20 print(separator_string) if test_manifest.is_pin_file(): --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59703): https://edk2.groups.io/g/devel/message/59703 Mute This Topic: https://groups.io/mt/74237841/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-