From nobody Tue Apr 30 16:47:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53391+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53391+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; t=1579499079; cv=none; d=zohomail.com; s=zohoarc; b=iPN6bVA8uBRcKeLo8tC4fr95Fcq9yx0IYrcBQyelwDs8qp24yUqv8vrSVwlLmezwILjPA+eOaDY6c5uDlJouS/cyknYBtEmg1lknp2de5D2M0LIkA0NCqQbIHi3UiH2HjMWdSPtqwFSCvhiFF1Yj/JbhnG9ay8J+XZ+Es2v1ahY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579499079; h=Content-Type:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Dfi629y1ePGQciFpn0zk8z2nkV0JH2iC1MPxr9vFfAc=; b=MCERxkZf0p6dolAsCOHncm0AOiuHYh9KlhNFLiyj0yjJUovSyV2TH4Rxb5x1uTPblocGfuOtnNlMWiIGU0eWKRAtFeSMlmM8cu4WTWJYuN9IaHmLtJP7RzkS07Z+usMlptd1/wphfCOY4I0O+Y/A87Swn3qMtWONqMYx7DiBewI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53391+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 157949907974756.578201370940405; Sun, 19 Jan 2020 21:44:39 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id vBiRYY1788612xfpH8CDbyxH; Sun, 19 Jan 2020 21:44:39 -0800 X-Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web12.6950.1579499078729314725 for ; Sun, 19 Jan 2020 21:44:38 -0800 X-Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 19 Jan 2020 21:44:23 -0800 X-Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 19 Jan 2020 21:44:37 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 19 Jan 2020 21:44:37 -0800 X-Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 20 Jan 2020 05:44:37 +0000 X-Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 20 Jan 2020 05:44:37 +0000 X-Received: from ashishsingha-lnx.nvidia.com (Not Verified[10.28.48.147]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Sun, 19 Jan 2020 21:44:37 -0800 From: "Ashish Singhal" To: , , CC: Ashish Singhal Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Date: Sun, 19 Jan 2020 22:44:34 -0700 Message-ID: X-NVConfidentiality: public MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com X-Gm-Message-State: UcjaDWJ4C9v2saEqp81VrKRCx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1579499079; bh=Yg6bA20CsOFuoPNc4v3/hftyv8hZZ/AS/omanYIdJjE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=wWW8rYtQc7CUgsea2nxEzHnI/RJpOed7rHhlC/L2ruGfoh/iaMTDI3ds8/IKbiXc3T4 FNgWHA5D88fCmdzdrEqjgKU26J34Uvnl31bf/e0zRuiiU0cLpaDX2nJPsJA8yRD6lTM/7 jp/MfdUIUciWdpScL19T68WlFl+vx27uiu8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" FADT parser was checking for reduced ACPI flag incorrectly leading to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both 0. Signed-off-by: Ashish Singhal Reviewed-by: Zhichao Gao --- .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fadt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa= rser.c index 5b8cc174f1..8acfbac3b1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c @@ -253,7 +253,7 @@ ParseAcpiFadt ( // present. if ((Trace) && (Flags !=3D NULL) && - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D EFI_ACPI_6_3_HW_REDU= CED_ACPI)) { IncrementErrorCount (); Print (L"ERROR: No FACS table found, " L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n"); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53391): https://edk2.groups.io/g/devel/message/53391 Mute This Topic: https://groups.io/mt/69926879/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-