From nobody Mon Feb 9 12:29:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91737+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91737+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658515604; cv=none; d=zohomail.com; s=zohoarc; b=ErRLTd40AbuEG4VJ96/wu1LOhpa4sZDr2TK5uP4iZuYGB0xFvaRO0N6fH24uN7Bf72D1RM/MdRFnvwyD4DS/aOINSst3DRrxTIxMysOPO/Qs6601XyTrCPZW0wxlA9X8hUvYl/qQEMuL0x4a45BEBRwsxh6zpz+V2PDE3a+S1eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658515604; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FR6laVPVKRkHG44FAW2vdVA6PBl0BpliDGICA1jCoxY=; b=MCV/xkIhE3xWplaslrElkhJfXs8B6Oeuqq6pncPdvQp8gnvqBrAGkHfRdXjSSR/cW/FU64/j1BPyi9tYyIIcZRFfFhvpKruuCooGaVeoCRD5B5OOwQhO5/FJgr7Um+TzX6DKcNp9tjE0K3zzXUCnvwXDG95roA+pFKvq8OFR57s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91737+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658515604457668.4404774539486; Fri, 22 Jul 2022 11:46:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Vg3jYY1788612xk1qkJGG0Kc; Fri, 22 Jul 2022 11:46:44 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:39 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138262" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138262" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767966" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:38 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Chasel Chiu Subject: [edk2-devel][edk2-platforms][PATCH V1 04/13] WhitleyOpenBoardPkg/Build: Reduce unnecessary code Date: Fri, 22 Jul 2022 11:46:15 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: LaKP8HlBY04gbNupIRaTTimfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658515604; bh=ljQuOfhIA24728GNKjIFj1IxQn9b0AwKsQmvZmz2b1w=; h=Cc:Date:From:Reply-To:Subject:To; b=WQIcKkqt4xc1WhavInCR/4bBiFxnwlSG/wUdGQ/+ry4HNDt6dPH7WNKIC5eP3pZul5b zdarfaqA8PVkhhnHxhqEhbZygJA6J0ks08naRUV7ddhrcanCluzO8gTCsawK0H7OmHXv3 lJDnCqouB716Uzwk8PBKQNrHDAeN/D2MAww= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658515605167100011 Content-Type: text/plain; charset="utf-8" Use MinPlatformFeaturesPcd.dsc.inc to initialize feature PCD Move individual feature enabling examples to BoardPortTemplate Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Aowanda/PlatformPkg.dsc | 3 -- .../BoardPortTemplate/PlatformPkg.dsc | 50 ++++++++++++++++++ .../JunctionCity/PlatformPkg.dsc | 3 -- .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 51 ------------------- 4 files changed, 50 insertions(+), 57 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc b/P= latform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc index 63648172da..8761f8b56a 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc @@ -26,9 +26,6 @@ !if $(gMinPlatformPkgTokenSpaceGuid.PcdBootStage) >=3D 5 gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |TRUE gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |TRUE -!else - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE !endif =20 !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git a/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformP= kg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.d= sc index e3e8ceb7ce..9bf5d02a3d 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/BoardPortTemplate/PlatformPkg.dsc @@ -15,6 +15,56 @@ =20 !include $(RP_PKG)/PlatformPkg.dsc =20 +# +# Feature enable/disable flags +# +[PcdsFeatureFlag] + # + # MinPlatform control flags + # + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |TRUE + + # + # Debugging features + # + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |FALSE + gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable = |FALSE + gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEnable = |FALSE + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |FALSE + + # + # Network features + # + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |FALSE + + # + # OutOfBandManagement features + # + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |FALSE + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable = |FALSE + + # + # PowerManagement features + # + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE + + # + # SystemInformation features + # + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |FALSE + + # + # UserInterface features + # + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable = |FALSE + gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE + gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEnable= |FALSE + +!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc + [Defines] DEFINE BOARD_NAME =3D BoardPortTemplate PLATFORM_GUID =3D f3518dd4-5dec-4d2c-9ac9-561121e2= 628b diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.ds= c b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc index 8cedbaccee..8e226c1552 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc @@ -26,9 +26,6 @@ !if $(gMinPlatformPkgTokenSpaceGuid.PcdBootStage) >=3D 5 gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |TRUE gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |TRUE -!else - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE !endif =20 !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc b/Platform/= Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc index 5b5d84779e..0ff9c00b94 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc @@ -59,57 +59,6 @@ [PcdsFixedAtBuild] gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 =20 -# -# Feature enable/disable flags -# -[PcdsFeatureFlag] - # - # MinPlatform control flags - # - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly = |FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |TRUE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |TRUE - - # - # Debugging features - # - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |FALSE - gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable = |FALSE - gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEnable = |FALSE - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |FALSE - - # - # Network features - # - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |FALSE - - # - # OutOfBandManagement features - # - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |FALSE - gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable = |FALSE - - # - # PowerManagement features - # - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE - - # - # SystemInformation features - # - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |FALSE - - # - # UserInterface features - # - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable = |FALSE - gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE - gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEnable= |FALSE - -!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc - # # Platform On/Off features are defined here # --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91737): https://edk2.groups.io/g/devel/message/91737 Mute This Topic: https://groups.io/mt/92554230/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-