From nobody Fri Apr 19 16:39:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93832+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93832+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1663249197; cv=none; d=zohomail.com; s=zohoarc; b=degSYReGz5zF3NawDk6f3zU6mNKjUegV3FbL/4HZKAq6xnB4Wm550E02nPBjFWZXpYHpYIp4SNH/a+EUCUTTLLb7RhBYUpe09CWraSB9tI8NBhlj5+ielkCRoDIHzfKUCk29DMK43wtXEyv4zdlwtubWe916kGhQ9TKHO9/P1i8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663249197; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=BjtYUHraKlbDzxZ/MPagNbfXSDUZmEL/HUQgpnJq6vM=; b=AIzGtecVCZaqd8hqCgW2vXdPv8GgvkApSFvskQxn3cJkC7qlYy8EFIva8hAk37RxOUBwb61LEM1mzO/tC8FNcMaJdioDjq9q9TK4bKB3ufO7lRU3fOGBIOTaG3AHyw+xMlxnGH7xxDrMLGhtQTxePAzXlStXi3vkb2XzIt91d2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93832+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166324919726040.19718315311104; Thu, 15 Sep 2022 06:39:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7Jj6YY1788612xLvQmuwvQuJ; Thu, 15 Sep 2022 06:39:55 -0700 X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.10156.1663249195170107289 for ; Thu, 15 Sep 2022 06:39:55 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="285754167" X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="285754167" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 06:39:54 -0700 X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="650476789" X-Received: from tedkuo1-win10.gar.corp.intel.com ([10.5.215.13]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 06:39:53 -0700 From: "Kuo, Ted" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng , Ashraf Ali S , Chinni B Duggapu Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Date: Thu, 15 Sep 2022 21:39:33 +0800 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ted.kuo@intel.com X-Gm-Message-State: 5fR8jo2lyz8fIvej84en1geJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663249195; bh=kETbfzNMoj2cNzDM65TrA/+CIHJRSQMwflojs34+xa8=; h=Cc:Date:From:Reply-To:Subject:To; b=sAft4Gs9QmeB3bBvO3agmZPyiJi/DwD+k6uihBLhSWDTQIyHB4jkIn8Q+dZIVg1Nc19 ab7IZcydnLkexfKvnzs2vRuYiCLjuOPeTb429KU6H3EIKpYbzz8cTam01QMVwFiKUhCXq Q/c08j3J2sbfCM8nu5BQtRzxFAMf9SByJy8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663249197486100001 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4063 Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm to align with FSP 2.4 SPEC. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Chinni B Duggapu Signed-off-by: Ted Kuo Reviewed-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm b/IntelFsp2Pk= g/FspSecCore/Ia32/Fsp24ApiEntryM.nasm index 997b9c0bff..15f8ecea83 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24 .Revision: resb 1 .Reserved: resb 3 .Length resd 1 + .NvsBufferPtr resq 1 .StackBase: resq 1 .StackSize: resq 1 .BootLoaderTolumSize: resd 1 .BootMode: resd 1 .FspEventHandler resq 1 - .Reserved1: resb 24 + .Reserved1: resb 16 ; } .size: endstruc diff --git a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm b/IntelFsp2Pkg= /FspSecCore/X64/Fsp24ApiEntryM.nasm index 8880721f29..a3b38e4585 100644 --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24 .Revision: resb 1 .Reserved: resb 3 .Length resd 1 + .NvsBufferPtr resq 1 .StackBase: resq 1 .StackSize: resq 1 .BootLoaderTolumSize: resd 1 .BootMode: resd 1 .FspEventHandler resq 1 - .Reserved1: resb 24 + .Reserved1: resb 16 ; } .size: endstruc --=20 2.35.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93832): https://edk2.groups.io/g/devel/message/93832 Mute This Topic: https://groups.io/mt/93699989/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-