IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063
Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm to
align with FSP 2.4 SPEC.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com>
Signed-off-by: Ted Kuo <ted.kuo@intel.com>
---
IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++-
IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
index 997b9c0bff..15f8ecea83 100644
--- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
+++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
@@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24
.Revision: resb 1
.Reserved: resb 3
.Length resd 1
+ .NvsBufferPtr resq 1
.StackBase: resq 1
.StackSize: resq 1
.BootLoaderTolumSize: resd 1
.BootMode: resd 1
.FspEventHandler resq 1
- .Reserved1: resb 24
+ .Reserved1: resb 16
; }
.size:
endstruc
diff --git a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
index 8880721f29..a3b38e4585 100644
--- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
+++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
@@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24
.Revision: resb 1
.Reserved: resb 3
.Length resd 1
+ .NvsBufferPtr resq 1
.StackBase: resq 1
.StackSize: resq 1
.BootLoaderTolumSize: resd 1
.BootMode: resd 1
.FspEventHandler resq 1
- .Reserved1: resb 24
+ .Reserved1: resb 16
; }
.size:
endstruc
--
2.35.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93832): https://edk2.groups.io/g/devel/message/93832
Mute This Topic: https://groups.io/mt/93699989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Thanks Ted! Reviewed-by: Chasel Chiu <chasel.chiu@intel.com> > -----Original Message----- > From: Kuo, Ted <ted.kuo@intel.com> > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf > Ali <ashraf.ali.s@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com> > Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in > Fsp24ApiEntryM.nasm > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063 > Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm > to align with FSP 2.4 SPEC. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Ashraf Ali S <ashraf.ali.s@intel.com> > Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com> > Signed-off-by: Ted Kuo <ted.kuo@intel.com> > --- > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > index 997b9c0bff..15f8ecea83 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: resd > 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstrucdiff --git > a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > index 8880721f29..a3b38e4585 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: resd > 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstruc-- > 2.35.3.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93847): https://edk2.groups.io/g/devel/message/93847 Mute This Topic: https://groups.io/mt/93699989/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Patch merged: https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124 Thanks, Chasel > -----Original Message----- > From: Kuo, Ted <ted.kuo@intel.com> > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf > Ali <ashraf.ali.s@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com> > Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in > Fsp24ApiEntryM.nasm > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063 > Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm > to align with FSP 2.4 SPEC. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Ashraf Ali S <ashraf.ali.s@intel.com> > Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com> > Signed-off-by: Ted Kuo <ted.kuo@intel.com> > --- > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > index 997b9c0bff..15f8ecea83 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: resd > 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstrucdiff --git > a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > index 8880721f29..a3b38e4585 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: resd > 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstruc-- > 2.35.3.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93851): https://edk2.groups.io/g/devel/message/93851 Mute This Topic: https://groups.io/mt/93699989/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.