From nobody Sun Feb 8 18:14:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66747+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66747+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603981149030290.13600334736327; Thu, 29 Oct 2020 07:19:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tzvHYY1788612x4GqevoNVAu; Thu, 29 Oct 2020 07:19:08 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.80]) by mx.groups.io with SMTP id smtpd.web12.9402.1603981146984679906 for ; Thu, 29 Oct 2020 07:19:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GeBpA27Gk1rCjWsOFgmvPOHaBdKFoyL9Q9/09UywYsjy0jTt4XNM0lbOu6JqHe3gapSynVR1REArxnosc90WUMUQCU4+GBzCZQKFJWi7kQzuIQK1nb7WSe55NOX9WcrOkrKj5438s5UXNbOBzzQ9UYIHA+eG4PlvPWgnDT7xPPLpPiem2i8Ro+9qnsusf3/ebsVBjeqOxLQ7kdxpI+15zeg5s/LrNMD6kZvWPFeRori89hUOM9Vz6Fti3RpHTWqC01rapkR9ACYYr0dVg5NmuRRqRYlRmgbnL3mf8FLUuAxsTNfAG4UmloSpQ1NpP7s9JnBtI8i2ArO2elzwWkGJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgZCc6wxVnz/Nrtf4qAOaxmDIT+GUm4Z4PAifjXDTCA=; b=jNOqQsk5JpSVoZWiIUkUiDAt6na+g2qywssi5YvyqzuYGJhiyieizLNCbdW0RQsJzbuj2SRT7yZ69rXQ6V2NeKIyehuuJiqAmx00IEtleLwK0GXAqlqbGtBiI181PrqHzUloC1yvCbwFnQhmoOlwwm003ObQz52xfXRiDjufjur7DaA/PZECWnoWhELzl2YLIvj6wt4qoZMhQ5XP7ISi+5fNpH0ANtxhz9wotgxfLWj1+EzJjposLUw/9k7mMs10MAo25y2Zrl1VrIP4IXujk7km0MTbyD8QJFoNNNI+PvkoSMN+zblvGFssrw6ckB3BgqBPfsqOROUdWeeNxf9exA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3276.namprd12.prod.outlook.com (2603:10b6:5:15e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Thu, 29 Oct 2020 14:19:04 +0000 X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba%6]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 14:19:04 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH v3 06/11] OvmfPkg/VmgExitLib: Set the SwScratch valid bit for MMIO events Date: Thu, 29 Oct 2020 09:17:57 -0500 Message-ID: In-Reply-To: References: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN6PR05CA0019.namprd05.prod.outlook.com (2603:10b6:805:de::32) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR05CA0019.namprd05.prod.outlook.com (2603:10b6:805:de::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.10 via Frontend Transport; Thu, 29 Oct 2020 14:19:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0cd77b38-a05d-4972-8bed-08d87c159704 X-MS-TrafficTypeDiagnostic: DM6PR12MB3276: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: iAXLbZ37xCciFclCD4Ajr44KdpFZFkE43CNfSco/Ei++6kYtzCcnB8YrsL7xpNNEHJhiCsUVCY2/QjCC7NEOM/m0fC+SVGrD3DGXj90GjVYvTSOSahe/B5Q0H349HmbHsBhpDBpDLVIQUdons7gGYe2qysXuXfVpJe8ATslltrrmaet36+/dEsRxxHN7eLrwwTM/VduAH2p1jiZMIMbH0ULbqktCUHke5PwXupWwrHpzOjhCV4iiidZuqiNOoS0xtt0kaEkMzgpeGnO7hT6+bFdgd6ETP6kJQ0yT3qWlu2awJecgU9TlREAMcvkHarbpJ/UL/spDOlR5MypWF6amMiXvfWLcfJL8x7uWSEi+cg6xEIW7DK8b1poH5w8LPQjD6+TCc5Qc3wypb16mY31wJQ== X-MS-Exchange-AntiSpam-MessageData: rAUIKkDWzjIp/54t7kyDXc8dHpcElJVubb1ArFJ88rcE4q2Xr+sqz9SvwBzfM9/Y38Nja9+2BrV5TZo7QaGeI2LCFsglMNY1OkZhviHqXd5cT37ugzOFvAQ40dA/lo7pX5lgnyJ2sd6TYIUqZmVlX27k5+g9BhE7LEFtGP5YWCO9B2BUXIC0Ul/tzmEScUiFU1jRjb19tBTxDdH1QrPCbGTHotUGNXTUM35qNSZQzQPrT1LFfuchU0QDKdD9qCRr3ZRhGJkc0xc1j0ZTCIh+8Nq/9dEqGR/30kz9vrwZnRbILSYtt2xB+gSO5datzHY4hzAOs1ryf+uzFiyqaB0rDll9o3wrl/Hpqc8p99/i9epCpfP3QX/Su7XIg6KY3pFo0wEt+UP6/Ob/6aXhbpW8ihHOoU7hYpbt9/WgcQghP+4jm3rh9zxU6gZOtsIfpacvwNOdMuzdQo0wbeRoyPCFm2odyuEoBuHisH05ddjzA0QEs5K2Eeglq6nqOAP5TFaAXzmhqYAT3/GIy0X12hmHFmTRZRXpf+LmsXKyR79iN6suXQ73YFR9c+iFriSXYvhednWoUveCC9tRtR/Ia4h+ROUozY0gcW4BDCIbVjo/hc2LoIqMA2qKNplb+xiuHI+9eG51xSW7wDBaeeTnrmxdXg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cd77b38-a05d-4972-8bed-08d87c159704 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2020 14:19:04.4099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z+SUpPrbwndojLLIV15mNDGGfzN4+mAvy7f2B3MJPQx8A1L9rPJUQMhqkniiHOZf8CHa2jgFh4K8QOo+qQsYWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3276 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: pUdhzcTOSxNTcsOtWXlgk70mx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603981148; bh=KOqO79wR+u+xfe9m2+HUoUvD/Ig25kYAW4cwQzcQraE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=p52druFiCPFX4iKarg8JKNICnf/Xy+mtDnXtOS/inRxr2BS081CD04wF0ZZlLLNmshJ pEWxyVr4qNGGHMq0jK+8jEs+cW3P02prUNKFO9uTxw1tNI0YLBEhPssdAXvnlzIHd40EQ Vfa94/WehIRq8L8GunZCfASamThHN7NVfeg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3008 All fields that are set in the GHCB should have their associated bit in the GHCB ValidBitmap field set. Add support to set the bit for the scratch area field (SwScratch). Fixes: c45f678a1ea2080344e125dc55b14e4b9f98483d Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Tom Lendacky Cc: Brijesh Singh Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Librar= y/VmgExitLib/VmgExitVcHandler.c index e5f14035b06f..9bf9d160179c 100644 --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c @@ -664,6 +664,7 @@ MmioExit ( CopyMem (Ghcb->SharedBuffer, &InstructionData->Ext.RegData, Bytes); =20 Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + VmgSetOffsetValid (Ghcb, GhcbSwScratch); Status =3D VmgExit (Ghcb, SVM_EXIT_MMIO_WRITE, ExitInfo1, ExitInfo2); if (Status !=3D 0) { return Status; @@ -693,6 +694,7 @@ MmioExit ( CopyMem (Ghcb->SharedBuffer, InstructionData->Immediate, Bytes); =20 Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + VmgSetOffsetValid (Ghcb, GhcbSwScratch); Status =3D VmgExit (Ghcb, SVM_EXIT_MMIO_WRITE, ExitInfo1, ExitInfo2); if (Status !=3D 0) { return Status; @@ -725,6 +727,7 @@ MmioExit ( ExitInfo2 =3D Bytes; =20 Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + VmgSetOffsetValid (Ghcb, GhcbSwScratch); Status =3D VmgExit (Ghcb, SVM_EXIT_MMIO_READ, ExitInfo1, ExitInfo2); if (Status !=3D 0) { return Status; @@ -755,6 +758,7 @@ MmioExit ( ExitInfo2 =3D Bytes; =20 Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + VmgSetOffsetValid (Ghcb, GhcbSwScratch); Status =3D VmgExit (Ghcb, SVM_EXIT_MMIO_READ, ExitInfo1, ExitInfo2); if (Status !=3D 0) { return Status; @@ -780,6 +784,7 @@ MmioExit ( ExitInfo2 =3D Bytes; =20 Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + VmgSetOffsetValid (Ghcb, GhcbSwScratch); Status =3D VmgExit (Ghcb, SVM_EXIT_MMIO_READ, ExitInfo1, ExitInfo2); if (Status !=3D 0) { return Status; --=20 2.28.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66747): https://edk2.groups.io/g/devel/message/66747 Mute This Topic: https://groups.io/mt/77888130/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-