From nobody Mon Apr 29 20:56:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55377+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55377+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1583315057; cv=none; d=zohomail.com; s=zohoarc; b=YXQMOoRI8o0SIW5NGT488j0+/OgwyhJbnLmUxetmzPj0ACSZPWPtlh/S6kPtT6EJG906479GCzhbtPcqQZr32o0hsP+P12op5iElVDkvBi4LkWWpaVqPbJjDHHV+YFEv3N0ASKp/JgGd8IUNjGdB5JkWxL2ORudmTM3qNITAFZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583315057; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=1aEkt/H5UxpdClBY/3JPlsq6CqTc7PgIyTBCYTGgpTQ=; b=WjYHI/UQ7rWu5hXCnHmmdvqooDybfc+7TLrv8kQ+OBelznt7ild+Igb6ASB476qeQ4/cJFUBHP2s15aABeOQ5TRRa5ryQv7RiAnKPnPOfHH8BnQjrqAEHCNq2YCZEi6uLauW7zJP9ZO0dA394XK8+azewiOIbB0/NigmptNpMVA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55377+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1583315057590965.8553849388076; Wed, 4 Mar 2020 01:44:17 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id GJpbYY1788612xnBskrc0bBy; Wed, 04 Mar 2020 01:44:16 -0800 X-Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mx.groups.io with SMTP id smtpd.web12.9039.1583315056134891152 for ; Wed, 04 Mar 2020 01:44:16 -0800 X-Received: by mail-pl1-f176.google.com with SMTP id j20so380413pll.6 for ; Wed, 04 Mar 2020 01:44:16 -0800 (PST) X-Gm-Message-State: xvq91lAVYjsy1cGJ3l1VRCjPx1787277AA= X-Google-Smtp-Source: ADFU+vvD1qpp21Ifop6i/E6v5DtFA/BcJt6mva31ymXDMo0kh9BTapAtdyoKHg5QHxBx7zdtuJNL7g== X-Received: by 2002:a17:90a:266f:: with SMTP id l102mr2226936pje.67.1583315055152; Wed, 04 Mar 2020 01:44:15 -0800 (PST) X-Received: from localhost.localdomain ([222.67.15.87]) by smtp.gmail.com with ESMTPSA id s12sm4991252pgv.73.2020.03.04.01.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 01:44:14 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ , Hao A Wu , Ray Ni Subject: [edk2-devel] [PATCH v2] MdeModulePkg/SdDxe: Potential NULL pointer on Token Date: Wed, 4 Mar 2020 17:41:18 +0800 Message-Id: Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,newexplorerj@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583315056; bh=Ggkr+WmJrYcYJy7OkvroTKVCnPISjh/aUKFCI4sqJ84=; h=Cc:Date:From:Reply-To:Subject:To; b=cs5ir4dLBjjdRBz2GcmDv9sfkE/nJbU90jUKx9/SXN6RzOqqlaagiG4IXAOUYrjlT22 kAT8wMRRjSbrnpxCr7F9zYeRGHqezBlbEmYF4+zCsk8ixEId3mCxIYv0i/SgrAzW14N+Y 2zL1xKIA2a04ld5++KytPq9W1+ddrXIjj7I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2286 Token pointer may be NULL, it is should be check before use it. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: GuoMinJ --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c b/MdeModulePkg/Bus/Sd/Sd= Dxe/SdBlockIo.c index 9f42abe7e2..0cc2e70b58 100644 --- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c @@ -1367,7 +1367,12 @@ SdEraseBlocks ( return Status; } =20 - DEBUG ((EFI_D_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x Event %p with= %r\n", Lba, BlockNum, Token->Event, Status)); + DEBUG ((DEBUG_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x with %r, ", L= ba, BlockNum, Status)); + if ((Token !=3D NULL) && (Token->Event !=3D NULL)) { + DEBUG ((DEBUG_ERROR, "Event pointer is %p\n", Token->Event)); + } else { + DEBUG ((DEBUG_ERROR, "Event is meaningless\n")); + } =20 return Status; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55377): https://edk2.groups.io/g/devel/message/55377 Mute This Topic: https://groups.io/mt/71722698/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-