From nobody Wed Apr 24 16:27:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+73394+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73394+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616771115; cv=none; d=zohomail.com; s=zohoarc; b=Hr3c+5nxGGWeFHLWtfUviNPU8jwkdfDgg4sDsfdozplEBok//c0/Wuc0XnDD23GJHYOfiUgU5mtPrQFIpmcUB5QJZrWOgl4GcKQUWP/jKtkpDsa+Yo3xsu7hf6DPYhD8BwqWcFYc3Tq+aO0bXu4I+Po4KNNA59RXlcs/OlB0Kh8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616771115; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Zg8mCj8oulh6PnZOqhEH/H9pIbosszRXc5mUgbG4VAs=; b=mfXs3iZNE+ywazwcbCD6vHstprT5kPhq/K6QNhmEL++OUbmefd8izZ+RmkChrgt80X9vc3CfxsmtRHJUP+PyMnB84YY2/2KS95vq87J/XxPWu946+f0THCEqHQuvDs+zPBZL8wQ9m0QX+oNkr3VO1LVQMYT/MRSzxqmlCmB9Psk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+73394+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1616771115613635.2750550050438; Fri, 26 Mar 2021 08:05:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8qLvYY1788612xuslg1HHhVn; Fri, 26 Mar 2021 08:05:15 -0700 X-Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mx.groups.io with SMTP id smtpd.web09.6080.1616719709364600975 for ; Thu, 25 Mar 2021 17:48:29 -0700 X-Received: by mail-il1-f179.google.com with SMTP id j11so3671791ilu.13 for ; Thu, 25 Mar 2021 17:48:29 -0700 (PDT) X-Gm-Message-State: i87AiBL9F9ninpfrCFVYqEpvx1787277AA= X-Google-Smtp-Source: ABdhPJyVokoy4K12uKUx71kUr+dITzT3p9i3HArBWMeSGM6/2mrkvB0zGgOlCyAeyDl2RbUXbm7tZg== X-Received: by 2002:a05:6e02:214b:: with SMTP id d11mr8568806ilv.135.1616719708676; Thu, 25 Mar 2021 17:48:28 -0700 (PDT) X-Received: from hircine.home.lan ([2601:282:700:f::9c8]) by smtp.gmail.com with ESMTPSA id v19sm3298124iol.21.2021.03.25.17.48.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 17:48:28 -0700 (PDT) From: "Tim Crawford" X-Google-Original-From: Tim Crawford To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of comparison Date: Thu, 25 Mar 2021 18:48:27 -0600 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,crawfxrd@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1616771115; bh=YNxMLwzkMCRDFyOe1zrwS6qT0G0S7NCaJU2LaOKoXrg=; h=Date:From:Reply-To:Subject:To; b=NaHXQzD2LbVwXoWqgFiWIqrGKhnd1F5vJgS3WHhUI9yvaxiat4ToMNdbYsoB73K0zda /W8a2DYyFvU5ngN5TwTPRyLYPEd7yuKbLEOB8ucR/eSMmYbAePZ8JDtB8Z4EVREdprdfJ 3fC9xj6JPr3WuFGm07fKyx3JFmI6p3tDjko= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The cast in IsDataShdr() is only applied the left side, causing it to always return FALSE. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3271 Signed-off-by: Tim Crawford --- BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +- BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/Source/C/G= enFw/Elf32Convert.c index 7f351287a9..df54991768 100644 --- a/BaseTools/Source/C/GenFw/Elf32Convert.c +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c @@ -262,7 +262,7 @@ IsDataShdr ( if (IsHiiRsrcShdr(Shdr)) { return FALSE; } - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF_= ALLOC | SHF_WRITE); + return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF= _ALLOC | SHF_WRITE)); } =20 STATIC diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/G= enFw/Elf64Convert.c index 4ed6b4477e..1bf1e9accb 100644 --- a/BaseTools/Source/C/GenFw/Elf64Convert.c +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c @@ -270,7 +270,7 @@ IsDataShdr ( if (IsHiiRsrcShdr(Shdr)) { return FALSE; } - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF_= ALLOC | SHF_WRITE); + return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D (SHF= _ALLOC | SHF_WRITE)); } =20 STATIC --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73394): https://edk2.groups.io/g/devel/message/73394 Mute This Topic: https://groups.io/mt/81630142/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-