From nobody Sat May 18 18:13:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109359+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1696522743385599.406419874173; Thu, 5 Oct 2023 09:19:03 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=TocNoCF90xZk7FvSjRo5Cc65ElDBfoYaHxSrFyortGM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1696522742; v=1; b=LHsHDNXcjy9jiLnY3Qly1t5b2s1Qi9lFj0xQv+sXnT63Ax+ff1oRCY/rz0XgN0HNw/jkghMB sGTJPOnILkL19+mMxZ873G6dm0YNcbEW9eizaXMhXma96tWhs5uE8Am1eR9t5Inr8W2DydCd5jl IrJwDr0KFQASAnNDJMIPda50= X-Received: by 127.0.0.2 with SMTP id wfVkYY1788612xwwPm6zznOw; Thu, 05 Oct 2023 09:19:02 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.57]) by mx.groups.io with SMTP id smtpd.web11.19915.1696522741985728426 for ; Thu, 05 Oct 2023 09:19:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5BvJyB0xHwV9yS/UvTrOnasnua0SPx4DnEU5C14HCwluAaO2fBzBskhvuZ1M9me8ht6TTbtb1f0JEHPfyjx6BoN5+RzJIA9PJMD6+4w8+SZtrBM1Gl8SZkWqiAlGAyij/FmcN9eTmBO45O+QgwPD2fps8hhZDUTULKbxhIwBRobVu0c2tPV7OIRmSFXR4RYhzdB/3cBDERN/QcOKZYL0ndS8dOYeNvLHf6UZfoh2rjKCC67Yd9XBOjEDD9gwfqTYeoU3wiwY+dt0Fv2V/aXQDTPuTC1ML6ldXVa8xgHKcx7+zkYJ9GYCWdlYFRovRtmNTMTrNp6w+x7tqCjYOUHeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WyVGESLNk4GVew7q2JY4kz9Ud374ezfeVA7cTTuX04=; b=lzgdT5BH3h0RnWM7rOq4CgzjkA6tZJdANSmqIla+gLkXCWy987/+RtT0aapS579FXgygTsz1EXCgRmhkwDGGJXcGJqr8m3tqP7/6x83oSvc16YQbJQR6hmDEDHIhYErGCIa9fV/4YXxauspGQGuTLEsKYg1c42HdeEFXO008R0iREXipMCs6Jk9hTHB1BuAnkS2jgstfZf+WsxVpQmo63tYTO5x5rcEy7yzTvn/52v4uD7yUkIC8/XN9ZYRfxb5eL0BqRNLKux6zAx+Mw/7DqlNyjRFZ8c2NPf1iiJg39MVd2lKJ4+fxEeIBEKVD4ASvPjiq919ebtT5KrzCHe2C7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from MW4PR03CA0014.namprd03.prod.outlook.com (2603:10b6:303:8f::19) by DM4PR12MB5088.namprd12.prod.outlook.com (2603:10b6:5:38b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Thu, 5 Oct 2023 16:18:59 +0000 X-Received: from CO1PEPF000044F9.namprd21.prod.outlook.com (2603:10b6:303:8f:cafe::98) by MW4PR03CA0014.outlook.office365.com (2603:10b6:303:8f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.29 via Frontend Transport; Thu, 5 Oct 2023 16:18:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109359+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000044F9.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.9 via Frontend Transport; Thu, 5 Oct 2023 16:18:58 +0000 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 5 Oct 2023 09:18:46 -0700 X-Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 5 Oct 2023 09:18:46 -0700 X-Received: from jake-build.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Thu, 5 Oct 2023 09:18:46 -0700 From: "Jake Garver via groups.io" To: CC: , , , Jake Garver Subject: [edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message Date: Thu, 5 Oct 2023 09:18:31 -0700 Message-ID: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F9:EE_|DM4PR12MB5088:EE_ X-MS-Office365-Filtering-Correlation-Id: 08b7c801-68e2-41cc-1884-08dbc5bec7bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: UOuUuZnvWesZRUAniH4Cl+qMgswQxeBqbyRifXB9O1VGYNk9kwqj3AhfgTjoSaSAXIEWRANKw+NuHdXQqGxguoEDfgRDhBskk44URcZfiG8ZhoEfUXND+A8ExNaz7HHXUilqBv1h/1Sw4OpYFDljQz1OYB//cs/AVz8U41r0Ht39M9WnW5cbVnHfh6fpqem67OzE5PvKCuUsfREU2csnhmkhxQAio8T3pJRnVtGFM2jLjRwC9ESt3NXTV8oMzXBjNFm5FQU095vPmd02puCixKs9ubkULZ1adXZttimhGkcdt55TE+F7jh+N6WO45q9n6ys7F/c87sZRL+2bKTKheTf+76OTmzdUkqUek+29FS26QJfdu4O7f9N5KBUufueBJFtHlL0dSpvIyxgTVZu8Pg316icCrYCdFGm6YX6k9e6FkcDYLxTjoNtzWiASBydozmbf6KsLUXmUgzHN8f+FNZGC+eO5e0NSNNjpPWInt7CumlTmC8upbxU1wizFDqOfYFJQNsZiqNgEqI7QChOkDeSxJkPSd4314FJLWWYC7T6WkYzXY2E/uo60u8whoWfuY5xqF46tVm0SDZjvuk5oQS9t538a3xvPxsM/rNMQdTtdkHy2Vcl7EaFipJqNPLZ3NU2EYbY+ZdNZybJdcF577cJItOplBVihzCAvh/J4QPI9XRdE9Etu8ol1d7UcY24P88CNAzvUfVF0o2ScleoyQ6gRkvEvU2LxEONxTLbV0WkrUpygrOdaARweQaUslmya X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 16:18:58.7923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08b7c801-68e2-41cc-1884-08dbc5bec7bf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F9.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5088 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jake@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 35LJLulXqSFQm7moOU9vvoYPx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1696522745225100001 Content-Type: text/plain; charset="utf-8" __builtin_return_address returns a pointer, not a string. Fix the STACK FAULT message in BaseStackCheckLib appropriately. Signed-off-by: Jake Garver Reviewed-by: Liming Gao > Reviewed-by: Liming Gao --- MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c b/MdePkg/= Library/BaseStackCheckLib/BaseStackCheckGcc.c index 0d2918668e..ea168841b6 100644 --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c @@ -6,6 +6,7 @@ to exiting the function. If the "canary" is overwritten __stack_chk_fail() is called. This is GCC specific code. =20 + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. Copyright (c) 2012, Apple Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -34,7 +35,7 @@ __stack_chk_fail ( { UINT8 DebugPropertyMask; =20 - DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow in function %a.\n", _= _builtin_return_address (0))); + DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow at 0x%p.\n", RETURN_A= DDRESS (0))); =20 // // Generate a Breakpoint, DeadLoop, or NOP based on PCD settings even if --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109359): https://edk2.groups.io/g/devel/message/109359 Mute This Topic: https://groups.io/mt/101779895/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-