From nobody Sat May 18 04:13:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76788+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76788+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624211496; cv=none; d=zohomail.com; s=zohoarc; b=eDK8g6t35uFoR/mpmwBCK+1gAKbIBC+I0KfnlP6ikwMrqgUCDYPLO9QniHe7VqJjqnIbjq4hbIbjnDetCnZr0betl5c0ySIJpk8dbedmJhsptffuASZ844AbxISceu7bKSjH/aikxN3Jy5gMOdY6O04aJrhHj9riLD0WaqooOpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624211496; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=RpGaybVhEw21IdSeJIfdePdyxYH8UJfsjMrmTMnw8lI=; b=J3yHF+wVj+47pqDIvIc/avA7TbO3lr+Uka+dI+7ZoythVKqU0eehysLB9ag09Ub3cqV2ZQwIJt4FN4tBRREOWH4On4KO0rIcuVty1qqr6DnlksqdzK/ir83lpa/ueR1nmmLmZtAuYAaXpA+GHbYLZAmDPVOM4YFonXYGEMnur5w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76788+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1624211496217970.3100183821083; Sun, 20 Jun 2021 10:51:36 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id FjeAYY1788612xdcLrvCYFBE; Sun, 20 Jun 2021 10:51:35 -0700 X-Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web08.3217.1623987066446475273 for ; Thu, 17 Jun 2021 20:31:06 -0700 X-Received: by mail-pl1-f179.google.com with SMTP id x19so3986161pln.2 for ; Thu, 17 Jun 2021 20:31:06 -0700 (PDT) X-Gm-Message-State: 80cmTs94TG9aqh5cD2WPYylnx1787277AA= X-Google-Smtp-Source: ABdhPJytsOjhAK3P89JUHZ5ZaUP2lg17UqT1TBo4nquxFkZiGswN1t6KeuribfgyCI4/C7VjeUykIQ== X-Received: by 2002:a17:90a:bb91:: with SMTP id v17mr2823999pjr.102.1623987065805; Thu, 17 Jun 2021 20:31:05 -0700 (PDT) X-Received: from UTILFW-8301.in.megatrends.com ([171.78.170.117]) by smtp.gmail.com with ESMTPSA id z24sm6606271pfk.149.2021.06.17.20.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 20:31:05 -0700 (PDT) From: "INDIA\\sivaramann" X-Google-Original-From: "INDIA\\sivaramann" To: devel@edk2.groups.io Cc: Sivaraman Subject: [edk2-devel] [PATCH] NetworkPkg: Addressed static code analyzer issues Date: Fri, 18 Jun 2021 09:00:45 +0530 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,emergingsiva@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1624211495; bh=R5zfwkaNqOUdzPaGHN5ENVSCm7fv+QLE4gi/aGyxtV0=; h=Cc:Date:From:Reply-To:Subject:To; b=oG+jf1o5aDw9zoOFJeArb003if69x/WY7PXdm9jKyuMfxKSQ7LsZDSp0ahmBqvpOTZF zLGtAo1T5++f/fhEL8PO0XuO1tgLGx9RnnM8EVADguj7O6yQdaZCA6ZKUyLwrwfDAvkwL xQqbjXA8MJAb9TWt2ymIRoYPdKeU+o1tZXc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function allowed events are Dhcp4RcvdOffer, Dhcp4SelectOffer, Dhcp4SendDiscover, Dhcp4RcvdAck. If any other event comes as input it will exit in beginning itself. Later below switch case handling the default case which is not reachable. I assume this code is a not reachable code and can be removed Signed-off-by: Sivaraman --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe= /PxeBcDhcp4.c index fb63cf61a9..c0d8211ea0 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1331,8 +1331,6 @@ PxeBcDhcp4CallBack ( } break; =20 - default: - break; } =20 return Status; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76788): https://edk2.groups.io/g/devel/message/76788 Mute This Topic: https://groups.io/mt/83671978/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-