From nobody Fri Dec 19 19:20:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57844+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587577352213224.47936220447446; Wed, 22 Apr 2020 10:42:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id l95IYY1788612xpgZldepe0Q; Wed, 22 Apr 2020 10:42:31 -0700 X-Received: from NAM02-CY1-obe.outbound.protection.outlook.com (NAM02-CY1-obe.outbound.protection.outlook.com []) by mx.groups.io with SMTP id smtpd.web12.476.1587577349670673050 for ; Wed, 22 Apr 2020 10:42:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lS+gPUo8N2V4PvXyPU/8Vm3ddw6QleuxXohtEdTBo+BfKMcPM8YSR7H2D77nIbYAtvFgTERZac/OgG3mL4Jc55cCX4ppZ7U3Fxp3cbfDxBesI5MUo6Ue7VKDcl3YBRQhoWRvlBcLQolGZnLrvlVQ5TgGib9H78QlHYkcNBaD7P07Tg55ZhSHvfHDf6cBDWR/Slp29CAMQ6Z0FVNIwNN0i9E/1udFWwCPfxs6UvQuGiIDzCNlahNAdhjDr6g8hjcz6oPV8XtwYpTohJvK2veQmNjq4664Jyw2TMUY1cK9TcVXR1uVg/GvAQB0VvdE0lK5FMIf9Z/cUIBQ1tDp9tg1Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9+2iy75ssCcIBxXjqoA4Tpqwln4QWoKc9QEQvK9fbPU=; b=Bl0/RwrTiPIJF/OO5v9wUVaiEhkC1wlaRxaPNZ1agdc3wVvqHZIeJ95ZrEC9VqoXYLFNtwiLx3CLAPwvu6cTRiHqkaEE9KeOTDShXIfG3NweoGzBKYjCo9rRvP0HM1+P1Orr+ckL1gAKV5Bm69jy6QSPzsVJ1A4C24uouLpf0GFEcMMY9Esur+EZV5UQ7lfltPffrQP0ZmSFk+71imd5+Kvmsnq0QIusNhxHZjg3FoHKx9jurVz3Tz1RIK/wYxKf5m9iCZJctxE03w+4JWDLGrDDPil7+TJydQ+T/EeWZoApjaQH7X5DgYfxLO/cFYqOgTp2/rnohy6aZc6BR05/yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) by DM6PR12MB3449.namprd12.prod.outlook.com (2603:10b6:5:3b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 22 Apr 2020 17:42:28 +0000 X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::9ae:cb95:c925:d5bf]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::9ae:cb95:c925:d5bf%4]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 17:42:28 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [edk2-devel] [PATCH v7 13/43] UefiCpuPkg/CpuExceptionHandler: Support string IO for IOIO_PROT NAE events Date: Wed, 22 Apr 2020 12:41:28 -0500 Message-Id: In-Reply-To: References: X-ClientProxiedBy: DM5PR04CA0060.namprd04.prod.outlook.com (2603:10b6:3:ef::22) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from tlendack-t1.amd.com (165.204.77.1) by DM5PR04CA0060.namprd04.prod.outlook.com (2603:10b6:3:ef::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Wed, 22 Apr 2020 17:42:28 +0000 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b5656247-39b0-4277-c084-08d7e6e486e2 X-MS-TrafficTypeDiagnostic: DM6PR12MB3449:|DM6PR12MB3449: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57844+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: I28QwOrs/T83pXQAR8q0EFf3zjmz6LNdcNyaDQ+HEuuCUmW2V8jLxyUqLXaJI8bu32QaaPxRNPIyEhFq0HvdG7yjtJZpfaLrBRgnSO+kCmovNJRINEd+E+LvigDg97sjkvJC2AxfrtCeXqztbsqhfhR5ZHXdJlIJTc/I+nT3Rq1y8QGX0W9jBgSSvqFKuCUcG/4+fjwM/X5O/WECt4MC/kN9sGPxF9iHASUAZqbWBGRg5kuP1rjGb3oYPt8weVrYxQ/V2yuRWdgnpOft6QFxHbo36oEN9JkJ4icuB/jTiPTsKoP4wCOnHnHzbLma8Ymr6PXhN3dFSIpYmOpwUijV6q8U4JZH21Wmimku/Mo8s8XDGo8Me4rLgYYK5Y99KoFeuyFsLhdtqDWLM+Ixx9rpjaxnYl8CfvCKfQSTmyRsGRfpiRmfFf7c9v0nXuTjloWc+YPcCg9Znuh0zXx7wnxpf4BQM0bsJjM8W/2hbaNkEa8RjvEaZOxJJiwcY+VmByHgMcT1bX7sepPbeJ1Hio20gqi94uxvKiGOKZnfe6fVCw2VlssaScoTqFBJJ6Jt9puG5XF0iryQa3iG8AWQ6O9F2w== X-MS-Exchange-AntiSpam-MessageData: dyVZhk0Gg831CZ8GU7qwGu2WaDK20qbo+/J4Lki6jksX37ylOuqvblU4CcyHFp9/kiKzyOFYZSbpzwLf7wfjpMqdA+QTFFxeqXS8WtU7FZ20OUUgbPMSfofGHwTv1IgHDCETTiWS3JSVkFr9P1GnLQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5656247-39b0-4277-c084-08d7e6e486e2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 17:42:28.7733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gkfAPNJflwRRbNzpyrIUiiT9kTj9FnThJpFOpp7OeZoODkXmnlhzDUOllKtbYiGMKG+4pKQdnTLweDwlzNASpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3449 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: YWXH2N5PojE6KvcXvd7C91ETx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587577351; bh=qOAZ4N6qofBnmtJ0OmgHb67o5iIKgU+J18RGwUSkQW4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=L8Tpn0LS5hdAbIWBenL2LFUITQRvXCXqQFxl2ZTDHZRYoWjsNPL++7cIPMVpr/akdcD xNhd96LheXNwjoW5tMcJsI7V/T8Dn6IFuYbk1vJ0kHkkG4PORTsGJxO+CosIQuWKfZZs4 Ea++XPyif7qR6vMjQlUsVbHRkNSfolhfqQo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 Add support to the #VC exception handler to handle string IO. This requires expanding the IO instruction parsing to recognize string based IO instructions as well as preparing an un-encrypted buffer to be used to transfer (either to or from the guest) the string contents for the IO operation. The SW_EXITINFO2 and SW_SCRATCH fields of the GHCB are set appropriately for the operation. Multiple VMGEXIT invocations may be needed to complete the string IO operation. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c | 86 ++++++++++++++++--- 1 file changed, 72 insertions(+), 14 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchAMDSevVcHand= ler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchAMDSevVcHandler.c index 588f2af572e1..5fade675ad84 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchAMDSevVcHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchAMDSevVcHandler.c @@ -446,6 +446,22 @@ IoioExitInfo ( ExitInfo =3D 0; =20 switch (*(InstructionData->OpCodes)) { + // INS opcodes + case 0x6C: + case 0x6D: + ExitInfo |=3D IOIO_TYPE_INS; + ExitInfo |=3D IOIO_SEG_ES; + ExitInfo |=3D ((Regs->Rdx & 0xffff) << 16); + break; + + // OUTS opcodes + case 0x6E: + case 0x6F: + ExitInfo |=3D IOIO_TYPE_OUTS; + ExitInfo |=3D IOIO_SEG_DS; + ExitInfo |=3D ((Regs->Rdx & 0xffff) << 16); + break; + // IN immediate opcodes case 0xE4: case 0xE5: @@ -483,6 +499,8 @@ IoioExitInfo ( } =20 switch (*(InstructionData->OpCodes)) { + case 0x6C: + case 0x6E: case 0xE4: case 0xE6: case 0xEC: @@ -543,30 +561,70 @@ IoioExit ( IN SEV_ES_INSTRUCTION_DATA *InstructionData ) { - UINT64 ExitInfo1, Status; + UINT64 ExitInfo1, ExitInfo2, Status; + BOOLEAN String; =20 ExitInfo1 =3D IoioExitInfo (Regs, InstructionData); if (!ExitInfo1) { return UnsupportedExit (Ghcb, Regs, InstructionData); } =20 - if (ExitInfo1 & IOIO_TYPE_IN) { - Ghcb->SaveArea.Rax =3D 0; + String =3D (ExitInfo1 & IOIO_TYPE_STR) ? TRUE : FALSE; + if (String) { + UINTN IoBytes, VmgExitBytes; + UINTN GhcbCount, OpCount; + + Status =3D 0; + + IoBytes =3D (ExitInfo1 >> 4) & 0x7; + GhcbCount =3D sizeof (Ghcb->SharedBuffer) / IoBytes; + + OpCount =3D (ExitInfo1 & IOIO_REP) ? Regs->Rcx : 1; + while (OpCount) { + ExitInfo2 =3D MIN (OpCount, GhcbCount); + VmgExitBytes =3D ExitInfo2 * IoBytes; + + if (!(ExitInfo1 & IOIO_TYPE_IN)) { + CopyMem (Ghcb->SharedBuffer, (VOID *) Regs->Rsi, VmgExitBytes); + Regs->Rsi +=3D VmgExitBytes; + } + + Ghcb->SaveArea.SwScratch =3D (UINT64) Ghcb->SharedBuffer; + Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, ExitInfo2); + if (Status) { + return Status; + } + + if (ExitInfo1 & IOIO_TYPE_IN) { + CopyMem ((VOID *) Regs->Rdi, Ghcb->SharedBuffer, VmgExitBytes); + Regs->Rdi +=3D VmgExitBytes; + } + + if (ExitInfo1 & IOIO_REP) { + Regs->Rcx -=3D ExitInfo2; + } + + OpCount -=3D ExitInfo2; + } } else { - CopyMem (&Ghcb->SaveArea.Rax, &Regs->Rax, IOIO_DATA_BYTES (ExitInfo1)); - } - GhcbSetRegValid (Ghcb, GhcbRax); + if (ExitInfo1 & IOIO_TYPE_IN) { + Ghcb->SaveArea.Rax =3D 0; + } else { + CopyMem (&Ghcb->SaveArea.Rax, &Regs->Rax, IOIO_DATA_BYTES (ExitInfo1= )); + } + GhcbSetRegValid (Ghcb, GhcbRax); =20 - Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, 0); - if (Status) { - return Status; - } + Status =3D VmgExit (Ghcb, SvmExitIoioProt, ExitInfo1, 0); + if (Status) { + return Status; + } =20 - if (ExitInfo1 & IOIO_TYPE_IN) { - if (!GhcbIsRegValid (Ghcb, GhcbRax)) { - return UnsupportedExit (Ghcb, Regs, InstructionData); + if (ExitInfo1 & IOIO_TYPE_IN) { + if (!GhcbIsRegValid (Ghcb, GhcbRax)) { + return UnsupportedExit (Ghcb, Regs, InstructionData); + } + CopyMem (&Regs->Rax, &Ghcb->SaveArea.Rax, IOIO_DATA_BYTES (ExitInfo1= )); } - CopyMem (&Regs->Rax, &Ghcb->SaveArea.Rax, IOIO_DATA_BYTES (ExitInfo1)); } =20 return 0; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57844): https://edk2.groups.io/g/devel/message/57844 Mute This Topic: https://groups.io/mt/73201902/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-