From nobody Mon Feb 9 03:14:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86789+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86789+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1645271934; cv=none; d=zohomail.com; s=zohoarc; b=KoVPv2pTuR8pzhZq7d9NvjX2xkD1svRcHOEcwDORBfMYULCdHrAufFX2SRZbnKi94BZPsJLWfY6/dogUuT/kR2bAPGbuTRNHFiD+ZS8fcW3W5/LhMVgAI6SxqMrFiyVRuDwuTyv+/5UyV7DJzQx7jQ+5iNnBvzaFrcsxTsKG/PM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645271934; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wPZO687IJJugqRXBCJuRlZvuV7qJt77VBPGYdqhq8SM=; b=HimvrFxN3uPgpEED2XLYhznCJocZeSkTYcW8JuII8qRMonjZyPHiz1fq3b7ezSExIGei7a06MwPXqGDP5BXCB9A/vvCbkzThOZxcJ32VAtXx7mNrsn3IPkIxJqVbVhgW6h715EbahSooa6XtYLsibIjIXDhw21XDwzRrhRwNhyY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86789+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16452719342874.427536249455329; Sat, 19 Feb 2022 03:58:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qiwbYY1788612xKGL2wdrupM; Sat, 19 Feb 2022 03:58:53 -0800 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.9100.1645271933337984887 for ; Sat, 19 Feb 2022 03:58:53 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="231915513" X-IronPort-AV: E=Sophos;i="5.88,381,1635231600"; d="scan'208";a="231915513" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2022 03:58:29 -0800 X-IronPort-AV: E=Sophos;i="5.88,381,1635231600"; d="scan'208";a="546691335" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.249.175.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2022 03:58:26 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min Xu , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Gerd Hoffmann Subject: [edk2-devel] [PATCH V6 27/42] OvmfPkg/Sec: Declare local variable as volatile in SecCoreStartupWithStack Date: Sat, 19 Feb 2022 19:56:40 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: JNPESMczbRTV4EiN4GMu5Kjrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1645271933; bh=G9d6aPG0uM/zGxpRbwosO0QXTT7I/rXlnvMFBYncZcY=; h=Cc:Date:From:Reply-To:Subject:To; b=BRTelY/lEgziIKKymH3wrvIwt03FxQGTAi14nbTqj9QE1kcvEUMsbPCFbYYUCTgWKZ1 OqcmteMnTUQerAr3sC4BcRGeawFfrcKE7cKeqBg8HaE6/bC0mTIkpoenUaQaz5kyNM3Gc XKJ+4zQTQonqTP/9o0qLrcBH6g22QMVbDO0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1645271936274100002 Content-Type: text/plain; charset="utf-8" RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 Declare the local variables in SecCoreStartupWithStack that actually move the data elements as volatile to prevent the optimizer from replacing this function with the intrinsic memcpy(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Signed-off-by: Min Xu Acked-by: Gerd Hoffmann --- OvmfPkg/Sec/SecMain.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c index 2c5561661ef3..02520e25ab9a 100644 --- a/OvmfPkg/Sec/SecMain.c +++ b/OvmfPkg/Sec/SecMain.c @@ -757,12 +757,17 @@ SecCoreStartupWithStack ( // IdtTableInStack.PeiService =3D NULL; for (Index =3D 0; Index < SEC_IDT_ENTRY_COUNT; Index++) { - UINT8 *Src; - UINT8 *Dst; - UINTN Byte; + // + // Declare the local variables that actually move the data elements as + // volatile to prevent the optimizer from replacing this function with + // the intrinsic memcpy() + // + CONST UINT8 *Src; + volatile UINT8 *Dst; + UINTN Byte; =20 - Src =3D (UINT8 *)&mIdtEntryTemplate; - Dst =3D (UINT8 *)&IdtTableInStack.IdtTable[Index]; + Src =3D (CONST UINT8 *)&mIdtEntryTemplate; + Dst =3D (volatile UINT8 *)&IdtTableInStack.IdtTable[Index]; for (Byte =3D 0; Byte < sizeof (mIdtEntryTemplate); Byte++) { Dst[Byte] =3D Src[Byte]; } --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86789): https://edk2.groups.io/g/devel/message/86789 Mute This Topic: https://groups.io/mt/89252057/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-