From nobody Tue Apr 30 06:37:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96783+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1669849348170242.53313240141927; Wed, 30 Nov 2022 15:02:28 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id XSPJYY1788612xrYByLNtAUq; Wed, 30 Nov 2022 15:02:27 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.77]) by mx.groups.io with SMTP id smtpd.web10.27858.1669849347163195264 for ; Wed, 30 Nov 2022 15:02:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JhIqkXNCunX9lJYe5UVc6NrFdRZD3LZ/4l/8AFqwYqHpcaWdj7wWeH56k/KKWbU8OUK2WFmYYHmv4T+aGmy2dKxpW/41aclKcQlWt+itfJ+VYeYP0UQrE3lrhi1Uv6Q/SqyoDVz/UEOw2dBshWRCarxmJX0NDFOtIEqjA7R2zkNDAGQ23iUQ5YswUItG9GYwr0+xM+FNZt1YI1j4zmbalMVwOVy2qvw6H+oNR5PxICHeaIOBe7r+qoHdFPd1ifdt+pLBxV6YSv0d0a+1M36yV8CyZ8NJ1mLavLSv4m1liv8olV4KXg2Q66gMr6zMXi71aZ5+CW3eM1lNXeJbKLHRqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vwjHY8VSWXouKtGsfvGZ2XB1AO8EA0ck2gbYglKuNeY=; b=AcK39i92CN3y0Ktx+vr3hXbDaDCAi1SPuBYa5NZEpFt1fxQ3MXJsZwvu6OGHSrWCefAXr1yO8H0o0FhH3B12Ds6Urj3L61o4AMFN7Rk7XuRHE45dHt5ORcCWkbIHwQvTcUsnAvrXXk86ICvKmtDRjJT/OsJm9CsC6vkBGzaB+BqGsiphcfhh2ll+5aIFnfpmHTP95xVcgFI6e50bowVfo5DbUQMY0VObtccK1/3LmWaCjEVc0zunns5Xw+3WvCx4S/THJDla9jdQYOrsTzR02FvJ9n1/+e6Y8qRHBB98mQtdj2WunoYmUeuiPv5fL01D9blUwnaqhTni2hAr8e/uXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from DS7PR03CA0286.namprd03.prod.outlook.com (2603:10b6:5:3ad::21) by SJ0PR12MB5661.namprd12.prod.outlook.com (2603:10b6:a03:422::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 23:02:25 +0000 X-Received: from DM6NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::89) by DS7PR03CA0286.outlook.office365.com (2603:10b6:5:3ad::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 23:02:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96783+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT065.mail.protection.outlook.com (10.13.172.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 30 Nov 2022 23:02:24 +0000 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 30 Nov 2022 15:02:17 -0800 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 30 Nov 2022 15:02:17 -0800 X-Received: from build-jeshuas-20220912T090427831.internal (10.127.8.9) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.986.36 via Frontend Transport; Wed, 30 Nov 2022 15:02:17 -0800 From: "Jeshua Smith via groups.io" To: CC: , , , Jeshua Smith Subject: [edk2-devel] [PATCH v3] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail Date: Wed, 30 Nov 2022 23:02:15 +0000 Message-ID: MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT065:EE_|SJ0PR12MB5661:EE_ X-MS-Office365-Filtering-Correlation-Id: 62ce947b-815c-4c13-1993-08dad326f20b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: i7N8pGYST1vu7fZfz48NuCyOyqMjTjMk8Ye2dWpZQv5FFrgJHwSJGIAitUUgu9R/fw4R68WuxSJpU9LK1D5desqYRvAbKReTXVuyc1HBEcuji7FAUxhYc0sEaWRyz7TX0ajKQ3CD9+98atysN1Pgv66zg7WBDeoclxd9da4clpgm1E+liV2eBc0ma6JiG4f0nh9Niod1ggELDhuoRcVgnMIFnUSvViQDT9FUZugafr9db5gmMEiKuWVs5/gSg4htG4xEiBCbV/JA806iDXqFuXdxwSXsBIg5ZZxAwn9nWXHFWyBkRrH2fvUJHfb0BUG/9yIVQE6/fumHaAK2cOV6mP0XpccZC5+3PCtVutNp3PYXaQcXF/NS/SWnRVCjPVwJfsqV+VhkrkHfIROni3wH56L2JTpJyNA9UUI2dZmXGfGdWJeXkQAgoeXhbfuda/WQEw/nJXz8Hf/53b4e0onmF40ySnahEHMxiGrWbu2Gp/VG+JNGtbC8VBPhsd08sqOvK8hLLrk6Obx7xuM8FOGln4XxXBeMSK/x96XfSVAQspiPjh3rCJOPYSZpZcpAOYQxxIvMyK+2/avMjvf4QsE+qbvVDJpYEQ7PpyuB3UggcMTSMAtB98bmtW1ywCr1E7YnUC20uzz7CK+KQLBjEdu5SMJ2RYZs+Q1AgBUE61rnuNng//+dq+zdc9XLlNSZfNRmWcvCFQ4z+KtC88+4amx9og== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 23:02:24.7972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62ce947b-815c-4c13-1993-08dad326f20b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5661 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeshuas@nvidia.com X-Gm-Message-State: MKYfXmIYj0sS1PLsASeYXSBWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1669849347; bh=41V6z6MBvJJkH1qGvq9z2oSG2oD9MR+SgKpL8ZZRRnU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=j2nBTCaIHjZsPGACRN2ebNx4soGzHcbSGGPhFnZ7LP74+o4e0tFpVuw1dOPAT3xea85 De6/Ukiu/LVzdU36hCsamNFPs12z2VOf0D1eMbL5Q+zHoDxHUe4wlyu3971NHlZ0J5ZJ4 r/17t2OQZNigoUEPgjNcPuNYCpnI9tm5hdY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1669849349662100001 Content-Type: text/plain; charset="utf-8" Update the UnitTestAssertStatusEqual error message to print out the expected value in addition to the seen value. Signed-off-by: Jeshua Smith Reviewed-by: Michael D Kinney Reviewed-by: Michael Kubacki --- UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c b/Unit= TestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c index dc05bbd438..0d8e36c938 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c @@ -290,7 +290,7 @@ UnitTestAssertStatusEqual ( { CHAR8 TempStr[MAX_STRING_SIZE]; =20 - snprintf (TempStr, sizeof (TempStr), "UT_ASSERT_STATUS_EQUAL(%s:%p)", De= scription, (VOID *)Status); + snprintf (TempStr, sizeof (TempStr), "UT_ASSERT_STATUS_EQUAL(%s:%p expec= ted:%p)", Description, (VOID *)Status, (VOID *)Expected); _assert_true ((Status =3D=3D Expected), TempStr, FileName, (INT32)LineNu= mber); =20 return (Status =3D=3D Expected); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96783): https://edk2.groups.io/g/devel/message/96783 Mute This Topic: https://groups.io/mt/95370662/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-