From nobody Sun Nov 24 10:46:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87797+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87797+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1647882359; cv=none; d=zohomail.com; s=zohoarc; b=PHm8o16+Z14Vm/PeKwXNyMoJdOHAQWvBkgc/ZFtmCadC/U7vNSzAG2tgIvUCSHp9RN2JFrQhDnZ0DtiItOOYKFG4ZwOof3qcu5ksU1bt2HuVS7kbc4V/rWX3a9rWN8e4hGdT+u7TC/ogDlmTrQ3RhUSIForkxLPirINw/w2PRFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647882359; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=PkgUgG8SkXPi24xDQnxRFgnhPI968x2IHJcm/77wfyE=; b=I1vxREXy5yLVgWxbHtBgAVt7uuGGZA0ZRs/6PV5KcV8yGU9F8ivI4Pzp6RD7To+WVvgccyk3uP/l9NXLbW/KvcFutJy/SxdMWGuG+frCnV35y5s0FRIBKGWCsDtlDPaZnsfqN28FXXjhO/2Nj4xOi1kMX6hAl5NJECKqx0+CW/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87797+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647882359948905.354133596714; Mon, 21 Mar 2022 10:05:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4FjJYY1788612xuG8mcfxmmp; Mon, 21 Mar 2022 10:05:59 -0700 X-Received: from rondra.lf-net.org (rondra.lf-net.org [188.68.36.203]) by mx.groups.io with SMTP id smtpd.web12.1051.1647882357401337969 for ; Mon, 21 Mar 2022 10:05:58 -0700 X-Received: from localhost (localhost [127.0.0.1]) by rondra.lf-net.org (Postfix) with ESMTP id 4AC2C5FDB5; Mon, 21 Mar 2022 17:05:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at rondra.lf-net.org X-Received: from rondra.lf-net.org ([127.0.0.1]) by localhost (rondra.lf-net.org [127.0.0.1]) (amavisd-new, port 10026) with LMTP id xRhCOt-c-DrA; Mon, 21 Mar 2022 17:05:55 +0000 (UTC) X-Received: from LF-T470 (unknown [IPv6:2001:16b8:5507:d001:529a:4cff:fed3:2f67]) by rondra.lf-net.org (Postfix) with ESMTPSA id 005E85FDB2; Mon, 21 Mar 2022 17:05:54 +0000 (UTC) Date: Mon, 21 Mar 2022 18:05:53 +0100 From: "Mara Sophie Grosch via groups.io" To: devel@edk2.groups.io, hao.a.wu@intel.com Subject: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,littlefox@lf-net.org X-Gm-Message-State: b4hvCf4G2TVyhMn1qFXq1SMhx1787277AA= Content-Disposition: inline DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647882359; bh=4acGrZ96DBGXZn/oOA/ocmWFqhOZP4x3CZU36tYlXrk=; h=Content-Type:Date:From:Reply-To:Subject:To; b=YGfbyMH1EHP38grRdH31nktTtawcpntVPTxfxIcu6J8RkR8utpwdtqbXI96DmXpotNf +Kwxlgy5WD1O0vXp8NsLN6nn2n47a+69kyel6sZFlbldBCtj2B202O8IG8kMEJECANpcp BWouAUcoN9K1apLeUfRP3j2Vl9DFJQhNFLE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1647882361535100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; format="flowed" Fix the check for NVMe command set being supported by the controller. Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe. Uncovered by commit 9dd14fc91c174eae87fd122c7ac70073a363527f, which changed the number of bits included in the Css register from 4 to 8. Signed-off-by: Mara Sophie Grosch --- MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModule= Pkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c index d87212ffb2..b90c48731c 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c @@ -761,7 +761,7 @@ NvmeControllerInit ( return Status; } =20 - if (Private->Cap.Css !=3D 0x01) { + if ((Private->Cap.Css & BIT0) =3D=3D 0) { DEBUG ((DEBUG_INFO, "NvmeControllerInit: the controller doesn't suppo= rt NVMe command set\n")); return EFI_UNSUPPORTED; } --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87797): https://edk2.groups.io/g/devel/message/87797 Mute This Topic: https://groups.io/mt/89833412/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-