From nobody Sun May 5 12:45:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86033+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86033+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=outlook.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643061478449595.9577206756205; Mon, 24 Jan 2022 13:57:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 53pHYY1788612xqfNk1uivmV; Mon, 24 Jan 2022 13:57:57 -0800 X-Received: from AUS01-ME3-obe.outbound.protection.outlook.com (AUS01-ME3-obe.outbound.protection.outlook.com [40.92.63.188]) by mx.groups.io with SMTP id smtpd.web09.1353.1643015400503582788 for ; Mon, 24 Jan 2022 01:10:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbVd+RD3bspO4l1xfwDybpBWptEtYOIfzO5DZAkKOJOIojXfhLmy+nnVTP39j78Y8JfUyxCAdBUwH+bJl407UzSnsGPM3Yk1sJMetoTbyDC6XyeUKsT9UH7fI+THH3WKQap583+ZY+4jI03rL904G85dmuglqqXafCeyicxMMW9P7zTikGwyOtjXlD0xkKEVe3f7k9JKDyt8fLVRa5aQY7eiWuvdEAD6b2Y7KjGvtSK+s7JBG/BO8mhseeOGqMTAqXPrED6Xi3rcm/h1iNQjU1aefjL4UqBJRH1HJIAGJq+33kNjwIXbtiVn1f7jfDjaO9mmia1qiaA+RiKeCwUDkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIlaI9RksfvtpxgwF8sg9frAx4RGyFQiLMZKoEylENU=; b=gl29nxX/N+tLstPu5mCT1thhaZTRyhTyECMwYXnMuyK63quANjyLkfIvI7z8bx0L6GCQgKbruHwzePWJqLwulSqSO/LZ+UM97RcZYODTbwlxldLpcbyFEnxzZ5pxoo7mkhZM0iZTa4X9sUwkcc0VoToxg/E9mbZchphsU6X0flu7+S+UTMo+lMIwRzzvdDcahfzagnfPNKc2JuceRUP6SG0DW+OR/bRK3UrP8I4TVoeN+J6yQ6Rp7/zKJDMH7c6mdFWm9ux2jnGcToEgcXexaFp1r07cmm7WmdZvqC5WMh340e+7sPYajT1/DNgW43683cfgVn4W/CnL0AgcV8Bh7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Received: from SY4P282MB3648.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:1c3::5) by ME3P282MB1987.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Mon, 24 Jan 2022 09:09:56 +0000 X-Received: from SY4P282MB3648.AUSP282.PROD.OUTLOOK.COM ([fe80::5083:7561:4b38:3e9d]) by SY4P282MB3648.AUSP282.PROD.OUTLOOK.COM ([fe80::5083:7561:4b38:3e9d%8]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 09:09:56 +0000 From: Vin Xue To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [edk2-platform PATCH] Intel/FitGen: Fixed overflow issue when overlap checking Date: Mon, 24 Jan 2022 17:10:11 +0800 Message-ID: X-TMN: [3dUDvJP+OnJ1r0N0nBpzTOFZ8nCAwSI+] X-ClientProxiedBy: HK2PR04CA0054.apcprd04.prod.outlook.com (2603:1096:202:14::22) To SY4P282MB3648.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:1c3::5) X-Microsoft-Original-Message-ID: <20220124091011.27833-1-vinxue@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2eb03de4-826d-4458-3b0e-08d9df194a3b X-MS-TrafficTypeDiagnostic: ME3P282MB1987:EE_ X-Microsoft-Antispam-Message-Info: QJeKJAO4ijkgxCtacUm7qS7j2xaKqU8PMGeu6/ofDCRGk1CZQ0GN64p/Id+txm33+zOuJmqj4mGnT3w2zxusDgwFLw8BqlyYvWmGBfFCpMB5GzsN3qeQFpcH0Gj+16+pyHbCcZluCHVxLijP4Yl/fvS7xNfamQ9SKrY8aca11JLLp8IQDs2Cx57KwfY8eIqGlvmE0rzBvqAKRes8oVHkiOhRX6IUdguXhBlmfRZRImg61Opnmcsxytmg0naUcgKHLUxR2P1Na3Nkpn1hSIcjkfoij6etqPG2sJUqczW+aLqFN9F4mjwK/bai8G+Ol28M1e08y74vMqDkQifkRq4tFZrIQxyapBn+wJKdXV1VYML3kK5zhExJdNuPU2KtmMDH7b99SdT8ScdWt/qnLjP9p4arGyOmJtZD5kxjZqT7iZ9JgaMNbW6Dq7SpANaCu323AinAPmLLQOCcNQNx1sJJXluCXbDozkOOzr9zXZ3VJ47OpODriz13mVmY9a8XizsTUN4GLanvpH9J+h0Kj6WOSe74rj1rlpCZxG0hWkaxHGf11SlkCapWhsWm3yt6fXmCK9dyii1G4Lh3RroL21lntQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X/hBSnMn7cvxYsJ54mxchmE0mAbyP+wuP1V8QH1L+TVD7W4jiVPPbyVFSjID?= =?us-ascii?Q?vpbtjmhPXAzQvxfYkMILA9wSD1MeNfsSlB2S/0+F2Zj5FCmqjmuGDB4TrL+o?= =?us-ascii?Q?ZRXEZA+8KrGLT52yZwNg/deHMNgU1kDapi7Ljh9CaiyYUwiQk0i929DvObEt?= =?us-ascii?Q?oyZ18IOwnKohUZaA21i8s6AbcGNzqor5KxSt3c+hgr6488Zd6Z19PGL0CeuD?= =?us-ascii?Q?BhrwcIIs0dYl8W7H7UTJB/gMH/3ttjA8RjIeoYVaveRxp36HXWxtwycVBpQf?= =?us-ascii?Q?JnbN8P9WchCWLun+OtnBrCP1JFyatTayow3hdxten9zC2U/f+Szp3gGeDlRe?= =?us-ascii?Q?m8Lqsnksd9f/lfIAR49Gg0vnQzRG4W+zZbCAQu9AtKbxwG497NlrQho0gARO?= =?us-ascii?Q?2NB6KsZVdIEUqho5DI+zzx8WVsm9q8ZUHqdi1ZaQeaMFlBxnHhI0NaK+EvDO?= =?us-ascii?Q?2cfg3wFaI8bkMWUkGPQArCbO9fSNeUPM1iiZgl4L9KE8yLCWq1GAjW2ocOMR?= =?us-ascii?Q?NGg5AXJ0Y20AkKZn1031U+5abGlWVbgWqgvgGOGxTKYhCFXLPw5K63Rkwimq?= =?us-ascii?Q?VMbUFFbAPgc0kIdcxPEAJY1ZC34wAlKxB9q9f5kRknyrarWVDgWdxh3bRcm5?= =?us-ascii?Q?6WFj7AS2bVjHDj6Ie2rn5ZkdClovhK6diOT5CVw+A+7YLcrOYix8/goAjFsb?= =?us-ascii?Q?sTJHoIeZkz3sM++LNpsSXzp+5q5yamF5KEOnRozGz4dLpUtySb/KViL07wMV?= =?us-ascii?Q?hzskSrYQAAEr80JInbL1IkuFS5a+sUoT40TMbgbCLjs88Zcne+aGcP6fGuVt?= =?us-ascii?Q?LzqiwitIWNUB+ot0/F//ItFDYaTQEBovCypGgcIhnpMOjf94CyMFFBPpI13+?= =?us-ascii?Q?7f9SQygUkNsLVrSvbyzib80TtczdbhdjcpLeignScE5HSweCaUb4TscgXXpt?= =?us-ascii?Q?W/1pPQ+pADo/BSEFYtj+sQ=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb03de4-826d-4458-3b0e-08d9df194a3b X-MS-Exchange-CrossTenant-AuthSource: SY4P282MB3648.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 09:09:56.5020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME3P282MB1987 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,vinxue@outlook.com X-Gm-Message-State: 7oO0HhNRtJ80dUOBhmi5PEZ2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643061477; bh=KQl3t1ZcJPYMpb/hTI42h8Cpr3YqTQkGXBx4Qdb+5AY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=qXptdhOov2YkrqMBV5mPlHHWI7uthbGGS/LBSBwYcbvZ1Qc99ewnNui8wjNYNxyGZBs nnbuf8tFl56KcaddINCDtS/QzKRJXFp3dMX9wup7K9bv111oOJuaADG3y42pl9UK4M36z o+dz0MIKzXvyE6qkS+cy8uS7D+nFL6X8TVk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643061479806100017 Content-Type: text/plain; charset="utf-8" When creating FIT table, if a IBB FV (e.g. Security FV) is blow ACM FV ( e.g. Firmware Binaries FV), but the size of IBB FV is smaller than ACM FV, it will cause overflow issue, unexpected split will happen. Added a statement checking to avoid this issue. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Vin Xue --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitG= en/FitGen.c index 290e688f6e..3cb8516757 100644 --- a/Silicon/Intel/Tools/FitGen/FitGen.c +++ b/Silicon/Intel/Tools/FitGen/FitGen.c @@ -759,7 +759,7 @@ CheckOverlap ( INTN Index; =20 for (Index =3D 0; Index < (INTN)gFitTableContext.BiosModuleNumber; Index= ++) { - if ((gFitTableContext.BiosModule[Index].Address <=3D Address) && + if ((gFitTableContext.BiosModule[Index].Address <=3D Address) && (gFit= TableContext.BiosModule[Index].Size >=3D Size) && ((gFitTableContext.BiosModule[Index].Size - Size) >=3D (Address - = gFitTableContext.BiosModule[Index].Address))) { UINT32 TempSize; INT32 SubIndex; --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86033): https://edk2.groups.io/g/devel/message/86033 Mute This Topic: https://groups.io/mt/88658814/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-