From nobody Wed Apr 24 11:00:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+83538+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+83538+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=intel.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1636515234587563.2509710624855; Tue, 9 Nov 2021 19:33:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id qbavYY1788612x7rRNCeU6pJ; Tue, 09 Nov 2021 19:33:54 -0800 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.6951.1636513183199122663 for ; Tue, 09 Nov 2021 18:59:43 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="213316576" X-IronPort-AV: E=Sophos;i="5.87,222,1631602800"; d="scan'208";a="213316576" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 18:59:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,222,1631602800"; d="scan'208";a="503774219" X-Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 09 Nov 2021 18:59:41 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 9 Nov 2021 18:59:41 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 9 Nov 2021 18:59:41 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 9 Nov 2021 18:59:41 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 9 Nov 2021 18:59:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQh6/eKUGIoZUDO5Cev1ODxZCgDyO3dQrD/KQN+786Gtlfey8+TRGq4bgUcGNGl+axFG0DkNT+qoRufQeF1jTHsjppTGzRzndn+B3heQAIbX0pRZt89GeVrPZmiFfZx/xGsZ+MUTh3pKciNfGDCprkJ3xJObjDPd9cqwZVIBnxGXCmpTMvr9CpFLVGXWHkRZ41yDqRQBxtm/dEf6n4x4bKjq2UmXC+sER2LMt4wPYvGrDJwslcQNRXedfNq6NRnu3JrxQRXcDBKMlsxO/wOKBwLHc6wFQXmN5sfxdz2q/ErfYAvw95UXRKQCPotnqoH+G0Aigmoj8KIhRdZbPsK7Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lvat+SOPKy96DQB+fSZYuL4imUvaqXNjbEJKh/zQpZo=; b=R38GrQJPCH+9A5cMDqaMnSid+lXwtyxvxyu8xz34nURRN611biIFF4NuxBbkzhAsNNJBFRHGYh0j9yYKh7Yap0hsfPbPNcMv/y4xSxXFaXFVQEivCzLtnPWfYhwJi/tncuSL7x78XrJw86h9hwszmMyqcJM9WHZhHt9HEUr1yjTP34mNGMVOSNQx72cb9uQZXbddFywli/08cduzbPJq6DqNe5qTE88uiubTdbDPMyXEE6z3o0PUzM8CHYeONYPW2CuLpnkxDgqrkM+796AdkDdeHNcHKb3YFjs4KGTIs/j0thAJf9YSzJ+t8hjm4Kbtuu++iujQhVXZKpKAjU0lfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB3994.namprd11.prod.outlook.com (2603:10b6:5:193::19) by DM6PR11MB4724.namprd11.prod.outlook.com (2603:10b6:5:2ad::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 02:59:32 +0000 X-Received: from DM6PR11MB3994.namprd11.prod.outlook.com ([fe80::5021:c72e:2201:1a62]) by DM6PR11MB3994.namprd11.prod.outlook.com ([fe80::5021:c72e:2201:1a62%6]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 02:59:32 +0000 From: "Jiang, Xiaolu" To: "devel@edk2.groups.io" CC: "Jiang, Xiaolu" , "Feng, Bob C" , Liming Gao , "Chen, Christine" , "Wu, Yidong" Subject: FW: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value. Thread-Topic: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value. Thread-Index: AQHX1HmuEBPQz6VJpUiV0e5xWnPs8av8FG2Q Date: Wed, 10 Nov 2021 02:59:32 +0000 Message-ID: References: <20211108082136.2707-1-xiaolu.jiang@intel.com> In-Reply-To: <20211108082136.2707-1-xiaolu.jiang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e5d23d0-b27a-42ba-b039-08d9a3f61ec0 x-ms-traffictypediagnostic: DM6PR11MB4724: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: rme0u0xdhC4TW6cnfacdx23NU4oUnQQXIv3GJaQk6suNMnftdh4SC0uyzJyHKwJODhdKji0x/JQ0X5MLnY6MxG1XMfPEBBqCX1JV3nmfBIA77bThtWrCC3dOwT7a6Q2QpGypNoJfgJu5poLcn24+ptIX+Dt3T98Nb2hbZYVFNPbxocX5zuBbVKlNhIBZ732+K+XzA7Btio6GkLwL/epFXNgFcdm3qx8gue0t8mHtN5WxUiD8E1N+BGaLm+hEp+bSENQ1bkJphSeIrIHouEBEjiHbcgw25NE1hWXqgSnSEK3qX6srF43m/evhGaNAydSnZflc+yVep05KDsI8ooTrruLW/ZWB19Y/Rdyy8JMNytqrmuBOajFml2bV9rc9rZvn7N/Bg+kG/21rF6kiS3QjwKYnu4YKw8FuA6f3WPzwMr8+EEBCCNv/wE23CKyafhkjnmEJNSa8uCRzb7fjoXhxwujtI9KMsw3lLcnpa1uvlHVdeQtJJRITHbROV2vKaCcdZdiwnCmG+qcI/0epzVa5Bo0t94Da5qbKrwoj7ZYtrJvqwWFWd4hPfc3+98AGMpGF2NvVPFfnwsvDap25PHf7kZa4K6Z7u3vinqbGby9RJKwDgZQMh1TnsUHd9fib10lE6x5E1iNNkI42RYoN+gCKgR4SX3zdY3zZoB3uKWUhsxZ37MEizzOjOdYDTYHtKQY/IFPDa7eI1MPXV2L9G3ZZuY0qnvTs/JuRR//22UKDZl0BTOY/xUUhLJM5srlMXTjex3R/0VKlxqxlaCglSSugpjPs+DbCHiM0+Sh/kv0WYv4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VERYV1FWY2ZEbTU3T3d4TXkwYlZHaCtyZmxRUDR0cHRvelAyKzVjVXYxVGFP?= =?utf-8?B?TWo5ZDZUMmJGc0Q2bTk3YWFtOTZJcmd5enRWSzBDRjIzYWVFSEFXQXM1Qnlx?= =?utf-8?B?ZGdSYXhJSVg3MGpaQWwrdTJEcU9ialM0ZE83cjNPVUpZWnEzZmRBL1F1SVFI?= =?utf-8?B?SG9oZk5kVG1ULzBEbmpBV3d6cUxuclp5THFUaE5remo0NkxEblJ5QWk1bWxZ?= =?utf-8?B?RU52d29NVzlPVjZhQng1TlljNU9ua1AvbUg2dytrMFFoWXRpK29WMkFMVTZX?= =?utf-8?B?NEtMc24vSVFLdVh2Nm02ZnpGSzFqNVhCSll4bWpRN2NPV1JrVnpXTm1keDV3?= =?utf-8?B?ZVNOY1lFUnRDQWtlSmR1TCsxK0lZdTZmZDdQSll5clR5VDhkOXN3eDRkQjZl?= =?utf-8?B?WlNPbTFsQnF6RmE5bVVpSk12YzF3RzlEaXdtQ25BeHoxNFF1R3dHYnNOenMw?= =?utf-8?B?N3ZnNUx3bk12NCthb1pCSXErWDYzSlljanYyMkkxd0ptWkZUcnQ4LzlUWEdt?= =?utf-8?B?SUN6VDgrS1VWd0huUXZlUm5IVERDUUl0QUZGeG9RTGJ4VjZ4STJCRk12YXpy?= =?utf-8?B?bUFwMXpscjZ0Smh0K3d1Umt5ODFOQ0JxQTJrVjBoUnNuRE5JbkhuWjN4Skgr?= =?utf-8?B?QVBZd0dZek9wNkhWR3NRYTNtWkZIMTJFZ0RGWGNhM3pmVW1tdEsyS0JLQXZr?= =?utf-8?B?bk5tQXNhcnZwL2VOMnd4YXNBcmQ5cUd5aVFWNW00ZDNtcmFuTVlYbTRZdURk?= =?utf-8?B?U0hEQmY0UHVIZzBNa0t4TlZmdFVidUlmREtWMWJOR1c4MHNoYk5DbGVOd3hH?= =?utf-8?B?RGw3Z2NHMWZNV0xuYkhYV2Q0RzVjU3N6NFR6bjE0ZnhaYUJwa3RSNUJ6alBC?= =?utf-8?B?azhwNUR2clVLL21oRHhZaWVWUTF0bWJEekhsZlJlM3FldWRpRzdhZmR2cU5H?= =?utf-8?B?ZXRaWjNncWd6Vm5nNjZhM2dKMmRWcDIrZkxXd1laQW5qOWd2RkJKSUNxVTFJ?= =?utf-8?B?eFRGYUQ3WGNWakdzMnZUMEJsN3RremtFV3ZUbVUzd2tCVVlMSlBIRnJrTFhq?= =?utf-8?B?cEM1OEYwN0Jpb0lYQ2VaZGdmcTRJblVjRUQ5TVFzeE5BM2tsM3lleUFCS0VO?= =?utf-8?B?dVRBZkV3ekdkM29iam0rRWZXRThCekViMFdQNXkyc0Q5WXJpT3FCNmszN09I?= =?utf-8?B?UW5Gci9RcTh0NkdnM0puMnJVanAzYVFPYzhhenFoaXdXTm5vaDVhSE02MjU2?= =?utf-8?B?ZkxETkVrRE03WXIxMjBJQ0hSeWRHWWJ1cGFIMlJldGpnVmhYdVYzNGkwK1V0?= =?utf-8?B?S1dSRmZSbWJ6Um5JL3J1anJWWW9QS0ZnVzUzQnhGZjNjOVJjOFB0MndGeFBI?= =?utf-8?B?elNLSzVtUHY2eW9OTGl3YmZHREVFRzFQcDBXTk0vTjFJVDFFTkZJT1NWOURB?= =?utf-8?B?eDZGQ21QdVozNjBOeXp0QUpSOFRWWDU1Y0lPZWFORmRveE81OU8zRWVPeEhU?= =?utf-8?B?clo0U1l1YU5TNkYrbzF3ZW95Yml1ZlNMOHRlMDNxVUNCazRxcFBaaTRQNVNw?= =?utf-8?B?T1JqRjFLQjJqd1p2WmsvN1R3RHI5S0ZBcG5Wa0F4SUx3TXdZdUNpVmpKWWZZ?= =?utf-8?B?NW91QWNseVJrSkx2SjN4V0NQbHVzYmJkano4R2hDUVlqOWEwV3hMTUJlRVdL?= =?utf-8?B?YzRjVnhORS9jcm5GTGVpV1I5QXRrWHlma2pOTC9QMVlKbmFCUkdjYWtrVVl5?= =?utf-8?B?WHRwS2dwVGxzNXBUVXlFUmxWVE8xQi9rUEtwNERtd1JlSVoxT3JyeFppWS9o?= =?utf-8?B?SHJzMVIvaG56YVNSZVpKdTZSOS9pUG5ka2NlWFJKSTBpYUo1M2tlZ2p4Zlhl?= =?utf-8?B?QmYwRjc5VDBxVWhnVEpBWWpJQWhrSjRINkx3NEpEQ3dNUkl4c0x6TzkrNksy?= =?utf-8?B?K1B6QmFBeVI1TS96eklUUW9jZmhPMGxKVVpTUUEyYmVVRjJWS0F0bzVKWW51?= =?utf-8?B?RENCbC9PNU9BWHBQREUxNXBLR0VHeFN1MFVOUXNNQ2MvNSt5Lzd4dlFMakFl?= =?utf-8?B?Y2RwQkhOMm5YeDZmZG5WRE9pYTFtSU1IbkZMdzRJNjZqRVM4WHQ5ZTRJSS9H?= =?utf-8?B?QStDN0tvYklJeVJ2SDZZdXRYeE1UWkVYMVJpVUxDamhRaGxZVWRmaVN2UlRI?= =?utf-8?B?dmc9PQ==?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e5d23d0-b27a-42ba-b039-08d9a3f61ec0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 02:59:32.1973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BhH8JLk59hvUD0DYk0zi1c4mqXaSxnPhMVbWE/GD5PTMuvObfBKUYNd/zNiFZgdf4Zw+kKfDvd7XOYOExahpag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4724 X-OriginatorOrg: intel.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiaolu.jiang@intel.com X-Gm-Message-State: p1AVK5iKVkw4rrwAYOF3mp0nx1787277AA= Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1636515234; bh=3NQjZdPtZ4NHTsGia3bwjZIlCfZK+tVar77lQpM1rZ8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=F4DUFidvQmYeAkAUxxnpM96MadlqqtPK+oCfbjFoB7fysv/UXJz87Erv60Get98fBou jRnpI4u439asGwMNfzglX1CokGjaK+tGi2yMi1GOJHV4P+fcKW7KKmgIoWfb9YheULxmG s7KxzPRfUIG5ioN+7MxxWvvQYnj5JppwU/s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1636515235983100001 Hi All, I have update the patch for the comments, Please help review the patch. -----Original Message----- From: Jiang, Xiaolu =20 Sent: Monday, November 8, 2021 4:22 PM To: devel@edk2.groups.io Cc: Jiang, Xiaolu ; Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for = support more PCD value. Currently the PCD Value only support 13 Guid,When use more 13 pcd will caus= e the build tool fail, Need calculate the required memory,then allocate it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3718 Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Xiaolu Jiang --- BaseTools/Source/C/DevicePath/DevicePath.c | 36 +++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/C/DevicePath/DevicePath.c b/BaseTools/Source/= C/DevicePath/DevicePath.c index c4d224ed61..8a0f5f4e2a 100644 --- a/BaseTools/Source/C/DevicePath/DevicePath.c +++ b/BaseTools/Source/C/DevicePath/DevicePath.c @@ -144,6 +144,40 @@ Returns: *UniString =3D '\0'; } ++/**+ Returns the length of a Null-terminated A= SCII string.++ This function returns the number of ASCII characters in the= Null-terminated+ ASCII string specified by String.++ If Length > 0 and D= estination is NULL, then ASSERT().+ If Length > 0 and Source is NULL, then= ASSERT().+ If PcdMaximumAsciiStringLength is not zero and String contains= more than+ PcdMaximumAsciiStringLength ASCII characters, not including th= e Null-terminator,+ then ASSERT().++ @param String A pointer to a Null-= terminated ASCII string.++ @return The length of String.++**/+UINTN+EFIAPI= +AsciiStrLen (+ IN CONST CHAR8 *String+ )+{+ UINTN = Length;++ ASSERT (String !=3D NULL);++ for (Len= gth =3D 0; *String !=3D '\0'; String++, Length++) {++ }+ return Length;+}= + int main(int argc, CHAR8 *argv[]) { CHAR8 * Str;@@ -170,7 +204,7 @@ int= main(int argc, CHAR8 *argv[]) fprintf(stderr, "Invalid option value, Device Path can't be NULL"); = return STATUS_ERROR; }- Str16 =3D (CHAR16 *)malloc(1024);+ Str16 =3D = (CHAR16 *)malloc((AsciiStrLen (Str) + 1) * sizeof (CHAR16)); if (Str16 = =3D=3D NULL) { fprintf(stderr, "Resource, memory cannot be allocated");= return STATUS_ERROR;--=20 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83538): https://edk2.groups.io/g/devel/message/83538 Mute This Topic: https://groups.io/mt/86949833/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-