From nobody Thu May 9 01:54:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+79468+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79468+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1629265639; cv=none; d=zohomail.com; s=zohoarc; b=N98NJFQ6h+LBr0pedG78Cam+NskgrCviRBWGeXjxIz7YZ+rCaxjnYbpCMVxC+IDyInK/PX7SA+SHsIp11j2EeB3iZPi/bA7KvXAOKOGIfiGrgy57vnJrIhIwgFGVQaJRTAAEWFV8ExS1OLKeZ5uAIbiHQyXcQwJiOZ+Tt44Spb4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629265639; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=cLjuaCd0dMM1OQdh7IoV4tacDW1q4D9tc4gUt3CNSV0=; b=Vqwg02q0fQgIHlW4vV7MShmc3p5Wvvj9c+6mVo4k54Ebb0AaLl6kKaFPMfUdM5j6+NHPeFZQh/BP6kWSjfAnliGXygYSBpgEdpU6UEMriXuPsopJpqHmTIWmcrEdPk71KQxz/ODWKV7Msph9enghNhZ8oZ+VfLZ8CE95BlXsWFM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+79468+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1629265639494161.73732596415198; Tue, 17 Aug 2021 22:47:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Hf5oYY1788612xoKkuQPeunu; Tue, 17 Aug 2021 22:47:19 -0700 X-Received: from us-smtp-delivery-162.mimecast.com (us-smtp-delivery-162.mimecast.com [216.205.24.162]) by mx.groups.io with SMTP id smtpd.web12.38683.1629204467474355308 for ; Tue, 17 Aug 2021 05:47:48 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2042.outbound.protection.outlook.com [104.47.57.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-MiuodUhhN1aW-6-8eDTWSw-1; Tue, 17 Aug 2021 08:47:45 -0400 X-MC-Unique: MiuodUhhN1aW-6-8eDTWSw-1 X-Received: from DF4PR8401MB0364.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7605::18) by DF4PR8401MB0412.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7606::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.18; Tue, 17 Aug 2021 12:47:44 +0000 X-Received: from DF4PR8401MB0364.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b98d:5b48:70bd:df8d]) by DF4PR8401MB0364.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b98d:5b48:70bd:df8d%9]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 12:47:44 +0000 From: "Stewart, Chris (SW Architect) via groups.io" To: "devel@edk2.groups.io" CC: "jiewen.yao@intel.com" , "jian.j.wang@intel.com" , "xiaoyux.lu@intel.com" , "guomin.jiang@intel.com" , "gaoliming@byosoft.com.cn" , "Stewart, Chris (SW Architect)" Subject: [edk2-devel] [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order Thread-Topic: [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order Thread-Index: AdeTZWn9e+OMYwM0SZuj1bAj4PHfAg== Date: Tue, 17 Aug 2021 12:47:44 +0000 Message-ID: Accept-Language: zh-TW, zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-bromium-msgid: b3215ff1-e3e9-4e8e-a88e-74d3c5e093b1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c9e5fd7-b8a8-494b-66f2-08d9617d3545 x-ms-traffictypediagnostic: DF4PR8401MB0412: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Gm/OoMPQqsr8kBFFEVgPJGN8L7Xyfl5yxZC8pFJn/xb0/VHxLmWCRu1mXFyRIhHjSYJb2OZJBwGqTXuoMoGl2QCD2929Lb41wjar/7c8dkA/YYoqDjfR/wf3NbAy94fkHbG5qEHmoFFFfNz7xFRwcB01JjUDb1N1AVzXVonVMLIZ8vzjWAIVU7mIEPvnq/5WGB7cmOrdQpPmT28F5osiwXHb2QCxA1BnKnyB/Nc4P4IvmNzJkHpZxIc6/+u1Eru25nQnYVJg8K8+GftAzgSYDLo6Jsws+8pUEsUTb3WSB8x29n+dc0PgOxptA1TdfsrPBgDXyEJalfoVfPSigiR4yWm7Ftr8W1xdsy2KlvdNl1yXOXDR/cvbSFd0AgFcySgfZA2I+F1GBGV3fKTB0let7Vm9ajp6o40qCOgMcTg0tM2CnrTns8kNWzAigQbRQiIRdlXiGs3GDs+8miI/aPKvIFfsMH4+iN4JjrlDFlpQZsyQoYnKgo9CfglX/Ggr2/X0i4X/vFOR1FRiy6oYaKDa57D59XVdcokU5La7ivGyqC4zCfXSq0aK/kqK+u4XghYH+++88/T5zbHlutZG8Ybcy0i9K6IbE6eTyhBWXfe7iE5YmHiUIuBZ0hX6CHIL6Q0Av199YOuj0SZ+UOHp+OUzkHd2GquTv5nkA+LPkw6i/tcUppPyriAbluvO4h87udcTJTchM4M7XsVgzmu/354ZXbpvkPbgpVpT1ycJyfOEcQY9fqEflVVCmYFv2AXlaeQA+t6IO7qpFWiYSxKs2ckDdsAMo19rJp5hvu3hGFZMTYs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dU1ONQvhizmgv4rYoQcf6bP1cBU9T7GajulYnP60+mYoBoBqRF7RaNthiuOS?= =?us-ascii?Q?tja0pvq2vXRi8/0z3OalZ8CUplgB34ii2QacxcthEUtQTYWGQLWTs9XUsqG3?= =?us-ascii?Q?o5x4LZwyUb5h5esOiIb4PZAkTBxcbnniCiBqVbDYq/lwO+2ES5hP5oYPSloB?= =?us-ascii?Q?MqPK2HLO2TqML3w0Gnaf6j6iR8lxmCcAZcZ72BmvGqy98qyBmEvKjqc2AV9C?= =?us-ascii?Q?ho8jzZvVOGvaUSrZMVGK7v5bv2AAGKf5SWbHl7VqOxeEBirA5DcEf47L9BmS?= =?us-ascii?Q?M+FhiKPvnZmLSkeP+yzhRJTCG3/RHSiXKt9yYpcojDo6zBZVpjqHelb9tyNy?= =?us-ascii?Q?T8Ztr1civ1cD8pu4iqwuOaWmzMPHyDwkULP0C0dPLqAqWD5tH9zpywAxhR1U?= =?us-ascii?Q?jKkneUcvv0JaZCWnepbqpRN6vQ9Atb81N1AItHjyEnYb+X2R37BjjH4+nQx5?= =?us-ascii?Q?+2rqVTGz0T4DFxmgjgC18PA4gaoUXfLKJuhrdYl7qaIEpQpfksPYm6+QKOZQ?= =?us-ascii?Q?slm3OvOHUu5kYgxQ+tgeZcgG9UdN5Nqw7+RpP1Q5V9i0LJJm1fdLq3n1dgKg?= =?us-ascii?Q?Mvq4WcnyXGOVRTSYCHNy0fmlTReJP8hQCwaeRrbnlnqofHENV0y1Z58wJeVu?= =?us-ascii?Q?2N0mBgo5eMv4aqBq/5fgDoS/CRp71eBz5zwZsepKLWJ+yFuQa3Jtfzf1/9aX?= =?us-ascii?Q?kSOcMS5HMFBFEJ2rd9YFND8ZkcHHTVCV2r83rVO99QJz93WOyBCKD4wBvbNz?= =?us-ascii?Q?ApNEJDjAPKbSoLotOQ+5/zaVgxcCwajp30jyA83BmdYdd1E9TXJcILmMGF3o?= =?us-ascii?Q?zsiBfDjrpFYPIpm57vvjX93f+9e1H+Ei5w2JB0nhgoaOvavmJv9Pu6KnzqUb?= =?us-ascii?Q?Gtf5IH7emD1cYea1VpwQnCQRIMmtPXj2bjLKqT5voX22UoMliesIxnycChrO?= =?us-ascii?Q?lV/TpuJ7vjSuiWNoasY83ZNXeprgkJT61CwyHui2YKBBU+bmMvGLilhbu2SR?= =?us-ascii?Q?joHbqfEeQvGjvsbNtnsB3pn9MRimef0y0K2q6f3I4REV2JdI4GZHpwBHgO8B?= =?us-ascii?Q?YfA5LoNNa6mRAEIOaUockFGI2pFQwkyPtibfOnuRBdhe3mZFBCgH+L6VeQXg?= =?us-ascii?Q?SogP+uMgCj1bSp49d0znMib7TclUdN7EKxT2NAP46nkBTHfFOOSIcNSyziwi?= =?us-ascii?Q?LlGSUJQW6hQB/SFpaBlN/yPEyz5kd8hsqGeTYo38fWigCkUR4rV89qIl49bg?= =?us-ascii?Q?0MaxPszU+pt9YizTOhv3PvXOqJn5Hyd58bGuJcRPNrP2vCJ3cYk2Y7REqk0n?= =?us-ascii?Q?hgyWDRFr8AKwA5iB574EfqDu?= MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0364.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 4c9e5fd7-b8a8-494b-66f2-08d9617d3545 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 12:47:44.0383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CTmYwD6VtZRr5Z1xf+0rHu8elhH7Z+fjdkxZEmZD5ewn9EYRfsIdjwcanJW2nZt6EgNaeuJ/f7+89BnsvdBM1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0412 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: hp.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chris.stewart@hp.com X-Gm-Message-State: TwVg1ReGuN2A5Hg9A0Ucguphx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1629265639; bh=jr66/uEtTlvKCRqT29LiCtEPFqVcRbSRl/haxuTvA8o=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=TGv9Aq8QN39Sh/UywNVRdgCqBgKegXFLUtOSca8ir/1za16dMELtjkTXidxU0mCHKej OauDel/cHgIUKa8ELlfq9upgLi1vFt3wB9FDNk1//vMbRQqdhgC950AVhU8vRORhxsH7+ yEFulunq9e1Ntg46UtJubvENCbtTIJnzpqo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1629265641707100002 Content-Type: text/plain; charset="utf-8" [PATCH] Package: CryptoPkg/BaseCryptLib: fix incorrect param order REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3550 Function ConvertAsn1TimeToEfiTime initializes timestamp to zeroes with SetM= em, but the actual parameters are out of order. The result is the SetMem operation has no effect. The fix is to put the act= ual parameters in the correct order. Signed-off-by: Chris Stewart Reviewed-by: Liming Gao CC: Jiewen Yao CC: Jian J Wang CC: Xiaoyu Lu CC: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c b/CryptoPkg/Librar= y/BaseCryptLib/Pk/CryptTs.c index ff7f6488f2..970e9b94a0 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c @@ -155,7 +155,7 @@ ConvertAsn1TimeToEfiTime ( } =20 Str =3D (CONST CHAR8*)Asn1Time->data; - SetMem (EfiTime, 0, sizeof (EFI_TIME)); + SetMem (EfiTime, sizeof (EFI_TIME), 0); =20 Index =3D 0; if (Asn1Time->type =3D=3D V_ASN1_UTCTIME) { /* two digit y= ear */ -- 2.19.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79468): https://edk2.groups.io/g/devel/message/79468 Mute This Topic: https://groups.io/mt/84966675/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-