From nobody Sun Feb 8 15:42:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91192+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657313928367346.9852493780222; Fri, 8 Jul 2022 13:58:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id EG4dYY1788612xv8K6adt4e3; Fri, 08 Jul 2022 13:58:48 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.51]) by mx.groups.io with SMTP id smtpd.web08.4196.1657313927181869771 for ; Fri, 08 Jul 2022 13:58:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eGsNc66fb763/E2S25qNvI5rn/AQktxq1erV+b1mAjR1QKplnIvfRulwA5evfKSNIywBP3ACGXxBOztwtIDiiBqTzILX7IJnEl6YpNqOrFPXUawWW9vnCAJ8f/ZPx3P4HrtWVejW53PjlguAso9JJIycjm5FWg/VjyoVbZnGmlY6n5AiKIPmh4Xk8sEjrcyRIMsSLmAK+Ksy0imVdq8Ote4AuGRyeUuQ96aRGSLaDpstNimX4+/3m9yjD3VaIM5yvkfpoDH4uGl8UyGWLJ1wvHNTnSVu6hcKzm08va/wiTwRuI2mK+pg9TJS5o38EOR+Q3ShpVmH3N9axwOx2DQfuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MjjxvJTNL0sXW+Bjdw2xGbkdZJgSg5iSJZiVnk5iJis=; b=cvw/UfVTxsn6vbEM08qFunSxLCoE+Xhx1APVj4j1VGu91WD0PEHoc51OcOZrtGsKK9cOabJX7GbIrDSXlclPg/Aa8RiHhfuvz8RHswKrUj9ZeCPeF54ARrdzZv7KjbtC/5sGxLVDuCstRmU6FxLzc3o8wvXdI3A30XXP0avkD/aukGXOhOHRMLR5cpPjPxEeOtuWfhZtYsGnS28puXVywV8Qo6g4uy7BerpCcxH1sbPbndn8+A2g4yKJxdltLspkQTcGfn98e0n5K4qEHCu6muaA/V/WprWdvqwlbjPy1UmOUKMRPbHhmvMSAgKkAb2rEx8UioRdPq+fbSKefTIy7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN0PR04CA0064.namprd04.prod.outlook.com (2603:10b6:408:ea::9) by BY5PR12MB4950.namprd12.prod.outlook.com (2603:10b6:a03:1d9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 20:58:43 +0000 X-Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::72) by BN0PR04CA0064.outlook.office365.com (2603:10b6:408:ea::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 20:58:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91192+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (12.22.5.235) by BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 20:58:43 +0000 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Fri, 8 Jul 2022 20:58:42 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Fri, 8 Jul 2022 13:58:41 -0700 X-Received: from perses.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.26 via Frontend Transport; Fri, 8 Jul 2022 13:58:41 -0700 From: "Jeff Brasen via groups.io" To: , CC: , , Jeff Brasen Subject: [edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value Date: Fri, 8 Jul 2022 14:59:01 -0600 Message-ID: <9cbfc2c4fdca71cd042cda4dcec1a029e767141a.1657313523.git.jbrasen@nvidia.com> In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4dafba0d-f76d-45d6-a00e-08da6124a497 X-MS-TrafficTypeDiagnostic: BY5PR12MB4950:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: iABeb3/XIP1l/JvGFLMbXSGxKnlRNTUiDwrD4+DQrrhWBcYTKPjMgV4Hh9F3Up7JLXMX6oPAY1+d+JCXih4CUyTIZwI1AWmlOaY6w8652rz/lLAaHy8m/NT6IpIZy7L3PS3XTHetUTuC41oOFMSlT8AyeZXvFw1RrDxG73QIgpm7LjIU1uD5Tq8AMwfdOD0pREvtvxCM0K0FjwSYzAooEJg3jC3Hvsh6yKzEE0wfJKBxKZmMsjvspsSymSfbFeNSKE2VgDK7lCrZCDjG2FCZfy1Qez4T3CEO0okJF3u7Hs23T5oNF63jaAgz1VsgdXAvVTPCrr4MWtdNYwUzrJOA7uqjgC/D/wSDNhBn7yr7nkhwqdN204vBu46mR5vNkiPvULa4r2Ge4/oFa2YOsYAyv6Ok3d1mCJzcAM92GAEwiP2OpP4FuLF2wZI5MdZ+UdOVKsMgO1+mQGjdD6kyOGMdwFMj8i2IuWSjAp9LDQBRGYOSnvAHuLkuXBkdVlq1UaR6pn9B0H1Gh554uia25uZHzixEbvARif0rGuBVwLuTZkChGUbq71GAaps7CqcREP8VILHGj+I8OqYEUgSpdCBp8X/M3LEJlXjSeg8c8oyQDqIAoa4/0eIRsuZlJIndWKwnud/j+TBcVyyyStn1P7EySeUAPqdcJTqEZsKQbtxTD+MMqda4HbNXIJDDqiYCDb1X9JrkuDWvLbcaFQxv1vOMtREiX3aXpjd1rIc+zsFr8JfCevZ4zhm74Q7/4WtNN3BL9uTQ4wtnfD0j6xe5pGhbiMK1YMA/hlGKVs2Er4M068HT9qHyq0RLOAGicBn3wcs8W89FiCpM8wwCN8p8r0rCijdsyABvadlEIanv78sioqjyDPgGrrOANQYG2zopljsp X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 20:58:43.2745 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dafba0d-f76d-45d6-a00e-08da6124a497 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.235];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4950 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: GWnTC9MztPdjlIRwCJWZQX1ix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657313928; bh=kCKcnFvy/fLsltGY/t4kPgVdEunJYuJSvgmAbL0dONU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=O12MmC8aQRx/qNmNkjz4SHWLEs4C+mzJl4Shp+zElO61GEI270niKE4HGhdFwm+WjET grjLL54ZrdHBpyjC2lE28sm181gDNgELtqoTEXEB4kAituaprBbUlCO7z6vUisF3VdFjL KSTlwIwTPIkGWdhjjO17axK4RbYQqQolSsY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657313929770100001 Content-Type: text/plain; charset="utf-8" The translation value in ACPI should be the difference between the CPU and = PCIe address. Signed-off-by: Jeff Brasen Reviewed-by: Sami Mujawar --- .../Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c index a34018151f..d4c5f47b07 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c @@ -540,6 +540,7 @@ GeneratePciCrs ( UINT32 RefCount; CM_ARM_PCI_ADDRESS_MAP_INFO *AddrMapInfo; AML_OBJECT_NODE_HANDLE CrsNode; + BOOLEAN IsPosDecode; =20 ASSERT (Generator !=3D NULL); ASSERT (CfgMgrProtocol !=3D NULL); @@ -609,6 +610,11 @@ GeneratePciCrs ( } =20 Translation =3D (AddrMapInfo->CpuAddress !=3D AddrMapInfo->PciAddress); + if (AddrMapInfo->CpuAddress >=3D AddrMapInfo->PciAddress) { + IsPosDecode =3D TRUE; + } else { + IsPosDecode =3D FALSE; + } =20 switch (AddrMapInfo->SpaceCode) { case PCI_SS_IO: @@ -616,12 +622,12 @@ GeneratePciCrs ( FALSE, TRUE, TRUE, - TRUE, + IsPosDecode, 3, 0, AddrMapInfo->PciAddress, AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1, - Translation ? AddrMapInfo->CpuAddress : 0, + Translation ? AddrMapInfo->CpuAddress - AddrMapInfo->Pc= iAddress : 0, AddrMapInfo->AddressSize, 0, NULL, @@ -635,7 +641,7 @@ GeneratePciCrs ( case PCI_SS_M32: Status =3D AmlCodeGenRdDWordMemory ( FALSE, - TRUE, + IsPosDecode, TRUE, TRUE, TRUE, @@ -643,7 +649,7 @@ GeneratePciCrs ( 0, AddrMapInfo->PciAddress, AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1, - Translation ? AddrMapInfo->CpuAddress : 0, + Translation ? AddrMapInfo->CpuAddress - AddrMapInfo->Pc= iAddress : 0, AddrMapInfo->AddressSize, 0, NULL, @@ -657,7 +663,7 @@ GeneratePciCrs ( case PCI_SS_M64: Status =3D AmlCodeGenRdQWordMemory ( FALSE, - TRUE, + IsPosDecode, TRUE, TRUE, TRUE, @@ -665,7 +671,7 @@ GeneratePciCrs ( 0, AddrMapInfo->PciAddress, AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1, - Translation ? AddrMapInfo->CpuAddress : 0, + Translation ? AddrMapInfo->CpuAddress - AddrMapInfo->Pc= iAddress : 0, AddrMapInfo->AddressSize, 0, NULL, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91192): https://edk2.groups.io/g/devel/message/91192 Mute This Topic: https://groups.io/mt/92260870/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-