From nobody Fri May 17 08:24:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91067+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91067+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1657037512; cv=none; d=zohomail.com; s=zohoarc; b=lswMnsYSq1me9jjYvIZH6caxPETnzsFmzh2vp1hnIlCmHi9385qXLFAKGuRL8+V6PenwBBfEqjSdU9766b+SB1zitNhgkCHk3QZC23A0WefW+9iuVl9USkDM/noZiv0Un1gtT6ladSRVFOhPlo/WimBCyjtyQkho5VOjmSRq/kM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657037512; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=pCw9Eq0amh6h4nEVIl9ZFlWyuBO/xjCqn1eaIuL+jZc=; b=UlRMhB9mBNbOp6PGjXxrHCIb+6mUudPbG+ZKuXhIXv7tS9hE8lQdibATwKfNZwFuqoBJJD7MSkbrzxGaxA/GY0DdZxPeYfvn+myDEWVQLwkfbGaJ9ZqcDDHkBytVXxzSbeMPqKsUfc51Dp/GErFGa99zN2Qep5+lqoscZjbd0nw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91067+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657037512577184.13928083248163; Tue, 5 Jul 2022 09:11:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3u3kYY1788612x7MHsuMPQyi; Tue, 05 Jul 2022 09:11:51 -0700 X-Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web08.70361.1656928814242654702 for ; Mon, 04 Jul 2022 03:00:14 -0700 X-Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id BCB0CCD1F7E0 for ; Mon, 4 Jul 2022 18:00:10 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id B78B0CD1F7DE for ; Mon, 4 Jul 2022 18:00:10 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com X-Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6D3B5CD1F6BA for ; Mon, 4 Jul 2022 18:00:10 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 8E90CCD1F7F6 for ; Mon, 4 Jul 2022 18:00:07 +0800 (CST) X-Received: from localhost.localdomain ([58.212.134.2]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 04 Jul 2022 17:59:58 +0800 X-WM-Sender: xueshengfeng@byosoft.com.cn X-Originating-IP: 58.212.134.2 X-WM-AuthFlag: YES X-WM-AuthUser: xueshengfeng@byosoft.com.cn From: "xueshengfeng via groups.io" To: devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn, edhaya.chandran@arm.com, samer.el-haj-mahmoud@arm.com, sunny.wang@arm.com, Lijun10x Subject: [edk2-devel] [PATCH] MdeModulePkg/Variable: SCT run AuthVar_conf is failed Date: Mon, 4 Jul 2022 17:59:48 +0800 Message-Id: <7d6c057e3c99869d75dd11d3a77671a3ec33ef2e.1656642493.git.junx1.li@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xueshengfeng@byosoft.com.cn X-Gm-Message-State: k09N53AWnU4k0f9ZNVulYZpvx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657037511; bh=DWCXcRDNAnlccwKQCHImKCB/B7O55I/2cha+KOVdLo0=; h=Cc:Date:From:Reply-To:Subject:To; b=S+/M2/9HhFiBXR4QWmSW8sioDu5hNHmzvPw92oM8v97PfpDaTct8N42lf0tQq+k1YaV j/VWgFC5FVRkoi23cetLsjcrSR8sc+StE+RaiyM0qoANYvT3yVmNXYHpDIG4S1P5NSJuQ fFH5vii9oqeUNy2HJa9mCYRLK0Rg0nNFiKM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657037513850100001 Content-Type: text/plain; charset="utf-8" From: Lijun10x REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3969 Attr are EFI_VARIABLE_NON_VOLATILE|VARIABLE_AUTHENTICATED_WRITE_ACCESS, will return EFI_INVALID_PARAMETER. Added one case, only when one attribute is EFI_VARIABLE_NON_VOLATILE will EFI_INVALID_PARAMETER be returned. If attr are EFI_VARIABLE_NON_VOLATILE|VARIABLE_AUTHENTICATED_WRITE_ACCESS will return EFI_UNSUPPORTED. In the UEFI2.7 spec, there is a description as below: EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and should not be used. Platforms should return EFI_UNSUPPORTED if a caller to SetVariable() specifies this attribute. Signed-off-by: JunX1 Li Reviewed-by: Liming Gao Reviewed-by: G Edhaya Chandran Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Sunny Wang --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeMod= ulePkg/Universal/Variable/RuntimeDxe/Variable.c index 6c1a3440ac..14c176887a 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -2676,7 +2676,11 @@ VariableServiceSetVariable ( // // Only EFI_VARIABLE_NON_VOLATILE attribute is invalid // - return EFI_INVALID_PARAMETER; + if ((Attributes & EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS) !=3D 0) { + return EFI_UNSUPPORTED; + } else { + return EFI_INVALID_PARAMETER; + } } else if ((Attributes & VARIABLE_ATTRIBUTE_AT_AW) !=3D 0) { if (!mVariableModuleGlobal->VariableGlobal.AuthSupport) { // --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91067): https://edk2.groups.io/g/devel/message/91067 Mute This Topic: https://groups.io/mt/92188170/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-