From nobody Tue Dec 16 03:11:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90961+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90961+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1656634462; cv=none; d=zohomail.com; s=zohoarc; b=acFQk4r0rNuE7c81B60eB11d6grOJ2z3uUf/I4ufBZoqXBQatfln+3l2iPAHdY05q9LT5RsuDxYIoVpNaWsvTys3abD6fwgDZM20r4U6G5za3bKPMCHBl6xb489bCdFOeCG9OUal11oNKVg2XyNtwabxziarkfPjaZL+2sN6Xok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656634462; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=vrHhjPT2cUcwFcD2pKqc60RV5G/NteKLgEv0QNVNp5I=; b=Adl2+Z0uLlP7/c3PRzme+gH61yARexm0HtdNFCAAoUdCocXVYugbx2rK/2TyMnZx2uuz8IkxlTKTMxak1fQGN/lPyNG5Qt4G0b+nmfOS19LbF7b48nEylj/vN3oQpQnu9Xx+MYrpgxtxRfZxwPF+Agg1nbn+lOYOyqx/pNKVWhE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90961+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 165663446224257.61946653608561; Thu, 30 Jun 2022 17:14:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WOTFYY1788612x7r0BVDaioe; Thu, 30 Jun 2022 17:14:21 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.32762.1656634461043942097 for ; Thu, 30 Jun 2022 17:14:21 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="281268317" X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="281268317" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 17:14:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="768313217" X-Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 17:14:20 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Nate DeSimone , Liming Gao Subject: [edk2-devel][edk2-platforms][PATCH V1 1/5] IpmiFeaturePkg/GenericIpmi: Fix GCC compilation warnings Date: Thu, 30 Jun 2022 17:14:06 -0700 Message-Id: <7af494accd8dea409ebbc05f7a5fa6f1e88f506a.1656634277.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: YB8S1T4VeSxfBDVHR7ttjz1gx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656634461; bh=jcxRvpI28j0uA09EaHQ9pzc7266DLt+k5hV+WajO0bo=; h=Cc:Date:From:Reply-To:Subject:To; b=G2mh954TexRcP8smkdNO4jkKexg5YxrRZo47aL5B2pmFHAqY2POQtTo1sVAMpJaWIyV 0HzChsC7z2184oDtyYXqAGTfZrwOBD3dYi5QnpErZb9vjT5Xwo+K7AyM508LZCeZ9L6bT y3V+Za7FZV4KHFDYDGB6emB6l8X47iPO/Yc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656634464370100008 Content-Type: text/plain; charset="utf-8" Fix compiler warnings for unused variables. Fix PeimIpmiInterfaceInit to return initialization status instead of EFI_SUCCESS. Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Isaac Oram --- .../IpmiFeaturePkg/GenericIpmi/Common/KcsBmc.c | 8 +++----- .../IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.c | 3 +-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Common/KcsBmc.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Generic= Ipmi/Common/KcsBmc.c index 7243d37cc5..cf1929f399 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/= KcsBmc.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/= KcsBmc.c @@ -36,7 +36,6 @@ Returns: EFI_STATUS Status; UINT8 KcsData; KCS_STATUS KcsStatus; - UINT8 BmcStatus; UINT8 RetryCount; UINT64 TimeOut; =20 @@ -101,7 +100,7 @@ Returns: TimeOut++; } while (!KcsStatus.Status.Obf); =20 - BmcStatus =3D IoRead8 (KcsPort); + IoRead8 (KcsPort); =20 KcsData =3D KCS_READ; IoWrite8 (KcsPort, KcsData); @@ -184,7 +183,6 @@ Returns: { EFI_STATUS Status; KCS_STATUS KcsStatus; - UINT8 KcsData; UINT64 TimeOut; =20 if (Idle =3D=3D NULL) { @@ -205,7 +203,7 @@ Returns: } while (KcsStatus.Status.Ibf); =20 if (KcsState =3D=3D KcsWriteState) { - KcsData =3D IoRead8 (KcsPort); + IoRead8 (KcsPort); } =20 if (KcsStatus.Status.State !=3D KcsState) { @@ -231,7 +229,7 @@ Returns: } =20 if (KcsState =3D=3D KcsWriteState || (*Idle =3D=3D TRUE)) { - KcsData =3D IoRead8 (KcsPort); + IoRead8 (KcsPort); } =20 return EFI_SUCCESS; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 14040c089c..3efb772b68 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c @@ -167,13 +167,12 @@ PeimIpmiInterfaceInit ( { EFI_STATUS Status; =20 - // // Performing Ipmi KCS physical layer initialization // Status =3D PeiInitializeIpmiKcsPhysicalLayer (PeiServices); =20 - return EFI_SUCCESS; + return Status; } // PeimIpmiInterfaceInit() =20 =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90961): https://edk2.groups.io/g/devel/message/90961 Mute This Topic: https://groups.io/mt/92099075/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-