From nobody Thu May 16 22:27:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110576+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110576+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1698969837; cv=none; d=zohomail.com; s=zohoarc; b=nd2sfWOX6KepVShgVH9wo1z+UaiI2vNPgu2e41LGdDOFgqdvCy+kLA7/cbuwdm6Rp6OeYMqLfRVG1S/MHZKNJ7knshhixIn1Lkp5TAMJ3pUDD+B3EszUy7PIFz5ty3zccANLd/yVdK+yoCY3IrP+aKUOEu1Ybc8+Op1j/psdXBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698969837; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=yDMgomRuQIuwH7y6LFUKNe92X5dgxRur5I3pN0Zq97E=; b=lD5YR4ItIKtoV78WkFtZsUeYWEeja5FnPci7V0Sc60giNL9E/wgcGifUKczB9XzP/uICNytdh3FpeIAwgzKzSexhkKS0HFLT+MPnjAHuLGzOVT9Pm3uLfnI49SxEGjYKJc0Aa4QW8lSQmzOjc2x1fN5sSL67ha8oj8lGh2f3EBs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110576+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698969837464400.5603201804447; Thu, 2 Nov 2023 17:03:57 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=0HQo+KslVvtP2okzsJLqPRFugAERHA2kF+RKm997yXE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698969837; v=1; b=b2HHl3fyMaz/On9qVYB7EuppRlYyaHDV6YAN5/BlEhhiql5ItURb6ygdb+lhsGOLeyHKLIBo Fq69satFAJQ/UkwIuYxbIt0rPgBwAs+EKFX3m9BDMp9IxxgIOQ5vE1SG1YOXRPsKdaEiRPcltF4 K1wC0AWvVQZAwLAHuhptWiJ8= X-Received: by 127.0.0.2 with SMTP id WOFiYY1788612x35H0YxJQy8; Thu, 02 Nov 2023 17:03:57 -0700 X-Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by mx.groups.io with SMTP id smtpd.web11.6528.1698969836350107893 for ; Thu, 02 Nov 2023 17:03:56 -0700 X-Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3595eb920e9so2148355ab.0 for ; Thu, 02 Nov 2023 17:03:56 -0700 (PDT) X-Gm-Message-State: F9r3dM35kKO8MeVEA2EvHe37x1787277AA= X-Google-Smtp-Source: AGHT+IFdkF7kGl4zkHH/x9BI0DGyw2NokiwFeu66lb4ciXaP8+5s8Bae+QCQo8a6DyzPHrAVKgl/Jg== X-Received: by 2002:a05:6602:2c82:b0:7aa:125a:b0c4 with SMTP id i2-20020a0566022c8200b007aa125ab0c4mr27919816iow.5.1698969835243; Thu, 02 Nov 2023 17:03:55 -0700 (PDT) X-Received: from JOE-LENO.redmond.corp.microsoft.com ([131.107.159.17]) by smtp.gmail.com with ESMTPSA id fd15-20020a056a002e8f00b006b5922221f4sm275600pfb.8.2023.11.02.17.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 17:03:54 -0700 (PDT) From: "Joe L" To: devel@edk2.groups.io Cc: joelopez333 , Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Jian J Wang , Liming Gao , Hao A Wu , Ray Ni , Pedro Falcato , Michael Brown Subject: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write Date: Thu, 2 Nov 2023 17:03:35 -0700 Message-Id: <742009f523e8645102f784a3c0df6af870c68804.1698966883.git.jlotwo@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlotwo@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698969839099100003 Content-Type: text/plain; charset="utf-8" From: joelopez333 REF:https://edk2.groups.io/g/devel/topic/102310377#110456 - Add a read after the final PCI Configuration space write in RootBridgeIoPciAccess. - When configuration space is strongly ordered, this ensures that program execution cannot continue until the completion is received for the previous Cfg-Write, which may have side-effects. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Cc: Pedro Falcato Cc: Michael Brown Signed-off-by: Joe Lopez --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c b/MdeM= odulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c index 157a0ada80..4bc774b574 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c @@ -1238,6 +1238,13 @@ RootBridgeIoPciAccess ( } } =20 + // + // Perform readback after write to confirm completion was received for t= he last write + // + if (!Read) { + PciSegmentRead8 (Address - InStride); + } + return EFI_SUCCESS; } =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110576): https://edk2.groups.io/g/devel/message/110576 Mute This Topic: https://groups.io/mt/102354842/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-