From nobody Wed May 1 13:26:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+60930+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60930+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=marvell.com ARC-Seal: i=1; a=rsa-sha256; t=1591676694; cv=none; d=zohomail.com; s=zohoarc; b=XEOYKmn9WsFfYXl2CqKQHTq0kVaqyvTm6WrsLe60pyf8N8mREttdgwHC64A7FWjYjavQlJUdIWtrBFjWV2p/PhDu3kZM4QVgmzTqtMdEzczujXvwiju96PXVOaqBYrBy6OG2syNZs1Qkoi9r8b9Zs9AeF5iY2Z5BMjEYeoxvmgg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591676694; h=Content-Type:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=GbYQxkTMz+RGhPXzjzjbYYlJkF0J+r6HgWdTPQR1LXs=; b=LSXeNtg0Ty3THdlXBYRw5M0ejp0z1qkdluZcmFa8aqXFYaKUs/cH2oXus38NYzRQDUHkKcVJH4yv+AT3DsK9xbLFePNh4Um422UH7cseamM5vhD+vNSd6E00Vjb9BEeUKcd1C4R9BJUsvZ4JOpHvqri+9kD0xpwyrOkasgJexkQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60930+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1591676693924684.6468412327021; Mon, 8 Jun 2020 21:24:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id GWJGYY1788612xYb6qFxt6e8; Mon, 08 Jun 2020 21:24:53 -0700 X-Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mx.groups.io with SMTP id smtpd.web12.299.1591676692693768489 for ; Mon, 08 Jun 2020 21:24:52 -0700 X-Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0594KFQo010990 for ; Mon, 8 Jun 2020 21:24:52 -0700 X-Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 31gann853g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jun 2020 21:24:51 -0700 X-Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Jun 2020 21:24:50 -0700 X-Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Jun 2020 21:24:50 -0700 X-Received: from DarkNight.caveonetworks.com (unknown [10.109.136.103]) by maili.marvell.com (Postfix) with ESMTP id 1FD453F703F; Mon, 8 Jun 2020 21:24:50 -0700 (PDT) From: "Abdul Lateef Attar" To: CC: Abdul Lateef Attar Subject: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. Date: Mon, 8 Jun 2020 21:22:30 -0700 Message-ID: <7018aead66cc281864e78280d3152963fb7ae9df.1591676531.git.abdul@marvell.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abdul@marvell.com X-Gm-Message-State: xhQm3NNj81DkR985Bqvtij1bx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1591676693; bh=NQUvA0RowN/0ZN1u8/XQ9t9y9eoIBCGI7gtgWJTUzJ4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=fTHyCNGTs0kLFvibyX7y6eZM4cSAwxhd7IgXE765ZCzG6xdg1DsqCjniHC+eD0jspW7 UGE9QozEp8JR0iIW+uC5K4HsolK6rpeVhxitGi4DpY43uVvgpUenIEFT4933zuaL69f7u KFDHR4YsymThkfPU19loVu6sXnX8xJhl4Ds= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Its been observed that in MenuManagerMenuApp when user selects a different BootOption using Up/Down key, the current Cursor position is not chaning. Still points to the old BootOption. This changes first dispalys/redraws the old BootOption followed by new BootOption. Doing so will make current cursor pointing to the user selected BootOption. Signed-off-by: Abdul Lateef Attar Reviewed-by: Dandan Bi --- .../BootManagerMenuApp/BootManagerMenu.c | 22 +++++++++++-------= ---- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c = b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c index 34d4089a55..9e729074ec 100644 --- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c +++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c @@ -451,20 +451,10 @@ BootMenuSelectItem ( } =20 // - // Print want to select item - // - FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; - gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLACK= ); - String =3D HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[Want= SelectItem], NULL); - PrintCol =3D StartCol + 1; - PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - FirstIt= em; - PrintStringAt (PrintCol, PrintRow, String); - FreePool (String); - - // // if Want Select and selected item isn't the same and doesn't re-draw s= electable // items, clear select item // + FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; if (WantSelectItem !=3D BootMenuData->SelectItem && !RePaintItems) { gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLU= E); String =3D HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[Bo= otMenuData->SelectItem], NULL); @@ -474,6 +464,16 @@ BootMenuSelectItem ( FreePool (String); } =20 + // + // Print want to select item + // + gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | EFI_BACKGROUND_BLACK= ); + String =3D HiiGetString (gStringPackHandle, BootMenuData->PtrTokens[Want= SelectItem], NULL); + PrintCol =3D StartCol + 1; + PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - FirstIt= em; + PrintStringAt (PrintCol, PrintRow, String); + FreePool (String); + gST->ConOut->SetAttribute (gST->ConOut, SavedAttribute); BootMenuData->SelectItem =3D WantSelectItem; return EFI_SUCCESS; --=20 2.11.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60930): https://edk2.groups.io/g/devel/message/60930 Mute This Topic: https://groups.io/mt/73146931/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-