From nobody Mon Feb 9 07:38:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+63339+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+63339+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1595863881653399.44064108316263; Mon, 27 Jul 2020 08:31:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uv0sYY1788612xmilpt57vxu; Mon, 27 Jul 2020 08:31:21 -0700 X-Received: from NAM04-SN1-obe.outbound.protection.outlook.com (NAM04-SN1-obe.outbound.protection.outlook.com [40.107.70.73]) by mx.groups.io with SMTP id smtpd.web11.58166.1595863880275543448 for ; Mon, 27 Jul 2020 08:31:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRMgXm3f1BsQkPM2297Y4+vi7XsnscWdLs4xT/P4obiLCoM3yqq2S5zJ4ov/pQTWEMPm9ugJrSHGD77oZPO2Ri0MhPIFfZuUakzK79AC+auVX9PzoHHv0+MAxSACYWtgPkey9yvSRm+HAx+sFvrdBoqytZD+y7hMddzFzbnvTFQPs/VDrMDtJ7DpocETzRRu84KUiN+KkoDhylIQvaQcRKkufMyW9g4raYQ11H4bU06o7J3p+HISBbJ5YfrJ7jfbW92u4kVv5USDFi3sk/7az0i8Wxo02+g3BEKwbAbPP5AooL888HMyuyRtP9/rZ7+NgC0tXIKgdmu/AcWeRZ2+EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JkyhLOofvIbow8VdM+XsfKiaUSck6a3v3S8jdpNjfQo=; b=adc91n3SLDAZ/UMSdgMOXQOPe9KwM4p8pBsJPbWs/v/8GI1mZe7vdx6oO5WdyhOthTqUHfKrc/xQVbs8YJmehxKl3w5P/Kyd6Xd0CPJiKZYFceaYq6njkrrE/pLWy1wSrwjqSmTgH4ieZ0594tTy0X7QvSbydo7kATIqqYupCkzi4ujAJOZyyAJoWw8kZ9d7rsfKQdnBaOZY6mB0Gd9+5qEeEdZxeLl70DorCievXTDiJ27iqkzGGT+sceU0H0zS5SgZSqVdna8gAiX9QZuwIXXmz4Kz6RHRB3RNpVrT1Pn4HwAYyLCSihDRYzfjSbibehh5D3Q+dJUAkTEdweWNnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB1163.namprd12.prod.outlook.com (2603:10b6:3:7a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.25; Mon, 27 Jul 2020 15:31:18 +0000 X-Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3216.031; Mon, 27 Jul 2020 15:31:18 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni , Anthony Perard , Julien Grall Subject: [edk2-devel] [PATCH v12 35/46] OvmfPkg/PlatformPei: Reserve SEV-ES work area if S3 is supported Date: Mon, 27 Jul 2020 10:26:16 -0500 Message-ID: <6de8f3220156163493b3614eb8c6e63f6d1d3095.1595863587.git.thomas.lendacky@amd.com> In-Reply-To: References: X-ClientProxiedBy: SN6PR01CA0008.prod.exchangelabs.com (2603:10b6:805:b6::21) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR01CA0008.prod.exchangelabs.com (2603:10b6:805:b6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Mon, 27 Jul 2020 15:31:17 +0000 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ca996c8d-6fdb-4473-4dcc-08d832421bab X-MS-TrafficTypeDiagnostic: DM5PR12MB1163: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: e17N9c5UYGCZgv2BGzocYmyNeHmO6D4vwMO5Jg3r2p9iSjw4G6zjYEbb0PYkkltB7RIUIzfZyGOsl+wCYYcxYoh+FIk0tSXy2+LSi4aHx/Ex5WcMdHlyQfmaeFY64c3PZiRfdY/bVU3hG8+8lHZtUJmwihTMfMpTHxWoLEfCEDBehc175RiRxZvfaYhd3/bNqqd6m20wDSowmBe/4zFPmSHBZOAkoC0sC7EMcS0w8kzpvgpQCqaIsSye5dlXraEZ5vAQFhyqNZJdK7ijcvz3MWZ2Ypx+DJT0JQjaVMhU1DZ7UnSJ81eLVS0KpsjNni0b5AosvRmV0VC/V4+tIsXZJosTdOPoVrGE5YMMyrMkkMooWC6GOMSdFoOeAFRmKBSZ+UdnbmVdP/baKjLrH0dX8PN1ljG7jDchAKrmEGxwdyXnKvBtTmZZZ7cSdu+6a2m/RxSlMqt3KaWGkuiaaMITkg== X-MS-Exchange-AntiSpam-MessageData: 7e+HhUV2LhOjkx/hr+EJzH30ha+9ktrrRH2WCGem0kFAw0Hx+PekePWBXPHfaSVF1sU5wAr/t0jmbUVdmroVoubKp9A282rIOdW2LbPSpuN2WN3AYbsd4VEBwYE1Tufihzhq7HfXmOhleuvWSL9MEioSQCXGZJ8H2o3/A/iYtgsVu0NVQ0bZpp8/finU/TIRsJZKiur0j0T9MeioutEzWUrFWzv2swc4x4CwjNEqI5zef9tfuUbGHLfs62HNH+gunDKSgnEkd4jEI5SI9vGqslgG2DSblLZstRTNj50AymeoGjHDCxR3Orm5jMGoqadDX35NaIt7cFdT17IvbwxHzHDUK88qfALIXJ0DQeY5/DwONCBSXymPaUt8hHiBMDeu6+F9BAt66j5/t5JOk6TtVCeYVwzOcwL+0rSpCWv3hmPNx1m3OfWAwgUWk0vPgRwJ0VaXHxo0AAzzYgyM03rOmEE/31/g2wfKpO5bIvTkHws= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca996c8d-6fdb-4473-4dcc-08d832421bab X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2020 15:31:18.7636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a+4oo+HLRmPl8N6k3yjQ6UfM5EcvGCrvldBdCOqTxm17MNysakyOXK2o3yW8uBErOwySyG+opXesFYSsK1zcMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1163 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: lMacujYW2jgC0ZE8yb8KKG4cx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1595863881; bh=5bBMS9xo5yMtOvg95eafPUjiL/VwEBJLT+6JsEk/Wlo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=mhfWVRauM0agiJi3mj0zMWqHAUB5IF2JvaR0FNnPxm2LOdhcKPHb8d0DYrio4UEDnP/ MSLE78w6hFKYROSHOQFnNQY8BRwoV5ekNpdBvgSJnhWGG5OAQcOWZNUL4iXuBpfbFb4GK ug+DS/b/8fZ1yDqH/3qMl0lW3bfZooWGtTg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 Protect the SEV-ES work area memory used by an SEV-ES guest. Regarding the lifecycle of the SEV-ES memory area: PcdSevEsWorkArea (a) when and how it is initialized after first boot of the VM If SEV-ES is enabled, the SEV-ES area is initialized during the SEC phase [OvmfPkg/ResetVector/Ia32/PageTables64.asm]. (b) how it is protected from memory allocations during DXE If SEV-ES is enabled, then InitializeRamRegions() [OvmfPkg/PlatformPei/MemDetect.c] protects the ranges with either an AcpiNVS (S3 enabled) or BootServicesData (S3 disabled) memory allocation HOB, in PEI. (c) how it is protected from the OS If S3 is enabled, then (b) reserves it from the OS too. If S3 is disabled, then the range needs no protection. (d) how it is accessed on the S3 resume path It is rewritten same as in (a), which is fine because (b) reserved it. (e) how it is accessed on the warm reset path It is rewritten same as in (a). Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/PlatformPei.inf | 2 ++ OvmfPkg/PlatformPei/MemDetect.c | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/Plat= formPei.inf index 4742e1bdf42b..c53be2f4925c 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -118,6 +118,8 @@ [FixedPcd] gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData + gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase + gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize =20 [FeaturePcd] gUefiOvmfPkgTokenSpaceGuid.PcdCsmEnable diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetec= t.c index 6b5fee166b5d..ffbbef891a11 100644 --- a/OvmfPkg/PlatformPei/MemDetect.c +++ b/OvmfPkg/PlatformPei/MemDetect.c @@ -940,5 +940,25 @@ InitializeRamRegions ( ); } } + +#ifdef MDE_CPU_X64 + if (MemEncryptSevEsIsEnabled ()) { + // + // If SEV-ES is enabled, reserve the SEV-ES work area. + // + // Since this memory range will be used by the Reset Vector on S3 + // resume, it must be reserved as ACPI NVS. + // + // If S3 is unsupported, then various drivers might still write to t= he + // work area. We ought to prevent DXE from serving allocation reques= ts + // such that they would overlap the work area. + // + BuildMemoryAllocationHob ( + (EFI_PHYSICAL_ADDRESS)(UINTN) FixedPcdGet32 (PcdSevEsWorkAreaBase), + (UINT64)(UINTN) FixedPcdGet32 (PcdSevEsWorkAreaSize), + mS3Supported ? EfiACPIMemoryNVS : EfiBootServicesData + ); + } +#endif } } --=20 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63339): https://edk2.groups.io/g/devel/message/63339 Mute This Topic: https://groups.io/mt/75825064/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-