From nobody Sun May 19 08:26:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+75504+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75504+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1621850467; cv=none; d=zohomail.com; s=zohoarc; b=IFANKZdTb/KaWpKX+8/wrCnFV6hfKh0XwcWZGiKOZ2Z728ef//BWLUmWvRW0Lh4Rv5NEtSwtT1xyq5T/q3Xl/64G3gVB95p6tKN0g+CwUTM492qDFR+q2VPeJ27KuKAWXe9Relc33aFlSGF5wc9wiyUgAR2UNGiu3b6vPgKpFOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621850467; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=MkqG6zE4tWxaobzYzkHOwDKaR0fTNZdrUl9HAUpNxzA=; b=HIVRO/+DIHDyfGF1+8SgpUCuDlHBMmoPtXOtUjvEqBWO064OuXvZwsWDSnfjNq1qtb++CaD6OSU6heYipM8DzjGs2R8c/c1rec/HykDNGg4fu4qQJHOp7ZoH+k2zL8dViHWJL4/lhrVnzComyjqfgzf6PFE7K5obzRTghh5s7Uc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+75504+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1621850467346248.67211842496602; Mon, 24 May 2021 03:01:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id A3JoYY1788612xhxGhM5Sk9w; Mon, 24 May 2021 03:01:06 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.20969.1621850460943036125 for ; Mon, 24 May 2021 03:01:01 -0700 IronPort-SDR: jtiglsIbQq+YJZiFtbiRKN3GmJvdkH+nT26JJ9D9HUwTpLBrR8Q58/2mxNNHgBTe6MN9XmWfks JbsAgXd74IZA== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="181537516" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="181537516" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 03:00:58 -0700 IronPort-SDR: FAo4iXa2lwuzNGv4qiLbSB6ntM9IfL+Jn0hm7lUNXwDc9OklvailWTNszbmxiC9wdAg72sYVAA 7X8ql0c/XZSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="545862622" X-Received: from ikuox-tiger-lake-client-platform.itwn.intel.com ([10.5.215.23]) by fmsmga001.fm.intel.com with ESMTP; 24 May 2021 03:00:43 -0700 From: "IanX Kuo" To: devel@edk2.groups.io Cc: IanX Kuo , Chasel Chiu , Nate DeSimone Subject: [edk2-devel] [PATCH v3] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412 Date: Mon, 24 May 2021 06:38:05 +0800 Message-Id: <6ba48b2f5b7676eb6bf1199e51ce691b54beff5f.1621846279.git.ianx.kuo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ianx.kuo@intel.com X-Gm-Message-State: KU9bNzNFoVtYmsr1WeVU1nEbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1621850466; bh=gQq9EfkKNzqpDnyFBKG/csIcjp6l/P6zwtH1HfyZczs=; h=Cc:Date:From:Reply-To:Subject:To; b=vybQ/O0m0QZlGT85oM5S1W68vkuWzGOTu/rwJ1LtmxkTevWhMG3RNCyzEQo//t3JRhy vcQ2GffORLtDZXv823SQU7zobI2rOMfpCDSPQOjT58mq0O+7mJNCWKNBDm7njqlnPbVbr HoiGd/BPM5vrL+86ug9m4IYlgyx53GsEjsQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: IanX Kuo (a) C:\Users\\AppData\Local\Program\Python\Python38 (b) C:\Python38 (c) C:\Program Files\Python38 Issue only happens on (a) and (c). (a) happen on have whitespace. Ex: Tony Chen (c) happen on "Program Files" have whitespace. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: IanX Kuo --- .../Tools/Fsp/RebaseAndPatchFspBinBaseAddress.py | 6 +++--- .../MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBa= seAddress.py b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBin= BaseAddress.py index 406e5ec130..f3cba2651a 100644 --- a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddre= ss.py +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddre= ss.py @@ -1,6 +1,6 @@ ## @ RebaseAndPatchFspBinBaseAddress.py # -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # =20 @@ -93,13 +93,13 @@ fspTBaseAddress =3D flashBase + fspTBaseOffset # Re-base FSP bin file to new address and save it as fspBinFileRebased usi= ng SplitFspBin.py # rebaseArguments =3D fspBinFilePath + " -c s m t -b " + str(hex(fspSBaseAdd= ress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rstrip("L")) + " " + st= r(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n " + fspBinF= ileRebased -os.system(pythontool + " " + splitFspBinPath + " rebase -f" + rebaseArgume= nts) +os.system('"' + pythontool + '"' + " " + splitFspBinPath + " rebase -f" + = rebaseArguments) =20 # # Split FSP bin to FSP-S/M/T segments # splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fspB= inPath + " -n Fsp_Rebased.fd" -os.system(pythontool + " " + splitFspBinPath + " split -f" + splitArgument= s) +os.system('"' + pythontool + '"' + " " + splitFspBinPath + " split -f" + s= plitArguments) =20 # # Patch dsc file with the re-based FSP-S/M/T address, so internally build = will use the same. diff --git a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddres= s.py b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py index fb4cf4f9b7..b7e4bcf5f9 100644 --- a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py @@ -1,6 +1,6 @@ ## @ RebaseFspBinBaseAddress.py # -# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # =20 @@ -87,12 +87,12 @@ fspTBaseAddress =3D flashBase + fspTBaseOffset # Re-base FSP bin file to new address and save it as fspBinFileRebased usi= ng SplitFspBin.py # rebaseArguments =3D fspBinFilePath + " -c s m t -b " + str(hex(fspSBaseAdd= ress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rstrip("L")) + " " + st= r(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n " + fspBinF= ileRebased -os.system(pythontool + " " + splitFspBinPath + " rebase -f" + rebaseArgume= nts) +os.system('"' + pythontool + '"' + " " + splitFspBinPath + " rebase -f" + = rebaseArguments) =20 # # Split FSP bin to FSP-S/M/T segments # splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fspB= inPath + " -n Fsp_Rebased.fd" -os.system(pythontool + " " + splitFspBinPath + " split -f" + splitArgument= s) +os.system('"' + pythontool + '"' + " " + splitFspBinPath + " split -f" + s= plitArguments) =20 exit(0) --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75504): https://edk2.groups.io/g/devel/message/75504 Mute This Topic: https://groups.io/mt/83047301/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-