From nobody Sat May 4 12:56:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54594+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54594+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582079874793323.6248367732951; Tue, 18 Feb 2020 18:37:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id I5y2YY1788612xsmtXCrZcQG; Tue, 18 Feb 2020 18:37:54 -0800 X-Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by mx.groups.io with SMTP id smtpd.web09.6678.1582079873287784517 for ; Tue, 18 Feb 2020 18:37:53 -0800 X-Received: by mail-pl1-f195.google.com with SMTP id e8so8903069plt.9 for ; Tue, 18 Feb 2020 18:37:53 -0800 (PST) X-Gm-Message-State: eB1KK00tbNqFm70Xzn57qPLgx1787277AA= X-Google-Smtp-Source: APXvYqzL6Nf9ARHxNMVAmf6IfiSwOu2Lm5X4JMeWqenPybQq2oVIMG8gFdKOX70DtRYAGfgPSoViDA== X-Received: by 2002:a17:902:7c05:: with SMTP id x5mr24355964pll.236.1582079872237; Tue, 18 Feb 2020 18:37:52 -0800 (PST) X-Received: from localhost.localdomain ([117.136.46.20]) by smtp.gmail.com with ESMTPSA id z5sm366987pfq.3.2020.02.18.18.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 18:37:51 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious check for pointer Suite Date: Wed, 19 Feb 2020 10:34:49 +0800 Message-Id: <688166e8ec46f20a29ffedb8703ca7d94059b483.1582079674.git.newexplorerj@gmail.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,newexplorerj@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582079874; bh=wGKv91IsuLG5UiyBLaFrlOa2c7/v6KXouzVjll0wKU8=; h=Cc:Date:From:Reply-To:Subject:To; b=ZsSueDUUWBDWENh2EZkV/TFXq6VUVji2gJtBBR45dsIH2SSvBYbDPcCH7sM/+QjUXIj wMdUsz/PrLhciz9UO9FiEfkU3be/zKuh7HuAifS45wpiK3ddR3jvXqVPkqHta3fmXakfq vN1012PmBmvMSwA5lTrfrMPsBEKMIuYzosg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2530 The Suite pointer is used before check if it is valid, correct it to check the validation before use. Signed-off-by: GuoMinJ Reviewed-by: Bret Barkelew Reviewed-by: Shenglei Zhang --- UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c b/UnitTest= FrameworkPkg/Library/UnitTestLib/RunTests.c index fb247c59e7..b053e04959 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c @@ -33,13 +33,13 @@ RunTestSuite ( UNIT_TEST *Test; UNIT_TEST_FRAMEWORK *ParentFramework; =20 - TestEntry =3D NULL; - ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; - if (Suite =3D=3D NULL) { return EFI_INVALID_PARAMETER; } =20 + TestEntry =3D NULL; + ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; + DEBUG ((DEBUG_VERBOSE, "------------------------------------------------= ---------\n")); DEBUG ((DEBUG_VERBOSE, "RUNNING TEST SUITE: %a\n", Suite->Title)); DEBUG ((DEBUG_VERBOSE, "------------------------------------------------= ---------\n")); --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54594): https://edk2.groups.io/g/devel/message/54594 Mute This Topic: https://groups.io/mt/71387157/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-