From nobody Sat May 4 13:43:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66594+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66594+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1603701827; cv=none; d=zohomail.com; s=zohoarc; b=HZ6bQCzdvGBBjLTAv6L8/VI/SsrXFeKQmrx0PZ7ZaBgE90lbFTGALk8V9Azx4GJEyEkSVIyBT18BUh04NJaOua6ypUA8qd5ZgeIF5Ogufc2oOIZ45AGTqEv9wMw4+Q0F89GycXKFUcT0sfs2BlneM06ld79QP365evLJVcdwbm4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603701827; h=Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Gq5ksfz77JXFwfdcXr5CFAAMPdv2RqKBit7Z1i1dAHE=; b=Y3m00gML9QooXTkFHHDHuJSjVRLVQ8vTI+Yui8SNJlPasn31VKFN0KjoPb5LAq/gP9Skp+l0MK83RyN+rewllhAUNS1ZrpBOlYoh9d8xSvMFzWNDXQLH1KvvvYDJpl9x9XjhlZs/YpcfELwIXhXsDctrjd5hkyAUIjbIpEcmLmI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66594+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603701827151857.7037406413239; Mon, 26 Oct 2020 01:43:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vBOTYY1788612xe61NrWk8RK; Mon, 26 Oct 2020 01:43:46 -0700 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.10053.1603701594351076169 for ; Mon, 26 Oct 2020 01:39:55 -0700 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 26 Oct 2020 16:39:47 +0800 X-WM-Sender: zhuenze@byosoft.com.cn From: "Enze Zhu" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c Date: Mon, 26 Oct 2020 16:39:37 +0800 Message-Id: <672cc8963666b2afe09b9ee899cc114e6a220930.1603680168.git.zhuenze@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhuenze@byosoft.com.cn X-Gm-Message-State: zSVkRkeLQL1OhIoB1xRmtY9bx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603701826; bh=9GcGTna5YZ7gM+tJi2X1E2ACjjP13ndcfajNLG8cuVo=; h=Date:From:Reply-To:Subject:To; b=ewjN3uUy5VbjLG1/AaqOq3TeOtABVz9geX6lJeOfHfY+XGKgFQu1gwcaSf1CS9nI8YM 5PeYXqHQTM11ZMLYLXbhn+RNFzR415rzP+vOl5GI+xIzpujW8UUHZNA1ynsJneaOX7WKi GLYB199TyXcwvhXaAgKGYKd6X5qxPnXUg54= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2998 In the function FileBufferCutLine(),set the CutLine pointer to NULL, The function header specifies that the pointer is valid on a successful or failed return code. Signed-off-by: Enze Zhu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c = b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c index 5659ec9810..925d910ae2 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c @@ -2767,6 +2767,8 @@ FileBufferCutLine ( UINTN Row; UINTN Col; =20 + *CutLine =3D NULL; + if (FileBuffer.ReadOnly) { StatusBarSetStatusString (L"Read Only File Can Not Be Modified"); return EFI_SUCCESS; --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66594): https://edk2.groups.io/g/devel/message/66594 Mute This Topic: https://groups.io/mt/77810838/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-